GNU bug report logs - #26693
[PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex Kost <alezost <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26693: closed ([PATCH 0/2] Fix indentation in indent-code.el
 and dir-locals.el)
Date: Thu, 04 May 2017 19:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 04 May 2017 22:47:00 +0300
with message-id <87vapgcsln.fsf <at> gmail.com>
and subject line Re: bug#26693: [PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el
has caused the debbugs.gnu.org bug report #26693,
regarding [PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26693: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26693
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Kost <alezost <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el
Date: Fri, 28 Apr 2017 16:28:53 +0300

As reported by Petter on #guix, "indent-code.el" may not work, and it is
absolutely not clear why it happens (it took me 20 minutes to figure out
what the problem was).

So the problem is that "indent-code.el" works only when it is run from
the top directory of the guix checkout (as it is described in the
manual), otherwise it doesn't indent properly (because it doesn't find
".dir-locals.el").

So the upcoming patch fixes this problem.  Also there is another patch
that indents 'modify-keywords' properly.

-- 
Alex

[Message part 3 (message/rfc822, inline)]

From: Alex Kost <alezost <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 26693-done <at> debbugs.gnu.org
Subject: Re: bug#26693: [PATCH 0/2] Fix indentation in indent-code.el and
 dir-locals.el
Date: Thu, 04 May 2017 22:47:00 +0300

Ludovic Courtès (2017-05-02 23:39 +0200) wrote:

> Hi Alex,
>
> Alex Kost <alezost <at> gmail.com> skribis:
>
>> As reported by Petter on #guix, "indent-code.el" may not work, and it is
>> absolutely not clear why it happens (it took me 20 minutes to figure out
>> what the problem was).
>>
>> So the problem is that "indent-code.el" works only when it is run from
>> the top directory of the guix checkout (as it is described in the
>> manual), otherwise it doesn't indent properly (because it doesn't find
>> ".dir-locals.el").
>>
>> So the upcoming patch fixes this problem.  Also there is another patch
>> that indents 'modify-keywords' properly.
>
> Good catch!
>
>> * .dir-locals.el: Add indentation rules for 'replace', 'add-before' and
>> 'add-after'.
>
> OK.
>
>> >From d4abac119e2c62cc42a8786034c905196d7262e6 Mon Sep 17 00:00:00 2001
>> From: Alex Kost <alezost <at> gmail.com>
>> Date: Fri, 28 Apr 2017 16:07:33 +0300
>> Subject: [PATCH] etc: indent-code.el: Define source tree by "indent-code.el".
>>
>> * etc/indent-code.el.in: Set default directory by "indent-code.el"
>> itself, otherwise it works only when called from the top directory of
>> the guix source tree.
>
> LGTM.
>
> Thank you!

Committed, thanks!

-- 
Alex

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.