GNU bug report logs - #26693
[PATCH 0/2] Fix indentation in indent-code.el and dir-locals.el

Previous Next

Full log

Message #17 received at 26693 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: 26693 <at> debbugs.gnu.org
Subject: Re: bug#26693: [PATCH 0/2] Fix indentation in indent-code.el and
 dir-locals.el
Date: Tue, 02 May 2017 23:39:24 +0200

Hi Alex,

Alex Kost <alezost <at> gmail.com> skribis:

> As reported by Petter on #guix, "indent-code.el" may not work, and it is
> absolutely not clear why it happens (it took me 20 minutes to figure out
> what the problem was).
>
> So the problem is that "indent-code.el" works only when it is run from
> the top directory of the guix checkout (as it is described in the
> manual), otherwise it doesn't indent properly (because it doesn't find
> ".dir-locals.el").
>
> So the upcoming patch fixes this problem.  Also there is another patch
> that indents 'modify-keywords' properly.

Good catch!

> * .dir-locals.el: Add indentation rules for 'replace', 'add-before' and
> 'add-after'.

OK.

> >From d4abac119e2c62cc42a8786034c905196d7262e6 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost <at> gmail.com>
> Date: Fri, 28 Apr 2017 16:07:33 +0300
> Subject: [PATCH] etc: indent-code.el: Define source tree by "indent-code.el".
>
> * etc/indent-code.el.in: Set default directory by "indent-code.el"
> itself, otherwise it works only when called from the top directory of
> the guix source tree.

LGTM.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.