GNU bug report logs - #26691
[PATCH] gnu: guile-git: Update to revision 2.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: bug#26691: closed (Re: bug#26691: [PATCH] gnu: guile-git: Update
 to revision 2.)
Date: Sun, 30 Apr 2017 23:09:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#26691: [PATCH] gnu: guile-git: Update to revision 2.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 26691 <at> debbugs.gnu.org.

-- 
26691: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26691
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kei Kebreau <kei <at> openmailbox.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26691-done <at> debbugs.gnu.org
Subject: Re: bug#26691: [PATCH] gnu: guile-git: Update to revision 2.
Date: Sun, 30 Apr 2017 19:08:30 -0400

[Message part 3 (text/plain, inline)]

Mathieu Othacehe <m.othacehe <at> gmail.com> writes:

> * gnu/packages/guile.scm (guile-git): Update to revision 2,
> [arguments]: remove "ccache -> site-ccache" substitution because it
> has been ported upstream.
>
> Bumping to sha1 0rcq0f8dh, adds remote & reset bindings to guile-git.
> ---
>
> Hi,
>
> This patch updates guile-git revision to add remote & reset
> bindings support.
>
> Thanks,
>
> Mathieu
>
>  gnu/packages/guile.scm | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
> index 9dd524e4b..f7382a5a9 100644
> --- a/gnu/packages/guile.scm
> +++ b/gnu/packages/guile.scm
> @@ -12,6 +12,7 @@
>  ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke <at> gnu.org>
>  ;;; Copyright © 2017 Andy Wingo <wingo <at> igalia.com>
>  ;;; Copyright © 2017 David Thompson <davet <at> gnu.org>
> +;;; Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1694,8 +1695,8 @@ is not available for Guile 2.0.")
>      (license license:lgpl3+)))
>  
>  (define-public guile-git
> -  (let ((revision "1")
> -        (commit "96dfb3bdba39a37cf6aefb18e335118a6115f963"))
> +  (let ((revision "2")
> +        (commit "06f9fc3d9ac95798d4a51e6310f7b594ce5597e0"))
>      (package
>        (name "guile-git")
>        (version (string-append "0.0-" revision "." (string-take commit 7)))
> @@ -1705,18 +1706,13 @@ is not available for Guile 2.0.")
>                  (uri (git-reference (url home-page) (commit commit)))
>                  (sha256
>                   (base32
> -                  "0v73251kmh1vs7gp3jh4pk4rikl4d8illwi0gnhwa55ij1mn9apl"))
> +                  "0rcq0f8dhl89ia7336bq8y279q5ada0b1kabcqw9zl3125k3cp4v"))
>                  (file-name (git-file-name name version))))
>        (build-system gnu-build-system)
>        (arguments
>         '(#:phases (modify-phases %standard-phases
>                      (add-after 'unpack 'bootstrap
>                        (lambda _
> -                        ;; Install .go files to "site-ccache", not "ccache".
> -                        (substitute* "Makefile.am"
> -                          (("/ccache")
> -                           "/site-ccache"))
> -
>                          (zero? (system* "autoreconf" "-vfi")))))))
>        (native-inputs
>         `(("autoconf" ,autoconf)

LGTM. I've pushed this to master. Thank you for the update.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] gnu: guile-git: Update to revision 2.
Date: Fri, 28 Apr 2017 13:45:13 +0200

* gnu/packages/guile.scm (guile-git): Update to revision 2,
[arguments]: remove "ccache -> site-ccache" substitution because it
has been ported upstream.

Bumping to sha1 0rcq0f8dh, adds remote & reset bindings to guile-git.
---

Hi,

This patch updates guile-git revision to add remote & reset
bindings support.

Thanks,

Mathieu

 gnu/packages/guile.scm | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index 9dd524e4b..f7382a5a9 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2016 Jan Nieuwenhuizen <janneke <at> gnu.org>
 ;;; Copyright © 2017 Andy Wingo <wingo <at> igalia.com>
 ;;; Copyright © 2017 David Thompson <davet <at> gnu.org>
+;;; Copyright © 2017 Mathieu Othacehe <m.othacehe <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1694,8 +1695,8 @@ is not available for Guile 2.0.")
     (license license:lgpl3+)))
 
 (define-public guile-git
-  (let ((revision "1")
-        (commit "96dfb3bdba39a37cf6aefb18e335118a6115f963"))
+  (let ((revision "2")
+        (commit "06f9fc3d9ac95798d4a51e6310f7b594ce5597e0"))
     (package
       (name "guile-git")
       (version (string-append "0.0-" revision "." (string-take commit 7)))
@@ -1705,18 +1706,13 @@ is not available for Guile 2.0.")
                 (uri (git-reference (url home-page) (commit commit)))
                 (sha256
                  (base32
-                  "0v73251kmh1vs7gp3jh4pk4rikl4d8illwi0gnhwa55ij1mn9apl"))
+                  "0rcq0f8dhl89ia7336bq8y279q5ada0b1kabcqw9zl3125k3cp4v"))
                 (file-name (git-file-name name version))))
       (build-system gnu-build-system)
       (arguments
        '(#:phases (modify-phases %standard-phases
                     (add-after 'unpack 'bootstrap
                       (lambda _
-                        ;; Install .go files to "site-ccache", not "ccache".
-                        (substitute* "Makefile.am"
-                          (("/ccache")
-                           "/site-ccache"))
-
                         (zero? (system* "autoreconf" "-vfi")))))))
       (native-inputs
        `(("autoconf" ,autoconf)
-- 
2.12.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.