GNU bug report logs - #26690
Crash with --ignore-matching-lines

Previous Next

Package: diffutils;

Reported by: Marcel Böhme <marcel.boehme <at> nus.edu.sg>

Date: Fri, 28 Apr 2017 01:22:02 UTC

Severity: normal

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 26690 <at> debbugs.gnu.org (full text, mbox):

From: Marcel Böhme <marcel.boehme <at> nus.edu.sg>
To: "26690 <at> debbugs.gnu.org" <26690 <at> debbugs.gnu.org>
Subject: Re: bug#26690: Acknowledgement (Crash with --ignore-matching-lines)
Date: Fri, 28 Apr 2017 01:32:30 +0000
Suggested patch:

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
diff --git a/src/diff.c b/src/diff.c
index 76851ac..9db7005 100644
--- a/src/diff.c
+++ b/src/diff.c
@@ -818,7 +818,18 @@ add_regexp (struct regexp_list *reglist, char const *pattern)
  char const *m = re_compile_pattern (pattern, patlen, reglist->buf);

  if (m != 0)
-    error (0, 0, "%s: %s", pattern, m);
+    {
+      error (0, 0, "%s: %s", pattern, m);
+
+      /* Recompile existing pattern if needed */
+      if (reglist->regexps)
+       {
+         m = re_compile_pattern (reglist->regexps, reglist->len,
+                                 reglist->buf);
+         if (m)
+           die (EXIT_TROUBLE, 0, "%s: %s", reglist->regexps, m);
+       }
+    }
  else
    {
      char *regexps = reglist->regexps;
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Best regards,
- Marcel

---
Marcel Böhme
Senior Research Fellow
TSUNAMi Security Research Centre
National University of Singapore


________________________________

Important: This email is confidential and may be privileged. If you are not the intended recipient, please delete it and notify us immediately; you should not copy or use it for any purpose, nor disclose its contents to any other person. Thank you.

This bug report was last modified 8 years and 19 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.