Subject: Re: bug#26676: [PATCH] gnu: Add xerces-c.

From: Ricardo Wurmus <[email-masked]>
Date: Fri, 28 Apr 2017 17:48:15 +0200

Marius Bakke <[email-masked]> writes:

> Ricardo Wurmus <[email-masked]> writes:
>
>> * gnu/packages/xml.scm (xerces-c): New variable.
>
> [...]
>
>> +(define-public xerces-c
>> +  (package
>> +    (name "xerces-c")
>> +    (version "3.1.4")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://apache/xerces/c/3/sources/"
>> +                                  "xerces-c-" version ".tar.xz"))
>> +              (sha256
>> +               (base32
>> +                "0hb29c0smqlpxj0zdm09s983z5jx37szlliccnvgh0qq91wwqwwr"))))
>> +    (build-system gnu-build-system)
>> +    (arguments
>> +     `(#:configure-flags (list "--disable-sse2")))
>
> SSE2 is part of the AMD64 specification[0], so enabling it for x86_64
> would be slightly nicer. Other than that looks good!
>
> [0] https://en.wikipedia.org/wiki/SSE2#CPU_support

Ah, you’re right.  I pushed it with a fix with commit 162a4a032^.
Thanks for the review!

--
Ricardo

  GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
  https://elephly.net