GNU bug report logs - #26672
25.2; Flyspell overlay conflicts with table.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26672: closed (25.2; Flyspell overlay conflicts with table.el)
Date: Sun, 30 Apr 2017 18:59:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 30 Apr 2017 21:57:40 +0300
with message-id <83y3uhk9jv.fsf <at> gnu.org>
and subject line Re: bug#26672: 25.2; Flyspell overlay conflicts with table.el
has caused the debbugs.gnu.org bug report #26672,
regarding 25.2; Flyspell overlay conflicts with table.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26672: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26672
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Allen Li <vianchielfaura <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; Flyspell overlay conflicts with table.el
Date: Wed, 26 Apr 2017 15:00:05 -0700

Flyspell's overlay for misspelled words conflicts with table.el

table.el adds its keymap as a text property to the text in table cells.
When Flyspell detects a misspelled word, it adds an overlay with a
keymap binding mouse2 to ‘flyspell-correct-word’.  Apparently, this
overlay keymap overrides table.el’s ‘keymap’ text property.

The effect of this is that pressing TAB to move between table cells will
instead insert a literal tab character if your cursor happens to be on a
misspelled word.  This is extremely annoying.

More generally, I’m not sure that an overlay keymap replacing the
‘keymap’ text property is desired behavior.  At the very least, there
should be an escape hatch option on the overlay keymap that defers to
the ‘keymap’ text property for cases like Flyspell where replacing the
‘keymap’ text property is not desired behavior.

I am aware that there’s an option ‘flyspell-highlight-properties’ to
prevent Flyspell adding its overlay if the text has properties, but
that’s not really useful since most modes other than perhaps fundamental or text
will add various properties to text.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Allen Li <vianchielfaura <at> gmail.com>
Cc: 26672-done <at> debbugs.gnu.org
Subject: Re: bug#26672: 25.2; Flyspell overlay conflicts with table.el
Date: Sun, 30 Apr 2017 21:57:40 +0300

> From: Allen Li <vianchielfaura <at> gmail.com>
> Date: Sat, 29 Apr 2017 14:42:15 -0700
> Cc: 26672 <at> debbugs.gnu.org
> 
> Works, thanks, although I had to rebase the patch on emacs-25 branch
> as I couldn't get the master branch to compile.

Thanks, pushed to the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.