GNU bug report logs - #26658
25.2; cc-mode doesn't use prog-mode-map as parent for c-mode-base-map

Previous Next

Packages: cc-mode, emacs;

Reported by: Vasilij Schneidermann <mail <at> vasilij.de>

Date: Tue, 25 Apr 2017 18:55:01 UTC

Severity: wishlist

Tags: patch

Merged with 23175

Found in version 25.2

Done: Alan Mackenzie <acm <at> muc.de>

Bug is archived. No further changes may be made.

Full log


Message #22 received at 26658 <at> debbugs.gnu.org (full text, mbox):

From: Vasilij Schneidermann <mail <at> vasilij.de>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 26658 <at> debbugs.gnu.org
Subject: Re: bug#26658: 25.2; cc-mode doesn't use prog-mode-map as parent for
 c-mode-base-map
Date: Fri, 28 Apr 2017 10:15:22 +0200
> So yes, this change would surely be a good idea, given that this CC Mode
> is derived from prog-mode anyway.

The more I think about it, the less sure I become.  Pretty much every
CC-derived mode does (define-derived-mode my-mode prog-mode ...) anyway
and according to the macro expansion, its keymap's parent is set to
(current-local-map) which should be equivalent to `prog-mode-map'.
Could very well be a non-issue in practice and merely faulty testing by
the user...

> Do you want to write the patch?  If so, have you got copyright
> assignments, or can you manage to write it as an "insignificant" (i.e.
> very small) change?  I think the limit for insignificant changes is less
> than 15 lines, but I'm not absolutely sure.  This wouldn't even need any
> changes in the manual.  :-)
> 
> If you don't really want to write the patch, just say so, and I'll do
> it.

I've assigned copyright already, but reckon this is a one-line patch.
Before I submit anything, I'd like to make sure it's needed and the
change works out as expected.




This bug report was last modified 8 years and 1 day ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.