GNU bug report logs - #26652
[PATCH 0/2] fresh: add -m manifest option.

Previous Next

Full log

Message #32 received at 26652 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26652 <at> debbugs.gnu.org
Subject: Re: bug#26652: [PATCH 2/2] scripts: refresh: Add -m manifest option.
Date: Thu, 04 May 2017 13:46:47 +0200

Hi Ludo,

Thanks for the review :)

>>    (display (_ "
>> +  -m, --manifest=FILE    select all the packages in FILE manifest"))
>
> “select all the package from the manifest in FILE” maybe?

Ok.

> Also, maybe s/get-manifest-packages/packages-from-manifest/, because
> ‘get-’ is quite unusual.  :-)

Seems better !

>
>> +         (packages
>> +          (or manifest-packages args-packages)))
>
> Maybe (append (match (assoc-ref opts 'manifest)
>                 (#f '())
>                 ((? string? file) (packages-from-manifest file)))
>               args-packages)

Mmh, I dont think we want to append manifest packages and args-packages.
We want only manifest packages if a manifest is specified IMO.

>
> ?
>
> Could you also update guix.texi to mention this option and the intended
> use case?

Sure.

I sent an updated patch taking your remarks into account.

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.