GNU bug report logs - #26652
[PATCH 0/2] fresh: add -m manifest option.

Previous Next

Full log

Message #26 received at 26652 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 26652 <at> debbugs.gnu.org
Subject: Re: bug#26652: [PATCH 2/2] scripts: refresh: Add -m manifest option.
Date: Wed, 03 May 2017 22:04:24 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * guix/scripts/refresh.scm (%options): Add -m option,
> (show-help): document it,
> (get-manifest-packages): new procedure,
> (guix-refresh): use packages from manifest if specified, otherwise
> keep the previous behaviour.

This sounds useful!

>    (display (_ "
> +  -m, --manifest=FILE    select all the packages in FILE manifest"))

“select all the package from the manifest in FILE” maybe?

> +(define (get-manifest-packages manifest)
> +  "Return the list of packages in loaded MANIFEST."
> +  (let* ((user-module (make-user-module '((guix profiles) (gnu))))
> +         (manifest    (load* manifest user-module)))
> +    (manifest->packages manifest)))

With ‘manifest->packages’ moved in this module, that would be fine.

Also, maybe s/get-manifest-packages/packages-from-manifest/, because
‘get-’ is quite unusual.  :-)

> +         (packages
> +          (or manifest-packages args-packages)))

Maybe (append (match (assoc-ref opts 'manifest)
                (#f '())
                ((? string? file) (packages-from-manifest file)))
              args-packages)

?

Could you also update guix.texi to mention this option and the intended
use case?

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.