From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 08:02:51 2017 Received: (at submit) by debbugs.gnu.org; 25 Apr 2017 12:02:51 +0000 Received: from localhost ([127.0.0.1]:38886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2zBD-0007Pz-0k for submit@debbugs.gnu.org; Tue, 25 Apr 2017 08:02:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2zBB-0007Pm-8t for submit@debbugs.gnu.org; Tue, 25 Apr 2017 08:02:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2zB1-0002uM-Hc for submit@debbugs.gnu.org; Tue, 25 Apr 2017 08:02:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2zB1-0002uG-F4 for submit@debbugs.gnu.org; Tue, 25 Apr 2017 08:02:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2zB0-0000sW-88 for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2017 08:02:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2zAx-0002tF-JH for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2017 08:02:38 -0400 Received: from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e]:32937) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2zAx-0002sx-DY for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2017 08:02:35 -0400 Received: by mail-pf0-x22e.google.com with SMTP id a188so26134420pfa.0 for ; Tue, 25 Apr 2017 05:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=/TiuSZLdDX7usJ7d1L7nYh6k/l0Gtv3HO60Zroisd60=; b=psq6rdKXljGsG+b7QVLVSG/SlKksyHR43nAZ7GtmKPpIAmrO6I/qKX79NbyEm8G1Qn dMEg/NvHuwKBqw9Qd7Zgwx99YYBUBZ4m2Z/mt+dJh3IVl03Zj0FBdNYtlWINy9oXzoJq UCLafWh9qRZsc5dbcIfoW8UY3oXuM9S3FAQkiJw2LiEt5LFKtciQr/TXVCPSUfZm2l9R Ryo/976r9H4VjjjwbsN6Txn1qLnOqCmwtydALMq703I2XEI86KDRwQturB/lMrYflxL0 49tPZFL0n3mEfkR7RFjKrJbSLMeUSA7/ABW36wv7xLN83K2ovdz3XWCKHUWZ0NTOkE3Y G+rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=/TiuSZLdDX7usJ7d1L7nYh6k/l0Gtv3HO60Zroisd60=; b=qS6O8U8X9d+NN59bzA4ybmZxLUNGUQHSQ++LbW2u8xx5NSyUytrktLfKl+vkhq5o3r JlCHl4mbpL22fAALZYpgOiri/4b1sRBJk15F83m/4ExAZ1YX5QC54SP/NfI2CHvx8A8H 07eHGKwEjDN9fUU547lRlJUy34L/vBwmEEhmkrnZIpqoZUBMwloSR07grxgcUoJxAfFI R6RO0RknetruUeAV9Q1yxEFfwaudIBEC2mUZYBLhcYlTZi6mtaUG/It5nVUroLL2TJR6 IUsqbEZaAHkS1ZohkMvg/9hT9X9cHM6BnW4leHuUIgYIWsFC/IMgY6sspc2OYpS2gOh6 mGnA== X-Gm-Message-State: AN3rC/6IWIOkLhwlE335MvBi61hGJwv9FgNUi9s0SUBOf+1FBsJJpmp/ VmSZMybjUWe/OTVt X-Received: by 10.99.158.2 with SMTP id s2mr28512464pgd.15.1493121748976; Tue, 25 Apr 2017 05:02:28 -0700 (PDT) Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id z136sm3397344pgz.42.2017.04.25.05.02.27 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Apr 2017 05:02:28 -0700 (PDT) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Protect *Backtrace* from accidental killing Date: Tue, 25 Apr 2017 21:02:24 +0900 Message-ID: <871ssgvgof.fsf@calancha-pc> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I often kills the *Backtrace* buffer; then, errors won't show *Backtrace* again in this session. Could *Backtrace* be guarded with something like `edebug-kill-buffer' in kill-buffer-hook? emacs -Q ;; eval following form: (error "hi") ; This jump to *Backtrace* q ; Back to top level ;; Eval it again: (error "hi") ; This time kill *Backtrace* C-x k RET ;; Eval it once more: (error "hi") ;; 'hi' is printed in echo area, but *Backtrace* is not shown. In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-04-25 built Repository revision: 5b0fdefb4ca54b0d3dac3047ac1e4b380beb6ba7 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 08:11:45 2017 Received: (at 26650) by debbugs.gnu.org; 25 Apr 2017 12:11:45 +0000 Received: from localhost ([127.0.0.1]:38894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2zJp-0007dR-6O for submit@debbugs.gnu.org; Tue, 25 Apr 2017 08:11:45 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:34422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2zJm-0007d8-Q0; Tue, 25 Apr 2017 08:11:43 -0400 Received: by mail-io0-f194.google.com with SMTP id h41so53510569ioi.1; Tue, 25 Apr 2017 05:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1rGuVsC0Do232Lq/IJyZXs6/itQ5Bx9eFRZpPBiPLi8=; b=gQ94mvkTNqp0IKcOOR6mFYgz+u6bzvlCG043eZeaQVcfD+43kuemEt405bHR2RgIvV 4u8I/dx/MNUAXnvMvGGcHbG3HXftCvVC2le4Q1AplD+tzhs6anTFgHXA9sUaPerhL9TS /zRkS5XomE6RyJCbf1EoL6k6UraSSU0Qg9qXWda1tHB8bD4zYESSJ6OEhdbbdOB+Sc98 hqUiYAvaZsT0Wj30i6q2MLGzyjH/bNTe531bn4Urv5MoF9xvattP6fka5nUFsDeiSvdB 5r4SYo+e9yRyb8/FBsWuf9Tg17I/KdhneFoyebeBUNAcR4poleoOdUecpcjvmOKKOmnE jzdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=1rGuVsC0Do232Lq/IJyZXs6/itQ5Bx9eFRZpPBiPLi8=; b=iv9cc2lmZifVLGQ8kI6f96jUtv4wpUMT8ZfJTUGxUYrdj3vpraNw+c2T5og2JzAMis SrnDDkPleaPPhBFmBGr+YOJfTFCYxY29SGzslRRs3pedVSmBqCsZg52S0djQrcKRXAPh Cy6kNFXbzjCyx8YqsFt4ZXMfn5P3MHC41JQ9U68LLW+RkjBY5ITsasQPPF+Xw+S/tS48 +1dQQpQdcVTVsR22wc84aNdkBluXNXxblfq8vq4hEx11V3EMJir9kb+bW9n1per2fjVr Xjpxt/Cso57QM3KHIuUMG9rmxqp4cny7uqC4DJzE06ylwzlYHxtyd2I6L2nYVgcWClGe Nozg== X-Gm-Message-State: AN3rC/6DFOheOlg0r0Qs2Rx6QG4X0FKNVzI6W/VkNzrR+ub/BegtcFQM EExsk6DW2zKdzw== X-Received: by 10.107.176.79 with SMTP id z76mr14589287ioe.223.1493122297052; Tue, 25 Apr 2017 05:11:37 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id h71sm9473711ioe.9.2017.04.25.05.11.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Apr 2017 05:11:36 -0700 (PDT) From: npostavs@users.sourceforge.net To: Tino Calancha Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> Date: Tue, 25 Apr 2017 08:13:07 -0400 In-Reply-To: <871ssgvgof.fsf@calancha-pc> (Tino Calancha's message of "Tue, 25 Apr 2017 21:02:24 +0900") Message-ID: <87wpa8ofcc.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) severity 26650 minor quit Tino Calancha writes: > (error "hi") ; This time kill *Backtrace* > C-x k RET > > ;; Eval it once more: > (error "hi") > ;; 'hi' is printed in echo area, but *Backtrace* is not shown. That's because you're still in the recursive edit, it's like evaluating '(error "hi")' before hitting 'q' in the *Backtrace* buffer. You can use C-M-c (exit-recursive-edit) to get back to normal. I think it would make sense to do that automatically if you kill the *Backtrace* buffer. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 08:18:20 2017 Received: (at 26650) by debbugs.gnu.org; 25 Apr 2017 12:18:20 +0000 Received: from localhost ([127.0.0.1]:38904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2zQC-00018S-2q for submit@debbugs.gnu.org; Tue, 25 Apr 2017 08:18:20 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:32843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2zQA-00018F-55 for 26650@debbugs.gnu.org; Tue, 25 Apr 2017 08:18:18 -0400 Received: by mail-pg0-f68.google.com with SMTP id 63so10918571pgh.0 for <26650@debbugs.gnu.org>; Tue, 25 Apr 2017 05:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=nRKEeNzFoubwh1kJSVUWAAO18gtQfkdUhQvbf2j8BhQ=; b=D9ekPVAYTqVFeKDOFla+bE3wOH1m0Srkm0z0WkqULa9YKqfKHJ3h8ZIpIA316Pa34E hQMgdbIghGG+yOGr53vU77Uj4+lHo0phcXyI/whUcIYw/JGZJ0ai1qrPfQwd/bZpk4WD mceLj7q9etAHop3g1MGiSrvw79eDWAHqDS5jCCUNm3iqQRWJpESOKY3VPY5mG1Fah5kL dFXg0nkkjHOABbSgCGLn+uLY5Jnty7K1AJ74XTHWqnz8B1TwoIKjd/nMKt8IPqFPBxMV qgSnjg9sKWx3WYIlIA1k7zWjNp5UTmFcAEFNpqlmPn8Y3XiyR2MWm4W+mqCBu0Fr+ByZ ukyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=nRKEeNzFoubwh1kJSVUWAAO18gtQfkdUhQvbf2j8BhQ=; b=Z6nHrmZSSuFScxtMSrWC39lfNIEcpJ2H1ElTLGyqATJGBviaOlnCzmIgQLi4t6JifY i/opB7C/GJeJywrfzQYj5tT2zzjVUq3W8pRzCDi3hC9xFdvcoCv2L9OniYi2pIURTIi2 BUZL1CvfmMwWldI8oNXphLt6go7ef5tIJPejZw/SegHAB4i+VZ+f6Rlfe3AXCgc6G8mD +MeylJPybVBroDUNMQVtubGwQWMz6ee03ZvoBXF5qFp4bVM7dgdbldDDEk1yKDvV/Mu9 NrmkTWdRguwWeG5x5Pp2uH2FU7Gg8hjIIBboPYvCKFrX2cucTgexnnpAWgg3o7v9W+xw eD/A== X-Gm-Message-State: AN3rC/5Ct2IieF5k6ttLbK41jzYZT/7mBnVpNa6UQT1gZtS1kydXvPco cvEb7AF0/1mNgw== X-Received: by 10.98.211.142 with SMTP id z14mr29201128pfk.46.1493122691975; Tue, 25 Apr 2017 05:18:11 -0700 (PDT) Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id m187sm36431611pfm.122.2017.04.25.05.18.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Apr 2017 05:18:11 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 25 Apr 2017 21:18:09 +0900 (JST) X-X-Sender: calancha@calancha-pc To: npostavs@users.sourceforge.net Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing In-Reply-To: <87wpa8ofcc.fsf@users.sourceforge.net> Message-ID: References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Tue, 25 Apr 2017, npostavs@users.sourceforge.net wrote: > severity 26650 minor > quit > > Tino Calancha writes: > >> (error "hi") ; This time kill *Backtrace* >> C-x k RET >> >> ;; Eval it once more: >> (error "hi") >> ;; 'hi' is printed in echo area, but *Backtrace* is not shown. > > That's because you're still in the recursive edit, it's like evaluating > '(error "hi")' before hitting 'q' in the *Backtrace* buffer. You can > use C-M-c (exit-recursive-edit) to get back to normal. I think it would > make sense to do that automatically if you kill the *Backtrace* buffer. Yes, it would be useful. I don't know how, though. Sometimes i kill *Bactrace* from *Ibuffer*/*Buffer List* with the recursive edit still ongoing. It's a classical mistake. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 08:48:38 2017 Received: (at 26650) by debbugs.gnu.org; 25 Apr 2017 12:48:38 +0000 Received: from localhost ([127.0.0.1]:38957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2ztW-0003hW-B3 for submit@debbugs.gnu.org; Tue, 25 Apr 2017 08:48:38 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:34735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2ztU-0003hC-4G; Tue, 25 Apr 2017 08:48:36 -0400 Received: by mail-io0-f195.google.com with SMTP id h41so53617944ioi.1; Tue, 25 Apr 2017 05:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jIBiGU5SzUZ1H3OB/3WILIqTmz6h1/2A1T5ZdPcqhM0=; b=vNHdkCCpeyKjAVKUpugtuJVZedymIQePMOg4d5H4zNOEe4ZDHUeZ4DSN7Qtxk2sxRy yUVRzQADJaboy7jkNYhOcqeOWlw38McTpWb3srccwL8pMQD41ahMAQe8yzmbO3hoGEHl cA5x76HF9RRYBPfphmJeZ7zXRd4/GhBmNnjEcTXnlC98Y/fYHE9yOsES6Hgf+jBiqdmY rJaVtiBKXHZJGEBa/3tmC1zi6wWOiGnIIOWEZkrcMUJ1527zK2ioHVScBpur9DFESF6e qIYWf9qPojPUkCLhTigxrrtz5C4LZmjm6c6t0KTuRoXvXYpLBn+nOvppfL58w3qezqS8 /uqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=jIBiGU5SzUZ1H3OB/3WILIqTmz6h1/2A1T5ZdPcqhM0=; b=IKjHpdYyVU1wIzfK44GJg12mCAsdT5sBeuntHv8b7rd2FjE8zHaBBPcLusxXlCLLh3 rWW7ErKDDjbyAbtQ+SUpqih/7ocJLkMAAmOdFa+qlZF8wOh8n72Bds3LMlKyC0LAGbd3 FrA9e02mcjDuEEoumgNIMvw0aR5/rNiJ5szg6gTAEH4rwPMvnuOy9L5IK3z0pzMvoeMm 6Sw0G1Zx841h4sJeHuM3f7j+FKraJflJlPyQPi97M2PPSK2BKGYm87+NY1ItWQsKXcHd XeJPaXkwIcEGMBW3qaCDLxlA+yS1Bu+KvPcKDVpt5v5V9J1GgChn7lHWpfjohqu7wDAi DMNQ== X-Gm-Message-State: AN3rC/7CwYMtxD/OR9DIz4VjnRr0ms7E3uJsFBs6k4I4yPIl3F5Q1hsJ 3x5ETp42cPh7rQ== X-Received: by 10.107.138.151 with SMTP id c23mr15705725ioj.235.1493124510498; Tue, 25 Apr 2017 05:48:30 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id w79sm1850995itb.11.2017.04.25.05.48.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Apr 2017 05:48:29 -0700 (PDT) From: npostavs@users.sourceforge.net To: Tino Calancha Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> Date: Tue, 25 Apr 2017 08:50:00 -0400 In-Reply-To: (Tino Calancha's message of "Tue, 25 Apr 2017 21:18:09 +0900 (JST)") Message-ID: <87shkwodmv.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain tags 26650 patch quit Tino Calancha writes: >> >> That's because you're still in the recursive edit, it's like evaluating >> '(error "hi")' before hitting 'q' in the *Backtrace* buffer. You can >> use C-M-c (exit-recursive-edit) to get back to normal. I think it would >> make sense to do that automatically if you kill the *Backtrace* buffer. > Yes, it would be useful. I don't know how, though. > Sometimes i kill *Bactrace* from *Ibuffer*/*Buffer List* with the > recursive edit still ongoing. It's a classical mistake. Actually, the obvious way of adding `top-level' (that's what 'q' does) to `kill-buffer-hook' does protect *Backtrace* from killing. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Protect-Backtrace-from-being-killed-Bug-26650.patch Content-Description: patch >From 9e2f66a300cc0c94fb1369cbf3721d41d98c2d94 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Tue, 25 Apr 2017 08:39:17 -0400 Subject: [PATCH v1] Protect *Backtrace* from being killed (Bug#26650) * lisp/emacs-lisp/debug.el (debugger-mode): Call `top-level' in `kill-buffer-hook'. --- lisp/emacs-lisp/debug.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el index 94b683dcb9..0aef94f1d2 100644 --- a/lisp/emacs-lisp/debug.el +++ b/lisp/emacs-lisp/debug.el @@ -753,6 +753,8 @@ debugger-mode \\{debugger-mode-map}" (setq truncate-lines t) (set-syntax-table emacs-lisp-mode-syntax-table) + (add-hook 'kill-buffer-hook + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) (use-local-map debugger-mode-map)) (defcustom debugger-record-buffer "*Debugger-record*" -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 09:02:30 2017 Received: (at 26650) by debbugs.gnu.org; 25 Apr 2017 13:02:30 +0000 Received: from localhost ([127.0.0.1]:38976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d306w-0005ov-DE for submit@debbugs.gnu.org; Tue, 25 Apr 2017 09:02:30 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:33928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d306v-0005oi-1e for 26650@debbugs.gnu.org; Tue, 25 Apr 2017 09:02:29 -0400 Received: by mail-pf0-f195.google.com with SMTP id g23so10300890pfj.1 for <26650@debbugs.gnu.org>; Tue, 25 Apr 2017 06:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=f1AThLDVN9JaYqWyeahpR/fmiI6Yxvws8S29ca72tK8=; b=IkBisr35D2hfhB5l69P4rKzKfeFqGHl0aNul1BarQ0J/H5kwon0tBKud8EuqKvCkuS kM9a4nqUgskex0tsXbfXtvrME0PTnTl+v4HK3f2LH9KbZiR64dqMGgviMAf7wo2tq0iX Z+HffbTXJBL+AiqExDm3qQnTGj9Ye7OvDXaW0aG0HdgteQJzXMTsXXqv1drYKXuniKW2 35oQZHJOVxuX06I2FUzw2MbRHM7D+jFflySbW4utMKROOsus1+KIrNEwGwZil5b3XWML abDbS74psysmHwQjRhByCT6e8ulprSrKtlyz/Ujp8fJg1+reuLYnyGwpnNua8/LGaFhI PLuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=f1AThLDVN9JaYqWyeahpR/fmiI6Yxvws8S29ca72tK8=; b=bnrGnvCa4qxQ1pPkGI56bm3ka3ANgZyWOmiYRN8wY0sPG5axoDIpRuf3iiAF+ETls0 qJWkVWynSp6yftE44zClKVfHMts6u618BzAyjc5EVuTlr6wGQLpFNDjm5XVYtKLmPprW VSVfGh7/+z9+KkMk3mV9rb1lYsHZxZ3q5PzI0cgwSQYNq531ysc6tmwlWGeuiFjzc0dK EntinjczwmR4b8O84YdAkCOBZJYFotQ8at3EQV2N3AHzewekmU9WZ2eHgRHSEiF2ToEg VqddHSjyzx9ZsxC8I88/2nU88gbwRrVjL5oTyv7XOnyaWclNu+rxABMPJoHrMsgHU6qb wXUQ== X-Gm-Message-State: AN3rC/6WBwZxIv4KRdWDrWQVc2seqKxzGcQLIjSK9F0KgeZjTWSJ3fTB 82MopDAjTqzzEQ== X-Received: by 10.84.191.228 with SMTP id a91mr38606398pld.62.1493125343230; Tue, 25 Apr 2017 06:02:23 -0700 (PDT) Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id s68sm36665606pfj.77.2017.04.25.06.02.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Apr 2017 06:02:22 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 25 Apr 2017 22:02:20 +0900 (JST) X-X-Sender: calancha@calancha-pc To: npostavs@users.sourceforge.net Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing In-Reply-To: <87shkwodmv.fsf@users.sourceforge.net> Message-ID: References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Tue, 25 Apr 2017, npostavs@users.sourceforge.net wrote: > tags 26650 patch > quit > > Tino Calancha writes: > >>> >>> That's because you're still in the recursive edit, it's like evaluating >>> '(error "hi")' before hitting 'q' in the *Backtrace* buffer. You can >>> use C-M-c (exit-recursive-edit) to get back to normal. I think it would >>> make sense to do that automatically if you kill the *Backtrace* buffer. >> Yes, it would be useful. I don't know how, though. >> Sometimes i kill *Bactrace* from *Ibuffer*/*Buffer List* with the >> recursive edit still ongoing. It's a classical mistake. > > Actually, the obvious way of adding `top-level' (that's what 'q' does) > to `kill-buffer-hook' does protect *Backtrace* from killing. Good! It solves the issue. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 06:08:42 2017 Received: (at 26650) by debbugs.gnu.org; 26 Apr 2017 10:08:42 +0000 Received: from localhost ([127.0.0.1]:40583 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3JsI-0005ST-Gm for submit@debbugs.gnu.org; Wed, 26 Apr 2017 06:08:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3JsG-0005SH-Ue for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 06:08:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3Js8-00031j-Fq for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 06:08:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52450) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3Js8-00031d-Cu; Wed, 26 Apr 2017 06:08:32 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3553 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d3Js7-0002Ds-Q0; Wed, 26 Apr 2017 06:08:32 -0400 Date: Wed, 26 Apr 2017 13:07:53 +0300 Message-Id: <838tmnpjly.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87shkwodmv.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Date: Tue, 25 Apr 2017 08:50:00 -0400 > Cc: 26650@debbugs.gnu.org > > diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el > index 94b683dcb9..0aef94f1d2 100644 > --- a/lisp/emacs-lisp/debug.el > +++ b/lisp/emacs-lisp/debug.el > @@ -753,6 +753,8 @@ debugger-mode > \\{debugger-mode-map}" > (setq truncate-lines t) > (set-syntax-table emacs-lisp-mode-syntax-table) > + (add-hook 'kill-buffer-hook > + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) This will throw to top-level when _any_ buffer is killed, as long as we are in recursive-edit, no? Is that a good idea? Shouldn't this hook do that only for *Backtrace*? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 06:37:06 2017 Received: (at 26650) by debbugs.gnu.org; 26 Apr 2017 10:37:07 +0000 Received: from localhost ([127.0.0.1]:40604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3KJm-0006Dp-Mm for submit@debbugs.gnu.org; Wed, 26 Apr 2017 06:37:06 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:35417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3KJk-0006DI-3S for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 06:37:04 -0400 Received: by mail-pf0-f194.google.com with SMTP id a188so15975884pfa.2 for <26650@debbugs.gnu.org>; Wed, 26 Apr 2017 03:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=aMZKCVS4yCwV9+d/watnf7t4ORTWTEuy/URdbZBuqYM=; b=EL0SxTQrl1Nx/XTLVpzSnFKo76sHRqezXG2ctAFmmttSm3mAKGJLfj0kJIHhsKwaGK lKVn2uuxGFONoiRDG8+rLAA0N35ortiLwEOGMPIrKL5gQZQzDcX5vtLkSmF+QMjjoGgN lCUfNpWlePLMK2TZVhLOR9GEAxPUxmsOawpmV9DLtJ7QGNmVyK0ibeamrcWpd3A9LqDL dOxvvGdE5F/4ssoJhbKqDyR3aHZ+GeJ6RTfWZNNyGD9q4kjwMqVUTy2uou+CnFee2QhV nWTMW80ZMGmozON4IVF+0tKlyEpw6xancAvciOaJdl0AhAPBzbu92DLdTeS4adMpoYQe 2OQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=aMZKCVS4yCwV9+d/watnf7t4ORTWTEuy/URdbZBuqYM=; b=Ky9tBwy/uL8M047sVm3I63UegcnRaZYAwmqhF+RkJl9BjCuUZVOV8pVmkcsTmubFYf rlL1oiDlVjDsajt6lxv4isY81DSEH1FEkOZf4c0wamTDEVJ2tyBQ3DKXH7xg82vMGqTi FLwolj12ViN5Mu4Nlj90L1wezDrQWnqbjgWxFebaRFTSV5qOLy/B64Se4Ug3aXhJe4WH hcIoG6BzjB2HXsX+ecfxreXFXfekHb1EurK+adYk0eQS3mor4mvoFRgotOxx6GP3qWj7 WQxIBTNe8loIXnGVYc1agT6rUjuLdXYdKnuzHRuQdlo4kP7qrcTluiEZiOwpsFMRGG/O LOxw== X-Gm-Message-State: AN3rC/7PMkGVGa+x6qo65gYiHyGzRdm2AzQ0NCctmHqdHLzYfTb39lAZ mVGR6jsnhefVtA== X-Received: by 10.99.48.71 with SMTP id w68mr26285935pgw.181.1493203018051; Wed, 26 Apr 2017 03:36:58 -0700 (PDT) Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id r77sm41597995pfe.105.2017.04.26.03.36.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Apr 2017 03:36:57 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 26 Apr 2017 19:36:54 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing In-Reply-To: <838tmnpjly.fsf@gnu.org> Message-ID: References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> <838tmnpjly.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, Tino Calancha , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Wed, 26 Apr 2017, Eli Zaretskii wrote: >> From: npostavs@users.sourceforge.net >> Date: Tue, 25 Apr 2017 08:50:00 -0400 >> Cc: 26650@debbugs.gnu.org >> >> diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el >> index 94b683dcb9..0aef94f1d2 100644 >> --- a/lisp/emacs-lisp/debug.el >> +++ b/lisp/emacs-lisp/debug.el >> @@ -753,6 +753,8 @@ debugger-mode >> \\{debugger-mode-map}" >> (setq truncate-lines t) >> (set-syntax-table emacs-lisp-mode-syntax-table) >> + (add-hook 'kill-buffer-hook >> + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) > > This will throw to top-level when _any_ buffer is killed, as long as > we are in recursive-edit, no? No, because `add-hook' is called with non-nil LOCAL arg. > Shouldn't this hook do that only for *Backtrace*? We can sandwich add-hook inside: (when (eq (current-buffer) (get-buffer "*Backtrace*")) (add-hook ... ) Then would be less general: just protect *Backtrace* for accidental killing. So far that was my request so i'm fine with that. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 06:49:31 2017 Received: (at 26650) by debbugs.gnu.org; 26 Apr 2017 10:49:31 +0000 Received: from localhost ([127.0.0.1]:40608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3KVm-0006XY-SI for submit@debbugs.gnu.org; Wed, 26 Apr 2017 06:49:31 -0400 Received: from mout.web.de ([212.227.17.11]:63038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3KVl-0006XD-EX for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 06:49:29 -0400 Received: from drachen.dragon ([88.73.21.103]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MAdst-1dF6jv3x9f-00Bpls; Wed, 26 Apr 2017 12:49:09 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> <838tmnpjly.fsf@gnu.org> Date: Wed, 26 Apr 2017 12:49:11 +0200 In-Reply-To: <838tmnpjly.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Apr 2017 13:07:53 +0300") Message-ID: <87d1bz4f6g.fsf@drachen> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:DcWDqmsYhG9Ng/W7OiCkjSGC8Gp0XHcPKmers4aM2gQARFq0RmH BtVtDTryLSiw2K4xHHOWnx2kaLqucOiu0X9/rG9V29mSzS7yMyctCyOErO8U6HUu352KDN4 Yl+rxiFvakxGOYdYktIbDmSs5KgAP0HQNUH0ti0mEJexAL+dxWjAnWpghX/pWUdX+g+waMZ XSP8RDU4AjtNnPMODZGNw== X-UI-Out-Filterresults: notjunk:1;V01:K0:TINZe2/bTlk=:YRDqFzpf1wZVwWpR/QPxsA NhwNF+/lwSQ4dDdwA3xZ0EFPpCxUeZxA/Gu5xtB9QgBN79617cJAG2l/qBu1lw+4NmoPWy69t uTSTeOlyVZ0Nc1HywH58P0MXoCLtwKERRR7Fa0j3ZZPRuNVMFRzqnmYgXJSG3YAO4zaiLEUVq pnK80lgRUChTcwVj4hMgPEu54p+evflsUlAVIpVQf3MxDpFLPbA972WHE9InYl8TYKEkps9kN P5C2EKxL+7XjNUTyxwql+OT0vOZ0a/IJOMtFJhYONs0CS6b4GzT31dC7lmzlA3KIc40fOG4hq VES/doNqRrxGS92KC8TpE4BC5oC2hFcjNYu8Z7S2SD8TVQO0tjYoHXFc5JwZy3ldGJt4Vfq0y lrMRpiH/ScjPtO3Jtqt205JXQ0gPqgSLTN3XfZ5yV0jHlrYa6bK7uCcejz0VC/IorF26pJIzM WDQDQKpWt+SvQgZIaOw70tt6OBePlAv1QRJwkojb5Ia9CMlfV0yE+9ghI71SHWtYVMtbYZuIy EExeXzSJ2tMyof5Up+UbRX4kFrGwz/gJYrG8e1iZKSENiRpU306zmrRFKeAcJ+KC4cSa4s8dy /Djbzczh9hhDEm0OVGBZpl5QmLfUBLUcOpnMWVmHir6aOvAP9AmC0EU2W1stxyG6pIYKQpyv7 1cbMY1RyIQqrvMBhuih+WxX6/En8yPnPM0GEN724mW4C+NZ+FoHlY9E83lMUEZFJdZI3eqJiX vdf6TnV46Z3wDiA8gvxkxFn5iOKTnQbnVzbB56GWrN6wrM2AjPPwz65yGdQebE7V3kcJGlwTZ yw1KSFl X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, tino.calancha@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > > From: npostavs@users.sourceforge.net > > Date: Tue, 25 Apr 2017 08:50:00 -0400 > > Cc: 26650@debbugs.gnu.org > > > > diff --git a/lisp/emacs-lisp/debug.el b/lisp/emacs-lisp/debug.el > > index 94b683dcb9..0aef94f1d2 100644 > > --- a/lisp/emacs-lisp/debug.el > > +++ b/lisp/emacs-lisp/debug.el > > @@ -753,6 +753,8 @@ debugger-mode > > \\{debugger-mode-map}" > > (setq truncate-lines t) > > (set-syntax-table emacs-lisp-mode-syntax-table) > > + (add-hook 'kill-buffer-hook > > + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) > > This will throw to top-level when _any_ buffer is killed, as long as > we are in recursive-edit, no? Is that a good idea? Shouldn't this > hook do that only for *Backtrace*? Did you notice that the lambda is added to the buffer-local binding of the hook? If you did, I don't understand why this would happen. If you didn't, maybe a line break should be added after the lambda expression? Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 07:04:26 2017 Received: (at 26650) by debbugs.gnu.org; 26 Apr 2017 11:04:26 +0000 Received: from localhost ([127.0.0.1]:40616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3KkE-0006xr-HS for submit@debbugs.gnu.org; Wed, 26 Apr 2017 07:04:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3KkC-0006xb-SE for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 07:04:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3Kk3-00075o-Sg for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 07:04:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3Kk3-00075k-Pi; Wed, 26 Apr 2017 07:04:15 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3689 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d3Kk3-0004E7-47; Wed, 26 Apr 2017 07:04:15 -0400 Date: Wed, 26 Apr 2017 14:03:36 +0300 Message-Id: <83wpa7o2gn.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Wed, 26 Apr 2017 19:36:54 +0900 (JST)) Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> <838tmnpjly.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Wed, 26 Apr 2017 19:36:54 +0900 (JST) > cc: npostavs@users.sourceforge.net, Tino Calancha , > 26650@debbugs.gnu.org > > >> + (add-hook 'kill-buffer-hook > >> + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) > > > > This will throw to top-level when _any_ buffer is killed, as long as > > we are in recursive-edit, no? > No, because `add-hook' is called with non-nil LOCAL arg. Right, sorry for not paying attention. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 08:51:02 2017 Received: (at 26650) by debbugs.gnu.org; 26 Apr 2017 12:51:02 +0000 Received: from localhost ([127.0.0.1]:40690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3MPO-0002wK-HU for submit@debbugs.gnu.org; Wed, 26 Apr 2017 08:51:02 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:35148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3MPM-0002vq-Ri for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 08:51:01 -0400 Received: by mail-it0-f67.google.com with SMTP id 70so350468ita.2 for <26650@debbugs.gnu.org>; Wed, 26 Apr 2017 05:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qF19qQ8NI0VIxWu9j3VKbtviqEJEGs3+j2tCddyEKH4=; b=nqvlXnw/WaHxrlePOYe2Nzu7C/oeJKyzEq7nOXrKBZE1DRvJi52pxeR5pwbeXK2Yzk 5xsXvWEswrxG3/x+eFaBi0viZv3W6ju58YUBMX4Vk4k07pSeOS7UVN51imBeoK8NCicm VVKs5bFNIIXVMcThydFHkR2z7Q5WXpNqkqCoNUnJfJBKkCo3rDlwPeECI4X/sy6gT/dV msnJrQY6chceA0mpNzN+88JPtZL/GitTV3RXq8dElzjc+CWtih+oqSQqnC9ECbeD3vnZ yXHQHVffj73Yk5EDZvDJK0BhqWGhzDobha07+Otzw9Hsswkq3d/JgwvJSrftj+205E28 tDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=qF19qQ8NI0VIxWu9j3VKbtviqEJEGs3+j2tCddyEKH4=; b=Zgiogz0+rYPcehyTRvAj96Jcbzaj+P7VXDCkkTHA8ounrdHUJAyryxEssjvI+JpDrX kiWflUxNBiPD0FQUSX7fziDx3SOgKdsjK2iCL17Or/9pzmH8WCP8sK8ChxnusCYnLXmh OhKL6UwJTaSU/Zk/NUMuObaWBZL2ZZUrAHp2J45Ne0BDX+0l3toTYYBKWXG5aSunGN+F yT6N0fNcD8s6hcaJdGkWlaFDd62aSeN5AmsElv3wUbZi1BMU5wb108xTWtBeIGzJqTSt aEg2+V3Guy40pQyLKgRHWAYD5sruE25OL8cBmbfpcoYpPpkK5qcW30g780mejxLrlthw aTTg== X-Gm-Message-State: AN3rC/7Fw5nisWq/bdZd/wjrGRrxyXzgTBj7M7RFBADkLdnaSvtJ+tGC bDz8InBIBzM2hw== X-Received: by 10.36.152.196 with SMTP id n187mr881814itd.28.1493211055116; Wed, 26 Apr 2017 05:50:55 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 66sm1527691ior.34.2017.04.26.05.50.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Apr 2017 05:50:54 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> <838tmnpjly.fsf@gnu.org> <83wpa7o2gn.fsf@gnu.org> Date: Wed, 26 Apr 2017 08:52:26 -0400 In-Reply-To: <83wpa7o2gn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Apr 2017 14:03:36 +0300") Message-ID: <87k267nxf9.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Eli Zaretskii writes: >> >> + (add-hook 'kill-buffer-hook >> >> + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) >> > >> > This will throw to top-level when _any_ buffer is killed, as long as >> > we are in recursive-edit, no? >> No, because `add-hook' is called with non-nil LOCAL arg. > > Right, sorry for not paying attention. Maybe I should have written (add-hook 'kill-buffer-hook (lambda ...) nil 'local) to emphasize this? I'm still undecided on the general style question of whether to use t or ' in these cases. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 09:57:34 2017 Received: (at 26650) by debbugs.gnu.org; 26 Apr 2017 13:57:35 +0000 Received: from localhost ([127.0.0.1]:41746 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3NRm-0004mc-Mo for submit@debbugs.gnu.org; Wed, 26 Apr 2017 09:57:34 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3NRl-0004mK-9e for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 09:57:33 -0400 Received: by mail-pg0-f66.google.com with SMTP id v1so222849pgv.3 for <26650@debbugs.gnu.org>; Wed, 26 Apr 2017 06:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=pG/kZgKyymT4uUYGDHnM30mm/hVu0SLfGDxLrVNhiZU=; b=HsAOYyAsgkaoMZYvBPXAI/AKpIQd8Azbzf9r1KI5vg/hcwVYtcI3ZQ/pKPaty0V//L ZE246JtuNCRt16yohGlyJeApuY5M+NEfcQ47Rll/TUd4BAYA8GK/4U2dvzIPCBLVrNVa t8MnEljgRogcyxRrRfcAnjoRO0wMG1LI7e8XPzamGMD6Ft1eAesseBlUytMSSl/g/VUg Zv+odHFMXonuzo138D5ZixjJ2jB7hTDvFMoV7LxjgWBnF40zj5XlKBwkBheHRupSWnsF ySO+1e2ehqJt9c4W37twJ1gC/BjgTdnCD/UsMXKLvKDa92DIKlTjFjliJozRTxnDSJpU tjqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=pG/kZgKyymT4uUYGDHnM30mm/hVu0SLfGDxLrVNhiZU=; b=ODillosxdSYxCcf/SItm61buxUTUDeKGeBr4v8Wan0prltJ5yovN+rCrQ3WiiRO8bl +yV59rBfolJRBr/Y61HOeXohwk9uEA8Bs9yjizL2Snxgz8UzVzKT8Q9O8ez1xmWOxqnK p3KeOxr1mCBE2c3Xv6BGvvTP9fGVL4IKkuhRF4sM8MYQNNxEd+dpC32SkIpxDTEEq7XN 2Ma7BhYFCgLbgMyGbOVk2DRI6sCTmZ4PlXhWU4pPAAVfCM+sSJLck/Fnxa5WLD4ZovSr sExUgtu1C4JYnmLaHIHL2bnRP3eLOAAK1TNS3lS4/DJucW8j553sIQKlrYejcYj3v3Ma Oa1g== X-Gm-Message-State: AN3rC/4jNBbSoLgzhgIw6iTVAJNvhploy4M25p3Xdo3u5NIGQQpI3YVQ xyVIrqP9/Nf8Iw== X-Received: by 10.99.111.1 with SMTP id k1mr32316608pgc.194.1493215047306; Wed, 26 Apr 2017 06:57:27 -0700 (PDT) Received: from calancha-pc (222.139.137.133.dy.bbexcite.jp. [133.137.139.222]) by smtp.gmail.com with ESMTPSA id c64sm687496pfa.110.2017.04.26.06.57.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Apr 2017 06:57:26 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 26 Apr 2017 22:57:23 +0900 (JST) X-X-Sender: calancha@calancha-pc To: npostavs@users.sourceforge.net Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing In-Reply-To: <87k267nxf9.fsf@users.sourceforge.net> Message-ID: References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> <838tmnpjly.fsf@gnu.org> <83wpa7o2gn.fsf@gnu.org> <87k267nxf9.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26650 Cc: Eli Zaretskii , 26650@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Wed, 26 Apr 2017, npostavs@users.sourceforge.net wrote: > Eli Zaretskii writes: > >>>>> + (add-hook 'kill-buffer-hook >>>>> + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) >>>> >>>> This will throw to top-level when _any_ buffer is killed, as long as >>>> we are in recursive-edit, no? >>> No, because `add-hook' is called with non-nil LOCAL arg. >> >> Right, sorry for not paying attention. > > Maybe I should have written > > (add-hook 'kill-buffer-hook (lambda ...) nil 'local) > > to emphasize this? I'm still undecided on the general style question of > whether to use t or ' in these cases. This reminds me the discussion here: https://github.com/bbatsov/emacs-lisp-style-guide/issues/30 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 11:33:46 2017 Received: (at 26650) by debbugs.gnu.org; 26 Apr 2017 15:33:46 +0000 Received: from localhost ([127.0.0.1]:41825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3Ows-0007C2-1l for submit@debbugs.gnu.org; Wed, 26 Apr 2017 11:33:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3Owq-0007Bo-6B for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 11:33:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3Owk-0005hm-CS for 26650@debbugs.gnu.org; Wed, 26 Apr 2017 11:33:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56501) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3Owk-0005hZ-6R; Wed, 26 Apr 2017 11:33:38 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4312 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d3Owj-0000TL-FY; Wed, 26 Apr 2017 11:33:37 -0400 Date: Wed, 26 Apr 2017 18:33:00 +0300 Message-Id: <83o9vjnpzn.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87k267nxf9.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> <838tmnpjly.fsf@gnu.org> <83wpa7o2gn.fsf@gnu.org> <87k267nxf9.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Cc: Tino Calancha , 26650@debbugs.gnu.org > Date: Wed, 26 Apr 2017 08:52:26 -0400 > > Eli Zaretskii writes: > > >> >> + (add-hook 'kill-buffer-hook > >> >> + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) > >> > > >> > This will throw to top-level when _any_ buffer is killed, as long as > >> > we are in recursive-edit, no? > >> No, because `add-hook' is called with non-nil LOCAL arg. > > > > Right, sorry for not paying attention. > > Maybe I should have written > > (add-hook 'kill-buffer-hook (lambda ...) nil 'local) > > to emphasize this? It's up to you, but the fact that I didn't see it is not a reason good enough to change anything, IMO. From debbugs-submit-bounces@debbugs.gnu.org Tue May 23 20:16:38 2017 Received: (at 26650) by debbugs.gnu.org; 24 May 2017 00:16:38 +0000 Received: from localhost ([127.0.0.1]:35251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDJyg-0001Lv-0U for submit@debbugs.gnu.org; Tue, 23 May 2017 20:16:38 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:36450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDJye-0001Gl-GT; Tue, 23 May 2017 20:16:36 -0400 Received: by mail-it0-f53.google.com with SMTP id o5so29543213ith.1; Tue, 23 May 2017 17:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1adRD2tyGtF60N+MfugTQsZnsXfg6HBdQRhC/2F8S4k=; b=SiDH9RGDU5J3rF8G0TvTiGkne1Vl362jNJsObHtrzA6V92urtbtXD2G+czFfQZhSn6 BAMWb6/kktyL2gCzpLWNcGriIkazSWo17sLmQ7KVhHr09Dav0fN80jMcb6E0bonbp90U /LpOTiVhqaQsoaEuw1t1Sfo832givH2/QbgW3sHtRRbsMs6Qv6p2o9lyxlxk075pSXSj 8I94+3mfqOZqAObjZyRQr/K7SnX5NihbtuLdSZFk7MTCtioVqKCQFyOXNVxiZxbnJeIW nunYneVxK87KmlRG1IvyvVsTkTBtW/BWtYnt2HmijNudtmS0RGuzQ7e7tyfsoI5sh3MI Ka2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=1adRD2tyGtF60N+MfugTQsZnsXfg6HBdQRhC/2F8S4k=; b=SzxlKBpgAXotxh5ApDJdlEy9YlEetppJL7V2jpW0Mk23DBEn+9vp+qH4h616YJYy8Z qhxII0T/LQDXRvC+K3FQkOg6FL2XGCh2aP2pwMDgehKwSrC2wqXGTHHgmOeiy7YiuY8z T8zLjtE0qcla8Jh+tXvZpxIt3wRq9DVvs8XAnNuW3j6TOtMEik0gKHxLIr3HqhYlx46W qvr09dPICkg0vBV4Vc9PTp1jX1GBNrxiaEgWRKtjiKQcuWhViOIMg/jF2NdTUWO2Em7o tQkiW/JBWb/GjAT3AfHzDYOZqV1+IcWMmhx2txx1YOzOLE15RFZyut0K7LCQdtYmhRRq 6OzA== X-Gm-Message-State: AODbwcDzQeAD03Ney1OFdhSTjFqw3CoHVWZAfew8HO26fqU+57Rbh87m wgtkEFOJHHTosw== X-Received: by 10.36.213.198 with SMTP id a189mr6049116itg.106.1495584990969; Tue, 23 May 2017 17:16:30 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id h189sm991356ith.6.2017.05.23.17.16.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 May 2017 17:16:30 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#26650: 26.0.50; Protect *Backtrace* from accidental killing References: <871ssgvgof.fsf@calancha-pc> <87wpa8ofcc.fsf@users.sourceforge.net> <87shkwodmv.fsf@users.sourceforge.net> <838tmnpjly.fsf@gnu.org> <83wpa7o2gn.fsf@gnu.org> <87k267nxf9.fsf@users.sourceforge.net> <83o9vjnpzn.fsf@gnu.org> Date: Tue, 23 May 2017 20:18:08 -0400 In-Reply-To: <83o9vjnpzn.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Apr 2017 18:33:00 +0300") Message-ID: <87zie35cqn.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26650 Cc: 26650@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 26650 fixed close 26650 26.1 quit Eli Zaretskii writes: >> >> >> + (add-hook 'kill-buffer-hook >> >> >> + (lambda () (if (> (recursion-depth) 0) (top-level))) nil t) >> >> > >> >> > This will throw to top-level when _any_ buffer is killed, as long as >> >> > we are in recursive-edit, no? >> >> No, because `add-hook' is called with non-nil LOCAL arg. >> > >> > Right, sorry for not paying attention. >> >> Maybe I should have written >> >> (add-hook 'kill-buffer-hook (lambda ...) nil 'local) >> >> to emphasize this? > > It's up to you, but the fact that I didn't see it is not a reason good > enough to change anything, IMO. Coming back to this, I found having the "... nil t)" on the same line as the lambda confusing to read. So I moved them to the next line; I didn't change the "t" to "local" [1: ef9f5c672a]. [1: ef9f5c672a]: 2017-05-23 20:11:23 -0400 Protect *Backtrace* from being killed (Bug#26650) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ef9f5c672a8e248dd7bd682101c03feb2e527340 From unknown Sat Jun 21 05:04:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 21 Jun 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator