From unknown Thu Jun 19 16:17:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26639 <26639@debbugs.gnu.org> To: bug#26639 <26639@debbugs.gnu.org> Subject: Status: 26.0.50; sxhash gives non-equal values for equal records Reply-To: bug#26639 <26639@debbugs.gnu.org> Date: Thu, 19 Jun 2025 23:17:31 +0000 retitle 26639 26.0.50; sxhash gives non-equal values for equal records reassign 26639 emacs submitter 26639 Damien Cassou severity 26639 normal tag 26639 confirmed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 24 10:50:09 2017 Received: (at submit) by debbugs.gnu.org; 24 Apr 2017 14:50:09 +0000 Received: from localhost ([127.0.0.1]:38127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2fJY-0000kN-MW for submit@debbugs.gnu.org; Mon, 24 Apr 2017 10:50:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2fJW-0000jo-EF for submit@debbugs.gnu.org; Mon, 24 Apr 2017 10:50:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2fJK-0000Nx-Vf for submit@debbugs.gnu.org; Mon, 24 Apr 2017 10:50:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2fJK-0000Nt-Rb for submit@debbugs.gnu.org; Mon, 24 Apr 2017 10:49:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2fJJ-0007N9-7C for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 10:49:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2fJG-0000N2-3t for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 10:49:53 -0400 Received: from mail.choca.pics ([62.210.108.126]:38566) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2fJF-0000Jn-Nf for bug-gnu-emacs@gnu.org; Mon, 24 Apr 2017 10:49:50 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 5F72B232AE29 for ; Mon, 24 Apr 2017 16:49:40 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id w9mMVVtLPLHI for ; Mon, 24 Apr 2017 16:49:39 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 3ED63232AE2A for ; Mon, 24 Apr 2017 16:49:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.choca.pics 3ED63232AE2A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=9EA44F5C-DEF4-11E6-A83F-A08DF322D8FB; t=1493045379; bh=Skz6uAwoBbzsbHI8r175X1sgHSv6jjkpAbFeD1J5YWQ=; h=From:To:Date:Message-ID:MIME-Version; b=Nt8DR3r9X/1S2zptT4G/fAbrcPfYDNePaaGC9o+RY045CqldaoZn5rm3GUJBZxSey aVC8iECGKOJi5zDKLJyLa54J4zC/H2PbAHtal3P14B03Mc1rNMxEDlUfPIW2MDFqJ2 G7dCNQNFyY11H9rclU2z0ae3h+KNGy/w/qh7YXn+Pg94ihN+ZCRjh2oj0VFepqb63m LtT7pM7/0IvD0tdPNW9proDoBaa6D8ffyN1bSOgLx9gBcxarLGim3IemPzuPnsmdhL xreMdiOTNJIc0H/W1mBustAtp/MVb7t+GEFL5cPqrAH8OJxQg42gM7HoCLvIE85nIn RCKBCiyQLmLEg== X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id Tn0pl23z7a1b for ; Mon, 24 Apr 2017 16:49:39 +0200 (CEST) Received: from luz4 (31-211-216-84.customers.ownit.se [31.211.216.84]) by mail.choca.pics (Postfix) with ESMTPSA id 014BB232AE29 for ; Mon, 24 Apr 2017 16:49:38 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: 26.0.50; gethash can't find value from equal key Date: Mon, 24 Apr 2017 16:49:35 +0200 Message-ID: <87h91d6etc.fsf@luz4> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) In emacs built from master today (53f8f4bf), evaluate this in the scratch buffer of `emacs -Q`: (cl-defstruct foo slot1 slot2) (setq foo1 (make-foo :slot1 "abc" :slot2 "cba")) (setq foo2 (make-foo :slot1 "abc" :slot2 "cba")) (equal foo1 foo2) ;; should be t (setq hytmp (make-hash-table :test 'equal)) (puthash foo1 'foobar hytmp) (gethash foo1 hytmp 'no) ;; should be 'foobar (gethash foo2 hytmp 'no) ;; should be 'foobar BUT IS 'no I'm expecting last line to return 'foobar instead of 'no. In GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-04-24 built on luz4 Repository revision: 53f8f4bf2db097f4a2c68194c55a87c5a1176c8c Windowing system distributor 'Fedora Project', version 11.0.11903000 System Description: Fedora release 25 (Twenty Five) Recent messages: Mark set [2 times] cl-lib foo #s(foo "abc" "cba") [2 times] t #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ( ...)) foobar [2 times] no GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-04-24 Making completion list... Configured using: 'configure --with-mailutils' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LC_MONETARY: fr_FR.UTF-8 value of $LC_NUMERIC: fr_FR.UTF-8 value of $LC_TIME: fr_FR.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils cl-seq cl-macs gv cl-loaddefs cl-lib time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 96944 8366) (symbols 48 20210 1) (miscs 40 48 194) (strings 32 17755 4844) (string-bytes 1 573035) (vectors 16 14717) (vector-slots 8 482626 4459) (floats 8 49 150) (intervals 56 269 33) (buffers 976 13)) -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 24 13:05:17 2017 Received: (at 26639) by debbugs.gnu.org; 24 Apr 2017 17:05:17 +0000 Received: from localhost ([127.0.0.1]:38217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2hQK-0007V3-Vv for submit@debbugs.gnu.org; Mon, 24 Apr 2017 13:05:17 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:53547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2hQI-0007Uv-SM for 26639@debbugs.gnu.org; Mon, 24 Apr 2017 13:05:15 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3wBXlY6gY3z1rDlX; Mon, 24 Apr 2017 19:05:13 +0200 (CEST) Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3wBXlY59csz3jgYf; Mon, 24 Apr 2017 19:05:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id b8NAqzGnCLXT; Mon, 24 Apr 2017 19:05:13 +0200 (CEST) X-Auth-Info: a7PLjpnKFFblFw217F/6QiXDRa4WKDetSDjV0c7jCmFng6xXakIesahwSL19kFCz Received: from igel.home (ppp-88-217-7-231.dynamic.mnet-online.de [88.217.7.231]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 24 Apr 2017 19:05:13 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 8A3782C4C86; Mon, 24 Apr 2017 19:05:12 +0200 (CEST) From: Andreas Schwab To: Damien Cassou Subject: Re: bug#26639: 26.0.50; gethash can't find value from equal key References: <87h91d6etc.fsf@luz4> X-Yow: Hand me a pair of leather pants and a CASIO keyboard -- I'm living for today! Date: Mon, 24 Apr 2017 19:05:12 +0200 In-Reply-To: <87h91d6etc.fsf@luz4> (Damien Cassou's message of "Mon, 24 Apr 2017 16:49:35 +0200") Message-ID: <8760htenxz.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 26639 Cc: 26639@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Apr 24 2017, Damien Cassou wrote: > In emacs built from master today (53f8f4bf), evaluate this in the > scratch buffer of `emacs -Q`: > > (cl-defstruct foo slot1 slot2) > (setq foo1 (make-foo :slot1 "abc" :slot2 "cba")) > (setq foo2 (make-foo :slot1 "abc" :slot2 "cba")) > > (equal foo1 foo2) ;; should be t Looks like sxhash doesn't correctly handle records: (= (sxhash foo1) (sxhash foo2)) => nil Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 25 01:58:05 2017 Received: (at submit) by debbugs.gnu.org; 25 Apr 2017 05:58:05 +0000 Received: from localhost ([127.0.0.1]:38741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2tUD-0000C1-Ar for submit@debbugs.gnu.org; Tue, 25 Apr 2017 01:58:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43127) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2tUB-0000BR-PM for submit@debbugs.gnu.org; Tue, 25 Apr 2017 01:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2tU5-0002W0-Ey for submit@debbugs.gnu.org; Tue, 25 Apr 2017 01:57:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50869) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2tU5-0002Vt-BE for submit@debbugs.gnu.org; Tue, 25 Apr 2017 01:57:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2tU3-0004Wo-SE for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2017 01:57:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2tTz-0002TC-1n for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2017 01:57:55 -0400 Received: from mail.choca.pics ([62.210.108.126]:49132) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2tTy-0002Sg-LC for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2017 01:57:50 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 62391232AE84; Tue, 25 Apr 2017 07:57:47 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id twSA7QNfVKuR; Tue, 25 Apr 2017 07:57:46 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 44DA5232AE85; Tue, 25 Apr 2017 07:57:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.choca.pics 44DA5232AE85 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=9EA44F5C-DEF4-11E6-A83F-A08DF322D8FB; t=1493099866; bh=9mlqKlIEGgct2nKFh8+yqsA8C9hvqZg9RTzgfg6q/5E=; h=From:To:Date:Message-ID:MIME-Version; b=Ug2Bd4Trc8erjEkvuD3eCVnAiGvXw17rpyO+//ec276fWvZy3Top0UjVXh0BMLnq6 o0Jenkd1ZoClc4V3ZViI+xXAxAlTteCWIxgqb6FPWqvCfpNfmILG7ZLCx0r1n+XVON fVDW9dt1a+wc39vQjrGWBkcKfqJBQVgxqRU9hbsgnPNsph5QhwWXcYIow1JLxICJ+V sPP8W5nk4wHY0WFYOqywNAFpqKpavqj0UlC53+MHuiEE4dXgG0t1y9q49OW3XeiVQk EyjlYsTGVhHG08+c6sKRQed3scm4MHdoHPHH18GAtX6Bpzn+Q2K7KadhaHPv+0ljES N1bYcZo/Se/Sg== X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id iMLv6gKFV_iH; Tue, 25 Apr 2017 07:57:46 +0200 (CEST) Received: from luz4 (31-211-216-84.customers.ownit.se [31.211.216.84]) by mail.choca.pics (Postfix) with ESMTPSA id EA236232AE84; Tue, 25 Apr 2017 07:57:45 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: Re: 26.0.50; gethash can't find value from equal key In-Reply-To: <87h91d6etc.fsf@luz4> References: <87h91d6etc.fsf@luz4> Date: Tue, 25 Apr 2017 07:57:41 +0200 Message-ID: <87d1c158ru.fsf@luz4> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: Lars Brinkhoff X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain The problem seems to be due to [056548283884d61b1b9637c3e56855ce3a17274d] Make cl-defstruct use records. I attach the result of git bisect as well as the script files I used to reproduce. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=script.el (let (foo1 foo2 hytmp) (require 'cl-lib) (cl-defstruct foo slot1 slot2) (setq foo1 (make-foo :slot1 "abc" :slot2 "cba")) (setq foo2 (make-foo :slot1 "abc" :slot2 "cba")) (equal foo1 foo2) (setq hytmp (make-hash-table :test 'equal)) (puthash foo1 'foobar hytmp) (when (eq 'no (gethash foo2 hytmp 'no)) (error "Problematic hash"))) --=-=-= Content-Type: application/x-sh Content-Disposition: attachment; filename=script.sh Content-Transfer-Encoding: base64 IyEvYmluL3NoCgojIGdvb2QgOiA1MTFhM2MzYmEyNzM1MmZkZTI2YWUyMzcxYTlkNGE2NGM2NDE4 MTIyCgpnaXQgY2xlYW4gLXhmZCA+IC9kZXYvbnVsbAooLi9hdXRvZ2VuLnNoICYmIC4vY29uZmln dXJlIC0tY2FjaGUtZmlsZT0vdG1wL2VtYWNzLmNvbmZpZy5jYWNoZSAmJiBtYWtlIC1qNCkgfHwg ZXhpdCAxMjUKc3JjL2VtYWNzIC0tYmF0Y2ggLVEgLS1sb2FkIH4vdG1wL3NjcmlwdC5lbCB8fCBl eGl0IDEKZXhpdCAwCg== --=-=-= Content-Type: text/plain Content-Disposition: attachment; filename=bisect.log # bad: [53f8f4bf2db097f4a2c68194c55a87c5a1176c8c] Fix XBM colour rendering in NS port (bug#22060) # good: [511a3c3ba27352fde26ae2371a9d4a64c6418122] Fix display of strike-through text in variable-height lines git bisect start 'origin/master' '511a3c3ba27352fde26ae2371a9d4a64c6418122' # good: [e69a5f5e456b39ad37f7d622386063548bea8208] * lisp/emacs-lisp/lisp-mode.el: Don't highlight \( at BOL git bisect good e69a5f5e456b39ad37f7d622386063548bea8208 # bad: [a2b3fea957440b8358d3632a4a05e41dee964b5d] Deprecate copy-record in favor of copy-sequence git bisect bad a2b3fea957440b8358d3632a4a05e41dee964b5d # good: [3887c54544bc2e5f8c2e7c12973887f9b2b88c40] Throw a `search-failed' derived error in Info search git bisect good 3887c54544bc2e5f8c2e7c12973887f9b2b88c40 # bad: [dd09e72ed6b1c6ba5c584e7aa32d98437d96326a] Allow a CANNOT_DUMP build to use exec-path during bootstrap. git bisect bad dd09e72ed6b1c6ba5c584e7aa32d98437d96326a # bad: [f1d34d9136fbf1dc2cf58b5ba36311451f024956] Minor cleanups related to type-of git bisect bad f1d34d9136fbf1dc2cf58b5ba36311451f024956 # bad: [f4b50dad8d5eade04f495c693c0bca46060b25cb] Make ediff handle remote and quoted file names git bisect bad f4b50dad8d5eade04f495c693c0bca46060b25cb # skip: [056548283884d61b1b9637c3e56855ce3a17274d] Make cl-defstruct use records. git bisect skip 056548283884d61b1b9637c3e56855ce3a17274d # bad: [8e6f204f44b6183ba73c7d1bec5841f2b7b8bdd0] Make EIEIO use records. git bisect bad 8e6f204f44b6183ba73c7d1bec5841f2b7b8bdd0 # good: [a2c33430292c79ac520100b1d0e8e7c04dfe426a] Add record objects with user-defined types. git bisect good a2c33430292c79ac520100b1d0e8e7c04dfe426a # only skipped commits left to test # possible first bad commit: [8e6f204f44b6183ba73c7d1bec5841f2b7b8bdd0] Make EIEIO use records. # possible first bad commit: [056548283884d61b1b9637c3e56855ce3a17274d] Make cl-defstruct use records. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 06 12:50:39 2017 Received: (at control) by debbugs.gnu.org; 6 May 2017 16:50:39 +0000 Received: from localhost ([127.0.0.1]:58444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d72ul-0005wE-9s for submit@debbugs.gnu.org; Sat, 06 May 2017 12:50:39 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:36946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d72uj-0005w2-O7 for control@debbugs.gnu.org; Sat, 06 May 2017 12:50:38 -0400 Received: by mail-it0-f53.google.com with SMTP id x188so22448146itb.0 for ; Sat, 06 May 2017 09:50:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=W6NQUKljOWxne4NyY5D8KAA59DmIJEZjwkqyx9zLh/U=; b=mWBRLuPEaE7BpHNhi1b4n1st5abA6p4ooX7VxlGcgB1KF45KO+7IH60/Cl+TbrziYe K77jbjv3xzGsJqv6r2JuIMPeKc7RHBFj9ZSCLyTdoDFqMBrPbIciP9KU/McD3HZGw6mC cEaJFXzu6QtoncRDQnKrla6D9Kl/8wYmLq2FI3iWN08LgiqaEDd/DI3zO/7YUAOtKuZL 3ljgXj0ev6HGnyc37597fJ3Npshv4bYenGEKO7l4CNqQI/mpMpeDPf25R7zd0Lv74ibq NQ/eShX6ZXWdIiRbPgVZ7sKzh8o2rHz4MBZ223NnW0JZp3xEGHsUs7XXJ9FJEvfFUSLA p68A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=W6NQUKljOWxne4NyY5D8KAA59DmIJEZjwkqyx9zLh/U=; b=RBCOQgvdJyRlhNwOrbDD0u7Qh0Sh1Rc3JUcLlQ0IcfjO4VErlTHC9gCf+qvZF2TIE4 EsXxO0xsNNev+yVxVeXRr1Qo+pgkx19NZW1zSvybo2EcaQPLjOcyJeE0QruAq7tawd+l FUZUPQdb4Ilt08E0ebiaEuNoNlsLGEitp9oH0i/KwQ0M47k3lQ4yxSTpnp6lT7vLXFce htKzuFgr927Khk3bYq2THvGA4lq4uk4RE1gDUiSA0wL35fVo58mcVdEJlDSqNZEDu8j4 FlVlIpUXbzbxnAPzpdB+xVb0MltF+cCaz5QjO/KKJ5qYAwYyq3fJze/mTej5Xhy+Web4 b7Jg== X-Gm-Message-State: AN3rC/4FIW5a9cFwdchJ61dKcNGaS/xH7K9u3DdwIQ/PI24vrCjVeSs/ T5+sbvZPvOyuh4Nf X-Received: by 10.36.66.67 with SMTP id i64mr13782937itb.22.1494089430879; Sat, 06 May 2017 09:50:30 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id w79sm2501613itb.11.2017.05.06.09.50.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 06 May 2017 09:50:30 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: Re: bug#26639: 26.0.50; gethash can't find value from equal key References: <87h91d6etc.fsf@luz4> <8760htenxz.fsf@linux-m68k.org> Date: Sat, 06 May 2017 12:52:03 -0400 In-Reply-To: <8760htenxz.fsf@linux-m68k.org> (Andreas Schwab's message of "Mon, 24 Apr 2017 19:05:12 +0200") Message-ID: <87r302kjws.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) retitle 26639 26.0.50; sxhash gives non-equal values for equal records tags 26639 confirmed quit Andreas Schwab writes: > On Apr 24 2017, Damien Cassou wrote: > >> (cl-defstruct foo slot1 slot2) >> (setq foo1 (make-foo :slot1 "abc" :slot2 "cba")) >> (setq foo2 (make-foo :slot1 "abc" :slot2 "cba")) >> >> (equal foo1 foo2) ;; should be t > > Looks like sxhash doesn't correctly handle records: > > (= (sxhash foo1) (sxhash foo2)) => nil From debbugs-submit-bounces@debbugs.gnu.org Wed May 24 11:47:36 2017 Received: (at control) by debbugs.gnu.org; 24 May 2017 15:47:36 +0000 Received: from localhost ([127.0.0.1]:36394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYVc-0003iG-3U for submit@debbugs.gnu.org; Wed, 24 May 2017 11:47:36 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:33273) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYVa-0003i3-AI for control@debbugs.gnu.org; Wed, 24 May 2017 11:47:34 -0400 Received: by mail-oi0-f43.google.com with SMTP id w10so247384022oif.0 for ; Wed, 24 May 2017 08:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=TR/5Gt9buQ4XWvC8qLhbjs5aKGooMTRk7W1+0TzgZB4=; b=pQfuINB2FTBruvIRQodSaqXMcH6HpYhblaPOFgdXUFiF+akQkuKh/uph5fBkboE7FV Ko0xjuhZI2W1fCjMFxoPl4ZvUYiNwzvxRQo3vxfs+Rt3Zb6Uun2YfDmGFmDhemvAPmts irmlNo5sQxUoiBTj62GO/qdfrUQRyAgnIEz7CcrJci0WjMUJ5y9yqDcWdry0HN7NpYUB H7zaML46XEExlbgPJfP10ev7BWdmVaTH+Srhf0XoQHUojBToUrMIpm/wVeeYmY8LzMbz uVp9NnAVSgWFItJVN+i8bWW1mXHJU5xLVcozGVt07xsHnTLf1DFwC64tPJTbv5JyAmoc YEGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=TR/5Gt9buQ4XWvC8qLhbjs5aKGooMTRk7W1+0TzgZB4=; b=Nae0Vf59tu3ISj+ToujAspIIjaUZ1h3QAkFmPOWoiL2EjEOj29qzWjpYSN8lB0KPEb rbwZBpzmEF3KRyhDk0Hyxj+JkiEr7mgSc3iZuv01SemguP495g9foAoU1FMWU0zSdBYM TBIpIBtv6pdtD6A0yw7tahNueM+mAOuGbAQn4WMaZwF5GWk6zUi+Nff43FhufHzxFgoN dJwkUlUJLLTZ/RdzXPEvJJYF1bQ/Rb1Y7tSQ4wx9Vh9ziYaTOroUkPmMeIz3Cgfa1XCG 1cHi03ZimcVvYBy1Mo02uJbT0d8ivqLVoZOlozOGllQ8kcLKY78zZ20nF31bMTWdb3xi VaRQ== X-Gm-Message-State: AODbwcDjeghhfPNgcbBNw2Ch3wG5mz8ghbRV7rS9vprLtHOaajF9Jd49 zLVrC3pStSyc+nqP2oi1Hq062YoGdVlL X-Received: by 10.157.29.235 with SMTP id w40mr5215495otw.128.1495640848275; Wed, 24 May 2017 08:47:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.139.83 with HTTP; Wed, 24 May 2017 08:47:27 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Wed, 24 May 2017 11:47:27 -0400 X-Google-Sender-Auth: zzvseyb65EFTHM1FiiYz9Skyjrc Message-ID: Subject: Re: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash To: GNU bug tracker automated control server Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) merge 27057 26639 quit From debbugs-submit-bounces@debbugs.gnu.org Wed May 24 11:56:34 2017 Received: (at 26639-done) by debbugs.gnu.org; 24 May 2017 15:56:34 +0000 Received: from localhost ([127.0.0.1]:36406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYeH-0003vi-8f for submit@debbugs.gnu.org; Wed, 24 May 2017 11:56:33 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:13773) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYeF-0003vM-R2; Wed, 24 May 2017 11:56:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DPBgCzrCVZ/7vmSC1cGwEBAQMBAQEJAQEBg1VChE2FWoV/kRMBl1ochgIEAgKCbUMVAQIBAQEBAQEBayiFGQZWIxALNBIUGA0lijivLYtAAQEBAQEBBAEBAQEki1mKVgEEniOVFgGJDIZ8lE41IoEKLyAIL4U8HYF/JIlZAQEB X-IPAS-Result: A0DPBgCzrCVZ/7vmSC1cGwEBAQMBAQEJAQEBg1VChE2FWoV/kRMBl1ochgIEAgKCbUMVAQIBAQEBAQEBayiFGQZWIxALNBIUGA0lijivLYtAAQEBAQEBBAEBAQEki1mKVgEEniOVFgGJDIZ8lE41IoEKLyAIL4U8HYF/JIlZAQEB X-IronPort-AV: E=Sophos;i="5.38,386,1491278400"; d="scan'208";a="313485316" Received: from 45-72-230-187.cpe.teksavvy.com (HELO pastel.home) ([45.72.230.187]) by smtp.teksavvy.com with ESMTP; 24 May 2017 11:56:25 -0400 Received: by pastel.home (Postfix, from userid 20848) id 86F6662DA8; Wed, 24 May 2017 11:56:25 -0400 (EDT) From: Stefan Monnier To: 27057-done@debbugs.gnu.org, 26639-done@debbugs.gnu.org Subject: Re: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash Message-ID: References: Date: Wed, 24 May 2017 11:56:25 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 24 May 2017 11:39:56 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 26639-done Cc: Lars Brinkhoff , Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (progn > (cl-defstruct sm-foo a b) > (setq sm-hash (make-hash-table :test 'equal)) > (puthash (make-sm-foo :a 4 :b 6) "test1" sm-hash) > (puthash (make-sm-foo :a 4 :b 6) "test2" sm-hash) > (hash-table-count sm-hash)) > > this code return 2 here instead of 1. This should be fixed now, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 24 12:02:16 2017 Received: (at 26639-done) by debbugs.gnu.org; 24 May 2017 16:02:16 +0000 Received: from localhost ([127.0.0.1]:36428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYjo-0005qy-Kk for submit@debbugs.gnu.org; Wed, 24 May 2017 12:02:16 -0400 Received: from mout.gmx.net ([212.227.17.21]:52456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dDYjk-0005js-8H; Wed, 24 May 2017 12:02:12 -0400 Received: from detlef.gmx.de ([212.86.45.192]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MSMr9-1dOrFA16p1-00TXLg; Wed, 24 May 2017 18:02:03 +0200 From: Michael Albinus To: Stefan Monnier Subject: Re: bug#27057: 26.0.50; Equal defstruct objects not recognized in puthash References: Date: Wed, 24 May 2017 18:02:01 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 24 May 2017 11:56:25 -0400") Message-ID: <874lwa9rba.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:D6d1xTHgF1vT1pnGflJd31nkL/avCX5sBQBsYpOV93wBMWrPnVP xpFKlldG0B83WTI5I5AdyRBfhZreSdTRGZWB/itAi1l738DUEdQFoWn/3gdppb6RnfjlqhK yIeFlbNP4ZRa3o5fXKjzGb4VedOa7lye/pvJ68CzQH8ws/QWWWli7Y1qelCSHC5D7zBCKcZ ibk2NQjEJf2GeU6tYpV3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:7Qfnk+peNj0=:YgHbdlZbm7SPnnfswEvxpv xtBkTpkn7GR7abpmQkLOQ7mru48L6XLKjOBD5G3WopEy51GYrn+i7IpSQbGLHArhD39DFV2X1 II3+ZzJchHCUWBd3Q4v7uDyGwUqmOTGEvCJOTMbWQruFjbjDXx2leqdMvXpJENBNbX7K1wDKN iLV1BG3dsntsBFNc6FznN/lfR0+MZ17OIyYC1BTgBakmCVsWFHiq0K+jfDizQOPHVJtEo+Lat EaaYJj8CUVZxZQyZrvOoayEOa3mj75/zh1x4CXqxAWPIePtp+6fPV7AB8pyw16z7MxSxbMTkg L6kri28Ia0KCG1Qzppc2ueYGLVNzqCkm/LZH0r24tOJsmz4u4fXafpoyp1R9KeTxo+e1qXPC6 FCkRyML/acxxktPa5BGhWWzr4D0TLlQV48i8Sv6QfpyzvkwnZAy6SPYO/xIZiV3+E+GBnQ8CX q6fCW8PFj0gHkpmCrKf0dubZ48L5DljyH3P3Vx1wJCSrEgMantzK1xzpPN+yYW2VkS7QXTA7P TLVRCn5U7JKZjnLjv5j0zgdMQcWOjRDjcctQJcljr/t6euAuIemyTuhO8qjmhodGzp8nSsXig YXpBqqy0VQahhWnD1K/ElHL4DAapU5jKWwbRsq1cTnpTVoYQvCg1auptc3l3zU6q39eJpYDTZ 8nFvA44sitVHDpaYioXtpSu4LsPTcpn84OUp8PqRIZo+i9bLCAQ0bwPK4YqU2GCVLqsRGDMh9 i6dS2YWCGYHHuwcTCAO194RH9HA3nJMB3dnrg2SLy3W2k7T68l8VqVIy8+jxG8z2wdLf4xEkV vVtlRKi X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 26639-done Cc: Lars Brinkhoff , 27057-done@debbugs.gnu.org, 26639-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.5 (---) Stefan Monnier writes: Hi Stefan >> this code return 2 here instead of 1. > > This should be fixed now, Thanks. But for Tramp, I'll keep the list type, due to backward compatibility. > Stefan Best regards, Michael. From unknown Thu Jun 19 16:17:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 22 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator