From unknown Sun Jun 22 00:10:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient Resent-From: Anders Waldenborg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Apr 2017 19:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 26628@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149297541012371 (code B ref -1); Sun, 23 Apr 2017 19:24:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Apr 2017 19:23:30 +0000 Received: from localhost ([127.0.0.1]:36757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2N6X-0003DR-Nr for submit@debbugs.gnu.org; Sun, 23 Apr 2017 15:23:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2N6W-0003DF-1w for submit@debbugs.gnu.org; Sun, 23 Apr 2017 15:23:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2N6Q-0002mR-95 for submit@debbugs.gnu.org; Sun, 23 Apr 2017 15:23:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56141) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d2N6Q-0002mN-6W for submit@debbugs.gnu.org; Sun, 23 Apr 2017 15:23:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2N6P-0002Ut-5f for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2017 15:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2N6M-0002lo-1i for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2017 15:23:21 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2N6L-0002lc-RF for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2017 15:23:17 -0400 Received: by mail-wm0-f45.google.com with SMTP id m123so51664309wma.0 for ; Sun, 23 Apr 2017 12:23:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZkASi0ReQqJ9jH5++RoipusOAsuOY1K+By/5Z7LN9Uo=; b=CTz3du5hOVzTxWdFOO87AayiWC8QbkrkZq1zb0HdC9KjqSHlYOqAn50JhxxtiHXQq+ CN9PbGar0aKYj/f+OaBQbGQ4+HrpYJNW6oo4X47uLyRK6Yp4Qqnt/vy5gIWSxzQRTWld mWHLYnSapuldkEwygxsZkUcNDx6ZL6F1SzJJJ1vG9YBSUxxvwEhV10RTXgDSn1ZcUaGa ZzbkaiSwCHbhtwOU/EYFxOfBpA1N/ys3Pb5u5xItuqhlpo+VWCYMEAqlZ5TYKjRC+v6Y Y6PhjJmNJQyE8WQXql/5K6VoL07pFa+bcrDZZE5KqhMHew1l8iMVx220G3Lg9FKaFkOr 6bbw== X-Gm-Message-State: AN3rC/7k2SSlBSPbAbCiCfzf/A4FxBh0IU9D42sQdu/yXAyNh2gZjiM6 sTz45ZcqFimD6qgbUEc= X-Received: by 10.28.37.3 with SMTP id l3mr6985313wml.100.1492975394960; Sun, 23 Apr 2017 12:23:14 -0700 (PDT) Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com. [74.125.82.43]) by smtp.gmail.com with ESMTPSA id 38sm19793015wru.1.2017.04.23.12.23.14 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Apr 2017 12:23:14 -0700 (PDT) Received: by mail-wm0-f43.google.com with SMTP id w64so47553577wma.0 for ; Sun, 23 Apr 2017 12:23:14 -0700 (PDT) X-Received: by 10.28.51.9 with SMTP id z9mr6637160wmz.77.1492975393831; Sun, 23 Apr 2017 12:23:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.182.145 with HTTP; Sun, 23 Apr 2017 12:23:13 -0700 (PDT) From: Anders Waldenborg Date: Sun, 23 Apr 2017 21:23:13 +0200 X-Gmail-Original-Message-ID: Message-ID: Content-Type: multipart/mixed; boundary=001a114445d202a186054dda6ca3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --001a114445d202a186054dda6ca3 Content-Type: multipart/alternative; boundary=001a114445d202a180054dda6ca1 --001a114445d202a180054dda6ca1 Content-Type: text/plain; charset=UTF-8 The attached patch fixes a tiny memory leak in emacsclient. --001a114445d202a180054dda6ca1 Content-Type: text/html; charset=UTF-8

The attached patch fixes a tiny memory leak in emacsclient.

--001a114445d202a180054dda6ca1-- --001a114445d202a186054dda6ca3 Content-Type: text/x-patch; charset=US-ASCII; name="0001-Fix-memory-leak-of-cwd-string-in-emacsclient.patch" Content-Disposition: attachment; filename="0001-Fix-memory-leak-of-cwd-string-in-emacsclient.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j1v2wmml0 RnJvbSBhNjczYWNlYWI0ZWIwYmNmYTRlNmZmMzRjMDJhZGM0NTMzODM4MDViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRlcnMgV2FsZGVuYm9yZyA8YW5kZXJzQDB4NjMubnU+CkRh dGU6IFN1biwgMjMgQXByIDIwMTcgMjE6MTU6NDYgKzAyMDAKU3ViamVjdDogW1BBVENIXSBGaXgg bWVtb3J5IGxlYWsgb2YgY3dkIHN0cmluZyBpbiBlbWFjc2NsaWVudAoKKiBsaWItc3JjL2VtYWNz Y2xpZW50LmMgKG1haW4pOiBlbWFjc2NsaWVudCByZXRyaWV2ZXMgdGhlIGN1cnJlbnQKICB3b3Jr aW5nIGRpcmVjdG9yeSB1c2luZyBnZXRfY3VycmVudF9kaXJfbmFtZSB3aGljaCByZXR1cm5zIGEg bmV3bHkKICBhbGxvY2F0ZWQgc3RyaW5nLiBNYWtlIHN1cmUgdGhpcyBzdHJpbmcgaXMgZnJlZWQg YmVmb3JlIGV4aXRpbmcuCi0tLQogbGliLXNyYy9lbWFjc2NsaWVudC5jIHwgMiArKwogMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL2xpYi1zcmMvZW1hY3NjbGll bnQuYyBiL2xpYi1zcmMvZW1hY3NjbGllbnQuYwppbmRleCBjMjJiMzA4Li4zZmZiOWVhIDEwMDY0 NAotLS0gYS9saWItc3JjL2VtYWNzY2xpZW50LmMKKysrIGIvbGliLXNyYy9lbWFjc2NsaWVudC5j CkBAIC0xOTAxLDYgKzE5MDEsOCBAQCBtYWluIChpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiAgIGlm IChybCA8IDApCiAgICAgZXhpdF9zdGF0dXMgPSBFWElUX0ZBSUxVUkU7CiAKKyAgZnJlZSAoY3dk KTsKKwogICBDTE9TRV9TT0NLRVQgKGVtYWNzX3NvY2tldCk7CiAgIHJldHVybiBleGl0X3N0YXR1 czsKIH0KLS0gCjIuNy40Cgo= --001a114445d202a186054dda6ca3-- From unknown Sun Jun 22 00:10:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Apr 2017 09:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Anders Waldenborg Cc: 26628@debbugs.gnu.org Received: via spool by 26628-submit@debbugs.gnu.org id=B26628.149302581016331 (code B ref 26628); Mon, 24 Apr 2017 09:24:02 +0000 Received: (at 26628) by debbugs.gnu.org; 24 Apr 2017 09:23:30 +0000 Received: from localhost ([127.0.0.1]:37099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2aDR-0004FL-Od for submit@debbugs.gnu.org; Mon, 24 Apr 2017 05:23:29 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:51994) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2aDP-0004FD-NS for 26628@debbugs.gnu.org; Mon, 24 Apr 2017 05:23:28 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3wBLVl21jpz1r55f; Mon, 24 Apr 2017 11:23:27 +0200 (CEST) Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3wBLVl1C3jz3jgYB; Mon, 24 Apr 2017 11:23:27 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id h09lGdCaAmNy; Mon, 24 Apr 2017 11:23:26 +0200 (CEST) X-Auth-Info: u56fR5GXy3hnvHzP+xohcox0OkivorK4XltL+lLDu62owNZFNHH9S66xidc4MhM7 Received: from igel.home (ppp-88-217-7-231.dynamic.mnet-online.de [88.217.7.231]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Mon, 24 Apr 2017 11:23:26 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 0C9292C428F; Mon, 24 Apr 2017 11:23:26 +0200 (CEST) From: Andreas Schwab References: X-Yow: That's a decision that can only be made between you & SY SPERLING!! Date: Mon, 24 Apr 2017 11:23:26 +0200 In-Reply-To: (Anders Waldenborg's message of "Sun, 23 Apr 2017 21:23:13 +0200") Message-ID: <87zif6dur5.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Apr 23 2017, Anders Waldenborg wrote: > * lib-src/emacsclient.c (main): emacsclient retrieves the current > working directory using get_current_dir_name which returns a newly > allocated string. Make sure this string is freed before exiting. There is no need to free it since the process exists right away anyway. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Sun Jun 22 00:10:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient Resent-From: Anders Waldenborg Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Apr 2017 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: 26628@debbugs.gnu.org Received: via spool by 26628-submit@debbugs.gnu.org id=B26628.149304996216735 (code B ref 26628); Mon, 24 Apr 2017 16:07:02 +0000 Received: (at 26628) by debbugs.gnu.org; 24 Apr 2017 16:06:02 +0000 Received: from localhost ([127.0.0.1]:38188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2gUz-0004Lm-Vo for submit@debbugs.gnu.org; Mon, 24 Apr 2017 12:06:02 -0400 Received: from 0x63.nu ([109.74.10.199]:54781 helo=gagarin.0x63.nu ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2gUx-0004LX-S8 for 26628@debbugs.gnu.org; Mon, 24 Apr 2017 12:06:00 -0400 Received: from andersg by gagarin.0x63.nu with local (Exim 4.80) (envelope-from ) id 1d2gUp-0001aE-IQ; Mon, 24 Apr 2017 18:05:51 +0200 Date: Mon, 24 Apr 2017 18:05:51 +0200 From: Anders Waldenborg Message-ID: <20170424160551.GA4913@gagarin.0x63.nu> References: <87zif6dur5.fsf@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zif6dur5.fsf@linux-m68k.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: andersg@gagarin.0x63.nu X-SA-Exim-Scanned: No (on gagarin.0x63.nu); SAEximRunCond expanded to false X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Mon, Apr 24, 2017 at 11:23:26AM +0200, Andreas Schwab wrote: > > * lib-src/emacsclient.c (main): emacsclient retrieves the current > > working directory using get_current_dir_name which returns a newly > > allocated string. Make sure this string is freed before exiting. > > There is no need to free it since the process exists right away anyway. Yes. Unless you compile with -fsanitize=address and this leak makes emacsclient mostly unusable as the asan leak checker will change the return code to non-zero (yes I'm aware that I can set ASAN_OPTIONS=detect_leaks=0 in the environment). anders From unknown Sun Jun 22 00:10:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jun 2017 02:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Andreas Schwab Cc: Anders Waldenborg , 26628@debbugs.gnu.org Received: via spool by 26628-submit@debbugs.gnu.org id=B26628.149628590228496 (code B ref 26628); Thu, 01 Jun 2017 02:59:02 +0000 Received: (at 26628) by debbugs.gnu.org; 1 Jun 2017 02:58:22 +0000 Received: from localhost ([127.0.0.1]:48240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGGJZ-0007PT-NC for submit@debbugs.gnu.org; Wed, 31 May 2017 22:58:21 -0400 Received: from mail-io0-f172.google.com ([209.85.223.172]:34972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGGJW-0007PA-Si; Wed, 31 May 2017 22:58:19 -0400 Received: by mail-io0-f172.google.com with SMTP id f102so25521659ioi.2; Wed, 31 May 2017 19:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=I1oPVBQJUcEz+WNyTs/aBvYee115UGscY9EmHHR0D9I=; b=PFKdoJ5pPUji2TrNS9PEaMwpa+0SBjeAvxvCZZPXPNlugUmAAwrVZvbU+o+NQzVPYK ooTKs0CENuN8q9/w34KrohKasnzGLIyuLYMte38zF6+cpGxj54oyE5IJj0U+SbKbWYlb ZfuMbxLIORPhPItNK5+fHpEkThHw/X+v0zeO3RU1GwAJDKkjYZVp8t0y/fEOgRJTS2Vr 5O9Ji1nzsh6i2gUdPYqf6ESbOYDyp5PHUoShl7JZKQW6+LIXB9lq08d95qZxJLiU9V6o +l6fcYk8IDw+/lYTFXWS3MTZgFdcrABuLMQfi74iJh61HCh0uwBLPxbxCajUGSnkvjc7 2X5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=I1oPVBQJUcEz+WNyTs/aBvYee115UGscY9EmHHR0D9I=; b=iNKnxEp8jQyxLZlk5ANo2MxSP0bqJgItJXxm4rm+IGbI5NA4hxwn6IMI+BE19x9Fo4 aNTKZiJ6waiBPnH4w7bXKylMBOYTE4HiZApuR7Q4rsl2yWBaCp+SOUCVXq2tEshd0GXi 8sE2ZSVYlXZs1vBnqU4QcYa+jWCO24FtnOdjtlhYbB+sBSSbKdvF15OY1q0FF89BiYT6 roqlrG4FTu9afxPXmjlVy4k1E03kuWts3zAF68C5aeroFHq5Dz16rqRgqd7EIrs3iUwb T8JRQ2MgHzw2u2e7G1rmVaVxE5QCrqsn8Z1ypA3pwRf/JPQ4vLHLxBcjY+rur2mVC4QQ Pd0Q== X-Gm-Message-State: AODbwcA2Rq+5rD5W67X2qO9C3VYDMKvBjbsL1FxwodjMq86qkGNcAYba hoJdxLNdXO1XBTGs X-Received: by 10.107.28.70 with SMTP id c67mr25338012ioc.142.1496285892991; Wed, 31 May 2017 19:58:12 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g198sm11880355itb.29.2017.05.31.19.58.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 May 2017 19:58:11 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87zif6dur5.fsf@linux-m68k.org> Date: Wed, 31 May 2017 22:59:49 -0400 In-Reply-To: <87zif6dur5.fsf@linux-m68k.org> (Andreas Schwab's message of "Mon, 24 Apr 2017 11:23:26 +0200") Message-ID: <87fufk2z16.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 26628 fixed close 26628 26.1 quit Andreas Schwab writes: > On Apr 23 2017, Anders Waldenborg wrote: > >> * lib-src/emacsclient.c (main): emacsclient retrieves the current >> working directory using get_current_dir_name which returns a newly >> allocated string. Make sure this string is freed before exiting. > > There is no need to free it since the process exists right away anyway. On the other hand, it doesn't really hurt to free it either, pushed to master [1: c221f1466e]. [1: c221f1466e]: 2017-05-31 22:58:30 -0400 Fix memory leak of cwd string in emacsclient (Bug#26628) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=c221f1466ed7e0f11f142d9cb3c0247b10e511c6 From unknown Sun Jun 22 00:10:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26628: [PATCH] Fix memory leak of cwd string in emacsclient References: In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 Jun 2017 06:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26628 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: npostavs@users.sourceforge.net Cc: Anders Waldenborg , 26628@debbugs.gnu.org Received: via spool by 26628-submit@debbugs.gnu.org id=B26628.149629866422276 (code B ref 26628); Thu, 01 Jun 2017 06:32:01 +0000 Received: (at 26628) by debbugs.gnu.org; 1 Jun 2017 06:31:04 +0000 Received: from localhost ([127.0.0.1]:48325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGJdP-0005nE-M3 for submit@debbugs.gnu.org; Thu, 01 Jun 2017 02:31:03 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGJdN-0005mf-PT for 26628@debbugs.gnu.org; Thu, 01 Jun 2017 02:31:02 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BBF421600C7; Wed, 31 May 2017 23:30:55 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id k9Pud1R25FA4; Wed, 31 May 2017 23:30:54 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2B9BD1600A7; Wed, 31 May 2017 23:30:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 9UwLgb0ACQap; Wed, 31 May 2017 23:30:54 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.188.248]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0B9E81600D1; Wed, 31 May 2017 23:30:54 -0700 (PDT) From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <6cc3d07a-0387-8d88-4bc2-e127f86b97f7@cs.ucla.edu> Date: Wed, 31 May 2017 23:30:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5237B341C12D132202C7D6D5" Content-Language: en-US X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------5237B341C12D132202C7D6D5 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Generally speaking we don't bother freeing storage just before program ex= it=20 merely to pacify AddressSanitizer, as that makes the program less efficie= nt and=20 is contrary to the goal of leak checking which is to increase efficiency.= Here,=20 though, we can free storage earlier, and this might have a point since th= e=20 storage can get reused. So I installed the attached further patch. > I'm aware that I can set ASAN_OPTIONS=3Ddetect_leaks=3D0 in the environ= ment It might not hurt to do that, if only to prevent our hassling with false = alarms. --------------5237B341C12D132202C7D6D5 Content-Type: text/plain; charset=UTF-8; name="0001-Free-cwd-when-no-longer-needed.txt" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Free-cwd-when-no-longer-needed.txt" RnJvbSA4NzdlODA4NDQwZDRiYzJlNjJkNmZiNTA5ZGVmZWU5MWEzZmRjODk1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDMxIE1heSAyMDE3IDIyOjM4OjA0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gRnJlZSBjd2Qgd2hlbiBubyBsb25nZXIgbmVlZGVkCk1JTUUtVmVyc2lvbjogMS4wCkNv bnRlbnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVy LUVuY29kaW5nOiA4Yml0CgoqIGxpYi1zcmMvZW1hY3NjbGllbnQuYyAobWFpbik6IERvbuKA mXQgZGFsbHkgd2hlbiBmcmVlaW5nIGN3ZC4KLS0tCiBsaWItc3JjL2VtYWNzY2xpZW50LmMg fCA1ICsrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL2xpYi1zcmMvZW1hY3NjbGllbnQuYyBiL2xpYi1zcmMvZW1h Y3NjbGllbnQuYwppbmRleCAzYTA3MTVmLi44ODI4Yjc2IDEwMDY0NAotLS0gYS9saWItc3Jj L2VtYWNzY2xpZW50LmMKKysrIGIvbGliLXNyYy9lbWFjc2NsaWVudC5jCkBAIC0yMDgsNyAr MjA4LDcgQEAgY2hhciAqZ2V0X2N1cnJlbnRfZGlyX25hbWUgKHZvaWQpOwogLyogUmV0dXJu IHRoZSBjdXJyZW50IHdvcmtpbmcgZGlyZWN0b3J5LiAgUmV0dXJucyBOVUxMIG9uIGVycm9y cy4KICAgIEFueSBvdGhlciByZXR1cm5lZCB2YWx1ZSBtdXN0IGJlIGZyZWVkIHdpdGggZnJl ZS4gIFRoaXMgaXMgdXNlZAogICAgb25seSB3aGVuIGdldF9jdXJyZW50X2Rpcl9uYW1lIGlz IG5vdCBkZWZpbmVkIG9uIHRoZSBzeXN0ZW0uICAqLwotY2hhcioKK2NoYXIgKgogZ2V0X2N1 cnJlbnRfZGlyX25hbWUgKHZvaWQpCiB7CiAgIGNoYXIgKmJ1ZjsKQEAgLTE3MDIsNiArMTcw Miw3IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJndikKICAgaWYgKHRyYW1wX3ByZWZp eCkKICAgICBxdW90ZV9hcmd1bWVudCAoZW1hY3Nfc29ja2V0LCB0cmFtcF9wcmVmaXgpOwog ICBxdW90ZV9hcmd1bWVudCAoZW1hY3Nfc29ja2V0LCBjd2QpOworICBmcmVlIChjd2QpOwog ICBzZW5kX3RvX2VtYWNzIChlbWFjc19zb2NrZXQsICIvIik7CiAgIHNlbmRfdG9fZW1hY3Mg KGVtYWNzX3NvY2tldCwgIiAiKTsKIApAQCAtMTk0NSw4ICsxOTQ2LDYgQEAgbWFpbiAoaW50 IGFyZ2MsIGNoYXIgKiphcmd2KQogICBpZiAocmwgPCAwKQogICAgIGV4aXRfc3RhdHVzID0g RVhJVF9GQUlMVVJFOwogCi0gIGZyZWUgKGN3ZCk7ICAgICAgICAgICAgICAgICAgIC8qIEtl ZXAgbGVhayBjaGVja2VycyBoYXBweS4gICovCi0KICAgQ0xPU0VfU09DS0VUIChlbWFjc19z b2NrZXQpOwogICByZXR1cm4gZXhpdF9zdGF0dXM7CiB9Ci0tIAoyLjcuNAoK --------------5237B341C12D132202C7D6D5--