Subject: bug#26622: closed (Re: bug#26622: [PATCH] Add freexl)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 25 Apr 2017 20:17:02 +0000

Your bug report

#26622: [PATCH] Add freexl

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
26622: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26622
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#26622: [PATCH] Add freexl
From: Ricardo Wurmus <[email-masked]>
To: Catonano <[email-masked]>
Cc: [email-masked]
Date: Tue, 25 Apr 2017 22:16:18 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Catonano <[email-masked]> writes:

> Another xls files reading library.
>
> The home page of Freexl says
>
> FreeXL is licensed under the MPL tri-license terms; you are free to choose
> the best-fit license between:
>
> the MPL 1.1
> the GPL v2.0 or any subsequent version
> the LGPL v2.1 or any subsequent version
>
> I'm not sure what this means for Guix

This means that we write something like this:

    ;; Any of these licenses may be chosen.
    (license (list license:mpl1.1
                   license:gpl2+
                   license:lgpl2.1+))

> Subject: [PATCH 1/1] gnu: Add freexl
>
> * gnu/packages/xml.scm (freexl): New variable.
> ---
>  gnu/packages/xml.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
> index 7460b5d85..02ae00514 100644
> --- a/gnu/packages/xml.scm
> +++ b/gnu/packages/xml.scm
> @@ -1122,3 +1122,23 @@ files.  It is designed to be fast and to handle large input files.")
>       "libxls is a C library which can read Excel (xls) files since Excel 97 (the BIFF8 format).
>  libxls cannot write Excel files.")
>      (license license:bsd-2)))
> +
> +(define-public freexl
> +  (package
> +    (name "freexl")
> +    (version "1.0.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://www.gaia-gis.it/gaia-sins/"
> +                                  name  "-"
> +                                  version ".tar.gz"))

I’d join these two lines.

> +              (sha256
> +               (base32
> +                "17a0yrjb0gln7819j0vp7y25imhvwpil2b0rm44mwgzml0a4i6mk"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://www.gaia-gis.it/fossil/freexl/index")
> +    (synopsis "Read Excel files")
> +    (description
> +     "FreeXL is an open source library to extract valid data
> +from within an Excel (.xls) spreadsheet.")

Please don’t use the term “open source”; besides, all software in Guix
is free software anyway.  Just “FreeXL is a C library to extract …” is
sufficient.

Pushed with these changes to master with commit 623fb4d16.

Thanks!

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Subject: [PATCH] Add freexl
From: Catonano <[email-masked]>
To: [email-masked]
Date: Sun, 23 Apr 2017 18:36:38 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Another xls files reading library.

The home page of Freexl says

FreeXL is licensed under the MPL tri-license terms; you are free to choose
the best-fit license between:

the MPL 1.1
the GPL v2.0 or any subsequent version
the LGPL v2.1 or any subsequent version

I'm not sure what this means for Guix

Thanks
From d5f10229fb928f63404c6097c60e09f2c2a5b1bb Mon Sep 17 00:00:00 2001
From: humanitiesNerd <[email-masked]>
Date: Sun, 23 Apr 2017 18:24:39 +0200
Subject: [PATCH 1/1] gnu: Add freexl

* gnu/packages/xml.scm (freexl): New variable.
---
 gnu/packages/xml.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
index 7460b5d85..02ae00514 100644
--- a/gnu/packages/xml.scm
+++ b/gnu/packages/xml.scm
@@ -1122,3 +1122,23 @@ files.  It is designed to be fast and to handle large input files.")
      "libxls is a C library which can read Excel (xls) files since Excel 97 (the BIFF8 format).
 libxls cannot write Excel files.")
     (license license:bsd-2)))
+
+(define-public freexl
+  (package
+    (name "freexl")
+    (version "1.0.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://www.gaia-gis.it/gaia-sins/"
+                                  name  "-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "17a0yrjb0gln7819j0vp7y25imhvwpil2b0rm44mwgzml0a4i6mk"))))
+    (build-system gnu-build-system)
+    (home-page "https://www.gaia-gis.it/fossil/freexl/index")
+    (synopsis "Read Excel files")
+    (description
+     "FreeXL is an open source library to extract valid data
+from within an Excel (.xls) spreadsheet.")
+    (license license:gpl2+)))
-- 
2.12.0