Subject: Re: bug#26620: [PATCH] gnu: Add font-linuxlibertine.

From: Kei Kebreau <[email-masked]>
Date: Sun, 23 Apr 2017 16:03:13 -0400

Ricardo Wurmus <[email-masked]> writes:

> * gnu/packages/fonts.scm (font-linuxlibertine): New variable.
> ---
>  gnu/packages/fonts.scm | 59 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 58 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 6579a66e4..2fb630ee6 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -5,7 +5,7 @@
>  ;;; Copyright © 2014 Alex Kost <[email-masked]>
>  ;;; Copyright © 2015 Sou Bunnbu <[email-masked]>
>  ;;; Copyright © 2015 Eric Dvorsak <[email-masked]>
> -;;; Copyright © 2015 Ricardo Wurmus <[email-masked]>
> +;;; Copyright © 2015, 2017 Ricardo Wurmus <[email-masked]>
>  ;;; Copyright © 2015, 2016 Leo Famulari <[email-masked]>
>  ;;; Copyright © 2016, 2017 ng0 <[email-masked]>
>  ;;; Copyright © 2016 Jookia <[email-masked]>
> @@ -370,6 +370,63 @@ and Bitstream Vera Sans Mono).
>  The Liberation Fonts are sponsored by Red Hat.")
>      (license license:silofl1.1)))
>  
> +(define-public font-linuxlibertine
> +  (package
> +    (name "font-linuxlibertine")
> +    (version "5.3.0")
> +    (source (origin
> +              (method url-fetch/tarbomb)
> +              (uri (string-append "mirror://sourceforge/linuxlibertine/"
> +                                  "linuxlibertine/" version
> +                                  "/LinLibertineSRC_" version "_2012_07_02.tgz"))
> +              (sha256
> +               (base32
> +                "0x7cz6hvhpil1rh03rax9zsfzm54bh7r4bbrq8rz673gl9h47v0v"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f ; there are no tests
> +       #:modules ((guix build utils)
> +                  (guix build gnu-build-system)
> +                  (srfi srfi-1)
> +                  (srfi srfi-26))
> +       #:phases
> +       (modify-phases %standard-phases
> +         (delete 'configure)
> +         (replace 'build
> +           (lambda _
> +             (let ((compile
> +                    (lambda (name ext)
> +                      (zero? (system*
> +                              "fontforge" "-lang=ff"
> +                              "-c" (string-append "Open('" name "');"
> +                                                  "Generate('"
> +                                                  (basename name "sfd") ext
> +                                                  "')"))))))
> +               (every (lambda (name)
> +                        (and (compile name "ttf")
> +                             (compile name "otf")))
> +                      (find-files "." "\\.sfd$")))))
> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((font-dir (string-append (assoc-ref outputs "out")
> +                                            "/share/fonts/truetype")))
> +               (mkdir-p font-dir)
> +               (for-each (cut install-file <> font-dir)
> +                         (find-files "." "\\.(otf|ttf)$"))
> +               #t))))))
> +    (native-inputs
> +     `(("fontforge" ,fontforge)))
> +    (home-page "http://www.linuxlibertine.org/")
> +    (synopsis "Serif and sans serif typefaces")
> +    (description "The Linux Libertine fonts is a set of typefaces containing
> +both a Serif version (\"Linux Libertine\") and a Sans Serif (\"Linux
> +Biolinum\") designed to be used together as an alternative for Times/Times New
> +Roman and Helvetica/Arial.  The Serif typeface comes in two shapes and two
> +weights, and with a Small Capitals version of the regular typeface.  Linux
> +Biolinum is available in both Regular and Bold weights.")
> +    ;; The fonts are released under either of these licenses.
> +    (license (list license:gpl3+ license:silofl1.1))))
> +

I might be missing it but I see GPL2+, not GPL3+, in the source directory.

>  (define-public font-terminus
>    (package
>      (name "font-terminus")

Otherwise LGTM.