Subject: Re: bug#26595: lugaru

From: Ricardo Wurmus <[email-masked]>
Date: Tue, 25 Apr 2017 22:18:59 +0200

Hi Julien,

thanks for one more game!

> Subject: [PATCH] gnu: Add lugaru.
>
> * gnu/packages/games.scm (lugaru): New variable.
> ---
>  gnu/packages/games.scm | 36 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 8ff5958d1..b66988967 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -3808,3 +3808,39 @@ utter witty remarks about their surroundings, the various inhabitants of their
>  underwater realm quarrel among themselves or comment on the efforts of your
>  fish.  The whole game is accompanied by quiet, comforting music.")
>      (license license:gpl2+)))
> +
> +(define-public lugaru
> +  (package
> +    (name "lugaru")
> +    (version "1.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://bitbucket.org/osslugaru/lugaru/downloads/"
> +                                  name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "15zgcshy22q51rm72zi6y9z7qlgnz5iw3gczjdlir4bqmxy4gspk"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:configure-flags
> +       (list "-DSYSTEM_INSTALL=ON")
> +       #:tests? #f))

Please add a comment to explain why the tests are disabled.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("sdl2" ,sdl2)
> +       ("glu" ,glu)
> +       ("libjpeg" ,libjpeg-turbo)
> +       ("libpng" ,libpng)
> +       ("openal" ,openal)
> +       ("vorbis" ,libvorbis)
> +       ("zlib" ,zlib)))
> +    (home-page "https://osslugaru.gitlab.io")
> +    (synopsis "Cross-platform third-person action game")
> +    (description "The main character, Turner, is an anthropomorphic rebel bunny
> +rabbit with impressive combat skills.  In his quest to find those responsible
> +for slaughtering his village, he uncovers a far-reaching conspiracy involving
> +the corrupt leaders of the rabbit republic and the starving wolves from a
> +nearby den.  Turner takes it upon himself to fight against their plot and save
> +his fellow rabbits from slavery.")

It would be good to start the description with a short description that
this is a game.

> +    (license (list license:gpl2+ license:cc-by-sa3.0))))

What does this list mean?  Please add a comment.

Could you please send an updated patch?  It’s good to push with these
changes.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net