From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 13:56:23 2017 Received: (at submit) by debbugs.gnu.org; 21 Apr 2017 17:56:24 +0000 Received: from localhost ([127.0.0.1]:32855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1cn9-0008GL-Np for submit@debbugs.gnu.org; Fri, 21 Apr 2017 13:56:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1cn7-0008G8-Es for submit@debbugs.gnu.org; Fri, 21 Apr 2017 13:56:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1cn1-0004Xk-96 for submit@debbugs.gnu.org; Fri, 21 Apr 2017 13:56:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56102) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d1cn1-0004Xc-5n for submit@debbugs.gnu.org; Fri, 21 Apr 2017 13:56:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58061) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1cmz-00084b-OP for guix-patches@gnu.org; Fri, 21 Apr 2017 13:56:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1cmv-0004SM-SZ for guix-patches@gnu.org; Fri, 21 Apr 2017 13:56:13 -0400 Received: from mail.lassieur.org ([83.152.10.219]:35654) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d1cmv-0004Pz-LJ for guix-patches@gnu.org; Fri, 21 Apr 2017 13:56:09 -0400 Received: from localhost.localdomain (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id d9ed85c3 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Fri, 21 Apr 2017 17:56:07 +0000 (UTC) From: =?UTF-8?q?Cl=C3=A9ment=20Lassieur?= To: guix-patches@gnu.org Subject: [PATCH] gnu: icecat: Fix GTK 3 file chooser crash. Date: Fri, 21 Apr 2017 19:55:40 +0200 Message-Id: <20170421175540.19672-1-clement@lassieur.org> X-Mailer: git-send-email 2.12.2 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * gnu/packages/gnuzilla.scm (icecat)[arguments]: Add a 'wrap-xdgdatadirs' phase to set XDG_DATA_DIRS. --- gnu/packages/gnuzilla.scm | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 91bb0a6a7..3b8c80d2c 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -750,7 +750,16 @@ standards.") (copy-file file (string-append icons "/icecat.png")))) '("default16.png" "default22.png" "default24.png" "default32.png" "default48.png" "content/icon64.png" - "mozicon128.png" "default256.png"))))))))) + "mozicon128.png" "default256.png")))))) + ;; This fixes the file chooser crash that happens with GTK 3. + (add-after 'install 'wrap-xdgdatadirs + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (lib (string-append out "/lib")) + (gtk (assoc-ref inputs "gtk+")) + (gtk-share (string-append gtk "/share"))) + (wrap-program (car (find-files lib "^icecat$")) + `("XDG_DATA_DIRS" ":" prefix (,gtk-share))))))))) (home-page "https://www.gnu.org/software/gnuzilla/") (synopsis "Entirely free browser derived from Mozilla Firefox") (description -- 2.12.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 14:18:37 2017 Received: (at 26593) by debbugs.gnu.org; 21 Apr 2017 18:18:37 +0000 Received: from localhost ([127.0.0.1]:32872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1d8f-0000Lm-Ej for submit@debbugs.gnu.org; Fri, 21 Apr 2017 14:18:37 -0400 Received: from mail.lassieur.org ([83.152.10.219]:60272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1d8d-0000Lb-8I for 26593@debbugs.gnu.org; Fri, 21 Apr 2017 14:18:35 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 83e5e12d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <26593@debbugs.gnu.org>; Fri, 21 Apr 2017 18:18:32 +0000 (UTC) References: <20170421175540.19672-1-clement@lassieur.org> User-agent: mu4e 0.9.18; emacs 25.2.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: 26593@debbugs.gnu.org Subject: Re: bug#26593: [PATCH] gnu: icecat: Fix GTK 3 file chooser crash. In-reply-to: <20170421175540.19672-1-clement@lassieur.org> Date: Fri, 21 Apr 2017 20:18:31 +0200 Message-ID: <87o9vpzkso.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26593 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Clément Lassieur writes: > * gnu/packages/gnuzilla.scm (icecat)[arguments]: Add a 'wrap-xdgdatadirs' > phase to set XDG_DATA_DIRS. > --- > gnu/packages/gnuzilla.scm | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm > index 91bb0a6a7..3b8c80d2c 100644 > --- a/gnu/packages/gnuzilla.scm > +++ b/gnu/packages/gnuzilla.scm > @@ -750,7 +750,16 @@ standards.") > (copy-file file (string-append icons "/icecat.png")))) > '("default16.png" "default22.png" "default24.png" > "default32.png" "default48.png" "content/icon64.png" > - "mozicon128.png" "default256.png"))))))))) > + "mozicon128.png" "default256.png")))))) > + ;; This fixes the file chooser crash that happens with GTK 3. > + (add-after 'install 'wrap-xdgdatadirs ^ I guess I should rename it to 'wrap-program, and update changelog accordingly. > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (lib (string-append out "/lib")) > + (gtk (assoc-ref inputs "gtk+")) > + (gtk-share (string-append gtk "/share"))) > + (wrap-program (car (find-files lib "^icecat$")) > + `("XDG_DATA_DIRS" ":" prefix (,gtk-share))))))))) > (home-page "https://www.gnu.org/software/gnuzilla/") > (synopsis "Entirely free browser derived from Mozilla Firefox") > (description From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 19:02:54 2017 Received: (at control) by debbugs.gnu.org; 21 Apr 2017 23:02:54 +0000 Received: from localhost ([127.0.0.1]:33058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1hZm-0003oO-1J for submit@debbugs.gnu.org; Fri, 21 Apr 2017 19:02:54 -0400 Received: from mail.lassieur.org ([83.152.10.219]:60274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1hZj-0003oF-U8 for control@debbugs.gnu.org; Fri, 21 Apr 2017 19:02:53 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 39760bca (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Fri, 21 Apr 2017 23:02:47 +0000 (UTC) Date: Sat, 22 Apr 2017 01:02:46 +0200 Message-Id: <87mvb9z7mx.fsf@lassieur.org> To: control@debbugs.gnu.org From: clement@lassieur.org (=?utf-8?Q?Cl=C3=A9ment?= Lassieur) Subject: control message for bug #26593 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tags 26593 fixed close 26593 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 22 01:20:42 2017 Received: (at 26593) by debbugs.gnu.org; 22 Apr 2017 05:20:42 +0000 Received: from localhost ([127.0.0.1]:33121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1nTO-0005kt-DH for submit@debbugs.gnu.org; Sat, 22 Apr 2017 01:20:42 -0400 Received: from mail.thebird.nl ([95.154.246.10]:38793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1nTM-0005kg-Nb for 26593@debbugs.gnu.org; Sat, 22 Apr 2017 01:20:41 -0400 Received: by mail.thebird.nl (Postfix, from userid 502) id B2F12137F60; Sat, 22 Apr 2017 07:20:19 +0200 (CEST) Date: Sat, 22 Apr 2017 05:20:19 +0000 From: Pjotr Prins To: =?iso-8859-1?Q?Cl=E9ment?= Lassieur Subject: Re: Icecat 52 crashing in file dialogues Message-ID: <20170422052019.GA15011@mail.thebird.nl> References: <20170421172745.oy56jbiwbhmz4rx4@abyayala> <87pog5zlh4.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87pog5zlh4.fsf@lassieur.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26593 Cc: guix-devel@gnu.org, ng0 , 26593@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Fri, Apr 21, 2017 at 08:03:51PM +0200, Clément Lassieur wrote: > ng0 writes: > > > Hi, > > > > has someone else experienced crashes since the icecat update? > > > > My system state isn't that old, but a week older than my profile state. > > File dialgues (save file) cause random crashes, Open file dialogues (change profile picture, etc) cause reproducible crashes all the time. > > Yes, I did experience the same thing. I wrote a small patch that fixes > it, see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26593. > > I'm not a GTK expert, there might be a cleaner way deal with > XDG_DATA_DIRS. Looks like we can use similar wrappers for all GTK tools, including gnumeric, geeqie, gnucash etc. Those are the ones that crash on me without XDG_DATA_DIRS. At this point I use alias on my Debian based system: alias gnucash='env XDG_DATA_DIRS=/usr/local/share:/usr/share gnucash' alias gnumeric='env XDG_DATA_DIRS=/usr/local/share:/usr/share gnumeric' -- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 22 03:49:37 2017 Received: (at 26593) by debbugs.gnu.org; 22 Apr 2017 07:49:37 +0000 Received: from localhost ([127.0.0.1]:33137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1pnV-0000ff-1y for submit@debbugs.gnu.org; Sat, 22 Apr 2017 03:49:37 -0400 Received: from mail.lassieur.org ([83.152.10.219]:60286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1pnT-0000fV-8d for 26593@debbugs.gnu.org; Sat, 22 Apr 2017 03:49:35 -0400 Received: from rodion (88.191.118.83 [88.191.118.83]) by mail.lassieur.org (OpenSMTPD) with ESMTPSA id 08b80fe2 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sat, 22 Apr 2017 07:49:33 +0000 (UTC) References: <20170421172745.oy56jbiwbhmz4rx4@abyayala> <87pog5zlh4.fsf@lassieur.org> <20170422052019.GA15011@mail.thebird.nl> User-agent: mu4e 0.9.18; emacs 25.2.1 From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur To: Pjotr Prins Subject: Re: Icecat 52 crashing in file dialogues In-reply-to: <20170422052019.GA15011@mail.thebird.nl> Date: Sat, 22 Apr 2017 09:49:32 +0200 Message-ID: <87k26czxtf.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26593 Cc: guix-devel@gnu.org, ng0 , 26593@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Pjotr Prins writes: > On Fri, Apr 21, 2017 at 08:03:51PM +0200, Clément Lassieur wrote: >> ng0 writes: >> >> > Hi, >> > >> > has someone else experienced crashes since the icecat update? >> > >> > My system state isn't that old, but a week older than my profile state. >> > File dialgues (save file) cause random crashes, Open file dialogues (change profile picture, etc) cause reproducible crashes all the time. >> >> Yes, I did experience the same thing. I wrote a small patch that fixes >> it, see https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26593. >> >> I'm not a GTK expert, there might be a cleaner way deal with >> XDG_DATA_DIRS. > > Looks like we can use similar wrappers for all GTK tools, including > gnumeric, geeqie, gnucash etc. Those are the ones that crash on me > without XDG_DATA_DIRS. At this point I use alias on my Debian based > system: > > alias gnucash='env XDG_DATA_DIRS=/usr/local/share:/usr/share gnucash' > alias gnumeric='env XDG_DATA_DIRS=/usr/local/share:/usr/share gnumeric' There is also a 'glib-or-gtk-build-system' (extension of 'gnu-build-system'), that does some more advanced wrapping. For some reason, I couldn't get it to work, but if that is the cleaner way, I could try to dig into it. From unknown Fri Jun 13 10:15:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 May 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator