Subject: Re: bug#26582: [PATCH] gnu: pcre: Fix Check for Hurd systems.

From: [email-masked] (Ludovic Courtès)
Date: Thu, 20 Apr 2017 23:27:29 +0200

rennes <[email-masked]> skribis:

> Hi,
>> Also this
>> 
>> >   ,@(if (hurd-triplet? ((or %current-system
>> >                             %current-target-system)))
>> 
>> should be this
>> 
>> >   ,@(if (hurd-triplet? (or (%current-system)
>> >                            (%current-target-system)))
>> 
>
> Fixed!
>
>> Btw trying to build it with `./pre-inst-env guix build
>> --target=i586-pc-gnu pcre' fails with
>> 
>> ** Cannot --enable-pcregrep-libz because zlib.h was not found
>> 
>> Maybe the inputs should become native-inputs?
>
> I moved zlib and readline to 'native-inputs'.

Are you sure they need to be native inputs?  Both are libraries, so I
imagine they’re used at run time, not at build time; they should be
inputs, in this case.

Thoughts?

Ludo’.