Subject: Re: bug#26581: Leftover patch round-up

From: Leo Famulari <[email-masked]>
Date: Fri, 21 Apr 2017 18:06:54 -0400

On Fri, Apr 21, 2017 at 11:19:41PM +0200, Ludovic Courtès wrote:
> Leo Famulari <[email-masked]> skribis:
> > gcc-libiberty-printf-decl.patch: Added in
> > b810a85019ab3c4ee1f889d0751b8eb06157dadc and mentioned in the
> > commit message but never used, AFAICT. Ludo?
> 
> It was used for 5.3 (commit e3d0fcbf7e55e8cbe8d0a1c5a24d73f341d7243b,
> which the commit above reinstated; see
> <https://gcc.gnu.org/ml/gcc-help/2016-04/msg00039.html>) but useless in
> 5.4.  So yes, can be removed!

Ah, thanks for sharing the context.

> Except for this one:
> 
> > gnu/packages/patches/readline-7.0-mingw.patch: Introduced in
> > ae12d586275cdd96db23fb01bf840b2055b5b979, but never used. Jan, can you
> > take a look?
> 
> … it looks like you can go ahead and remove’em all!

Done as 04b906799168008c41f62402eee74bd47c1c2681.

> Maybe we should add a makefile target to check for stale patches?

We're discussing it here:

http://lists.gnu.org/archive/html/guix-devel/2017-04/msg00439.html

I'll leave this bug open while we decide what to do about
readline-7.0-mingw.patch.