From pjones@pmade.com Fri Mar 13 07:36:38 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 13 Mar 2009 14:36:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2DEaYYB017537 for ; Fri, 13 Mar 2009 07:36:35 -0700 Received: from mail.gnu.org ([199.232.76.166]:39039 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Li8Uz-0001Fr-LR for emacs-pretest-bug@gnu.org; Fri, 13 Mar 2009 10:36:33 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Li8Uv-0004P5-Iz for emacs-pretest-bug@gnu.org; Fri, 13 Mar 2009 10:36:33 -0400 Received: from pmade.com ([64.92.223.213]:60176) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Li8Uv-0004ND-8C for emacs-pretest-bug@gnu.org; Fri, 13 Mar 2009 10:36:29 -0400 Received: from beefy.local.pmade.com (75-166-113-14.hlrn.qwest.net [75.166.113.14]) (authenticated bits=0) by pmade.com (8.13.8/8.13.8) with ESMTP id n2DEaKm2001644 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 13 Mar 2009 14:36:21 GMT (envelope-from pjones@pmade.com) From: Peter Jones To: emacs-pretest-bug@gnu.org Subject: 23.0.91; [PATCH] Cocoa Port Doesn't Honor cursor-in-non-selected-windows Date: Fri, 13 Mar 2009 08:36:14 -0600 Message-ID: <86d4cl32xt.fsf@pmade.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: FreeBSD 6.x (1) --=-=-= Attached is a patch that changes the Cocoa (Nextstep) port so that it correctly respects the setting of cursor-in-non-selected-windows. Currently, the Objective-C code forces the cursor in non-selected windows to a hollow box, although the function is called with the correct cursor to draw. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=nsterm.m.diff --- src/nsterm.m.orig 2009-03-11 13:17:10.000000000 -0600 +++ src/nsterm.m 2009-03-12 17:18:26.000000000 -0600 @@ -2351,7 +2351,7 @@ int fx, fy, h; struct frame *f = WINDOW_XFRAME (w); struct glyph *phys_cursor_glyph; - int overspill, cursorToDraw; + int overspill; NSTRACE (dumpcursor); //fprintf(stderr, "drawcursor (%d,%d) activep = %d\tonp = %d\tc_type = %d\twidth = %d\n",x,y, active_p,on_p,cursor_type,cursor_width); @@ -2407,8 +2407,7 @@ NSDisableScreenUpdates (); #endif - cursorToDraw = active_p ? cursor_type : HOLLOW_BOX_CURSOR; - switch (cursorToDraw) + switch (cursor_type) { case NO_CURSOR: break; @@ -2425,7 +2424,7 @@ s = r; s.origin.y += lrint (0.75 * s.size.height); s.size.width = min (FRAME_COLUMN_WIDTH (f), s.size.width); - s.size.height = lrint (s.size.height * 0.25); + s.size.height = min (cursor_width, 2); //FIXME(see above) NSRectFill (s); break; case BAR_CURSOR: @@ -2437,7 +2436,7 @@ ns_unfocus (f); /* draw the character under the cursor */ - if (cursorToDraw != NO_CURSOR) + if (cursor_type != NO_CURSOR) draw_phys_cursor_glyph (w, glyph_row, DRAW_CURSOR); #ifdef NS_IMPL_COCOA --=-=-= In GNU Emacs 23.0.91.4 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-03-12 on beefy.local Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x RET r e p o r t C-g C-g M-x r e p o r t - b Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. call-interactively: Text is read-only Quit [2 times] Quit --=-=-=-- From rgm@gnu.org Fri Mar 13 10:25:18 2009 Received: (at control) by emacsbugs.donarmstrong.com; 13 Mar 2009 17:25:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2DHPFGq002673 for ; Fri, 13 Mar 2009 10:25:16 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LiB8E-0007WV-Ry; Fri, 13 Mar 2009 13:25:14 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18874.38650.797222.437733@fencepost.gnu.org> Date: Fri, 13 Mar 2009 13:25:14 -0400 From: Glenn Morris To: control Subject: control message severity 2623 minor tags 2600 moreinfo reassign 2655 spam reassign 2658 emacs,ns severity 2659 minor reassign 2660 spam From adrian.b.robert@gmail.com Sun May 31 09:18:04 2009 Received: (at 2658) by emacsbugs.donarmstrong.com; 31 May 2009 16:18:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.7 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-pz0-f118.google.com (mail-pz0-f118.google.com [209.85.222.118]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n4VGI07g003802 for <2658@emacsbugs.donarmstrong.com>; Sun, 31 May 2009 09:18:02 -0700 Received: by pzk16 with SMTP id 16so2083003pzk.19 for <2658@emacsbugs.donarmstrong.com>; Sun, 31 May 2009 09:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:content-type :message-id:cc:content-transfer-encoding:from:subject:date:to :x-mailer; bh=P2q1rEyA9BbINGbPXEgi8wt7VFvwRpo70R5ZBoXIrqc=; b=tNSlhVy318rUVf4HdMKUF+VtOhDero6/kvu3+4HVyZfTGNonRpPDt6Wu1l+6lPb0/N 8q31yJOAi5un00cv9D8sa3egkuCbRItLoylbywftYAwQJ/3zjEWVfzzofISJjTbQcQqJ ipbe28ihCeIpINH4LNYF4SjVx0q8QYrjM2it0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:content-type:message-id:cc:content-transfer-encoding :from:subject:date:to:x-mailer; b=NgWLzdSB20OoECK8u2RXW7kSKaXsz7Khwb/YVEAr37btVDZ8KA/TfvLDD2DmBw4GgK Lkr5MIvv287UNJYpL5I386LZxY0i/J8ZPXNGgX1T/Amy5KOlx8eEM9DXw1dERvnDHycG g+QAJUh0l+K5sB/tduQr0mrzV8mhEDzIP2QXw= Received: by 10.142.153.8 with SMTP id a8mr1489260wfe.94.1243786675822; Sun, 31 May 2009 09:17:55 -0700 (PDT) Received: from ?110.49.0.112? ([110.49.0.112]) by mx.google.com with ESMTPS id m25sm4762074waf.9.2009.05.31.09.17.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 31 May 2009 09:17:55 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <55DBE184-2C1B-4DDE-A9AD-7D8A66073F21@gmail.com> Cc: Peter Jones Content-Transfer-Encoding: 7bit From: Adrian Robert Subject: Re: [PATCH] Cocoa Port Doesn't Honor cursor-in-non-selected-windows Date: Sun, 31 May 2009 23:18:20 +0700 To: 2658@debbugs.gnu.org X-Mailer: Apple Mail (2.753.1) http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2658 Thank you for the patch, I have applied and tested it and will check it in as soon as I am able. From rgm@gnu.org Wed Jun 17 13:22:35 2009 Received: (at control) by emacsbugs.donarmstrong.com; 17 Jun 2009 20:22:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,ONEWORD,PHONENUMBER, VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5HKMVgb030690 for ; Wed, 17 Jun 2009 13:22:33 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MH1eR-0007i7-2N; Wed, 17 Jun 2009 16:22:31 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19001.20615.29387.897755@fencepost.gnu.org> Date: Wed, 17 Jun 2009 16:22:31 -0400 From: Glenn Morris To: control Subject: control X-Debbugs-No-Ack: yes reassign 3204 emacs,ns close 3204 reassign 3233 emacs,ns tags 1131 moreinfo unreproducible tags 1804 moreinfo close 2658 From unknown Sun Aug 17 04:21:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Jul 2009 14:24:10 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator