Subject: bug#26575: [PATCH] gnu: pcre: Fix Check for Hurd systems.

From: Manolis Ragkousis <[email-masked]>
Date: Thu, 20 Apr 2017 17:08:01 +0300

Hello Rene

On 04/20/2017 08:12 AM, rennes wrote:
> Hello,
> This patch fix the Check phase on GNU/Hurd.
> Built in Linux and Hurd.
> 
> Additional, I have a doubt regarding the outputs of the package, after
> build shows:
> /gnu/store/9bx00n7mpxiyp9nyjz5qas53kc3wid5i-pcre-8.40-bin
> /gnu/store/qb2mbv1wj3b18ix88blfidyy0yzrzggz-pcre-8.40-doc
> /gnu/store/v8ma5z2d1m78f64c9m3dp6s3359w02h0-pcre-8.40
> 
> The outputs have different hash, is this correct?

You have 3 outputs because of this
(outputs '("out"           ;library & headers
           "bin"           ;depends on Readline (adds 20MiB to the closure)
           "doc"))         ;1.8 MiB of HTML

It seems correct to me.

Also this

>   ,@(if (hurd-triplet? ((or %current-system
>                             %current-target-system)))

should be this

>   ,@(if (hurd-triplet? (or (%current-system)
>                            (%current-target-system)))

Btw trying to build it with `./pre-inst-env guix build
--target=i586-pc-gnu pcre' fails with

** Cannot --enable-pcregrep-libz because zlib.h was not found

Maybe the inputs should become native-inputs?

Thank you!
Manolis