From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 03:36:02 2017 Received: (at submit) by debbugs.gnu.org; 19 Apr 2017 07:36:02 +0000 Received: from localhost ([127.0.0.1]:55449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0k9h-0004Lf-W7 for submit@debbugs.gnu.org; Wed, 19 Apr 2017 03:36:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0k9g-0004LA-0S for submit@debbugs.gnu.org; Wed, 19 Apr 2017 03:36:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0k9Z-0006Ho-RA for submit@debbugs.gnu.org; Wed, 19 Apr 2017 03:35:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0k9Z-0006Hk-Os for submit@debbugs.gnu.org; Wed, 19 Apr 2017 03:35:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0k9Y-0006mX-GT for guix-patches@gnu.org; Wed, 19 Apr 2017 03:35:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0k9V-0006Gt-EC for guix-patches@gnu.org; Wed, 19 Apr 2017 03:35:52 -0400 Received: from o146.p8.mailjet.com ([87.253.233.146]:38256) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d0k9V-0006Fa-2u for guix-patches@gnu.org; Wed, 19 Apr 2017 03:35:49 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints: x-mj-mid:mime-version:content-transfer-encoding; bh=t8gjLKHTdo7rnR0oh2rf/VITU9g=; b=NftxcetncBHGlMYbp5XViz3Z57nNlawEUUWTMPwSmqJOEuQ7ApBeIiGxm I4NpcQX5NxiyS7vLDLaYH8yBujFArCPsEsySI+32/7te1NL9EOROYMxuq0/Z EQHyc9bcw2TB4fCSpn/MwRxLc7r3jErVp77FjmzNQ82K8YtRykcWvU= Message-Id: From: Arun Isaac To: guix-patches@gnu.org Subject: [PATCH] build: emacs: Install only a subset of files. Date: Wed, 19 Apr 2017 13:05:25 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAJWr4p0UAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABY9xNR7CX6lKaOR8OA_5zumYwhJgAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * guix/build/emacs-build-system.scm (install): Install files matching #:include while excluding files matching #:exclude. * guix/build-system/emacs.scm (emacs-build): Add keyword arguments #:includ= e and #:exclude. --- guix/build-system/emacs.scm | 6 ++++++ guix/build/emacs-build-system.scm | 24 +++++++++++++++++++++--- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/guix/build-system/emacs.scm b/guix/build-system/emacs.scm index a7982002b..e6c021c7e 100644 --- a/guix/build-system/emacs.scm +++ b/guix/build-system/emacs.scm @@ -83,6 +83,10 @@ (phases '(@ (guix build emacs-build-system) %standard-phases)) (outputs '("out")) + (include ''(".*.el$" ".*.el.in$" "^dir$" + ".*.info$" ".*.texi$" ".*.texinfo$" + "doc/dir" "doc/*.info$" "doc/*.texi$" "do= c/*.texinfo$")) + (exclude ''("^.dir-locals.el$" "^test.el$" "^tests.e= l$" ".*-test.el$" ".*-tests.el$")) (search-paths '()) (system (%current-system)) (guile #f) @@ -108,6 +112,8 @@ #:tests? ,tests? #:phases ,phases #:outputs %outputs + #:include ,include + #:exclude ,exclude #:search-paths ',(map search-path-specification->sexp search-paths) #:inputs %build-inputs))) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-sys= tem.scm index 44e8b0d31..579596d72 100644 --- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -28,6 +28,7 @@ #:use-module (ice-9 rdelim) #:use-module (ice-9 regex) #:use-module (ice-9 match) + #:use-module (ice-9 ftw) #:export (%standard-phases emacs-build)) =20 @@ -93,14 +94,31 @@ store in '.el' files." (substitute-cmd)))) #t)) =20 -(define* (install #:key outputs #:allow-other-keys) +(define* (install #:key outputs + (include '(".*.el$" ".*.el.in$" "^dir$" + ".*.info$" ".*.texi$" ".*.texinfo$" + "^doc/dir" "^doc/*.info$" "^doc/*.texi$" "^do= c/*.texinfo$")) + (exclude '("^.dir-locals.el$" "^test.el$" "^tests.el$" "= .*-test.el$" ".*-tests.el$")) + #:allow-other-keys) "Install the package contents." + + (define (include-file? file) + (and (any (cut string-match <> file) include) + (not (any (cut string-match <> file) exclude)))) + (let* ((out (assoc-ref outputs "out")) (elpa-name-ver (store-directory->elpa-name-version out)) (src-dir (getcwd)) (tgt-dir (string-append out %install-suffix "/" elpa-name-ver))) - (copy-recursively src-dir tgt-dir) - #t)) + (ftw src-dir + (lambda (file stat flag) + (let ((stripped-file (substring file (string-length src-dir)))) + (when (and (eq? flag 'regular) + (include-file? (string-trim stripped-file #\/))) + (format #t "`~a' -> `~a'~%" + file (string-append tgt-dir stripped-file)) + (install-file file tgt-dir))) + #t)))) =20 (define* (move-doc #:key outputs #:allow-other-keys) "Move info files from the ELPA package directory to the info directory." --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 03:43:07 2017 Received: (at 26559) by debbugs.gnu.org; 19 Apr 2017 07:43:07 +0000 Received: from localhost ([127.0.0.1]:55461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0kGZ-0004WF-2I for submit@debbugs.gnu.org; Wed, 19 Apr 2017 03:43:07 -0400 Received: from m13-135.163.com ([220.181.13.135]:1986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0kGW-0004W4-7N for 26559@debbugs.gnu.org; Wed, 19 Apr 2017 03:43:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=U3+EG F2bLY9T+k6GKRtyK0qhYqHYh/xYau2eeq3ScdE=; b=mPET3qiY/sq8RPsAO+Xhs TjHk0NcTL8lpENpoz7AL/zwFS75pm0GfW9hMmU7tFKzpxh9yy/Ysd/3xWfXw/ZLF Ua7Bfxvu9/QkNCY+5sJQWXwwOpKPnTm80le8rOr6TC9E5IqlvK3W8hCHQtYaAxkm +Bt0DK1BWL+cIg8ukoNCPs= Received: from tumashu$163.com ( [218.92.14.78] ) by ajax-webmail-wmsvr135 (Coremail) ; Wed, 19 Apr 2017 15:43:00 +0800 (CST) X-Originating-IP: [218.92.14.78] Date: Wed, 19 Apr 2017 15:43:00 +0800 (CST) From: tumashu To: "Arun Isaac" Subject: Re:bug#26559: [PATCH] build: emacs: Install only a subset of files. X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 163com In-Reply-To: References: Content-Type: multipart/alternative; boundary="----=_Part_109074_1337663948.1492587780587" MIME-Version: 1.0 Message-ID: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: h8GowEBZ0kAEFfdYd+3RAA--.12869W X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiERC+1FWBaBX2awABse X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) ------=_Part_109074_1337663948.1492587780587 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 V2hhdCBhYm91dCAgcGFja2FnZS1wa2cuZWwgIGZpbGU/LgoKCgoKCgoKCkF0IDIwMTctMDQtMTkg MTU6MzU6MjUsICJBcnVuIElzYWFjIiA8YXJ1bmlzYWFjQHN5c3RlbXJlYm9vdC5uZXQ+IHdyb3Rl Ogo+KiBndWl4L2J1aWxkL2VtYWNzLWJ1aWxkLXN5c3RlbS5zY20gKGluc3RhbGwpOiBJbnN0YWxs IGZpbGVzIG1hdGNoaW5nCj4gICM6aW5jbHVkZSB3aGlsZSBleGNsdWRpbmcgZmlsZXMgbWF0Y2hp bmcgIzpleGNsdWRlLgo+KiBndWl4L2J1aWxkLXN5c3RlbS9lbWFjcy5zY20gKGVtYWNzLWJ1aWxk KTogQWRkIGtleXdvcmQgYXJndW1lbnRzICM6aW5jbHVkZQo+ICBhbmQgIzpleGNsdWRlLgo+LS0t Cj4gZ3VpeC9idWlsZC1zeXN0ZW0vZW1hY3Muc2NtICAgICAgIHwgIDYgKysrKysrCj4gZ3VpeC9i dWlsZC9lbWFjcy1idWlsZC1zeXN0ZW0uc2NtIHwgMjQgKysrKysrKysrKysrKysrKysrKysrLS0t Cj4gMiBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Cj5k aWZmIC0tZ2l0IGEvZ3VpeC9idWlsZC1zeXN0ZW0vZW1hY3Muc2NtIGIvZ3VpeC9idWlsZC1zeXN0 ZW0vZW1hY3Muc2NtCj5pbmRleCBhNzk4MjAwMmIuLmU2YzAyMWM3ZSAxMDA2NDQKPi0tLSBhL2d1 aXgvYnVpbGQtc3lzdGVtL2VtYWNzLnNjbQo+KysrIGIvZ3VpeC9idWlsZC1zeXN0ZW0vZW1hY3Mu c2NtCj5AQCAtODMsNiArODMsMTAgQEAKPiAgICAgICAgICAgICAgICAgICAgICAgKHBoYXNlcyAn KEAgKGd1aXggYnVpbGQgZW1hY3MtYnVpbGQtc3lzdGVtKQo+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAlc3RhbmRhcmQtcGhhc2VzKSkKPiAgICAgICAgICAgICAgICAgICAgICAg KG91dHB1dHMgJygib3V0IikpCj4rICAgICAgICAgICAgICAgICAgICAgIChpbmNsdWRlICcnKCIu Ki5lbCQiICIuKi5lbC5pbiQiICJeZGlyJCIKPisgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAiLiouaW5mbyQiICIuKi50ZXhpJCIgIi4qLnRleGluZm8kIgo+KyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJkb2MvZGlyIiAiZG9jLyouaW5mbyQiICJkb2MvKi50ZXhpJCIg ImRvYy8qLnRleGluZm8kIikpCj4rICAgICAgICAgICAgICAgICAgICAgIChleGNsdWRlICcnKCJe LmRpci1sb2NhbHMuZWwkIiAiXnRlc3QuZWwkIiAiXnRlc3RzLmVsJCIgIi4qLXRlc3QuZWwkIiAi LiotdGVzdHMuZWwkIikpCj4gICAgICAgICAgICAgICAgICAgICAgIChzZWFyY2gtcGF0aHMgJygp KQo+ICAgICAgICAgICAgICAgICAgICAgICAoc3lzdGVtICglY3VycmVudC1zeXN0ZW0pKQo+ICAg ICAgICAgICAgICAgICAgICAgICAoZ3VpbGUgI2YpCj5AQCAtMTA4LDYgKzExMiw4IEBACj4gICAg ICAgICAgICAgICAgICAgICAjOnRlc3RzPyAsdGVzdHM/Cj4gICAgICAgICAgICAgICAgICAgICAj OnBoYXNlcyAscGhhc2VzCj4gICAgICAgICAgICAgICAgICAgICAjOm91dHB1dHMgJW91dHB1dHMK PisgICAgICAgICAgICAgICAgICAgICM6aW5jbHVkZSAsaW5jbHVkZQo+KyAgICAgICAgICAgICAg ICAgICAgIzpleGNsdWRlICxleGNsdWRlCj4gICAgICAgICAgICAgICAgICAgICAjOnNlYXJjaC1w YXRocyAnLChtYXAgc2VhcmNoLXBhdGgtc3BlY2lmaWNhdGlvbi0+c2V4cAo+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNlYXJjaC1wYXRocykKPiAgICAgICAgICAg ICAgICAgICAgICM6aW5wdXRzICVidWlsZC1pbnB1dHMpKSkKPmRpZmYgLS1naXQgYS9ndWl4L2J1 aWxkL2VtYWNzLWJ1aWxkLXN5c3RlbS5zY20gYi9ndWl4L2J1aWxkL2VtYWNzLWJ1aWxkLXN5c3Rl bS5zY20KPmluZGV4IDQ0ZThiMGQzMS4uNTc5NTk2ZDcyIDEwMDY0NAo+LS0tIGEvZ3VpeC9idWls ZC9lbWFjcy1idWlsZC1zeXN0ZW0uc2NtCj4rKysgYi9ndWl4L2J1aWxkL2VtYWNzLWJ1aWxkLXN5 c3RlbS5zY20KPkBAIC0yOCw2ICsyOCw3IEBACj4gICAjOnVzZS1tb2R1bGUgKGljZS05IHJkZWxp bSkKPiAgICM6dXNlLW1vZHVsZSAoaWNlLTkgcmVnZXgpCj4gICAjOnVzZS1tb2R1bGUgKGljZS05 IG1hdGNoKQo+KyAgIzp1c2UtbW9kdWxlIChpY2UtOSBmdHcpCj4gICAjOmV4cG9ydCAoJXN0YW5k YXJkLXBoYXNlcwo+ICAgICAgICAgICAgIGVtYWNzLWJ1aWxkKSkKPiAKPkBAIC05MywxNCArOTQs MzEgQEAgc3RvcmUgaW4gJy5lbCcgZmlsZXMuIgo+ICAgICAgICAgICAoc3Vic3RpdHV0ZS1jbWQp KSkpCj4gICAgICN0KSkKPiAKPi0oZGVmaW5lKiAoaW5zdGFsbCAjOmtleSBvdXRwdXRzICM6YWxs b3ctb3RoZXIta2V5cykKPisoZGVmaW5lKiAoaW5zdGFsbCAjOmtleSBvdXRwdXRzCj4rICAgICAg ICAgICAgICAgICAgKGluY2x1ZGUgJygiLiouZWwkIiAiLiouZWwuaW4kIiAiXmRpciQiCj4rICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiLiouaW5mbyQiICIuKi50ZXhpJCIgIi4qLnRleGlu Zm8kIgo+KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIl5kb2MvZGlyIiAiXmRvYy8qLmlu Zm8kIiAiXmRvYy8qLnRleGkkIiAiXmRvYy8qLnRleGluZm8kIikpCj4rICAgICAgICAgICAgICAg ICAgKGV4Y2x1ZGUgJygiXi5kaXItbG9jYWxzLmVsJCIgIl50ZXN0LmVsJCIgIl50ZXN0cy5lbCQi ICIuKi10ZXN0LmVsJCIgIi4qLXRlc3RzLmVsJCIpKQo+KyAgICAgICAgICAgICAgICAgICM6YWxs b3ctb3RoZXIta2V5cykKPiAgICJJbnN0YWxsIHRoZSBwYWNrYWdlIGNvbnRlbnRzLiIKPisKPisg IChkZWZpbmUgKGluY2x1ZGUtZmlsZT8gZmlsZSkKPisgICAgKGFuZCAoYW55IChjdXQgc3RyaW5n LW1hdGNoIDw+IGZpbGUpIGluY2x1ZGUpCj4rICAgICAgICAgKG5vdCAoYW55IChjdXQgc3RyaW5n LW1hdGNoIDw+IGZpbGUpIGV4Y2x1ZGUpKSkpCj4rCj4gICAobGV0KiAoKG91dCAoYXNzb2MtcmVm IG91dHB1dHMgIm91dCIpKQo+ICAgICAgICAgIChlbHBhLW5hbWUtdmVyIChzdG9yZS1kaXJlY3Rv cnktPmVscGEtbmFtZS12ZXJzaW9uIG91dCkpCj4gICAgICAgICAgKHNyYy1kaXIgKGdldGN3ZCkp Cj4gICAgICAgICAgKHRndC1kaXIgKHN0cmluZy1hcHBlbmQgb3V0ICVpbnN0YWxsLXN1ZmZpeCAi LyIgZWxwYS1uYW1lLXZlcikpKQo+LSAgICAoY29weS1yZWN1cnNpdmVseSBzcmMtZGlyIHRndC1k aXIpCj4tICAgICN0KSkKPisgICAgKGZ0dyBzcmMtZGlyCj4rICAgICAgICAgKGxhbWJkYSAoZmls ZSBzdGF0IGZsYWcpCj4rICAgICAgICAgICAobGV0ICgoc3RyaXBwZWQtZmlsZSAoc3Vic3RyaW5n IGZpbGUgKHN0cmluZy1sZW5ndGggc3JjLWRpcikpKSkKPisgICAgICAgICAgICAgKHdoZW4gKGFu ZCAoZXE/IGZsYWcgJ3JlZ3VsYXIpCj4rICAgICAgICAgICAgICAgICAgICAgICAgKGluY2x1ZGUt ZmlsZT8gKHN0cmluZy10cmltIHN0cmlwcGVkLWZpbGUgI1wvKSkpCj4rICAgICAgICAgICAgICAg KGZvcm1hdCAjdCAiYH5hJyAtPiBgfmEnfiUiCj4rICAgICAgICAgICAgICAgICAgICAgICBmaWxl IChzdHJpbmctYXBwZW5kIHRndC1kaXIgc3RyaXBwZWQtZmlsZSkpCj4rICAgICAgICAgICAgICAg KGluc3RhbGwtZmlsZSBmaWxlIHRndC1kaXIpKSkKPisgICAgICAgICAgICN0KSkpKQo+IAo+IChk ZWZpbmUqIChtb3ZlLWRvYyAjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKPiAgICJN b3ZlIGluZm8gZmlsZXMgZnJvbSB0aGUgRUxQQSBwYWNrYWdlIGRpcmVjdG9yeSB0byB0aGUgaW5m byBkaXJlY3RvcnkuIgo+LS0gCj4yLjEyLjIKPgo+Cj4KPgo= ------=_Part_109074_1337663948.1492587780587 Content-Type: text/html; charset=GBK Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6MS43O2NvbG9yOiMwMDAwMDA7Zm9udC1zaXplOjE0cHg7 Zm9udC1mYW1pbHk6QXJpYWwiPldoYXQgYWJvdXQmbmJzcDsgcGFja2FnZS1wa2cuZWwmbmJzcDsg ZmlsZT8uPGJyPjxicj48YnI+PGJyPjxicj48ZGl2IHN0eWxlPSJwb3NpdGlvbjpyZWxhdGl2ZTt6 b29tOjEiPjwvZGl2PjxkaXYgaWQ9ImRpdk5ldGVhc2VNYWlsQ2FyZCI+PC9kaXY+PGJyPjxwcmU+ PGJyPkF0IDIwMTctMDQtMTkgMTU6MzU6MjUsICJBcnVuIElzYWFjIiAmbHQ7YXJ1bmlzYWFjQHN5 c3RlbXJlYm9vdC5uZXQmZ3Q7IHdyb3RlOgomZ3Q7KiBndWl4L2J1aWxkL2VtYWNzLWJ1aWxkLXN5 c3RlbS5zY20gKGluc3RhbGwpOiBJbnN0YWxsIGZpbGVzIG1hdGNoaW5nCiZndDsgICM6aW5jbHVk ZSB3aGlsZSBleGNsdWRpbmcgZmlsZXMgbWF0Y2hpbmcgIzpleGNsdWRlLgomZ3Q7KiBndWl4L2J1 aWxkLXN5c3RlbS9lbWFjcy5zY20gKGVtYWNzLWJ1aWxkKTogQWRkIGtleXdvcmQgYXJndW1lbnRz ICM6aW5jbHVkZQomZ3Q7ICBhbmQgIzpleGNsdWRlLgomZ3Q7LS0tCiZndDsgZ3VpeC9idWlsZC1z eXN0ZW0vZW1hY3Muc2NtICAgICAgIHwgIDYgKysrKysrCiZndDsgZ3VpeC9idWlsZC9lbWFjcy1i dWlsZC1zeXN0ZW0uc2NtIHwgMjQgKysrKysrKysrKysrKysrKysrKysrLS0tCiZndDsgMiBmaWxl cyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQomZ3Q7CiZndDtkaWZm IC0tZ2l0IGEvZ3VpeC9idWlsZC1zeXN0ZW0vZW1hY3Muc2NtIGIvZ3VpeC9idWlsZC1zeXN0ZW0v ZW1hY3Muc2NtCiZndDtpbmRleCBhNzk4MjAwMmIuLmU2YzAyMWM3ZSAxMDA2NDQKJmd0Oy0tLSBh L2d1aXgvYnVpbGQtc3lzdGVtL2VtYWNzLnNjbQomZ3Q7KysrIGIvZ3VpeC9idWlsZC1zeXN0ZW0v ZW1hY3Muc2NtCiZndDtAQCAtODMsNiArODMsMTAgQEAKJmd0OyAgICAgICAgICAgICAgICAgICAg ICAgKHBoYXNlcyAnKEAgKGd1aXggYnVpbGQgZW1hY3MtYnVpbGQtc3lzdGVtKQomZ3Q7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAlc3RhbmRhcmQtcGhhc2VzKSkKJmd0OyAgICAg ICAgICAgICAgICAgICAgICAgKG91dHB1dHMgJygib3V0IikpCiZndDsrICAgICAgICAgICAgICAg ICAgICAgIChpbmNsdWRlICcnKCIuKi5lbCQiICIuKi5lbC5pbiQiICJeZGlyJCIKJmd0OysgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLiouaW5mbyQiICIuKi50ZXhpJCIgIi4qLnRl eGluZm8kIgomZ3Q7KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJkb2MvZGlyIiAi ZG9jLyouaW5mbyQiICJkb2MvKi50ZXhpJCIgImRvYy8qLnRleGluZm8kIikpCiZndDsrICAgICAg ICAgICAgICAgICAgICAgIChleGNsdWRlICcnKCJeLmRpci1sb2NhbHMuZWwkIiAiXnRlc3QuZWwk IiAiXnRlc3RzLmVsJCIgIi4qLXRlc3QuZWwkIiAiLiotdGVzdHMuZWwkIikpCiZndDsgICAgICAg ICAgICAgICAgICAgICAgIChzZWFyY2gtcGF0aHMgJygpKQomZ3Q7ICAgICAgICAgICAgICAgICAg ICAgICAoc3lzdGVtICglY3VycmVudC1zeXN0ZW0pKQomZ3Q7ICAgICAgICAgICAgICAgICAgICAg ICAoZ3VpbGUgI2YpCiZndDtAQCAtMTA4LDYgKzExMiw4IEBACiZndDsgICAgICAgICAgICAgICAg ICAgICAjOnRlc3RzPyAsdGVzdHM/CiZndDsgICAgICAgICAgICAgICAgICAgICAjOnBoYXNlcyAs cGhhc2VzCiZndDsgICAgICAgICAgICAgICAgICAgICAjOm91dHB1dHMgJW91dHB1dHMKJmd0Oysg ICAgICAgICAgICAgICAgICAgICM6aW5jbHVkZSAsaW5jbHVkZQomZ3Q7KyAgICAgICAgICAgICAg ICAgICAgIzpleGNsdWRlICxleGNsdWRlCiZndDsgICAgICAgICAgICAgICAgICAgICAjOnNlYXJj aC1wYXRocyAnLChtYXAgc2VhcmNoLXBhdGgtc3BlY2lmaWNhdGlvbi0mZ3Q7c2V4cAomZ3Q7ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNlYXJjaC1wYXRocykKJmd0 OyAgICAgICAgICAgICAgICAgICAgICM6aW5wdXRzICVidWlsZC1pbnB1dHMpKSkKJmd0O2RpZmYg LS1naXQgYS9ndWl4L2J1aWxkL2VtYWNzLWJ1aWxkLXN5c3RlbS5zY20gYi9ndWl4L2J1aWxkL2Vt YWNzLWJ1aWxkLXN5c3RlbS5zY20KJmd0O2luZGV4IDQ0ZThiMGQzMS4uNTc5NTk2ZDcyIDEwMDY0 NAomZ3Q7LS0tIGEvZ3VpeC9idWlsZC9lbWFjcy1idWlsZC1zeXN0ZW0uc2NtCiZndDsrKysgYi9n dWl4L2J1aWxkL2VtYWNzLWJ1aWxkLXN5c3RlbS5zY20KJmd0O0BAIC0yOCw2ICsyOCw3IEBACiZn dDsgICAjOnVzZS1tb2R1bGUgKGljZS05IHJkZWxpbSkKJmd0OyAgICM6dXNlLW1vZHVsZSAoaWNl LTkgcmVnZXgpCiZndDsgICAjOnVzZS1tb2R1bGUgKGljZS05IG1hdGNoKQomZ3Q7KyAgIzp1c2Ut bW9kdWxlIChpY2UtOSBmdHcpCiZndDsgICAjOmV4cG9ydCAoJXN0YW5kYXJkLXBoYXNlcwomZ3Q7 ICAgICAgICAgICAgIGVtYWNzLWJ1aWxkKSkKJmd0OyAKJmd0O0BAIC05MywxNCArOTQsMzEgQEAg c3RvcmUgaW4gJy5lbCcgZmlsZXMuIgomZ3Q7ICAgICAgICAgICAoc3Vic3RpdHV0ZS1jbWQpKSkp CiZndDsgICAgICN0KSkKJmd0OyAKJmd0Oy0oZGVmaW5lKiAoaW5zdGFsbCAjOmtleSBvdXRwdXRz ICM6YWxsb3ctb3RoZXIta2V5cykKJmd0OysoZGVmaW5lKiAoaW5zdGFsbCAjOmtleSBvdXRwdXRz CiZndDsrICAgICAgICAgICAgICAgICAgKGluY2x1ZGUgJygiLiouZWwkIiAiLiouZWwuaW4kIiAi XmRpciQiCiZndDsrICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLiouaW5mbyQiICIuKi50 ZXhpJCIgIi4qLnRleGluZm8kIgomZ3Q7KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIl5k b2MvZGlyIiAiXmRvYy8qLmluZm8kIiAiXmRvYy8qLnRleGkkIiAiXmRvYy8qLnRleGluZm8kIikp CiZndDsrICAgICAgICAgICAgICAgICAgKGV4Y2x1ZGUgJygiXi5kaXItbG9jYWxzLmVsJCIgIl50 ZXN0LmVsJCIgIl50ZXN0cy5lbCQiICIuKi10ZXN0LmVsJCIgIi4qLXRlc3RzLmVsJCIpKQomZ3Q7 KyAgICAgICAgICAgICAgICAgICM6YWxsb3ctb3RoZXIta2V5cykKJmd0OyAgICJJbnN0YWxsIHRo ZSBwYWNrYWdlIGNvbnRlbnRzLiIKJmd0OysKJmd0OysgIChkZWZpbmUgKGluY2x1ZGUtZmlsZT8g ZmlsZSkKJmd0OysgICAgKGFuZCAoYW55IChjdXQgc3RyaW5nLW1hdGNoICZsdDsmZ3Q7IGZpbGUp IGluY2x1ZGUpCiZndDsrICAgICAgICAgKG5vdCAoYW55IChjdXQgc3RyaW5nLW1hdGNoICZsdDsm Z3Q7IGZpbGUpIGV4Y2x1ZGUpKSkpCiZndDsrCiZndDsgICAobGV0KiAoKG91dCAoYXNzb2MtcmVm IG91dHB1dHMgIm91dCIpKQomZ3Q7ICAgICAgICAgIChlbHBhLW5hbWUtdmVyIChzdG9yZS1kaXJl Y3RvcnktJmd0O2VscGEtbmFtZS12ZXJzaW9uIG91dCkpCiZndDsgICAgICAgICAgKHNyYy1kaXIg KGdldGN3ZCkpCiZndDsgICAgICAgICAgKHRndC1kaXIgKHN0cmluZy1hcHBlbmQgb3V0ICVpbnN0 YWxsLXN1ZmZpeCAiLyIgZWxwYS1uYW1lLXZlcikpKQomZ3Q7LSAgICAoY29weS1yZWN1cnNpdmVs eSBzcmMtZGlyIHRndC1kaXIpCiZndDstICAgICN0KSkKJmd0OysgICAgKGZ0dyBzcmMtZGlyCiZn dDsrICAgICAgICAgKGxhbWJkYSAoZmlsZSBzdGF0IGZsYWcpCiZndDsrICAgICAgICAgICAobGV0 ICgoc3RyaXBwZWQtZmlsZSAoc3Vic3RyaW5nIGZpbGUgKHN0cmluZy1sZW5ndGggc3JjLWRpcikp KSkKJmd0OysgICAgICAgICAgICAgKHdoZW4gKGFuZCAoZXE/IGZsYWcgJ3JlZ3VsYXIpCiZndDsr ICAgICAgICAgICAgICAgICAgICAgICAgKGluY2x1ZGUtZmlsZT8gKHN0cmluZy10cmltIHN0cmlw cGVkLWZpbGUgI1wvKSkpCiZndDsrICAgICAgICAgICAgICAgKGZvcm1hdCAjdCAiYH5hJyAtJmd0 OyBgfmEnfiUiCiZndDsrICAgICAgICAgICAgICAgICAgICAgICBmaWxlIChzdHJpbmctYXBwZW5k IHRndC1kaXIgc3RyaXBwZWQtZmlsZSkpCiZndDsrICAgICAgICAgICAgICAgKGluc3RhbGwtZmls ZSBmaWxlIHRndC1kaXIpKSkKJmd0OysgICAgICAgICAgICN0KSkpKQomZ3Q7IAomZ3Q7IChkZWZp bmUqIChtb3ZlLWRvYyAjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKJmd0OyAgICJN b3ZlIGluZm8gZmlsZXMgZnJvbSB0aGUgRUxQQSBwYWNrYWdlIGRpcmVjdG9yeSB0byB0aGUgaW5m byBkaXJlY3RvcnkuIgomZ3Q7LS0gCiZndDsyLjEyLjIKJmd0OwomZ3Q7CiZndDsKJmd0Owo8L3By ZT48L2Rpdj4= ------=_Part_109074_1337663948.1492587780587-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 03:55:21 2017 Received: (at 26559) by debbugs.gnu.org; 19 Apr 2017 07:55:21 +0000 Received: from localhost ([127.0.0.1]:55472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0kSO-0004p1-U0 for submit@debbugs.gnu.org; Wed, 19 Apr 2017 03:55:21 -0400 Received: from o144.p8.mailjet.com ([87.253.233.144]:60072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0kSN-0004ot-0S for 26559@debbugs.gnu.org; Wed, 19 Apr 2017 03:55:19 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:references: x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=Bo62DQ3ezgTIYrlbDtJSxORl+gw=; b=QkrEz+TY6UKbTDUjkUfdRzRkVTxPLNHtfkbdcx0sB2umSqZOV+Bue0v2k qPgJgHvrzrZqho6i/FD1t8VlK6z3x+VAvr2r+d8Ex8ITe9n603BGwyAOSfwj ZMIxl0DEVXmRvb44Jppt1WKyvrUmV39TQ/uYmqzGFiU6v4Jw9+Vuug= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: 26559@debbugs.gnu.org Subject: Re: [PATCH] build: emacs: Install only a subset of files. Date: Wed, 19 Apr 2017 13:25:12 +0530 References: <20170419073525.2357-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEUAJJ_62WgAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY9xflwHULXMlUTh6Ax4u8DFE0rAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a work in progress patch for the discussion at https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00274.html All feedback welcome! Arun Isaac writes: > + (include ''(".*.el$" ".*.el.in$" "^dir$" > + ".*.info$" ".*.texi$" ".*.texinfo$" > + "doc/dir" "doc/*.info$" "doc/*.texi$" "= doc/*.texinfo$")) > + (exclude ''("^.dir-locals.el$" "^test.el$" "^tests= .el$" ".*-test.el$" ".*-tests.el$")) I've copied all this from MELPA's default :files property described at https://github.com/melpa/melpa . I have no idea what the rationale for some of these regexes are. Currently, include and exclude are a list of regexes that file names are matched against. Should this be combined into one big regex? Would it be a good idea to add a third keyword argument, say #:documentation, that will select info documentation files and install them separately in some other directory? = From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 05:23:44 2017 Received: (at 26559) by debbugs.gnu.org; 19 Apr 2017 09:23:44 +0000 Received: from localhost ([127.0.0.1]:55537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0lpv-0006yJ-PS for submit@debbugs.gnu.org; Wed, 19 Apr 2017 05:23:43 -0400 Received: from o105.p8.mailjet.com ([87.253.233.105]:58292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0lpt-0006yB-R1 for 26559@debbugs.gnu.org; Wed, 19 Apr 2017 05:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=f/iEk7i9p9Qb4hY3w5mJosZDeus=; b=WINOUnzDl6SJbygz9wfkAMvmYf6XMIGGzFX1GAoAsH44vdiEsXUEHZc0t h8Qp+a0N42KEfN5bRuzO+YsKsNJyCtnwhujRA606s4+87c/IYSG1aW1HXAeO YCqvg8SXt7v1m+6C6ZDUk/azfVlrqGxE+47JMlHDcqg/j5A7yRhxlU= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: 26559@debbugs.gnu.org Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Wed, 19 Apr 2017 14:53:24 +0530 In-reply-to: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> References: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAJcMSQmcAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY9yycBrgsNdqTTR6ZLM5yNbB_UAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tumashu writes: > What about package-pkg.el file?. What about it? I am not familiar with this file. Could you please elaborate? = From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 05:58:02 2017 Received: (at 26559) by debbugs.gnu.org; 19 Apr 2017 09:58:03 +0000 Received: from localhost ([127.0.0.1]:55572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0mN8-0007nR-Ne for submit@debbugs.gnu.org; Wed, 19 Apr 2017 05:58:02 -0400 Received: from m13-124.163.com ([220.181.13.124]:33542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0mN5-0007mp-5W for 26559@debbugs.gnu.org; Wed, 19 Apr 2017 05:58:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=7ylsP jPyHBmkGUPoeh3CgXePg3aLMGEjjXmIPSKJv+w=; b=KJVnwVgQlcBgbEw9y+QcT zuF2p9dkagISxKyVvcDIKMDZcW4uj8TBlDB6jC3g1HbXI2ZzXxKt+gttVMVCyPY5 /bRGcVJksuq1bGq3Zcc73z+4fF27khnxJD2IOPfJvLEAvFv9idqScNCDMq+JntUN KFI4SvWmBUwJTAtlTW7LZo= Received: from tumashu$163.com ( [36.149.40.164] ) by ajax-webmail-wmsvr124 (Coremail) ; Wed, 19 Apr 2017 17:57:41 +0800 (CST) X-Originating-IP: [36.149.40.164] Date: Wed, 19 Apr 2017 17:57:41 +0800 (CST) From: tumashu To: "Arun Isaac" Subject: Re:bug#26559: [PATCH] build: emacs: Install only a subset of files. X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 163com In-Reply-To: References: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> Content-Type: multipart/alternative; boundary="----=_Part_145428_896015378.1492595861561" MIME-Version: 1.0 Message-ID: <6068eafc.9594.15b85a56839.Coremail.tumashu@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: fMGowEDJL0GVNPdYwTbSAA--.60854W X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiwA2+1FXlYr7O1QABsR X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: "26559@debbugs.gnu.org" <26559@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) ------=_Part_145428_896015378.1492595861561 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 CgoKCgoKKi5wa2cuZWwgc2VlbSB0byBiZSB1c2VkIGJ5IGVtYWNzICBwYWNrYWdlLmVsLCAgd2hp Y2ggY2FuIG5vdCBiZSBjb21waWxlIHdpdGhvdXQgd2Fybi4gSSBjYW4gbm90IGZpbmQgdGhlIGRv Y3VtZW50Lgp0aGlzIG5lZWQgdG8gYmUgdmVyaWZ5LgoKCkF0IDIwMTctMDQtMTkgMTc6MjM6MjQs ICJBcnVuIElzYWFjIiA8YXJ1bmlzYWFjQHN5c3RlbXJlYm9vdC5uZXQ+IHdyb3RlOgo+Cj50dW1h c2h1IHdyaXRlczoKPgo+PiBXaGF0IGFib3V0ICBwYWNrYWdlLXBrZy5lbCAgZmlsZT8uCj4KPldo YXQgYWJvdXQgaXQ/IEkgYW0gbm90IGZhbWlsaWFyIHdpdGggdGhpcyBmaWxlLiBDb3VsZCB5b3Ug cGxlYXNlCj5lbGFib3JhdGU/Cj4KPgo+Cg== ------=_Part_145428_896015378.1492595861561 Content-Type: text/html; charset=GBK Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6MS43O2NvbG9yOiMwMDAwMDA7Zm9udC1zaXplOjE0cHg7 Zm9udC1mYW1pbHk6QXJpYWwiPjxicj48YnI+PGJyPjxicj48YnI+PGRpdiBzdHlsZT0icG9zaXRp b246cmVsYXRpdmU7em9vbToxIj48L2Rpdj48ZGl2IGlkPSJkaXZOZXRlYXNlTWFpbENhcmQiPjwv ZGl2PjxkaXY+Ki5wa2cuZWwgc2VlbSB0byBiZSB1c2VkIGJ5IGVtYWNzJm5ic3A7IHBhY2thZ2Uu ZWwsJm5ic3A7IHdoaWNoIGNhbiBub3QgYmUgY29tcGlsZSB3aXRob3V0IHdhcm4uIEkgY2FuIG5v dCBmaW5kIHRoZSBkb2N1bWVudC48YnI+dGhpcyBuZWVkIHRvIGJlIHZlcmlmeS48YnI+PC9kaXY+ PHByZT48YnI+QXQgMjAxNy0wNC0xOSAxNzoyMzoyNCwgIkFydW4gSXNhYWMiICZsdDthcnVuaXNh YWNAc3lzdGVtcmVib290Lm5ldCZndDsgd3JvdGU6CiZndDsKJmd0O3R1bWFzaHUgd3JpdGVzOgom Z3Q7CiZndDsmZ3Q7IFdoYXQgYWJvdXQgIHBhY2thZ2UtcGtnLmVsICBmaWxlPy4KJmd0OwomZ3Q7 V2hhdCBhYm91dCBpdD8gSSBhbSBub3QgZmFtaWxpYXIgd2l0aCB0aGlzIGZpbGUuIENvdWxkIHlv dSBwbGVhc2UKJmd0O2VsYWJvcmF0ZT8KJmd0OwomZ3Q7CiZndDsKPC9wcmU+PC9kaXY+ ------=_Part_145428_896015378.1492595861561-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 10:26:16 2017 Received: (at 26559) by debbugs.gnu.org; 19 Apr 2017 14:26:16 +0000 Received: from localhost ([127.0.0.1]:56951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0qYi-0001W0-IP for submit@debbugs.gnu.org; Wed, 19 Apr 2017 10:26:16 -0400 Received: from o179.p8.mailjet.com ([87.253.233.179]:51526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <968f0dff.ADsAAHQpxPwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY93OF@bnc3.mailjet.com>) id 1d0qYf-0001Vp-TI for 26559@debbugs.gnu.org; Wed, 19 Apr 2017 10:26:14 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=C74FA9DKhTvrFXavoyYLxSz/LDo=; b=imZhPQPrsVo/CKvYO4vTKkSqh1qAEjaGQq3JZIu4T4awl7xxDVcKPqfbC jX52lcUUgvtkKXvtQe08JtTxSAlh7UbZc+YvQJ0jISuH7lHEpr+Lt48NzMW6 2HAWR8MNUkO1P8boTCe7tIed98LOsmEGwn/aIP05dBQtvOVocUtCb8= Message-Id: <968f0dff.ADsAAHQpxPwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY93OF@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: "26559@debbugs.gnu.org" <26559@debbugs.gnu.org> Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Wed, 19 Apr 2017 19:56:06 +0530 In-reply-to: <6068eafc.9594.15b85a56839.Coremail.tumashu@163.com> References: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> <6068eafc.9594.15b85a56839.Coremail.tumashu@163.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: ADsAAHQpxPwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY93OFOWmDSA6zQ1yk7oklJWug3AAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tumashu writes: > *.pkg.el seem to be used by emacs package.el, which can not be compile > without warn. I can not find the document. this need to be verify. In the current implementation, *.pkg.el files will be installed due to the ".*.el" regexp in #:include. So, this is not an issue. = From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 22:26:26 2017 Received: (at 26559) by debbugs.gnu.org; 20 Apr 2017 02:26:26 +0000 Received: from localhost ([127.0.0.1]:57735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d11nd-000616-Tc for submit@debbugs.gnu.org; Wed, 19 Apr 2017 22:26:26 -0400 Received: from m13-60.163.com ([220.181.13.60]:51454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d11na-00060t-14 for 26559@debbugs.gnu.org; Wed, 19 Apr 2017 22:26:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=l2jfx 87p6Bt41xM3qSSlr2xdtzVwi3hVPME7H4wdC8k=; b=JybuYpxn+2RYEKTSwM3OJ BoagImkBQ5kM/E3AYkI43bGAg9juJOU6HE+RMwgky+OjQHzxt4utG7/USlA1neN5 oGhb8EVaBCwDzoGQlc54rdgjqWRl6hdjjBz9Z4XjWEbTa/wNBKyVGwVYW8wd0+tM QCqi2X6vsD59sAaiNtXAEw= Received: from tumashu$163.com ( [218.92.14.78] ) by ajax-webmail-wmsvr60 (Coremail) ; Thu, 20 Apr 2017 10:26:17 +0800 (CST) X-Originating-IP: [218.92.14.78] Date: Thu, 20 Apr 2017 10:26:17 +0800 (CST) From: tumashu To: "Arun Isaac" Subject: Re:bug#26559: [PATCH] build: emacs: Install only a subset of files. X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160729(86883.8884) Copyright (c) 2002-2017 www.mailtech.cn 163com In-Reply-To: <968f0dff.ADsAAHQpxPwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY93OF@mailjet.com> References: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> <6068eafc.9594.15b85a56839.Coremail.tumashu@163.com> <968f0dff.ADsAAHQpxPwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY93OF@mailjet.com> Content-Type: multipart/alternative; boundary="----=_Part_53221_724489141.1492655177919" MIME-Version: 1.0 Message-ID: <49e327f1.35e2.15b892e80c0.Coremail.tumashu@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: PMGowAA3JdVKHPhYs0cAAA--.345W X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiShq-1FO-40vTkwABs+ X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: "26559@debbugs.gnu.org" <26559@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) ------=_Part_53221_724489141.1492655177919 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 UEFDS0FHRS1wa2cuZWwgc2VlbSB0byAqb25seSogdXNlZnVsIHRvIHBhY2thZ2UuZWwsICAgaXQg aXMgdXNlbGVzcyBmb3IgZ3VpeCBlbWFjcyBwYWNrYWdlLgoKVGhlIGJlbG93IGlzIGNvbWUgZnJv bSBwYWNrYWdlLmVsJ3MgY29tbWVudGFyeQoKCiMrQkVHSU5fQ09NTUVOVAoKOzsgQSBwYWNrYWdl IGlzIGRlc2NyaWJlZCBieSBpdHMgbmFtZSBhbmQgdmVyc2lvbi4gIFRoZSBkaXN0cmlidXRpb24K OzsgZm9ybWF0IGlzIGVpdGhlciAgYSB0YXIgZmlsZSBvciBhIHNpbmdsZSAuZWwgZmlsZS4KCjs7 IEEgdGFyIGZpbGUgc2hvdWxkIGJlIG5hbWVkICJOQU1FLVZFUlNJT04udGFyIi4gIFRoZSB0YXIg ZmlsZSBtdXN0Cjs7IHVucGFjayBpbnRvIGEgZGlyZWN0b3J5IG5hbWVkIGFmdGVyIHRoZSBwYWNr YWdlIGFuZCB2ZXJzaW9uOgo7OyAiTkFNRS1WRVJTSU9OIi4gIEl0IG11c3QgY29udGFpbiBhIGZp bGUgbmFtZWQgIlBBQ0tBR0UtcGtnLmVsIgo7OyB3aGljaCBjb25zaXN0cyBvZiBhIGNhbGwgdG8g ZGVmaW5lLXBhY2thZ2UuICBJdCBtYXkgYWxzbyBjb250YWluIGEKOzsgImRpciIgZmlsZSBhbmQg dGhlIGluZm8gZmlsZXMgaXQgcmVmZXJlbmNlcy4KCjs7IEEgLmVsIGZpbGUgaXMgbmFtZWQgIk5B TUUtVkVSU0lPTi5lbCIgaW4gdGhlIHJlbW90ZSBhcmNoaXZlLCBidXQgaXMKOzsgaW5zdGFsbGVk IGFzIHNpbXBseSAiTkFNRS5lbCIgaW4gYSBkaXJlY3RvcnkgbmFtZWQgIk5BTUUtVkVSU0lPTiIu CgojK0VORF9DT01NRU5UCgoKCgoKCgoKQXQgMjAxNy0wNC0xOSAyMjoyNjowNiwgIkFydW4gSXNh YWMiIDxhcnVuaXNhYWNAc3lzdGVtcmVib290Lm5ldD4gd3JvdGU6Cj4KPnR1bWFzaHUgd3JpdGVz Ogo+Cj4+ICoucGtnLmVsIHNlZW0gdG8gYmUgdXNlZCBieSBlbWFjcyBwYWNrYWdlLmVsLCB3aGlj aCBjYW4gbm90IGJlIGNvbXBpbGUKPj4gd2l0aG91dCB3YXJuLiBJIGNhbiBub3QgZmluZCB0aGUg ZG9jdW1lbnQuICB0aGlzIG5lZWQgdG8gYmUgdmVyaWZ5Lgo+Cj5JbiB0aGUgY3VycmVudCBpbXBs ZW1lbnRhdGlvbiwgKi5wa2cuZWwgZmlsZXMgd2lsbCBiZSBpbnN0YWxsZWQgZHVlIHRvCj50aGUg Ii4qLmVsIiByZWdleHAgaW4gIzppbmNsdWRlLiBTbywgdGhpcyBpcyBub3QgYW4gaXNzdWUuCj4K Pgo+Cg== ------=_Part_53221_724489141.1492655177919 Content-Type: text/html; charset=GBK Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0ibGluZS1oZWlnaHQ6MS43O2NvbG9yOiMwMDAwMDA7Zm9udC1zaXplOjE0cHg7 Zm9udC1mYW1pbHk6QXJpYWwiPjxkaXY+UEFDS0FHRS1wa2cuZWwgc2VlbSB0byAqb25seSogdXNl ZnVsIHRvIHBhY2thZ2UuZWwsJm5ic3A7Jm5ic3A7IGl0IGlzIHVzZWxlc3MgZm9yIGd1aXggZW1h Y3MgcGFja2FnZS48YnI+PGJyPlRoZSBiZWxvdyBpcyBjb21lIGZyb20gcGFja2FnZS5lbCdzIGNv bW1lbnRhcnk8YnI+PGJyPjwvZGl2PjxkaXY+IytCRUdJTl9DT01NRU5UPGJyPjxicj47OyBBIHBh Y2thZ2UgaXMgZGVzY3JpYmVkIGJ5IGl0cyBuYW1lIGFuZCB2ZXJzaW9uLiZuYnNwOyBUaGUgZGlz dHJpYnV0aW9uPGJyPjs7IGZvcm1hdCBpcyBlaXRoZXImbmJzcDsgYSB0YXIgZmlsZSBvciBhIHNp bmdsZSAuZWwgZmlsZS48YnI+PGJyPjs7IEEgdGFyIGZpbGUgc2hvdWxkIGJlIG5hbWVkICJOQU1F LVZFUlNJT04udGFyIi4mbmJzcDsgVGhlIHRhciBmaWxlIG11c3Q8YnI+OzsgdW5wYWNrIGludG8g YSBkaXJlY3RvcnkgbmFtZWQgYWZ0ZXIgdGhlIHBhY2thZ2UgYW5kIHZlcnNpb246PGJyPjs7ICJO QU1FLVZFUlNJT04iLiZuYnNwOyBJdCBtdXN0IGNvbnRhaW4gYSBmaWxlIG5hbWVkICJQQUNLQUdF LXBrZy5lbCI8YnI+Ozsgd2hpY2ggY29uc2lzdHMgb2YgYSBjYWxsIHRvIGRlZmluZS1wYWNrYWdl LiZuYnNwOyBJdCBtYXkgYWxzbyBjb250YWluIGE8YnI+OzsgImRpciIgZmlsZSBhbmQgdGhlIGlu Zm8gZmlsZXMgaXQgcmVmZXJlbmNlcy48YnI+PGJyPjs7IEEgLmVsIGZpbGUgaXMgbmFtZWQgIk5B TUUtVkVSU0lPTi5lbCIgaW4gdGhlIHJlbW90ZSBhcmNoaXZlLCBidXQgaXM8YnI+OzsgaW5zdGFs bGVkIGFzIHNpbXBseSAiTkFNRS5lbCIgaW4gYSBkaXJlY3RvcnkgbmFtZWQgIk5BTUUtVkVSU0lP TiIuPGJyPjxicj4jK0VORF9DT01NRU5UPGJyPjwvZGl2Pjxicj48YnI+PGJyPjxkaXYgc3R5bGU9 InBvc2l0aW9uOnJlbGF0aXZlO3pvb206MSI+PC9kaXY+PGRpdiBpZD0iZGl2TmV0ZWFzZU1haWxD YXJkIj48L2Rpdj48YnI+PHByZT48YnI+QXQgMjAxNy0wNC0xOSAyMjoyNjowNiwgIkFydW4gSXNh YWMiICZsdDthcnVuaXNhYWNAc3lzdGVtcmVib290Lm5ldCZndDsgd3JvdGU6CiZndDsKJmd0O3R1 bWFzaHUgd3JpdGVzOgomZ3Q7CiZndDsmZ3Q7ICoucGtnLmVsIHNlZW0gdG8gYmUgdXNlZCBieSBl bWFjcyBwYWNrYWdlLmVsLCB3aGljaCBjYW4gbm90IGJlIGNvbXBpbGUKJmd0OyZndDsgd2l0aG91 dCB3YXJuLiBJIGNhbiBub3QgZmluZCB0aGUgZG9jdW1lbnQuICB0aGlzIG5lZWQgdG8gYmUgdmVy aWZ5LgomZ3Q7CiZndDtJbiB0aGUgY3VycmVudCBpbXBsZW1lbnRhdGlvbiwgKi5wa2cuZWwgZmls ZXMgd2lsbCBiZSBpbnN0YWxsZWQgZHVlIHRvCiZndDt0aGUgIi4qLmVsIiByZWdleHAgaW4gIzpp bmNsdWRlLiBTbywgdGhpcyBpcyBub3QgYW4gaXNzdWUuCiZndDsKJmd0OwomZ3Q7CjwvcHJlPjwv ZGl2Pg== ------=_Part_53221_724489141.1492655177919-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 20 04:43:33 2017 Received: (at 26559) by debbugs.gnu.org; 20 Apr 2017 08:43:33 +0000 Received: from localhost ([127.0.0.1]:57898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d17ga-0001wN-UL for submit@debbugs.gnu.org; Thu, 20 Apr 2017 04:43:33 -0400 Received: from o155.p9.mailjet.com ([87.253.234.155]:42098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <1c00c312.AEEAJsZ1aH8AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-HSy@bnc3.mailjet.com>) id 1d17gZ-0001wF-8W for 26559@debbugs.gnu.org; Thu, 20 Apr 2017 04:43:31 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=2QaIuK2+x+6fiY7tc4F/QDbimHY=; b=NwkadmWW1tW8WlXhzqmijILhiOwT70hheDXslTdZijDrLCMpkHRaqPKVE fZRS1w1H5jonnsED0xFqY+23eTyhLtpY4We0PndyfI2/IkTa1NLlEixYz8yh N+MAAfuUMkGT5gieTKGNkueXlyXc5aUEDlRWbUJ1goy5J52RsDtrLU= Message-Id: <1c00c312.AEEAJsZ1aH8AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-HSy@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26559@debbugs.gnu.org Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Thu, 20 Apr 2017 14:13:22 +0530 In-reply-to: <49e327f1.35e2.15b892e80c0.Coremail.tumashu@163.com> References: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> <6068eafc.9594.15b85a56839.Coremail.tumashu@163.com> <968f0dff.ADsAAHQpxPwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY93OF@mailjet.com> <49e327f1.35e2.15b892e80c0.Coremail.tumashu@163.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAJsZ1aH8AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-HSyaeDK4qj5TsGfHCXihAleagAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tumashu writes: > it is useless for guix emacs package. If it is unnecessary we can simply include one more regexp to the #:exclude keyword argument so that it does not get installed. = From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 20 07:39:36 2017 Received: (at 26559) by debbugs.gnu.org; 20 Apr 2017 11:39:36 +0000 Received: from localhost ([127.0.0.1]:58034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1AQw-0001e5-Qo for submit@debbugs.gnu.org; Thu, 20 Apr 2017 07:39:35 -0400 Received: from mail-lf0-f47.google.com ([209.85.215.47]:35628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1AQu-0001dp-8c for 26559@debbugs.gnu.org; Thu, 20 Apr 2017 07:39:33 -0400 Received: by mail-lf0-f47.google.com with SMTP id 75so27235817lfs.2 for <26559@debbugs.gnu.org>; Thu, 20 Apr 2017 04:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=uhQ0AmRhvw9dXjsVbXMjcH0IpXp4TxSvQFtFyzgv+7g=; b=SEyiYR/IxrFyNKm4rc9T6QXW9uFKjVMaroEx6qxIar3NNCbO+uXhiYE75jm3Jk4FFX bB484AfMGMIw+ETzhqFkq3kh3Ie1/lDePoeN+qK1yor2MbyuB1SyhvLhsuL2RLDuW8lx Su1UitrLutkWzK3doON48LDB9CdKxzd6VEAv1J3z+zE5XJdXhYPoevfpxTI0H1SuTuJZ RvoHNP5BOQHIVZaEnwVTZ79RiQU9+xkxPw7SqfRh9efp3FoF+oc115WFCgkqQ+P2UO1b pn0OmqD/WaUTY8Xd+FPbsrRwWLZNBuEvcobdjBSOy2+Eso08/hn47MJMfFyY+GfXPpkP mg7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=uhQ0AmRhvw9dXjsVbXMjcH0IpXp4TxSvQFtFyzgv+7g=; b=j0Y+3yDqBWuuTBcpPBCf6PEYxaamrQUkMbAEzmWzxIES1jhNqjs8ujoeIP2jAok9BB yT1kbtAP+saUavozWpS+vbY/wAg2ltIDMjqs+Sjx5YTe1WcjKem/smlXiNFmwvZJdsbU tagbEdMj8PxbLwKySKhOavL8BvsBjE2mftknihrQPXKzWZbAI8kxqWMz8Cm8iwenlEzD qHXTqcgsznBf4lUp+rT/5uFu/OEneJMChBLCgH2ZmhjnWI39Lq59RulOyyAVYVaYRNkf 0GoqrJpH7gEiUysv9avvOLWUiLi6CsjgTLl9ydckc1UA8x51C1RYYqh9zrUn9ZmXWNHa hPCA== X-Gm-Message-State: AN3rC/4zEsZvwbPRLJECBYMmDBzjkDc3Eu8f+gRGz40NJBLnrQz0bL0/ cdM98r2yQS0cQAdU X-Received: by 10.46.7.17 with SMTP id 17mr2800335ljh.43.1492688366135; Thu, 20 Apr 2017 04:39:26 -0700 (PDT) Received: from leviafan ([217.107.194.138]) by smtp.gmail.com with ESMTPSA id g17sm622952ljd.23.2017.04.20.04.39.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Apr 2017 04:39:25 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. References: <20170419073525.2357-1-arunisaac@systemreboot.net> Date: Thu, 20 Apr 2017 14:39:24 +0300 In-Reply-To: (Arun Isaac's message of "Wed, 19 Apr 2017 13:25:12 +0530") Message-ID: <877f2fqpeb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-04-19 13:25 +0530) wrote: > This is a work in progress patch for the discussion at > https://lists.gnu.org/archive/html/guix-devel/2017-04/msg00274.html > > All feedback welcome! Great, thanks for working on it! > Arun Isaac writes: > >> + (include ''(".*.el$" ".*.el.in$" "^dir$" >> + ".*.info$" ".*.texi$" ".*.texinfo$" >> + "doc/dir" "doc/*.info$" "doc/*.texi$" "doc/*.texinfo$")) >> + (exclude ''("^.dir-locals.el$" "^test.el$" "^tests.el$" ".*-test.el$" ".*-tests.el$")) > > I've copied all this from MELPA's default :files property described at > https://github.com/melpa/melpa . I have no idea what the rationale for > some of these regexes are. What regexps are not clear for you? > Currently, include and exclude are a list of regexes that file names are > matched against. Should this be combined into one big regex? I think it is not needed, it is more clean to separate regexps. > Would it be a good idea to add a third keyword argument, say > #:documentation, that will select info documentation files and install > them separately in some other directory? Regarding documentation: note that it is already installed into the proper place. I mean if the package has ".info" files, they are installed into "share/info" (look at 'move-doc' procedure in (guix build emacs-build-system) module). For example, 'emacs-debbugs' has the info manual and it is installed appropriately. So I think #:documentation is not needed. Also I would like to note that this patch (when it will be ready) shouldn't be committed alone: there are some emacs packages that should be adjusted to include additional files. One that comes to mind is 'emacs-slime' - it *must* contain *.lisp files (and other files as listed at ). Otherwise, it wouldn't work at all. So I think this patch should be committed with the according fixes for such "complex" packages (not sure if there are other ones along with 'emacs-slime'). -- Alex From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 20 07:50:49 2017 Received: (at 26559) by debbugs.gnu.org; 20 Apr 2017 11:50:49 +0000 Received: from localhost ([127.0.0.1]:58039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1Abo-0001ut-VR for submit@debbugs.gnu.org; Thu, 20 Apr 2017 07:50:49 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:33416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1Abn-0001uh-OX for 26559@debbugs.gnu.org; Thu, 20 Apr 2017 07:50:48 -0400 Received: by mail-lf0-f50.google.com with SMTP id 88so27414081lfr.0 for <26559@debbugs.gnu.org>; Thu, 20 Apr 2017 04:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=AydwzeLKuPkeinIQGFPnzptG2a1JJNtIXd/HeDedii0=; b=SIUTqTc0J+9z1kHPd8WXFAGpvIiwUoa3t4P7iS4mMk+7IraXpqaOaeZ5nTMcVQIcQE UnnKwacu1EsQE97+YI9s8/DGABKJ98WQG882vVgpTDpLx8TNTBzNp7cP/Dvue7lCTJcR 39zae3uz37+QPh24Y5KYOHHwcPGN5VH7eWU/q/ZtQ2+5oIkYB30fyN2W3FC6EzKr/5F5 CzquXyIIMn0GIHeKOkcK9uaRksSRBsu3WmEhsPzV3VY/ixIkonIeeudN522c9yCBvMd+ 1R/q6uoVNbcCx0VQALSWk0dELJHypbJ5v9/X39dTaI9DkYRcKYowyTdc7T4oo2Yvj++H B1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=AydwzeLKuPkeinIQGFPnzptG2a1JJNtIXd/HeDedii0=; b=jmRM/Lhzl2ku/MdVwGSMpbdShDuHF109huxEumbDlc9uYWP49ub4i3kxfK847fcZDJ VRw8DgSg8ODavZuukEWNlvgqNgULTrfgrm94smYCLqGZvgw6Tsni2UB80+hwKWGtYVkf mAIer5y2cTKMcRXl/22YzmZXqGoaQD5P9GAfM2Etvukt2uStt5zMULeOqJeGQ1b0V4Pg rdgBsy9XieLcjJjJvVUmzx3YPyzFqcEB0lC60Oqbfxiy1PD2eKUYzmAn+aAP7bQMPMGQ 17qn5/JqzgpH45tawoiW5l6zeu0GTC3QSv0rBsKPk5b7YOPSe7sUFLG32KwWVdiuyntm B3nA== X-Gm-Message-State: AN3rC/7ur3T2ha9mq549TzPIEGjtu8kWQFQRQVORdFrH+H2KO6dQEknF dnKrkO94UIp4dg== X-Received: by 10.46.32.35 with SMTP id g35mr2921817ljg.126.1492689041839; Thu, 20 Apr 2017 04:50:41 -0700 (PDT) Received: from leviafan ([217.107.194.138]) by smtp.gmail.com with ESMTPSA id g129sm840256lfe.69.2017.04.20.04.50.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Apr 2017 04:50:41 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. References: <6c8662dc.6f62.15b852a19eb.Coremail.tumashu@163.com> <6068eafc.9594.15b85a56839.Coremail.tumashu@163.com> <968f0dff.ADsAAHQpxPwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY93OF@mailjet.com> <49e327f1.35e2.15b892e80c0.Coremail.tumashu@163.com> <1c00c312.AEEAJsZ1aH8AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-HSy@mailjet.com> Date: Thu, 20 Apr 2017 14:50:41 +0300 In-Reply-To: <1c00c312.AEEAJsZ1aH8AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-HSy@mailjet.com> (Arun Isaac's message of "Thu, 20 Apr 2017 14:13:22 +0530") Message-ID: <8760hzqovi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-04-20 14:13 +0530) wrote: > tumashu writes: > >> it is useless for guix emacs package. > > If it is unnecessary we can simply include one more regexp to the > #:exclude keyword argument so that it does not get installed. Yes, it is completely unnecessary for Guix, so it can be excluded. -- Alex From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 20 08:52:44 2017 Received: (at 26559) by debbugs.gnu.org; 20 Apr 2017 12:52:44 +0000 Received: from localhost ([127.0.0.1]:58084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1BZk-0003U8-1h for submit@debbugs.gnu.org; Thu, 20 Apr 2017 08:52:44 -0400 Received: from o157.p9.mailjet.com ([87.253.234.157]:43841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@bnc3.mailjet.com>) id 1d1BZi-0003Tz-GH for 26559@debbugs.gnu.org; Thu, 20 Apr 2017 08:52:43 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=o1E92gpEMKs2Xf0/F1P0SKK9lts=; b=i6Hs9u11OCu6BZ+eVXBcavpKwHPvFOBNcCaioF5xr7RG/tpIGklnqTwft J1YThUCqK0dWROoRJr+XOTddOkwn9d28Ndjdq1hmrpDMc85H6NUMifkpWFyy iB0ybULu7GZrsOpikrxeMNMOOEw3HRI7zQCHsvP5WZywDPy3hN//8k= Message-Id: <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26559@debbugs.gnu.org Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Thu, 20 Apr 2017 18:22:34 +0530 In-reply-to: <877f2fqpeb.fsf@gmail.com> References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y-YGG1bLsT46-WGGatSavZwAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >>> + (include ''(".*.el$" ".*.el.in$" "^dir$" >>> + ".*.info$" ".*.texi$" ".*.texinfo$" >>> + "doc/dir" "doc/*.info$" "doc/*.texi$"= "doc/*.texinfo$")) >>> + (exclude ''("^.dir-locals.el$" "^test.el$" "^tes= ts.el$" ".*-test.el$" ".*-tests.el$")) >> >> I've copied all this from MELPA's default :files property described at >> https://github.com/melpa/melpa . I have no idea what the rationale for >> some of these regexes are. > > What regexps are not clear for you? I don't understand what ".*.el.in$", "^dir$" and "doc/dir" are for. >> Currently, include and exclude are a list of regexes that file names are >> matched against. Should this be combined into one big regex? > > I think it is not needed, it is more clean to separate regexps. Ok. Also, please suggest better names if #:include and #:exclude are not clear. Perhaps #:include-files and #:exclude-files, or #:install-files and #:no-install-files ? Any other style changes to the code are also welcome. > Regarding documentation: note that it is already installed into the > proper place. I mean if the package has ".info" files, they are > installed into "share/info" (look at 'move-doc' procedure in (guix build > emacs-build-system) module). For example, 'emacs-debbugs' has the info > manual and it is installed appropriately. So I think #:documentation is > not needed. Yeah, move-doc is good. I forgot about it. > Also I would like to note that this patch (when it will be ready) > shouldn't be committed alone: there are some emacs packages that should > be adjusted to include additional files. One that comes to mind is > 'emacs-slime' - it *must* contain *.lisp files (and other files as > listed at ). > Otherwise, it wouldn't work at all. For specific packages, we can always override the #:include and #:exclude keyword arguments. Or, even replace the 'install phase if it comes to that. > So I think this patch should be committed with the according fixes for > such "complex" packages (not sure if there are other ones along with > 'emacs-slime'). Is there some standard workflow for testing packages when there is a build system change? There are currently 154 packages in gnu/packages/emacs.scm. Should I test them all? = From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 22 15:56:15 2017 Received: (at 26559) by debbugs.gnu.org; 22 Apr 2017 19:56:15 +0000 Received: from localhost ([127.0.0.1]:34739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d218h-0001KB-DV for submit@debbugs.gnu.org; Sat, 22 Apr 2017 15:56:15 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:33634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d218e-0001Jx-Vt for 26559@debbugs.gnu.org; Sat, 22 Apr 2017 15:56:13 -0400 Received: by mail-lf0-f54.google.com with SMTP id 88so58161559lfr.0 for <26559@debbugs.gnu.org>; Sat, 22 Apr 2017 12:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wIDN0sgrIm4lD6OgorrfOLXG2pku91kQT4LxT67NXGI=; b=n/z7dY7BR0HpJ2bvPXgge41y3wDBys5loCF9UiwdbctSCqWbETm1qujJA2ubnXC9ES I6SJIDR5XneAuRke8aun5gYZw3iUr9FdkerVlmb3B7BxGngNAVbf2lMZR2TCYr8SbJm5 plax9aFOWgX6a6ReC94lf9Sey8VKX3514+3ljqd8QnPlckhSJkTWXNdzKN4u1pIsMpMT mjBQJSRa4Hf8TvHa+LG425IunWA18FdK93qedCsYqjm/hvzNVdYCOEYr5dB1b4bhGA3D e/wMCncsG/ezBM5FOGeyZ8EMxfC7YYZfZn779DKIRGCZQ/HUi6IAiwEd8LwrpY7D84OK Y9XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wIDN0sgrIm4lD6OgorrfOLXG2pku91kQT4LxT67NXGI=; b=kOMMziGqi/j8LNgJlXDoexIayK24j4YKuYvybRqh+GBZROuRQpkR6gS5Snud0j7NlP RukgM8d9t449/5ua5H6YcDgPBFqGqJ+W7d5tUp4pX6OH7rXRFws9W+4hVwdTlSsnOTUW 3G0r2cEzQ/Ov+Qfw5Ht/x+tuZyHvzAwmZ4m7rpb4TgZWlz8JYm663DPd6KE7S1XApRtN 0QTKvSgEuVKx4jR/XElnQp7ypjKV9gj4uV47st++dcrXn5XGf37SW4DZvJ5p0dSEiMii 9K0rjRxv1BYxPsUFxdj4bYHsJyfx+SOeS2PAl7Vr9YpXDUefaf7CtRcs2RmAaaS5Qz29 er/A== X-Gm-Message-State: AN3rC/4rSz8uRoEXL5AC1lVFy2bhqMcrmjSFTNjDvNA0yJy8cylYA3GX 1G9rGZ7dD7ZEzRDz X-Received: by 10.46.19.26 with SMTP id 26mr7124807ljt.117.1492890966634; Sat, 22 Apr 2017 12:56:06 -0700 (PDT) Received: from leviafan ([217.107.194.138]) by smtp.gmail.com with ESMTPSA id e25sm2285584ljb.17.2017.04.22.12.56.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Apr 2017 12:56:05 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@mailjet.com> Date: Sat, 22 Apr 2017 22:56:07 +0300 In-Reply-To: <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@mailjet.com> (Arun Isaac's message of "Thu, 20 Apr 2017 18:22:34 +0530") Message-ID: <87shl09pyg.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-04-20 18:22 +0530) wrote: >>>> + (include ''(".*.el$" ".*.el.in$" "^dir$" >>>> + ".*.info$" ".*.texi$" ".*.texinfo$" >>>> + "doc/dir" "doc/*.info$" "doc/*.texi$" "doc/*.texinfo$")) >>>> + (exclude ''("^.dir-locals.el$" "^test.el$" "^tests.el$" ".*-test.el$" ".*-tests.el$")) >>> >>> I've copied all this from MELPA's default :files property described at >>> https://github.com/melpa/melpa . I have no idea what the rationale for >>> some of these regexes are. >> >> What regexps are not clear for you? > > I don't understand what ".*.el.in$", "^dir$" and "doc/dir" are for. "dir" file is for documentation (to make the according manual entry appear in the top Info directory). These "dir" files are not needed for Guix, as Guix generates "dir" after updating a profile ("/share/info/dir"). Usually files with ".in" ending are used as templates to generate other files from them (in this case ".el" from ".el.in"). It looks like there are packages that have ".el.in" files but not ".el" files, and package-build (used by melpa) just renames such files. At least that's what I understood from: https://github.com/melpa/package-build/commit/d1c217a7ef33807c4948853114133af72284031c But I'm sure we don't have the packages with ".el.in" files, and if we will, most likely gnu-build-system will be used for them, so I suggest to remove ".el.in" regexp from the "include" list. >>> Currently, include and exclude are a list of regexes that file names are >>> matched against. Should this be combined into one big regex? >> >> I think it is not needed, it is more clean to separate regexps. > > Ok. Also, please suggest better names if #:include and #:exclude are not > clear. Perhaps #:include-files and #:exclude-files, or #:install-files > and #:no-install-files ? I think include/exclude is OK. But maybe other people (if anyone else reads this thread :-)) have other opinions. [...] >> Also I would like to note that this patch (when it will be ready) >> shouldn't be committed alone: there are some emacs packages that should >> be adjusted to include additional files. One that comes to mind is >> 'emacs-slime' - it *must* contain *.lisp files (and other files as >> listed at ). >> Otherwise, it wouldn't work at all. > > For specific packages, we can always override the #:include and > #:exclude keyword arguments. Or, even replace the 'install phase if it > comes to that. Yes, that's what I meant. >> So I think this patch should be committed with the according fixes for >> such "complex" packages (not sure if there are other ones along with >> 'emacs-slime'). > > Is there some standard workflow for testing packages when there is a > build system change? AFAIK, there is no standard workflow :-) > There are currently 154 packages in > gnu/packages/emacs.scm. Should I test them all? I think it would be too much work. I quickly looked at the emacs packages, and I believe that only slime, auctex and yasnippet need to be adjusted to include non-standard files. Of course, there may be other packages that I'm not aware of, but they can be fixed later. -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 22 15:57:12 2017 Received: (at 26559) by debbugs.gnu.org; 22 Apr 2017 19:57:12 +0000 Received: from localhost ([127.0.0.1]:34743 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d219b-0001Lk-Pw for submit@debbugs.gnu.org; Sat, 22 Apr 2017 15:57:11 -0400 Received: from mail-lf0-f45.google.com ([209.85.215.45]:35412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d219a-0001LX-Cl for 26559@debbugs.gnu.org; Sat, 22 Apr 2017 15:57:10 -0400 Received: by mail-lf0-f45.google.com with SMTP id 75so58136563lfs.2 for <26559@debbugs.gnu.org>; Sat, 22 Apr 2017 12:57:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0kJ8nFJHQ0ajfGL8Njw/057zsjQ4pRCufiNPDdTAaWg=; b=AtYPXM0k/VCoJNPCDKZmhPZb03kdNDExlVN65zooa58fZXcsnbyiC+IbanPJJEDwD2 5KK2BgwP9rI8xpqGW0OhHKNn1+N2aFY9gh5DKbT5DstjxuhP1PjHF3to95DvBTS1flzV WZselNJDhyjy1z6RZAWEzXlAjQoHZq0WxrOP+BUFccIPgXj9+2invu/Me+y0WsF240So 8BUxbOj64P2usUI4hoKZPxKpl3bHbgdB7RSB9KUC8T7i+TNhloy8N63N1kMtlwCipddS v+KTtk/W811dT5lI8fjKPDs3VzNNVcHQydNs1mTRlD5khoLv0w2RPKadbVV829YQsv5A vZ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=0kJ8nFJHQ0ajfGL8Njw/057zsjQ4pRCufiNPDdTAaWg=; b=OkXdblnClPfqYj5Q2V8hZ92ia8iRxOY+zuSiwcL9FnsxyQXOZwTxAR4Lkl7ZME2Qb2 IG/zCymrLnanCfU876/6Roomj6zpCsvT+G0KeWbhFl0XJAUfMkF/W2HYBYTLDFgl5CnI po1Lvp5kiFnTTNEEyZIkMpsoMdGhQy4w7sBPTwAYMu1YD5wjT/SJnuM5on4T2I/2j7Ly JOqLctKOse6gqYGfqEH+HJ6nPe8n6P9Buv7IY+fmRJEHOPhfrmnfrFPTX8jlvjYuAT6I OUWx1OYHfR1QRsWz053PlBRhhZv9LAZjAFzGQ7Mr2zbrecROE0ktl1xk84OYlD9vtGiM bDFQ== X-Gm-Message-State: AN3rC/6a4/csMMZII7QfeSAbglDq5hFGHIrQFCDV+IZ+IgLyulTWzA00 Rc6g/ZiPTcNppw== X-Received: by 10.46.22.76 with SMTP id 12mr6845369ljw.55.1492891024649; Sat, 22 Apr 2017 12:57:04 -0700 (PDT) Received: from leviafan ([217.107.194.138]) by smtp.gmail.com with ESMTPSA id x5sm2314334lfi.41.2017.04.22.12.57.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Apr 2017 12:57:04 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. References: Date: Sat, 22 Apr 2017 22:57:05 +0300 In-Reply-To: (Arun Isaac's message of "Wed, 19 Apr 2017 13:05:25 +0530") Message-ID: <87r30k9pwu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-04-19 13:05 +0530) wrote: > * guix/build/emacs-build-system.scm (install): Install files matching > #:include while excluding files matching #:exclude. > * guix/build-system/emacs.scm (emacs-build): Add keyword arguments #:include > and #:exclude. > --- > guix/build-system/emacs.scm | 6 ++++++ > guix/build/emacs-build-system.scm | 24 +++++++++++++++++++++--- > 2 files changed, 27 insertions(+), 3 deletions(-) > > diff --git a/guix/build-system/emacs.scm b/guix/build-system/emacs.scm > index a7982002b..e6c021c7e 100644 > --- a/guix/build-system/emacs.scm > +++ b/guix/build-system/emacs.scm > @@ -83,6 +83,10 @@ > (phases '(@ (guix build emacs-build-system) > %standard-phases)) > (outputs '("out")) > + (include ''(".*.el$" ".*.el.in$" "^dir$" > + ".*.info$" ".*.texi$" ".*.texinfo$" > + "doc/dir" "doc/*.info$" "doc/*.texi$" "doc/*.texinfo$")) I think only ".*.el$", ".*.info$", and probably "doc/*.info$" are needed here. The rest regexps look useless to me. Note, however, that 'move-doc' procedure should be adjusted to find info in "doc" subdir (for "doc/*.info$" regex). > + (exclude ''("^.dir-locals.el$" "^test.el$" "^tests.el$" ".*-test.el$" ".*-tests.el$")) Don't forget to add ".*-pkg.el" here. [...] > -(define* (install #:key outputs #:allow-other-keys) > +(define* (install #:key outputs > + (include '(".*.el$" ".*.el.in$" "^dir$" > + ".*.info$" ".*.texi$" ".*.texinfo$" > + "^doc/dir" "^doc/*.info$" "^doc/*.texi$" "^doc/*.texinfo$")) > + (exclude '("^.dir-locals.el$" "^test.el$" "^tests.el$" ".*-test.el$" ".*-tests.el$")) It doesn't look right that these regexps are duplicated in 2 places. I'm not very familiar with build systems, but what if the 'include'/'exclude' arguments of 'install' procedure would simply be empty lists? I think it wouldn't do harm if you leave these regexps only in 'emacs-build' procedure or would it? -- Alex From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 10:11:41 2017 Received: (at 26559) by debbugs.gnu.org; 26 Apr 2017 14:11:42 +0000 Received: from localhost ([127.0.0.1]:41775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3NfL-00057h-LQ for submit@debbugs.gnu.org; Wed, 26 Apr 2017 10:11:41 -0400 Received: from o107.p9.mailjet.com ([87.253.234.107]:41674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <05f43388.ADsAAHWtufMAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKqN@bnc3.mailjet.com>) id 1d3NfC-00057S-GC for 26559@debbugs.gnu.org; Wed, 26 Apr 2017 10:11:32 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=910Zb9DTislAzKWpRJb3K3r1A80=; b=RyxrqtUxOtQyfYqv/lWVhBZdBB6ywTsWE1j7PgQdQQ9h+AecQ3MIVUstj GsBKONIi269l+ma5yGFkywyMW3h6RIFLCqlNM8fwOkq9Nf2t4j0NpLiqMGze ZCjzsCLgEYm3aFQwAmIDMZfu8sshFxbAiEb1nSAvx6aAeeLlxWXOCI= Message-Id: <05f43388.ADsAAHWtufMAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKqN@mailjet.com> From: Arun Isaac To: 26559@debbugs.gnu.org Subject: [PATCH 2/3] gnu: emacs-slime: Add arguments to work with new `install' phase. Date: Wed, 26 Apr 2017 19:39:28 +0530 In-Reply-To: <20170426140929.27133-1-arunisaac@systemreboot.net> References: <20170426140929.27133-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: ADsAAHWtufMAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKqN3A-3m5Q1R4m8H3PZbR0WmAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) * gnu/packages/emacs.scm (emacs-slime)[arguments]: Add #:include and #:excl= ude arguments. --- gnu/packages/emacs.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 14d851184..9c919c49d 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -2333,7 +2333,10 @@ in @code{html-mode}.") (native-inputs `(("texinfo" ,texinfo))) (arguments - `(#:phases + `(#:include '("\\.el$" "\\.lisp$" "\\.asd$" "\\.goo$" + "\\.ss$" "\\.k$" "\\.scm$" "\\.rb$" "\\.sml$") + #:exclude '("^contrib/test/") + #:phases (modify-phases %standard-phases (add-before 'install 'configure (lambda* _ --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 10:14:10 2017 Received: (at 26559) by debbugs.gnu.org; 26 Apr 2017 14:14:10 +0000 Received: from localhost ([127.0.0.1]:41780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3Nhm-0005Bf-50 for submit@debbugs.gnu.org; Wed, 26 Apr 2017 10:14:09 -0400 Received: from o176.p8.mailjet.com ([87.253.233.176]:33517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <03c35e3d.AEMAJpkR4_oAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKsn@bnc3.mailjet.com>) id 1d3Nhh-0005Ay-1k for 26559@debbugs.gnu.org; Wed, 26 Apr 2017 10:14:04 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=F7MSEQiXsmVvqtx2IKKl+gHIjBw=; b=sdbd9hPNmTx/wuNh+QzgtIq5u+jI3gI2Og7/UWe7UVCw7xfZZJoiWaKm/ XGj0wOf2Nms1ZuW9+aFc9FPDSVgvco6oMjf+BvHgM+nBQbFsox3J9ClVTM+N W699hxmw8guH69PIed42f/tNatC3ljzFijOxMPRocGqPvcvYAfwQJU= Message-Id: <03c35e3d.AEMAJpkR4_oAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKsn@mailjet.com> From: Arun Isaac To: 26559@debbugs.gnu.org Subject: [PATCH 3/3] gnu: emacs-auctex: Add arguments to work with new `install' phase. Date: Wed, 26 Apr 2017 19:39:29 +0530 In-Reply-To: <20170426140929.27133-1-arunisaac@systemreboot.net> References: <20170426140929.27133-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAJpkR4_oAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKsny3qHmTRISLykCusZAnXmUgAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) * gnu/packages/emacs.scm (emacs-auctex)[arguments]: Add #:include and #:exclude arguments. --- gnu/packages/emacs.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 9c919c49d..d9cdcf2b5 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -1197,7 +1197,10 @@ as a library for other Emacs packages.") (build-system emacs-build-system) ;; We use 'emacs' because AUCTeX requires dbus at compile time ;; ('emacs-minimal' does not provide dbus). - (arguments `(#:emacs ,emacs)) + (arguments + `(#:emacs ,emacs + #:include '("\\.el$" "^images/" "^latex/" "\\.info$") + #:exclude '("^tests/" "^latex/README"))) (native-inputs `(("perl" ,perl))) (home-page "https://www.gnu.org/software/auctex/") --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 10:14:14 2017 Received: (at 26559) by debbugs.gnu.org; 26 Apr 2017 14:14:14 +0000 Received: from localhost ([127.0.0.1]:41782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3Nhp-0005Bl-Vf for submit@debbugs.gnu.org; Wed, 26 Apr 2017 10:14:14 -0400 Received: from o176.p8.mailjet.com ([87.253.233.176]:50123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3Nhh-0005Az-2a for 26559@debbugs.gnu.org; Wed, 26 Apr 2017 10:14:06 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints: x-mj-mid:mime-version:content-transfer-encoding; bh=m2fi9hSLN/i0JyM0jGPmiCxwywk=; b=FaV/mBLaVp+T1F11y9VEORwffNZSbgOOF/hE3/lVqUVXLZh31WmAe6fJB rIrlHCKjCI4SFa7lx4J1EMQ6fulS4wV6QbWg3mFyVu+D/lWF4mHiK1iACAyj CcYY3RHvARY4j7ZHZwZGtI8QdCZjkDieTAhrbX8tjDN4Un/ci1HPGw= Message-Id: From: Arun Isaac To: 26559@debbugs.gnu.org Subject: [PATCH 1/3] build: emacs: Install only a subset of files. Date: Wed, 26 Apr 2017 19:39:27 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAJpkR4roAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKsni5lI1qjjRYi6WLuhgFALFQAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) * guix/build/emacs-build-system.scm (install): Install files matching #:include while excluding files matching #:exclude. * guix/build-system/emacs.scm (emacs-build): Add keyword arguments #:includ= e and #:exclude. --- guix/build-system/emacs.scm | 4 ++++ guix/build/emacs-build-system.scm | 25 +++++++++++++++++++++---- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/guix/build-system/emacs.scm b/guix/build-system/emacs.scm index a7982002b..9a46ecfd2 100644 --- a/guix/build-system/emacs.scm +++ b/guix/build-system/emacs.scm @@ -83,6 +83,8 @@ (phases '(@ (guix build emacs-build-system) %standard-phases)) (outputs '("out")) + (include ''("^[^/]*\\.el$" "^[^/]*\\.info$" "^doc/.*= \\.info$")) + (exclude ''("^\\.dir-locals\\.el$" "-pkg\\.el$" "^[^= /]*tests?\\.el$")) (search-paths '()) (system (%current-system)) (guile #f) @@ -108,6 +110,8 @@ #:tests? ,tests? #:phases ,phases #:outputs %outputs + #:include ,include + #:exclude ,exclude #:search-paths ',(map search-path-specification->sexp search-paths) #:inputs %build-inputs))) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-sys= tem.scm index 44e8b0d31..fefdbb96e 100644 --- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -28,6 +28,7 @@ #:use-module (ice-9 rdelim) #:use-module (ice-9 regex) #:use-module (ice-9 match) + #:use-module (ice-9 ftw) #:export (%standard-phases emacs-build)) =20 @@ -93,14 +94,30 @@ store in '.el' files." (substitute-cmd)))) #t)) =20 -(define* (install #:key outputs #:allow-other-keys) +(define* (install #:key outputs + (include '("^[^/]*\\.el$" "^[^/]*\\.info$" "^doc/.*\\.in= fo$")) + (exclude '("^\\.dir-locals\\.el$" "-pkg\\.el$" "^[^/]*te= sts?\\.el$")) + #:allow-other-keys) "Install the package contents." + + (define src-dir (getcwd)) + + (define (install-file? file stat) + (let ((stripped-file (string-trim (substring file (string-length src-d= ir)) #\/))) + (and (any (cut string-match <> stripped-file) include) + (not (any (cut string-match <> stripped-file) exclude))))) + (let* ((out (assoc-ref outputs "out")) (elpa-name-ver (store-directory->elpa-name-version out)) - (src-dir (getcwd)) (tgt-dir (string-append out %install-suffix "/" elpa-name-ver))) - (copy-recursively src-dir tgt-dir) - #t)) + (for-each + (lambda (file) + (let* ((stripped-file (substring file (string-length src-dir))) + (tgt-file (string-append tgt-dir stripped-file))) + (format #t "`~a' -> `~a'~%" file tgt-file) + (install-file file (dirname tgt-file)))) + (find-files src-dir install-file?))) + #t) =20 (define* (move-doc #:key outputs #:allow-other-keys) "Move info files from the ELPA package directory to the info directory." --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 26 10:21:10 2017 Received: (at 26559) by debbugs.gnu.org; 26 Apr 2017 14:21:10 +0000 Received: from localhost ([127.0.0.1]:41788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3Noc-0005MQ-93 for submit@debbugs.gnu.org; Wed, 26 Apr 2017 10:21:10 -0400 Received: from o174.p8.mailjet.com ([87.253.233.174]:43919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3Nob-0005MI-9a for 26559@debbugs.gnu.org; Wed, 26 Apr 2017 10:21:09 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=Lu7jeq1rIfQt4SDKEokMy8eML3o=; b=Vu5gKqoUzTKuKOEcliHXRoSKhuStUEgu8e9s610VmKANb34LLMJhbZHyx PIudMsCjfu2dM8DxWiwfSq8RJi3PXFajwE6njuFQD+QljQIEd5lIyCjnc2Ji e857Bof5Gy1k4VkLv4oOuk4cWc3FZHFl6DIQhfjsPLuJLGbyYP0F8Q= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: 26559@debbugs.gnu.org Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Wed, 26 Apr 2017 19:50:56 +0530 In-reply-to: <87shl09pyg.fsf@gmail.com> References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@mailjet.com> <87shl09pyg.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEUAJc4AQSAAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKzU57-viRwkT-OBPHkyiqU54wAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) In the new patchset, I have cleaned up and removed some of the regexps, as you suggested. I have also rewritten the logic using `find-files' rather than with `ftw'. > Note, however, that 'move-doc' procedure should be adjusted to find > info in "doc" subdir (for "doc/*.info$" regex). I don't think the `move-doc' phase needs to be changed. It finds .info files with `find-files' which is recursive. > It doesn't look right that these regexps are duplicated in 2 places. > I'm not very familiar with build systems, but what if the > 'include'/'exclude' arguments of 'install' procedure would simply be > empty lists? I think it wouldn't do harm if you leave these regexps > only in 'emacs-build' procedure or would it? I am not too familiar with build systems, but I think the include/exclude arguments need to be duplicated in two places. For example, look at arguments #:strip-flags and #:strip-directories in the `strip' phase of the gnu-build-system. Even there, the default values of the arguments are repeated in two places. > I think it would be too much work. I quickly looked at the emacs > packages, and I believe that only slime, auctex and yasnippet need to be > adjusted to include non-standard files. Of course, there may be other > packages that I'm not aware of, but they can be fixed later. I've provided patches for emacs-slime and emacs-auctex packages as well. I believe I got all the required files, but please check. As it stands, emacs-yasnippet does not seem to need any changes. But, I think the package is already broken. It needs a snippets directory pulled from a git submodule. And, even the current package does not pull this submodule. So, I believe the yasnippet package is already broken. But, I don't use yasnippet, and I'm not too sure. = From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 06:10:11 2017 Received: (at 26559) by debbugs.gnu.org; 2 May 2017 10:10:11 +0000 Received: from localhost ([127.0.0.1]:50342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5Ul0-0002FO-LE for submit@debbugs.gnu.org; Tue, 02 May 2017 06:10:11 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34283) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5Uky-0002FB-Ja for 26559@debbugs.gnu.org; Tue, 02 May 2017 06:10:09 -0400 Received: by mail-wm0-f65.google.com with SMTP id z129so3041514wmb.1 for <26559@debbugs.gnu.org>; Tue, 02 May 2017 03:10:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=RiDtWII0gDZr5b+RVWbuc7lRjbtW+0ghh6fNSXpsnjI=; b=pHDNSR6TlumZgJ6kbD2Dv/fGL7cHJQNX1eba+TXUAGwZeWC0TzZ53N22MsaV07geHA wpULOHjvMnJG4I0rg3UrzejFHq7fU6S9zS+KhkK6bKSPx2AMeIC2qR2TONXORR0ASzCq 3pced+QT0d3lKL4pyqZ7kcMtYF2NetiVFnSq0N51ybt/jTmvIHPp8fYxvapRHMY8w4eL fnjdbtsLs6KTu5HXXdwch6pGkdB/ifusi3dhK5vpVxYR+59P9GBte99OUPr/cMIYqPEl u+SUdNPXv2AMYUi0kYLYb4X/28+GVg/KnQO9Bh+9YyAcLAHLHXQZeBCs2E+WRccd2PMH OTXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=RiDtWII0gDZr5b+RVWbuc7lRjbtW+0ghh6fNSXpsnjI=; b=rJiDW7oungyc8cHA7JSqF8D0H9KUCAX73Th14HUTT9gIphp8uwKvv0zK6xiAAT5NgX glYj0OL6Ybg1mhkOiE7qBpWUVV0KRHEGrdRZ3SJDu7kI8A3dKXV8V965qhLPbRQx/Icf UjOmrqbl+Ur5l3wRDdBcnH4FyuliXh+oyGhy8iqSZ3/zZGxGhsjMZxeLRYAY70EUbQkx V0myrcYtEhU8nV6KtOq89c8b3WPGWaMWIXiC0dUFdt/Tb2CRA4aNlTsOIY9nvktXzX7K AUatnmADPJgSVYGOZApD7SRK8+29MPhykUftyazjjMBKCqe/F7ViEB5VIQilFSlyBOCm ITJw== X-Gm-Message-State: AN3rC/51iDVHgMohfzulUQ7/i69HK7qaQvJ/CZ6128w3oCwCcS3xeVYn fFQIiwXt3Nk9OQ== X-Received: by 10.25.130.147 with SMTP id e141mr8601658lfd.96.1493719802726; Tue, 02 May 2017 03:10:02 -0700 (PDT) Received: from leviafan ([217.107.194.133]) by smtp.gmail.com with ESMTPSA id h192sm2768907lfe.68.2017.05.02.03.10.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2017 03:10:02 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> <628c0262.AEEAJtCcXW0AAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABY-K8Y@mailjet.com> <87shl09pyg.fsf@gmail.com> Date: Tue, 02 May 2017 13:10:03 +0300 In-Reply-To: (Arun Isaac's message of "Wed, 26 Apr 2017 19:50:56 +0530") Message-ID: <871ss736ys.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-04-26 19:50 +0530) wrote: > In the new patchset, I have cleaned up and removed some of the regexps, > as you suggested. I have also rewritten the logic using `find-files' > rather than with `ftw'. Great, thanks! >> Note, however, that 'move-doc' procedure should be adjusted to find >> info in "doc" subdir (for "doc/*.info$" regex). > > I don't think the `move-doc' phase needs to be changed. It finds .info > files with `find-files' which is recursive. Oh, right. >> It doesn't look right that these regexps are duplicated in 2 places. >> I'm not very familiar with build systems, but what if the >> 'include'/'exclude' arguments of 'install' procedure would simply be >> empty lists? I think it wouldn't do harm if you leave these regexps >> only in 'emacs-build' procedure or would it? > > I am not too familiar with build systems, but I think the > include/exclude arguments need to be duplicated in two places. For > example, look at arguments #:strip-flags and #:strip-directories in the > `strip' phase of the gnu-build-system. Even there, the default values of > the arguments are repeated in two places. Hm, ok, although I still think that these arguments are not needed to be duplicated in 'install' procedure, but I'm not the one to judge about it. >> I think it would be too much work. I quickly looked at the emacs >> packages, and I believe that only slime, auctex and yasnippet need to be >> adjusted to include non-standard files. Of course, there may be other >> packages that I'm not aware of, but they can be fixed later. > > I've provided patches for emacs-slime and emacs-auctex packages as > well. I believe I got all the required files, but please check. I personally don't use these packages, but I think they should be OK now, thank you! > As it stands, emacs-yasnippet does not seem to need any changes. But, I > think the package is already broken. It needs a snippets directory > pulled from a git submodule. Oh, right; last time I checked "yasnippet" (several years ago) this "snippets" directory was a part of the repo. > And, even the current package does not pull > this submodule. So, I believe the yasnippet package is already > broken. But, I don't use yasnippet, and I'm not too sure. Yeah, you are probably right, without snippets, yasnippet is=E2=80=A6 well, let's say limited. But let's leave this problem for those who use yasnippet :-) Thank you for this work! I hope someone else will look at this thread and will say "OK". As for me, I don't have any further comments and I think it is ready to be committed. In the worst case there would be a couple of broken emacs packages but they could be easily fixed. --=20 Alex From debbugs-submit-bounces@debbugs.gnu.org Tue May 02 06:10:26 2017 Received: (at 26559) by debbugs.gnu.org; 2 May 2017 10:10:26 +0000 Received: from localhost ([127.0.0.1]:50345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5UlF-0002Fq-Ro for submit@debbugs.gnu.org; Tue, 02 May 2017 06:10:26 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5UlE-0002Fe-Va for 26559@debbugs.gnu.org; Tue, 02 May 2017 06:10:25 -0400 Received: by mail-wm0-f67.google.com with SMTP id u65so3029701wmu.3 for <26559@debbugs.gnu.org>; Tue, 02 May 2017 03:10:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=zA3ynwFAZKzyG+w8KllNkS4tWFXbUHqErqzSjOmHAp8=; b=IrFzo2YmHDXbATvJym8Yv8aoWJ3tYnVRS0D5OpOG+ZErZi5DuI8WEjEJg7zGM4t7Nv 5MLN970J1imT9TLsn9ixOqzZijhGBL3HwTD9bqI5HQduFi6ymHXcbLb4ArvFNXw4pft6 ejg6HMrHqulIVEGv9lwVBC4yEXp3zr/bB1BU3VdvWhkFJevpVitvSsfs2Nv86U+7WFFI AHLUDLRnCx8vf8iI7HkqxvnevDnUB9WA7SNPbGBvr7+cVnFS/IzVOeBTBnUxpHB6FdyQ +uU1c4f0oj+iz+72lqC4o7xN9lNWi8BUgreGu7O8bOuW9mMMWfbZDQgyeF8sX2GmoAZw IMaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=zA3ynwFAZKzyG+w8KllNkS4tWFXbUHqErqzSjOmHAp8=; b=dl7EOAncSHUgchsb8ObIlAB1uA7XalKH4D0ODpHOH3+zw9RCjgfUFu6i/ShamWTQbz lhbn41Zn74bGVHjx3eM22wnK/jwVWiO1yP5RWvBPeh9u4mTJD/HFHFiidLCCnX3DSbSf Gn9KtTiFcobOgIkJSs3glpRFt2OzAyhIyA1/l0ts7eMSV7lZ3G4cSOoY8PoT+ap+twrA afa0VGv3by3NoMaaYKZMJ+0As0mk+NbLSX2BuohZmnXpjxc9xIfGvF++J4V3YQTUgNSA xGNQw3FoxXPfFx3dsjbx/3p5vlcnKYtsSUd4Dw0cUhW/jlQNNydC7DufQRISmL+o4II8 VuXA== X-Gm-Message-State: AN3rC/7uVztdFYmOz+H4VsNPPZOVGnZqAAD2rx64db5fm3yd+MoXw/fF Fm54JHiuxn6YPg== X-Received: by 10.25.80.10 with SMTP id e10mr763696lfb.131.1493719819448; Tue, 02 May 2017 03:10:19 -0700 (PDT) Received: from leviafan ([217.107.194.133]) by smtp.gmail.com with ESMTPSA id h191sm3201894lfh.62.2017.05.02.03.10.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 May 2017 03:10:18 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26559: [PATCH 2/3] gnu: emacs-slime: Add arguments to work with new `install' phase. References: <20170426140929.27133-1-arunisaac@systemreboot.net> <05f43388.ADsAAHWtufMAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKqN@mailjet.com> Date: Tue, 02 May 2017 13:10:22 +0300 In-Reply-To: <05f43388.ADsAAHWtufMAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKqN@mailjet.com> (Arun Isaac's message of "Wed, 26 Apr 2017 19:39:28 +0530") Message-ID: <87ziev1sdt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-04-26 19:39 +0530) wrote: > * gnu/packages/emacs.scm (emacs-slime)[arguments]: Add #:include and #:exclude > arguments. > --- > gnu/packages/emacs.scm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm > index 14d851184..9c919c49d 100644 > --- a/gnu/packages/emacs.scm > +++ b/gnu/packages/emacs.scm > @@ -2333,7 +2333,10 @@ in @code{html-mode}.") > (native-inputs > `(("texinfo" ,texinfo))) > (arguments > - `(#:phases > + `(#:include '("\\.el$" "\\.lisp$" "\\.asd$" "\\.goo$" > + "\\.ss$" "\\.k$" "\\.scm$" "\\.rb$" "\\.sml$") All these additional files are placed in "contrib" directory, so what about the following list: #:include '("\\.el$" "\\.lisp$" "\\.asd$" "^contrib/") > + #:exclude '("^contrib/test/") and excluding Makefile from there: #:exclude '("^contrib/test/" "^contrib/Makefile") > + #:phases > (modify-phases %standard-phases > (add-before 'install 'configure > (lambda* _ -- Alex From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 02:05:02 2017 Received: (at 26559) by debbugs.gnu.org; 4 May 2017 06:05:02 +0000 Received: from localhost ([127.0.0.1]:53469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d69ss-0002bR-8V for submit@debbugs.gnu.org; Thu, 04 May 2017 02:05:02 -0400 Received: from o131.p9.mailjet.com ([87.253.234.131]:52676) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <9f1f4e0e.AEEAKP-1KagAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZCsSK@bnc3.mailjet.com>) id 1d69sp-0002bA-Kh for 26559@debbugs.gnu.org; Thu, 04 May 2017 02:05:00 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=dcXA7KHmzUMtwhGcE2bi/edL0Cw=; b=Hm/JaSmoB7BmdV18pMfRpnVMeV5FdJEUR1MnvlL+f6wzRRHf+aPAsAcGb sjG9HohkfJPYK/8+uKmW6/FE6uNqBCZeXmmN3uHOM1LMuJ6vgUhZfwbMY17/ J4AKJ9CTty9QFkBbBhopU5+oABIaFlom2k7EGOizWPXwOMbSS6wAqc= Message-Id: <9f1f4e0e.AEEAKP-1KagAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZCsSK@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26559@debbugs.gnu.org Subject: Re: bug#26559: [PATCH 2/3] gnu: emacs-slime: Add arguments to work with new `install' phase. Date: Thu, 04 May 2017 11:34:21 +0530 In-reply-to: <87ziev1sdt.fsf@gmail.com> References: <20170426140929.27133-1-arunisaac@systemreboot.net> <05f43388.ADsAAHWtufMAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZAKqN@mailjet.com> <87ziev1sdt.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAKP-1KagAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZCsSK_vcPpYZrRXSjB-jSRtQUbwAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) >> (arguments >> - `(#:phases >> + `(#:include '("\\.el$" "\\.lisp$" "\\.asd$" "\\.goo$" >> + "\\.ss$" "\\.k$" "\\.scm$" "\\.rb$" "\\.sml$") > > All these additional files are placed in "contrib" directory, so what > about the following list: > > #:include '("\\.el$" "\\.lisp$" "\\.asd$" "^contrib/") > >> + #:exclude '("^contrib/test/") > > and excluding Makefile from there: > > #:exclude '("^contrib/test/" "^contrib/Makefile") Yes, this is a good idea. I'll send a new patchset as soon as possible. = From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 14:36:56 2017 Received: (at 26559) by debbugs.gnu.org; 4 May 2017 18:36:56 +0000 Received: from localhost ([127.0.0.1]:54814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6LcV-0001r5-UV for submit@debbugs.gnu.org; Thu, 04 May 2017 14:36:56 -0400 Received: from o149.p8.mailjet.com ([87.253.233.149]:53800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <69fb1b9c.AEQAKESq4HQAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3TE@bnc3.mailjet.com>) id 1d6LcU-0001qw-2c for 26559@debbugs.gnu.org; Thu, 04 May 2017 14:36:54 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=Ls3kRQUbr9KpB94EgBM3PbjoHEY=; b=MZs+xPE53fMXbM43iumeyOUhytEU4cMQlaNNVFKx3vdDDuxemQTgDVJ44 4U3fVTckH3WFS/h/gJ8f2I5s1Mm/9HCmGLbxWj9AJa017w616/Q/a2qRtq9f cf2tVYr1y+vO5e+PypS3l0p5c8y3n2rC2RWR0zatfJO3VH5r4uK60Q= Message-Id: <69fb1b9c.AEQAKESq4HQAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3TE@mailjet.com> From: Arun Isaac To: 26559@debbugs.gnu.org Subject: [PATCH 2/3] gnu: emacs-slime: Add arguments to work with new `install' phase. Date: Fri, 5 May 2017 00:05:57 +0530 In-Reply-To: <20170504183558.4444-1-arunisaac@systemreboot.net> References: <20170504183558.4444-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAKESq4HQAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3TEePAiDF2QTByB9KUe4fQmsAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26559 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) * gnu/packages/emacs.scm (emacs-slime)[arguments]: Add #:include and #:excl= ude arguments. --- gnu/packages/emacs.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 74f0ff8b5..8c27407a7 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -2333,7 +2333,9 @@ in @code{html-mode}.") (native-inputs `(("texinfo" ,texinfo))) (arguments - `(#:phases + `(#:include '("\\.el$" "\\.lisp$" "\\.asd$" "contrib") + #:exclude '("^contrib/test/" "^contrib/Makefile$" "^contrib/README.= md$") + #:phases (modify-phases %standard-phases (add-before 'install 'configure (lambda* _ --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 14:37:13 2017 Received: (at 26559) by debbugs.gnu.org; 4 May 2017 18:37:13 +0000 Received: from localhost ([127.0.0.1]:54818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Lcn-0001rx-4r for submit@debbugs.gnu.org; Thu, 04 May 2017 14:37:13 -0400 Received: from o168.p9.mailjet.com ([87.253.234.168]:33873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <54844865.AEEAKSDn3pcAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3TW@bnc3.mailjet.com>) id 1d6Lcl-0001ro-Ns for 26559@debbugs.gnu.org; Thu, 04 May 2017 14:37:12 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:in-reply-to:references: x-csa-complaints:x-mj-mid:mime-version:content-transfer-encoding; bh=IHODlM3Oh3+IP0Q6wvdwaPH9YWk=; b=qWPiogJappbWqCrbF5IhcZxRLeiO0Vtqz88P3PvzAPc1Lp4kSgyHS8IK2 YlDbHXRKSQXZrZz+lYaZRahIIyLjEkAIN8Hh9xML0QG5jJB4KXXDUFE7pllS BigZ/Lp2j02j++ji+N/hkYEOJdi3BSEJJJ7rYEw4jHnV54t7DSvobM= Message-Id: <54844865.AEEAKSDn3pcAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3TW@mailjet.com> From: Arun Isaac To: 26559@debbugs.gnu.org Subject: [PATCH 3/3] gnu: emacs-auctex: Add arguments to work with new `install' phase. Date: Fri, 5 May 2017 00:05:58 +0530 In-Reply-To: <20170504183558.4444-1-arunisaac@systemreboot.net> References: <20170504183558.4444-1-arunisaac@systemreboot.net> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAKSDn3pcAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3TW7NcwEsjQQdm7At6M4XNftAAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) * gnu/packages/emacs.scm (emacs-auctex)[arguments]: Add #:include and #:exclude arguments. --- gnu/packages/emacs.scm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index 8c27407a7..b15767606 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -1197,7 +1197,10 @@ as a library for other Emacs packages.") (build-system emacs-build-system) ;; We use 'emacs' because AUCTeX requires dbus at compile time ;; ('emacs-minimal' does not provide dbus). - (arguments `(#:emacs ,emacs)) + (arguments + `(#:emacs ,emacs + #:include '("\\.el$" "^images/" "^latex/" "\\.info$") + #:exclude '("^tests/" "^latex/README"))) (native-inputs `(("perl" ,perl))) (home-page "https://www.gnu.org/software/auctex/") --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 14:37:34 2017 Received: (at 26559) by debbugs.gnu.org; 4 May 2017 18:37:34 +0000 Received: from localhost ([127.0.0.1]:54821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6Ld8-0001sa-F5 for submit@debbugs.gnu.org; Thu, 04 May 2017 14:37:34 -0400 Received: from o109.p9.mailjet.com ([87.253.234.109]:43134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <8e661119.AEEAKSDn4NYAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3To@bnc3.mailjet.com>) id 1d6Ld5-0001sP-Vj for 26559@debbugs.gnu.org; Thu, 04 May 2017 14:37:32 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:from:to:subject:date:list-unsubscribe:cc:x-csa-complaints: x-mj-mid:mime-version:content-transfer-encoding; bh=m2fi9hSLN/i0JyM0jGPmiCxwywk=; b=YPUViQcP/BaVQ++yMyonna2Vub+8k9glcIQAI6k+2D2wSbkX/FDxlixf/ OfeASztm6a9NK0KCTP+JkVnAINDO+88D1jTfmtcOM2gcuF+Co+fC/9ofpyeR 6unWrSWFy3UpuElFIvRVq9llTbXsywX21Meb06ZPD7MXZcrAOdeQVc= Message-Id: <8e661119.AEEAKSDn4NYAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3To@mailjet.com> From: Arun Isaac To: 26559@debbugs.gnu.org Subject: [PATCH 1/3] build: emacs: Install only a subset of files. Date: Fri, 5 May 2017 00:05:56 +0530 X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAKSDn4NYAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3ToVE-Lw4ylR1CrmMxpz2o3wwAFgUc MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) * guix/build/emacs-build-system.scm (install): Install files matching #:include while excluding files matching #:exclude. * guix/build-system/emacs.scm (emacs-build): Add keyword arguments #:includ= e and #:exclude. --- guix/build-system/emacs.scm | 4 ++++ guix/build/emacs-build-system.scm | 25 +++++++++++++++++++++---- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/guix/build-system/emacs.scm b/guix/build-system/emacs.scm index a7982002b..9a46ecfd2 100644 --- a/guix/build-system/emacs.scm +++ b/guix/build-system/emacs.scm @@ -83,6 +83,8 @@ (phases '(@ (guix build emacs-build-system) %standard-phases)) (outputs '("out")) + (include ''("^[^/]*\\.el$" "^[^/]*\\.info$" "^doc/.*= \\.info$")) + (exclude ''("^\\.dir-locals\\.el$" "-pkg\\.el$" "^[^= /]*tests?\\.el$")) (search-paths '()) (system (%current-system)) (guile #f) @@ -108,6 +110,8 @@ #:tests? ,tests? #:phases ,phases #:outputs %outputs + #:include ,include + #:exclude ,exclude #:search-paths ',(map search-path-specification->sexp search-paths) #:inputs %build-inputs))) diff --git a/guix/build/emacs-build-system.scm b/guix/build/emacs-build-sys= tem.scm index 44e8b0d31..fefdbb96e 100644 --- a/guix/build/emacs-build-system.scm +++ b/guix/build/emacs-build-system.scm @@ -28,6 +28,7 @@ #:use-module (ice-9 rdelim) #:use-module (ice-9 regex) #:use-module (ice-9 match) + #:use-module (ice-9 ftw) #:export (%standard-phases emacs-build)) =20 @@ -93,14 +94,30 @@ store in '.el' files." (substitute-cmd)))) #t)) =20 -(define* (install #:key outputs #:allow-other-keys) +(define* (install #:key outputs + (include '("^[^/]*\\.el$" "^[^/]*\\.info$" "^doc/.*\\.in= fo$")) + (exclude '("^\\.dir-locals\\.el$" "-pkg\\.el$" "^[^/]*te= sts?\\.el$")) + #:allow-other-keys) "Install the package contents." + + (define src-dir (getcwd)) + + (define (install-file? file stat) + (let ((stripped-file (string-trim (substring file (string-length src-d= ir)) #\/))) + (and (any (cut string-match <> stripped-file) include) + (not (any (cut string-match <> stripped-file) exclude))))) + (let* ((out (assoc-ref outputs "out")) (elpa-name-ver (store-directory->elpa-name-version out)) - (src-dir (getcwd)) (tgt-dir (string-append out %install-suffix "/" elpa-name-ver))) - (copy-recursively src-dir tgt-dir) - #t)) + (for-each + (lambda (file) + (let* ((stripped-file (substring file (string-length src-dir))) + (tgt-file (string-append tgt-dir stripped-file))) + (format #t "`~a' -> `~a'~%" file tgt-file) + (install-file file (dirname tgt-file)))) + (find-files src-dir install-file?))) + #t) =20 (define* (move-doc #:key outputs #:allow-other-keys) "Move info files from the ELPA package directory to the info directory." --=20 2.12.2 = From debbugs-submit-bounces@debbugs.gnu.org Thu May 04 14:39:52 2017 Received: (at 26559) by debbugs.gnu.org; 4 May 2017 18:39:52 +0000 Received: from localhost ([127.0.0.1]:54828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6LfL-0001w1-Sa for submit@debbugs.gnu.org; Thu, 04 May 2017 14:39:51 -0400 Received: from o112.p8.mailjet.com ([87.253.233.112]:41701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d6LfK-0001vs-Ih for 26559@debbugs.gnu.org; Thu, 04 May 2017 14:39:50 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=jizMoXP42M2CPoca0F5pDmcIYsc=; b=GEo1z2Yeaqh/aEAIODg269juoX6e84pU9wrbShdeCSqus69nq0OWh29cO bAtzZGW7Rjs9SgpypGdZefRMGwI97FIU+2qRvY4jkNwBA4IN+okBHxED7rJh eGdzsB2LNTXLCv7Hn+q/MNzteWaJmuNtsX1MEZnjwJLNbe0pcKUBlc= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: 26559@debbugs.gnu.org Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Fri, 05 May 2017 00:09:03 +0530 In-reply-to: <877f2fqpeb.fsf@gmail.com> References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAKSDtWVwAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZC3V14ZuN1296Qk28P6Y--hL0RwAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26559 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) I've sent a new patchset. Now, we just have to wait for someone else to look at this thread... = From debbugs-submit-bounces@debbugs.gnu.org Sun May 14 09:43:14 2017 Received: (at 26559) by debbugs.gnu.org; 14 May 2017 13:43:14 +0000 Received: from localhost ([127.0.0.1]:43730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9tnl-0007PF-Vb for submit@debbugs.gnu.org; Sun, 14 May 2017 09:43:14 -0400 Received: from o177.p9.mailjet.com ([87.253.234.177]:60057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <5a0587f7.AEQAKXg1cDoAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZGF7v@bnc3.mailjet.com>) id 1d9tnk-0007P6-E7 for 26559@debbugs.gnu.org; Sun, 14 May 2017 09:43:12 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=/xhNI7hpMbvZGU83x6ElPj7feSE=; b=BC41JdJGAp4/JDgytyz5cGoPCKmBfVBK8TanJ/RwwX7rAhnxZQQ6vSBSf TWj0X+z3vC+c7szh8hmpFuEyfAbyBX4sJQkkBa3zRpED7g0Piaffdgh7LTHT vH+iRYko/FrxZhhH1uI7I6lMQJSGY7TC0EDjNCRQo9KPrq9wdAk8K8= Message-Id: <5a0587f7.AEQAKXg1cDoAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZGF7v@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: Alex Kost Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Sun, 14 May 2017 19:12:27 +0530 In-reply-to: <87r30k9pwu.fsf@gmail.com> References: <87r30k9pwu.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAKXg1cDoAAAAAAAAAAAO2CuIAAAACwQwAAAAAAAW9WABZGF7vRVJ3swfqR3--XIIK0DtqdwAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Ludo said (in another thread) that we should prefer `string-drop' to `substring'. I'll make that change along with any others suggested by others who review this patch. = From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 05:14:27 2017 Received: (at 26559) by debbugs.gnu.org; 21 May 2017 09:14:28 +0000 Received: from localhost ([127.0.0.1]:57716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMwV-00005V-Od for submit@debbugs.gnu.org; Sun, 21 May 2017 05:14:27 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:35469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCMwT-00005E-H6 for 26559@debbugs.gnu.org; Sun, 21 May 2017 05:14:26 -0400 Received: by mail-lf0-f51.google.com with SMTP id a5so4224313lfh.2 for <26559@debbugs.gnu.org>; Sun, 21 May 2017 02:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9GQ7t6IZBgFyx9PHDXfM+/s3STQ0nTU7bMw7Eg0iBPU=; b=AXeprMIN/EnVQW9bMLbqhpwc+HmKA8+G0+mPHgwXWB55Ewe9SEcfu9ABi8qXDOJmy7 POWff8z97xfVdOp5bDVOZ8BC1HR0bTgagUzb+zqz+fC3cayahMa5EOA5UBMhqHVBk/kl rgNMGD3RVn0MkAuQo1/nJIctiDvJ9moQn55jn5SyExAObVjUE4MMqe2l/f1xmvK8k+V9 ZKl9jjB1HaEPjd6EuxVCCol7K8Bk7YdmGqWvncVtksOrKpm0XB7QwYgbxX/gUzQEmzjT WLP2C4tDez+BaV01bMV/Z7eEQKZPV7uF9CLDVwPdQz3mz9wRGK07K/+r40eBzMSyVffS PaxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9GQ7t6IZBgFyx9PHDXfM+/s3STQ0nTU7bMw7Eg0iBPU=; b=Rd1nK1cLKU7mKQnCIa3pH+Pv653FBAFkk53CrjXkfa/4LqdURMarWegd7JMQxiNfqv 5WWbHNSW/he63XPa1GNpNwryUIXN63VK13hQPKjuJEXY/tEeGnYjUWZovdOL4g9NdVCX gXJD5miJrJjmc3LLhMJZuxszSbQxEy8L2vhzSKkJIJKTRN1qG0alwebMNOS6nse6HAOA 0mX4RN8D4v6JR80zG5X/rcUdBtxO29lFOLIq4gOLsEyEKwimX/svqhfvisG+RFwkCvo/ bvMOhlIqvUTbPy+ocWu17Qh//Fw74el/mY/ziF4xWEx9RYWMvYRDeCszkWLKFZW/LVi2 ShLw== X-Gm-Message-State: AODbwcBNwOJl3MxeV+oVVLyKfMTYrAreyBFgUaKLNfQiKu/Mhdq5JV7m CIHetuA3hj5Kpg== X-Received: by 10.25.16.219 with SMTP id 88mr4676402lfq.134.1495358059844; Sun, 21 May 2017 02:14:19 -0700 (PDT) Received: from leviafan ([217.107.194.130]) by smtp.gmail.com with ESMTPSA id a79sm2429247ljb.54.2017.05.21.02.14.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 21 May 2017 02:14:19 -0700 (PDT) From: Alex Kost To: Arun Isaac Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> Date: Sun, 21 May 2017 12:14:20 +0300 In-Reply-To: (Arun Isaac's message of "Fri, 05 May 2017 00:09:03 +0530") Message-ID: <87o9umh8r7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Arun Isaac (2017-05-05 00:09 +0530) wrote: > I've sent a new patchset. Now, we just have to wait for someone else to > look at this thread... This thread is already 1 month old, IMO it's not necessary to wait any longer. I think you can just commit these patches. If there will be some breakage caused by this change, we will fix it. -- Alex From debbugs-submit-bounces@debbugs.gnu.org Sun May 21 18:25:39 2017 Received: (at 26559) by debbugs.gnu.org; 21 May 2017 22:25:40 +0000 Received: from localhost ([127.0.0.1]:59703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCZIB-0005pu-Ko for submit@debbugs.gnu.org; Sun, 21 May 2017 18:25:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59199) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCZI9-0005pi-Ii for 26559@debbugs.gnu.org; Sun, 21 May 2017 18:25:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCZI1-00021D-EI for 26559@debbugs.gnu.org; Sun, 21 May 2017 18:25:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCZI1-000213-Ae; Sun, 21 May 2017 18:25:29 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:36254 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dCZI0-0003um-Hh; Sun, 21 May 2017 18:25:28 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Alex Kost Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> <87o9umh8r7.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 3 Prairial an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Mon, 22 May 2017 00:25:26 +0200 In-Reply-To: <87o9umh8r7.fsf@gmail.com> (Alex Kost's message of "Sun, 21 May 2017 12:14:20 +0300") Message-ID: <87mva5g84p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26559 Cc: 26559@debbugs.gnu.org, Arun Isaac X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Alex Kost skribis: > Arun Isaac (2017-05-05 00:09 +0530) wrote: > >> I've sent a new patchset. Now, we just have to wait for someone else to >> look at this thread... > > This thread is already 1 month old, IMO it's not necessary to wait any > longer. I think you can just commit these patches. If there will be > some breakage caused by this change, we will fix it. I agree with this strategy! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon May 22 20:48:28 2017 Received: (at 26559-done) by debbugs.gnu.org; 23 May 2017 00:48:28 +0000 Received: from localhost ([127.0.0.1]:33512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCxzw-00076w-8J for submit@debbugs.gnu.org; Mon, 22 May 2017 20:48:28 -0400 Received: from o112.p9.mailjet.com ([87.253.234.112]:55008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCxzt-00076n-RI for 26559-done@debbugs.gnu.org; Mon, 22 May 2017 20:48:26 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=469psx87fxLrbUpFjOH+dbRXbXI=; b=Mk7tTblpW9qMqBeVGdR/78Xx7N38hKTcgpQl3/3KQHbGkmL7yerkY9yDC P/5C79vrUvjGPpkGwY3YAyzYCCrdx332WIP+wiWCmyPPbGqDi3vi/jhka5Nm k2qafL5MF2dIv3PcsxgfLTbf21791jG1l14tg5hwk1//v8VWs4bDs4= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: Alex Kost Subject: Re: bug#26559: [PATCH] build: emacs: Install only a subset of files. Date: Tue, 23 May 2017 06:18:00 +0530 In-reply-to: <87o9umh8r7.fsf@gmail.com> References: <20170419073525.2357-1-arunisaac@systemreboot.net> <877f2fqpeb.fsf@gmail.com> <87o9umh8r7.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAK4YvdBMAAAAAAAAAAAPCi7MAAAACwQwAAAAAAAW9WABZI4bYHEMSDQgoQpa5W4bOzpsxdQAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26559-done Cc: 26559-done@debbugs.gnu.org, Ludovic =?iso-8859-1?q?Court=E8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Pushed with a few minor changes! = From unknown Fri Aug 15 14:45:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator