GNU bug report logs - #26557
[PATCH] gnu: let exwm command work with arguments

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26557 in the body.
You can then email your comments to 26557 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Feng Shu <tumashu <at> 163.com>
To: guix-patches <at> gnu.org
Cc: Feng Shu <tumashu <at> 163.com>
Subject: [PATCH] gnu: let exwm command work with arguments
Date: Wed, 19 Apr 2017 06:33:48 +0800

* gnu/packages/emacs.scm (emacs-exwm): Add $* to exwm shell-wrap
---
 gnu/packages/emacs.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 6eb8751ad..27f9e2f63 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4475,7 +4475,7 @@ It should enable you to implement low-level X11 applications.")
                    (format #t "#!~a ~@
                      export DISPLAY=:0 ~@
                      ~a +SI:localuser:$USER ~@
-                     exec ~a --exit-with-session ~a --eval '~s' ~%"
+                     exec ~a --exit-with-session ~a $* --eval '~s' ~%"
                            (string-append (assoc-ref inputs "bash") "/bin/sh")
                            (string-append (assoc-ref inputs "xhost") "/bin/xhost")
                            (string-append (assoc-ref inputs "dbus") "/bin/dbus-launch")
-- 
2.12.2

Message #8 received at 26557 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26557 <at> debbugs.gnu.org
Subject: Re: bug#26557: [PATCH] gnu: let exwm command work with arguments
Date: Wed, 19 Apr 2017 11:31:41 +0530

What use case does this address?

Message #11 received at 26557 <at> debbugs.gnu.org (full text, mbox):

From: tumashu  <tumashu <at> 163.com>
To: "Arun Isaac" <arunisaac <at> systemreboot.net>
Cc: 26557 <at> debbugs.gnu.org
Subject: Re:bug#26557: [PATCH] gnu: let exwm command work with arguments
Date: Wed, 19 Apr 2017 15:40:48 +0800 (CST)

[Message part 1 (text/plain, inline)]

The most useful case is  adding "--debug-init" to debug the emacs problem,  "-q" may useful too.




At 2017-04-19 14:01:41, "Arun Isaac" <arunisaac <at> systemreboot.net> wrote:>
>What use case does this address?

> > >

[Message part 2 (text/html, inline)]

Message #14 received at 26557 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26557 <at> debbugs.gnu.org
Subject: Re: bug#26557: [PATCH] gnu: let exwm command work with arguments
Date: Wed, 19 Apr 2017 13:45:05 +0530

> The most useful case is adding "--debug-init" to debug the emacs
> problem, "-q" may useful too.

Ok.

> -                     exec ~a --exit-with-session ~a --eval '~s' ~%"
> +                     exec ~a --exit-with-session ~a $* --eval '~s' ~%"

To account for arguments with spaces in them, could you make this "$@"
instead of $* ?

https://stackoverflow.com/questions/12314451/accessing-bash-command-line-args-vs

Also, the first line of the commit message should be

gnu: emacs-exwm: Let exwm ...

Note the addition of "emacs-exwm" and title case of "Let".

Thanks!

Message #17 received at 26557 <at> debbugs.gnu.org (full text, mbox):

From: tumashu  <tumashu <at> 163.com>
To: "Arun Isaac" <arunisaac <at> systemreboot.net>
Cc: "26557 <at> debbugs.gnu.org" <26557 <at> debbugs.gnu.org>
Subject: Re:bug#26557: [PATCH] gnu: let exwm command work with arguments
Date: Wed, 19 Apr 2017 18:03:28 +0800 (CST)

[Message part 1 (text/plain, inline)]

updated patch:










At 2017-04-19 16:15:05, "Arun Isaac" <arunisaac <at> systemreboot.net> wrote:
>
>> The most useful case is adding "--debug-init" to debug the emacs
>> problem, "-q" may useful too.
>
>Ok.
>
>> -                     exec ~a --exit-with-session ~a --eval '~s' ~%"
>> +                     exec ~a --exit-with-session ~a $* --eval '~s' ~%"
>
>To account for arguments with spaces in them, could you make this "$@"
>instead of $* ?
>
>https://stackoverflow.com/questions/12314451/accessing-bash-command-line-args-vs
>
>Also, the first line of the commit message should be
>
>gnu: emacs-exwm: Let exwm ...
>
>Note the addition of "emacs-exwm" and title case of "Let".
>
>Thanks!
>
>
>

[Message part 2 (text/html, inline)]

[0001-gnu-emacs-exwm-Let-exwm-shell-wrap-work-with-argumen.patch (application/octet-stream, attachment)]

Message #22 received at 26557-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26557-done <at> debbugs.gnu.org
Subject: Re: bug#26557: [PATCH] gnu: let exwm command work with arguments
Date: Wed, 19 Apr 2017 22:22:45 +0530

Pushed!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.