Subject: Re: bug#26544: [PATCH v2 0/8] system: Move "--load" and other guix-specific parameters from the grub module to the generic system module.

From: Mathieu Othacehe <[email-masked]>
Date: Fri, 21 Apr 2017 10:22:49 +0200

Hi Danny,

Most of the serie LGTM.

However, I noticed that the grub menuentries in /boot/grub/grub.cfg
produced during a reconfigure are loosing their labels (#1, ...).

Thanks,

Mathieu

Danny Milosavljevic writes:

> Danny Milosavljevic (8):
>   system: Rename operating-system-kernel-arguments to
>     operating-system-user-kernel-arguments.
>   system: Rename operating-system-parameters-file to
>     operating-system-boot-parameters-file.
>   system: Factorize operating-system-boot-parameters-file.
>   system: Introduce operating-system-kernel-arguments and use it.
>   system: Introduce read-boot-parameters-file.
>   system: vm: Use operating-system-kernel-arguments.
>   system: Use operating-system-boot-parameters directly.
>   system: grub: Use boot-parameters instead of menu-entry where
>     possible.
>
>  gnu/system.scm          | 133 +++++++++++++++++++++++++++++++-----------------
>  gnu/system/grub.scm     |  14 ++++-
>  gnu/system/vm.scm       |   7 +--
>  guix/scripts/system.scm |  24 ++++-----
>  4 files changed, 110 insertions(+), 68 deletions(-)