Subject: Re: [PATCH v4 03/10] system: Factorize operating-system-boot-parameters-file.

From: Danny Milosavljevic <[email-masked]>
Date: Sat, 22 Apr 2017 22:08:11 +0200

On Fri, 21 Apr 2017 14:37:07 +0200
Danny Milosavljevic <[email-masked]> wrote:

> +(define (operating-system-boot-parameters os system root-device)

Might make sense to call SYSTEM "SYSTEM.DRV" instead - since it's either a derivation or #f.

> +  "Return a monadic <boot-parameters> record that describes the boot parameters of OS.
> +SYSTEM is optional.  If given, adds kernel arguments for that system to <boot-parameters>."

Might want to elaborate on how SYSTEM is optional (#f stands for "not given").

SYSTEM is not used anywhere in the procedure.  The next patch rectifies that - but I didn't feel like messing up the function signature just to fix it up one patch later.  But even after only patch 03/10 you can give SYSTEM (and patch 03/10 operating-system-boot-parameters-file does that already) - it will just be ignored.