Subject: Re: bug#26544: [PATCH v4 10/10] scripts: Remove profile-grub-entries.

From: Mathieu Othacehe <[email-masked]>
Date: Fri, 21 Apr 2017 15:04:48 +0200

Thanks for v3 and v4 !

It seems to me that my remarks have been addressed, except for the
old-entries label ? I can't found a patch fixing this issue.

I know that it is not common on this list, but a brief changelog for
each serie would be nice :)

Thanks,

Mathieu

Danny Milosavljevic writes:

> * guix/scripts/system.scm (profile-grub-entries): Delete variable.
> ---
>  guix/scripts/system.scm | 37 -------------------------------------
>  1 file changed, 37 deletions(-)
>
> diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
> index 242bd8074..3feccb2ab 100644
> --- a/guix/scripts/system.scm
> +++ b/guix/scripts/system.scm
> @@ -384,43 +384,6 @@ NUMBERS, which is a list of generation numbers."
>                         systems)))
>      (filter-map system->boot-parameters systems numbers times)))
>  
> -(define* (profile-grub-entries #:optional (profile %system-profile)
> -                                  (numbers (generation-numbers profile)))
> -  "Return a list of 'menu-entry' for the generations of PROFILE specified by
> -NUMBERS, which is a list of generation numbers."
> -  (define (system->grub-entry system number time)
> -    (unless-file-not-found
> -     (let* ((params           (read-boot-parameters-file system))
> -            (label            (boot-parameters-label params))
> -            (root             (boot-parameters-root-device params))
> -            (root-device      (if (bytevector? root)
> -                                  (uuid->string root)
> -                                  root))
> -            (kernel           (boot-parameters-kernel params))
> -            (kernel-arguments (boot-parameters-kernel-arguments params))
> -            (initrd           (boot-parameters-initrd params)))
> -       (menu-entry
> -        (label (string-append label " (#"
> -                              (number->string number) ", "
> -                              (seconds->string time) ")"))
> -        (device (boot-parameters-store-device params))
> -        (device-mount-point (boot-parameters-store-mount-point params))
> -        (linux kernel)
> -        (linux-arguments
> -         (cons* (string-append "--root=" root-device)
> -                (string-append "--system=" system)
> -                (string-append "--load=" system "/boot")
> -                kernel-arguments))
> -        (initrd initrd)))))
> -
> -  (let* ((systems (map (cut generation-file-name profile <>)
> -                       numbers))
> -         (times   (map (lambda (system)
> -                         (unless-file-not-found
> -                          (stat:mtime (lstat system))))
> -                       systems)))
> -    (filter-map system->grub-entry systems numbers times)))
> -
>  
>  ;;;
>  ;;; Roll-back.