GNU bug report logs - #26532
[PATCH] gnu: update you-get version

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26532 in the body.
You can then email your comments to 26532 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Feng Shu" <tumashu <at> 163.com>
To: guix-patches <guix-patches <at> gnu.org>
Cc: Feng Shu <tumashu <at> 163.com>
Subject: [PATCH] gnu: update you-get version
Date: Sun, 16 Apr 2017 18:33:30 +0800

[Message part 1 (text/plain, inline)]

you-get stable version is outdate, it can not work with many websites
so I update you-get to git snapshot version

[0001-gnu-update-you-get-version.patch (text/x-patch, inline)]

From a25b84494a75c746e0e2e23b4aa00d474898beaa Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu <at> 163.com>
Date: Sun, 16 Apr 2017 18:27:18 +0800
Subject: [PATCH] gnu: update you-get version

* gnu/packages/video.scm (you-get): Update to git snapshot
---
 gnu/packages/video.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index b64664176..2db7f9a79 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1027,15 +1027,16 @@ YouTube.com and a few more sites.")
 (define-public you-get
   (package
     (name "you-get")
-    (version "0.4.652")
+    (version "0.4-7.15a1a20")
     (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/soimort/you-get.git")
+                    (commit "15a1a20fb9e4a92f10dcbf8494ad3555ac4d4e61")))
+              (file-name (string-append name "-" version "-checkout"))
               (sha256
                (base32
-                "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))))
+                "1ycq0nafpcw1jawdi994fzq708swrarmhrvn53mbf244k0y0dvnf"))))
     (build-system python-build-system)
     (arguments
      ;; no tests
-- 
2.12.2

[Message part 3 (text/plain, inline)]

-- 

Message #8 received at 26532 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Feng Shu <tumashu <at> 163.com>, 26532 <at> debbugs.gnu.org
Subject: Re: bug#26532: [PATCH] gnu: update you-get version
Date: Sun, 16 Apr 2017 21:12:39 +0200

[Message part 1 (text/plain, inline)]

Feng Shu <tumashu <at> 163.com> writes:

> you-get stable version is outdate, it can not work with many websites
> so I update you-get to git snapshot version

Version 0.4.715 was released just some hours ago and is the latest
upstream commit. Can you try updating to this version instead?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 26532 <at> debbugs.gnu.org (full text, mbox):

From: tumashu  <tumashu <at> 163.com>
To: "Marius Bakke" <mbakke <at> fastmail.com>
Cc: 26532 <at> debbugs.gnu.org
Subject: Re:Re: bug#26532: [PATCH] gnu: update you-get version
Date: Mon, 17 Apr 2017 10:27:06 +0800 (CST)

[Message part 1 (text/plain, inline)]

I prefer packaging a git snapshot version to  stable version,  many website
update frequently theirs codes,  so you-get need to update to fix the problem.
git snapshot is more useful than stable version.


At 2017-04-17 03:12:39, "Marius Bakke" <mbakke <at> fastmail.com> wrote:
>Feng Shu <tumashu <at> 163.com> writes:
>
>> you-get stable version is outdate, it can not work with many websites
>> so I update you-get to git snapshot version
>
>Version 0.4.715 was released just some hours ago and is the latest
>upstream commit. Can you try updating to this version instead?

[Message part 2 (text/html, inline)]

Message #14 received at 26532 <at> debbugs.gnu.org (full text, mbox):

From: "Feng Shu" <tumashu <at> 163.com>
To: "Marius Bakke" <mbakke <at> fastmail.com>
Cc: Feng Shu <tumashu <at> 163.com>, 26532 <at> debbugs.gnu.org
Subject: Re: bug#26532: Re: bug#26532: [PATCH] gnu: update you-get version
Date: Mon, 17 Apr 2017 18:04:27 +0800

[Message part 1 (text/plain, inline)]

tumashu  <tumashu <at> 163.com> writes:

This is the updated patch, I use git-fetch instead of url-fetch for I
want to package git-snapshot if need.

[0001-gnu-update-you-get-version.patch (text/x-patch, inline)]

From fc6114749fa00b9171d0f308daa268ce343d4538 Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu <at> 163.com>
Date: Sun, 16 Apr 2017 18:27:18 +0800
Subject: [PATCH] gnu: update you-get version

* gnu/packages/video.scm (you-get): Update to git snapshot
---
 gnu/packages/video.scm | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index b64664176..95af55dab 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1027,15 +1027,16 @@ YouTube.com and a few more sites.")
 (define-public you-get
   (package
     (name "you-get")
-    (version "0.4.652")
+    (version "0.4.715")
     (source (origin
-              (method url-fetch)
-              (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/soimort/you-get.git")
+                    (commit "v0.4.715")))
+              (file-name (string-append name "-" version "-checkout"))
               (sha256
                (base32
-                "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))))
+                "1miakavayg0x0vg1llbs97j6hj7k6rv9dp8idn2v2hnplvhgn08d"))))
     (build-system python-build-system)
     (arguments
      ;; no tests
-- 
2.12.2

[Message part 3 (text/plain, inline)]

> I prefer packaging a git snapshot version to stable version, many
> website
> update frequently theirs codes, so you-get need to update to fix the
> problem.
> git snapshot is more useful than stable version.
>
> At 2017-04-17 03:12:39, "Marius Bakke" <mbakke <at> fastmail.com> wrote:
>>Feng Shu <tumashu <at> 163.com> writes:
>>
>>> you-get stable version is outdate, it can not work with many websites
>>> so I update you-get to git snapshot version
>>
>>Version 0.4.715 was released just some hours ago and is the latest
>>upstream commit. Can you try updating to this version instead?

-- 

Message #17 received at 26532 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Feng Shu <tumashu <at> 163.com>
Cc: Feng Shu <tumashu <at> 163.com>, 26532 <at> debbugs.gnu.org
Subject: Re: bug#26532: Re: bug#26532: [PATCH] gnu: update you-get version
Date: Mon, 17 Apr 2017 17:14:58 +0200

[Message part 1 (text/plain, inline)]

Feng Shu <tumashu <at> 163.com> writes:

> tumashu  <tumashu <at> 163.com> writes:
>
> This is the updated patch, I use git-fetch instead of url-fetch for I
> want to package git-snapshot if need.

What is the rationale for packaging the git version in anticipation of
needing it later? In this case the latest release is also the latest
commit, so I don't see any compelling reason for switching to git-fetch
at this moment.

Git snapshots use more bandwidth than regular downloads (mostly due to
Guix' lack of shallow clones), and also more disk space since they
create a source derivation. They also introduce a dependency on git
which ticks in at 344.5MiB.

Note that you can also build a package from a local source code copy
with `guix build --with-source=/path/to/git/checkout you-get` in case of
emergency :)

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 26532 <at> debbugs.gnu.org (full text, mbox):

From: "Feng Shu" <tumashu <at> 163.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: Feng Shu <tumashu <at> 163.com>, 26532 <at> debbugs.gnu.org
Subject: Re: bug#26532: Re: bug#26532: [PATCH] gnu: update you-get version
Date: Tue, 18 Apr 2017 06:07:15 +0800

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Feng Shu <tumashu <at> 163.com> writes:
>
>> tumashu  <tumashu <at> 163.com> writes:
>>
>> This is the updated patch, I use git-fetch instead of url-fetch for I
>> want to package git-snapshot if need.
>
> What is the rationale for packaging the git version in anticipation of
> needing it later? In this case the latest release is also the latest
> commit, so I don't see any compelling reason for switching to git-fetch
> at this moment.
>
> Git snapshots use more bandwidth than regular downloads (mostly due to
> Guix' lack of shallow clones), and also more disk space since they
> create a source derivation. They also introduce a dependency on git
> which ticks in at 344.5MiB.

344.5MiB ...

you are right, tarball seem to be a better approach.

>
> Note that you can also build a package from a local source code copy
> with `guix build --with-source=/path/to/git/checkout you-get` in case of
> emergency :)
>

This is a very useful tip, thanks!


the below is updated patch:

[0001-gnu-update-you-get-version.patch (text/x-patch, inline)]

From 77df519f20b5304ec0e838ad519aef26ab18115c Mon Sep 17 00:00:00 2001
From: Feng Shu <tumashu <at> 163.com>
Date: Tue, 18 Apr 2017 06:04:12 +0800
Subject: [PATCH] gnu: update you-get version

* gnu/packages/video.scm (you-get): Update you-get version
---
 gnu/packages/video.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index e1c6a989f..dcac350d0 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1105,7 +1105,7 @@ other site that youtube-dl supports.")
 (define-public you-get
   (package
     (name "you-get")
-    (version "0.4.652")
+    (version "0.4.715")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -1113,7 +1113,7 @@ other site that youtube-dl supports.")
                     version "/you-get-" version ".tar.gz"))
               (sha256
                (base32
-                "0brkz98lycx8mmxjwmn7jlhqfdbvl0hy070n7skwr1k75kh99q30"))))
+                "043122hfh56fbbszp1kwd1f65asgyn60j1ijday93hf2dkhvbrnh"))))
     (build-system python-build-system)
     (arguments
      ;; no tests
-- 
2.12.2

[Message part 3 (text/plain, inline)]

-- 

Message #25 received at 26532-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Feng Shu <tumashu <at> 163.com>
Cc: Feng Shu <tumashu <at> 163.com>, 26532-done <at> debbugs.gnu.org
Subject: Re: bug#26532: Re: bug#26532: [PATCH] gnu: update you-get version
Date: Tue, 18 Apr 2017 00:33:44 +0200

[Message part 1 (text/plain, inline)]

Feng Shu <tumashu <at> 163.com> writes:

> the below is updated patch:

Thank you! I changed the commit message to match what we usually write
for updates. Pushed as f0bc6ca1f26184bda9f2afe2576042a952fb735b.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.