GNU bug report logs - #26515
[PATCH] gnu: Add emacs-calfw.

Previous Next

Package: guix-patches;

Reported by: Vasile Dumitrascu <va511e <at> yahoo.com>

Date: Sat, 15 Apr 2017 11:26:02 UTC

Severity: normal

Tags: patch

Done: Alex Kost <alezost <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Vasile Dumitrascu <va511e <at> yahoo.com>
To: Alex Kost <alezost <at> gmail.com>
Cc: 26515-done <at> debbugs.gnu.org
Subject: bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)
Date: Mon, 17 Apr 2017 22:00:00 +0000
  Hi

  I did miss the linter warning, regarding the tarball name, sorry for that.

  I will prepare packages for 'howm' and 'google-maps', in order not to
leave the calfw only partially working, and I will send the patches asap.

  Thank you for the observations,

   Vasile

Alex Kost:
> Vasile Dumitrascu (2017-04-15 14:37 +0000) wrote:
> 
>>    Hi
>>
>> I have added a small correction on the homepage for calfw, as I forgot
>> to update the Url from the code stub I have used.
> 
> Applied¹, thanks!  Next time, if you have corrections to your original
> patch, please send an updated patch instead of the new patch build on
> top of the original one.
> 
> Note that "guix lint emacs-calfw" reports:
> 
>   gnu/packages/emacs.scm:1200:5: emacs-calfw <at> 1.5: the source file name should contain the package name
> 
> This means the source origin should contain:
> 
>   (file-name (string-append name "-" version ".tar.gz"))
> 
> Otherwise, the downloaded tarball will have the following name in the
> store (this is often the case with github tagged releases):
> 
>    /gnu/store/...-v1.5.tar.gz
> 
> while we prefer
> 
>    /gnu/store/...-emacs-calfw-1.5.tar.gz
> 
> 
> Finally, I see that for some additional features, this package require
> 'howm' and 'google-maps' emacs packages, so these features won't work;
> but you probably know about it.
> 
> ¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=36890436710032d6c731e31becf6a5bd7aa4afaf
> 




This bug report was last modified 8 years and 35 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.