GNU bug report logs - #26515
[PATCH] gnu: Add emacs-calfw.

Previous Next

Package: guix-patches;

Reported by: Vasile Dumitrascu <va511e <at> yahoo.com>

Date: Sat, 15 Apr 2017 11:26:02 UTC

Severity: normal

Tags: patch

Done: Alex Kost <alezost <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex Kost <alezost <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#26515: closed ([PATCH] gnu: Add emacs-calfw.)
Date: Sun, 16 Apr 2017 09:21:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 16 Apr 2017 12:20:52 +0300
with message-id <87k26kr9mz.fsf <at> gmail.com>
and subject line Re: bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)
has caused the debbugs.gnu.org bug report #26515,
regarding [PATCH] gnu: Add emacs-calfw.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
26515: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=26515
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Vasile Dumitrascu <va511e <at> yahoo.com>
To: guix-patches <at> gnu.org
Cc: Vasile Dumitrascu <va511e <at> yahoo.com>
Subject: [PATCH] gnu: Add emacs-calfw.
Date: Sat, 15 Apr 2017 13:24:52 +0200
* gnu/packages/emacs.scm (emacs-calfw): New variable.
---
 gnu/packages/emacs.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 976ea31e0..aa7d21dbc 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1207,6 +1207,26 @@ writing input files for TeX, LaTeX, ConTeXt, Texinfo, and docTeX using Emacs
 or XEmacs.")
     (license license:gpl3+)))
 
+(define-public emacs-calfw
+  (package
+    (name "emacs-calfw")
+    (version "1.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/kiwanami/emacs-calfw/archive/v"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "17ssg8gx66yp63nhygjq2r6kgl4h45cacmrxsxs9f0lrfcx37k0l"))))
+    (build-system emacs-build-system)
+    (home-page "https://elpa.gnu.org/packages/aggressive-indent.html")
+    (synopsis "Calendar framework for Emacs")
+    (description
+     "This program displays a calendar view in the Emacs buffer.")
+    (license license:gpl3+)))
+
 (define-public emacs-mmm-mode
   (package
     (name "emacs-mmm-mode")
-- 
2.11.0



[Message part 3 (message/rfc822, inline)]
From: Alex Kost <alezost <at> gmail.com>
To: Vasile Dumitrascu <va511e <at> yahoo.com>
Cc: 26515-done <at> debbugs.gnu.org
Subject: Re: bug#26515: Acknowledgement ([PATCH] gnu: Add emacs-calfw.)
Date: Sun, 16 Apr 2017 12:20:52 +0300
Vasile Dumitrascu (2017-04-15 14:37 +0000) wrote:

>    Hi
>
> I have added a small correction on the homepage for calfw, as I forgot
> to update the Url from the code stub I have used.

Applied¹, thanks!  Next time, if you have corrections to your original
patch, please send an updated patch instead of the new patch build on
top of the original one.

Note that "guix lint emacs-calfw" reports:

  gnu/packages/emacs.scm:1200:5: emacs-calfw <at> 1.5: the source file name should contain the package name

This means the source origin should contain:

  (file-name (string-append name "-" version ".tar.gz"))

Otherwise, the downloaded tarball will have the following name in the
store (this is often the case with github tagged releases):

   /gnu/store/...-v1.5.tar.gz

while we prefer

   /gnu/store/...-emacs-calfw-1.5.tar.gz


Finally, I see that for some additional features, this package require
'howm' and 'google-maps' emacs packages, so these features won't work;
but you probably know about it.

¹ http://git.savannah.gnu.org/cgit/guix.git/commit/?id=36890436710032d6c731e31becf6a5bd7aa4afaf

-- 
Alex


This bug report was last modified 8 years and 57 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.