GNU bug report logs - #26500
[PATCH] gnu: Add mcomix.

Previous Next

Full log

Message #32 received at 26500 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>, nee <nee <at> cock.li>
Cc: 26500 <at> debbugs.gnu.org
Subject: Re: bug#26500: [PATCH] gnu: Add mcomix.
Date: Fri, 21 Apr 2017 11:00:27 +0200

Hello!

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> nee writes:

[...]

>> @@ -28,6 +29,7 @@
>>    #:use-module (guix packages)
>>    #:use-module (guix build-system gnu)
>>    #:use-module (guix build-system cmake)
>> +  #:use-module (guix build-system python)
>>    #:use-module (gnu packages autotools)
>>    #:use-module (gnu packages algebra)
>>    #:use-module (gnu packages base)
>> @@ -46,6 +48,7 @@
>>    #:use-module (gnu packages pkg-config)
>>    #:use-module (gnu packages qt)
>>    #:use-module (gnu packages xorg)
>> +  #:use-module (gnu packages python)
>>    #:use-module (gnu packages))
>
> Since these modules are already in alphabetical order, it would be good
> to keep them that way. Insert (gnu packages python) at an appropriate
> position.
>
>> +    (inputs `(("python2-pillow" ,python2-pillow)
>> +              ("python2-pygtk" ,python2-pygtk)
>> +              ("p7zip" ,p7zip)))
>
> Please put these in alphabetical order too. That means p7zip will go on
> the top.
>
>> +    (description "MComix is a customizable image viewer that specializes as
>> +a comic and manga reader.  It supports a variety of container formats
>> +including CBZ, CB7, CBT, LHA.
>> +CBR and rar are currently unsupported, due to unfree dependencies.
>> +For optional pdf support, you can install the mupdf package.")
>
> Can we move the information about RAR and PDF support to a comment above
> the package definition, as done for the octave package?

I agree with the comments, though I also think this shouldn’t block the
patch or drive nee away.  :-)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.