From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 14 13:51:15 2017 Received: (at submit) by debbugs.gnu.org; 14 Apr 2017 17:51:15 +0000 Received: from localhost ([127.0.0.1]:47420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz5NK-0002Q7-Um for submit@debbugs.gnu.org; Fri, 14 Apr 2017 13:51:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz5NH-0002Pt-Rs for submit@debbugs.gnu.org; Fri, 14 Apr 2017 13:51:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz5NB-0001wJ-Ck for submit@debbugs.gnu.org; Fri, 14 Apr 2017 13:51:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44846) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cz5NB-0001wF-9W for submit@debbugs.gnu.org; Fri, 14 Apr 2017 13:51:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz5NA-0000LW-1V for guix-patches@gnu.org; Fri, 14 Apr 2017 13:51:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz5N6-0001uh-0Q for guix-patches@gnu.org; Fri, 14 Apr 2017 13:51:04 -0400 Received: from cock.li ([185.100.85.212]:54182) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cz5N5-0001sx-Im for guix-patches@gnu.org; Fri, 14 Apr 2017 13:50:59 -0400 To: guix-patches@gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1492192254; bh=rZEFtJOYOusVChYU978ISqSANPsCqhQ0kcDol694BC8=; h=To:From:Subject:Date:From; b=KveVfaS7kLlHskmdL37Am0vae/h9aSceX8Qh0NzFcxF1RiAxrAZo/8eWggI1qRuyY RyWZBJ57zsfzjgKQfhzTLKG+IB3k7Q8mNCFO1dls8wvB1lYek9kZ13IyuuWIEuX8na cIfiG+5ukq8YJeG6mGAU9gplMR78vHF7nRvSBJ4oZPWD4Pvrmu5+dlP5DQQakuD5Ch jVr0sFHF2S3lg/mj2u7uCG/ub/ppjWai8OsTuuAr57WNH6oWxvIrZr6wZTerXGc/J6 TmQxHJQouOLRrFBkosjAPrmhC3Vc11acyGxZOfF89JmW4sYRTIPnI1jSLlxFktBEIl MR9gIiJYTRujw== From: nee Subject: [PATCH] gnu: Add mcomix. X-Enigmail-Draft-Status: N1110 Message-ID: Date: Fri, 14 Apr 2017 19:50:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------5E6B16D499494EFD65FDDB3D" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) This is a multi-part message in MIME format. --------------5E6B16D499494EFD65FDDB3D Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, here is mcomix. I tested it with zip, CBZ, 7zip pdf files, and a directory with normal images, they all work fine. I also tried unrar, but couldn't extract any archive with it, neither through mcomix, nor manually through the commandline tool, so this might be a separate problem. --------------5E6B16D499494EFD65FDDB3D Content-Type: text/x-patch; name="0001-gnu-Add-mcomix.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-mcomix.patch" =46rom 7aee659716fab9cfcb9c22eed7ad302696ded374 Mon Sep 17 00:00:00 2001 From: nee Date: Fri, 14 Apr 2017 19:09:40 +0200 Subject: [PATCH] gnu: Add mcomix. * gnu/packages/image-viewers.scm (mcomix): New variable. --- gnu/packages/image-viewers.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.= scm index 830ce10ea..d1e14f053 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -28,6 +28,7 @@ #:use-module (guix packages) #:use-module (guix build-system gnu) #:use-module (guix build-system cmake) + #:use-module (guix build-system python) #:use-module (gnu packages autotools) #:use-module (gnu packages algebra) #:use-module (gnu packages base) @@ -46,6 +47,7 @@ #:use-module (gnu packages pkg-config) #:use-module (gnu packages qt) #:use-module (gnu packages xorg) + #:use-module (gnu packages python) #:use-module (gnu packages)) =20 (define-public feh @@ -360,3 +362,31 @@ imaging. It supports several HDR and LDR image form= ats, and it can: @item Copy EXIF data between sets of images. @end itemize\n") (license license:gpl2+))) + +(define-public mcomix + (package + (name "mcomix") + (version "1.2.1") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mcomix/MComix-" version= + "/mcomix-" version ".tar.bz2")) + (sha256 + (base32 + "0fzsf9pklhfs1rzwzj64c0v30b74nk94p93h371rpg45qnfiahvy")))) + (build-system python-build-system) + ;; Python 2.5 or newer (Python 3 and up is not supported) + (arguments `(#:python ,python-2)) + (propagated-inputs `(("python2-pygtk" ,python2-pygtk) + ("gtk+" ,gtk+) + ("python2-pillow" ,python2-pillow))) + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") + (synopsis "Image viewer for comics") + (description "A customizable image viewer that specializes as +a comic and manga reader. It supports a variety of container formats +including CBR, CBZ, CB7, CBT, LHA. +For 7z support install the p7zip package. +For rar support install the unrar package. +For pdf support install the mupdf package.") + (license license:gpl2))) --=20 2.12.2 --------------5E6B16D499494EFD65FDDB3D-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 15 04:36:47 2017 Received: (at 26500) by debbugs.gnu.org; 15 Apr 2017 08:36:47 +0000 Received: from localhost ([127.0.0.1]:47827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czJCJ-0006XC-Aw for submit@debbugs.gnu.org; Sat, 15 Apr 2017 04:36:47 -0400 Received: from o177.p8.mailjet.com ([87.253.233.177]:37134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@bnc3.mailjet.com>) id 1czJCI-0006X4-1q for 26500@debbugs.gnu.org; Sat, 15 Apr 2017 04:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=1dw3zrACKq2PtxWSRNu5MXH+yfM=; b=g2bad+zL3yIXmlQSoRAxmH/tDIgPJ5OxgPTGnpoZJm5s1OTrDx/dj3AbN Xlk7y85smzHdnzmqHsrc/MxyQyNnLIjtu754Xwt1YQWaIsRuuFgScq4KIEEX 4iW5FkOVTOy2MMDY+IT6vzdW2oo9bqCA6TmV1an9LqxZU4actCckSY= Message-Id: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26500@debbugs.gnu.org Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. Date: Sat, 15 Apr 2017 14:06:22 +0530 In-reply-to: References: X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8duddAle8sSrTJin5Ywg7EHm0wAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > Hello, here is mcomix. Thanks for the patch! > I tested it with zip, CBZ, 7zip pdf files, and a directory with normal > images, they all work fine. > > I also tried unrar, but couldn't extract any archive with it, neither > through mcomix, nor manually through the commandline tool, so this might > be a separate problem. I'm yet to actually test running the application. Will do so and get back in a while. Meanwhile, other changes. > + ;; Python 2.5 or newer (Python 3 and up is not supported) > + (arguments `(#:python ,python-2)) You can remove the comment. It's more or less obvious from the 'arguments' section that mcomix needs python 2. > + (propagated-inputs `(("python2-pygtk" ,python2-pygtk) > + ("gtk+" ,gtk+) > + ("python2-pillow" ,python2-pillow))) These are inputs not propagated-inputs. propagated-inputs are only required for python libraries. For python applications such as mcomix, the executable gets wrapped in a script which sets the correct PYTHONPATH variable. Look at $out/bin/mcomix and $out/bin/.mcomix-real Also, is the gtk+ dependency required? mcomix seems to build and run fine on my system without it. > + (description "A customizable image viewer that specializes as > +a comic and manga reader. It supports a variety of container formats > +including CBR, CBZ, CB7, CBT, LHA. Please make this "MComix is a ... ". See https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Description= s.html > + (license license:gpl2))) This should be license:gpl2+. When no license version is explicitly specified in the source headers, it is of the "or later" variant. See https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00026.html Also, add a copyright header for yourself at the top of the source file (gnu/packages/image-viewers.scm in this case). = From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 15 05:09:39 2017 Received: (at 26500) by debbugs.gnu.org; 15 Apr 2017 09:09:39 +0000 Received: from localhost ([127.0.0.1]:47841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czJi7-0007HD-Gt for submit@debbugs.gnu.org; Sat, 15 Apr 2017 05:09:39 -0400 Received: from perdizione.investici.org ([94.23.50.208]:58320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czJi5-0007H4-7y for 26500@debbugs.gnu.org; Sat, 15 Apr 2017 05:09:38 -0400 Received: from [94.23.50.208] (perdizione [94.23.50.208]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id A7D49120D4B; Sat, 15 Apr 2017 09:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1492247376; bh=bkSWepxJJ3iudxM75yPO1MVBUyG4yxniUSSc1IJD3LA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=tyBvPkt9WZqTX4c8NK49RGfQtQYs4m8OGGwVnW/+gWC+KN8bQDI2ylrgKF0Tp5OV4 2vw2PkbK56BfKxwmmbhtBRpqWW84U4D1RXpmqRSOSp5tCdWOuZQE4FgB1koBRRfmdo XWxcHYyqwBIyYXzS7JP6WvaswshUa6B0bKMDVD/s= Date: Sat, 15 Apr 2017 09:09:32 +0000 From: ng0 To: Arun Isaac Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. Message-ID: <20170415090932.ed7dzowf6s5cwln5@abyayala> Mail-Followup-To: Arun Isaac , 26500@debbugs.gnu.org References: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26500 Cc: 26500@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Arun Isaac transcribed 1.8K bytes: > > > Hello, here is mcomix. > > Thanks for the patch! > > > I tested it with zip, CBZ, 7zip pdf files, and a directory with normal > > images, they all work fine. > > > > I also tried unrar, but couldn't extract any archive with it, neither > > through mcomix, nor manually through the commandline tool, so this might > > be a separate problem. > > I'm yet to actually test running the application. Will do so and get > back in a while. Meanwhile, other changes. > > > + ;; Python 2.5 or newer (Python 3 and up is not supported) > > + (arguments `(#:python ,python-2)) > > You can remove the comment. It's more or less obvious from the > 'arguments' section that mcomix needs python 2. No, I think a short comment behind or above the #:python keyword is necessary, in case someone in the future wonders "Hey, why do we package this for python 2 only and not for python 3" even if both languages are developed in parallel. > > + (propagated-inputs `(("python2-pygtk" ,python2-pygtk) > > + ("gtk+" ,gtk+) > > + ("python2-pillow" ,python2-pillow))) > > These are inputs not propagated-inputs. propagated-inputs are only > required for python libraries. For python applications such as mcomix, > the executable gets wrapped in a script which sets the correct > PYTHONPATH variable. Look at $out/bin/mcomix and $out/bin/.mcomix-real > > Also, is the gtk+ dependency required? mcomix seems to build and run > fine on my system without it. > > > + (description "A customizable image viewer that specializes as > > +a comic and manga reader. It supports a variety of container formats > > +including CBR, CBZ, CB7, CBT, LHA. > > Please make this "MComix is a ... ". See > https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html > > > + (license license:gpl2))) > > This should be license:gpl2+. When no license version is explicitly > specified in the source headers, it is of the "or later" variant. See > https://lists.gnu.org/archive/html/guix-devel/2017-02/msg00026.html > > Also, add a copyright header for yourself at the top of the source file > (gnu/packages/image-viewers.scm in this case). > > > -- PGP and more: https://people.pragmatique.xyz/ng0/ From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 16 04:53:20 2017 Received: (at 26500) by debbugs.gnu.org; 16 Apr 2017 08:53:20 +0000 Received: from localhost ([127.0.0.1]:49717 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czfvs-0001Jq-7A for submit@debbugs.gnu.org; Sun, 16 Apr 2017 04:53:20 -0400 Received: from o143.p9.mailjet.com ([87.253.234.143]:49981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@bnc3.mailjet.com>) id 1czfvq-0001Ji-Lz for 26500@debbugs.gnu.org; Sun, 16 Apr 2017 04:53:19 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=x6HBiOjujwlhyf/c+KxhhyMyEeI=; b=QajQXC8Qh1F8PBbybGH7xRLZlpw4/D59VsVpgQlN+nR4haxtv6lvh9TLe MeZ5rDtZuYzphD7Vqo2B6LCjaix5Abr87Y643VauRhxeoTkseXUkWe+HBdBW O5SYdR3nwnKJmO2H4D6g+UgT1QgInHW1o4SUW7GaqRsegmDhTDKv4o= Message-Id: <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26500@debbugs.gnu.org Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. Date: Sun, 16 Apr 2017 14:23:02 +0530 In-reply-to: <20170415090932.ed7dzowf6s5cwln5@abyayala> References: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> <20170415090932.ed7dzowf6s5cwln5@abyayala> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9MMmmDqp6TYipbRTrncwbDQAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > No, I think a short comment behind or above the #:python keyword is > necessary, in case someone in the future wonders "Hey, why do we package > this for python 2 only and not for python 3" even if both languages are > developed in parallel. Ok, it doesn't hurt to keep the comment. Let's keep it. > + (description "A customizable image viewer that specializes as > +a comic and manga reader. It supports a variety of container formats > +including CBR, CBZ, CB7, CBT, LHA. > +For 7z support install the p7zip package. > +For rar support install the unrar package. > +For pdf support install the mupdf package.") Instead of mentioning p7zip, unrar and mupdf in the description, it would be better if we could make them inputs and patch all references to the executables in the source with their absolute paths. Could you try this= ? = From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 16 22:46:01 2017 Received: (at 26500) by debbugs.gnu.org; 17 Apr 2017 02:46:01 +0000 Received: from localhost ([127.0.0.1]:51223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czwfw-00082m-Mk for submit@debbugs.gnu.org; Sun, 16 Apr 2017 22:46:00 -0400 Received: from cock.li ([185.100.85.212]:37346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czwft-00082R-Mw for 26500@debbugs.gnu.org; Sun, 16 Apr 2017 22:45:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on cock.li X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40, NO_RECEIVED, NO_RELAYS, T_DKIM_INVALID autolearn=disabled version=3.4.0 Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1492397149; bh=LkiscUAdVCSc8n+ZO/Xs+49ytJx5qxqfxqnDgLGYVhc=; h=Subject:To:References:From:Date:In-Reply-To:From; b=lPQTR9jHThulFlhwEoB3zY5xaKrvO1QYjDgoUoxv3jyjQqRjh00bpgE/Vi3ig8VeM iXA7UMtT6vLMV9jIUAMpNjYzKojCAE++eqqDNabKDCm/PvKJhHGbALDQJtS/7CTq1n QWD5ZaOQkk0fD9vpXhSKCQgyR3UC206855Pv6OYd/3QukSC9WWhL/2urJM43QCEXX5 0Ohhh7MhPKxSI0wFWPRLqyR+rFC3E5Hf4vD1Zo89uN7WpuyYXxUf7fEaEcEbIjfly5 a/sbgrVFqoUdxS5oAYs8JyWzOSAwMceStqMijguc8Gfcv/AFEawgZg2QjAnlX9JMVI xVtjnCwar32VQ== To: Arun Isaac , 26500@debbugs.gnu.org References: <495758ba.AEAAJEuaJ4UAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8dud@mailjet.com> <20170415090932.ed7dzowf6s5cwln5@abyayala> <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com> From: nee X-Enigmail-Draft-Status: N1110 Message-ID: <5e116405-23c7-b059-e4af-9cee0893ae57@cock.li> Date: Mon, 17 Apr 2017 06:45:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <23131da0.AEMAJPO5alAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY8zD9@mailjet.com> Content-Type: multipart/mixed; boundary="------------ED9FEC04165E4D4BEF87F6FC" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------ED9FEC04165E4D4BEF87F6FC Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Am 16.04.2017 um 10:53 schrieb Arun Isaac: > Instead of mentioning p7zip, unrar and mupdf in the description, it > would be better if we could make them inputs and patch all references to > the executables in the source with their absolute paths. Could you try this? I could try that, but mupdf is a pretty heavy dependency. guix size says it's self-size is 208MiB and total-size is 491MiB. I personally never needed it with mcomix, so I like that it is optional. Is there some way to define a package with optional inputs? For now I'm appending my WIP that should address your previous remarks. --------------ED9FEC04165E4D4BEF87F6FC Content-Type: text/x-patch; name="0001-gnu-Add-mcomix.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-mcomix.patch" =46rom 493a6e0c1c5dd9ef6b454b31be9b80646f201fb4 Mon Sep 17 00:00:00 2001 From: nee Date: Fri, 14 Apr 2017 19:09:40 +0200 Subject: [PATCH] gnu: Add mcomix. * gnu/packages/image-viewers.scm (mcomix): New variable. --- gnu/packages/image-viewers.scm | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.= scm index 830ce10ea..bfcad99f1 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -6,6 +6,7 @@ ;;; Copyright =C2=A9 2017 Alex Griffin ;;; Copyright =C2=A9 2017 ng0 ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2017 nee ;;; ;;; This file is part of GNU Guix. ;;; @@ -28,6 +29,7 @@ #:use-module (guix packages) #:use-module (guix build-system gnu) #:use-module (guix build-system cmake) + #:use-module (guix build-system python) #:use-module (gnu packages autotools) #:use-module (gnu packages algebra) #:use-module (gnu packages base) @@ -46,6 +48,7 @@ #:use-module (gnu packages pkg-config) #:use-module (gnu packages qt) #:use-module (gnu packages xorg) + #:use-module (gnu packages python) #:use-module (gnu packages)) =20 (define-public feh @@ -360,3 +363,30 @@ imaging. It supports several HDR and LDR image form= ats, and it can: @item Copy EXIF data between sets of images. @end itemize\n") (license license:gpl2+))) + +(define-public mcomix + (package + (name "mcomix") + (version "1.2.1") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mcomix/MComix-" version= + "/mcomix-" version ".tar.bz2")) + (sha256 + (base32 + "0fzsf9pklhfs1rzwzj64c0v30b74nk94p93h371rpg45qnfiahvy")))) + (build-system python-build-system) + ;; Python 2.5 or newer (Python 3 and up is not supported) + (arguments `(#:python ,python-2)) + (inputs `(("python2-pygtk" ,python2-pygtk) + ("python2-pillow" ,python2-pillow))) + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") + (synopsis "Image viewer for comics") + (description "MComix is a customizable image viewer that specializes= as +a comic and manga reader. It supports a variety of container formats +including CBR, CBZ, CB7, CBT, LHA. +For 7z support install the p7zip package. +For rar support install the unrar package. +For pdf support install the mupdf package.") + (license license:gpl2+))) --=20 2.12.2 --------------ED9FEC04165E4D4BEF87F6FC-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 17 15:21:40 2017 Received: (at 26500) by debbugs.gnu.org; 17 Apr 2017 19:21:40 +0000 Received: from localhost ([127.0.0.1]:52914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0CDT-0006v6-QT for submit@debbugs.gnu.org; Mon, 17 Apr 2017 15:21:39 -0400 Received: from o175.p9.mailjet.com ([87.253.234.175]:44575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@bnc3.mailjet.com>) id 1d0CDS-0006uy-04 for 26500@debbugs.gnu.org; Mon, 17 Apr 2017 15:21:38 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=3t3CeGmtWkQPax73n4cRAL3SbTg=; b=XXh5JUSS4F3b8DkH0ybHMj6zUXO2bJZRBbTNu7lnPEGzAze+QW3enb9gE O1hF8jmv2gzjrGcyIOTv5HD7Sf0unfsVXLy0CDuBx1dmdL/k1Y+nO/7QU7c4 SftN6QqMq0m503IrN/dJXjGHxxrHD3YZmiySY0KGIiq2PvCssTXIZY= Message-Id: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26500@debbugs.gnu.org Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. Date: Tue, 18 Apr 2017 00:51:31 +0530 In-reply-to: <5e116405-23c7-b059-e4af-9cee0893ae57@cock.li> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXBvrb9zbYGTwGXECbbP3fIKQAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >> Instead of mentioning p7zip, unrar and mupdf in the description, it >> would be better if we could make them inputs and patch all references to >> the executables in the source with their absolute paths. Could you try t= his? > I could try that, but mupdf is a pretty heavy dependency. guix size says > it's self-size is 208MiB and total-size is 491MiB. > I personally never needed it with mcomix, so I like that it is optional. > Is there some way to define a package with optional inputs? As far as I understand, there is no way to specify optional inputs (yet?). Here are two of many threads discussing this. https://lists.gnu.org/archive/html/guix-devel/2014-11/msg00549.html https://lists.gnu.org/archive/html/guix-devel/2015-05/msg00379.html If mupdf is a heavy dependency and it is not commonly needed, you can drop it and just package with 7z and rar as dependencies. > + (arguments `(#:python ,python-2)) > + (inputs `(("python2-pygtk" ,python2-pygtk) > + ("python2-pillow" ,python2-pillow))) Sort these inputs alphabetically, as I mentioned in the crawl thread. LGTM, otherwise! Please send an updated patch. Thanks! = From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 18 18:09:54 2017 Received: (at 26500) by debbugs.gnu.org; 18 Apr 2017 22:09:54 +0000 Received: from localhost ([127.0.0.1]:55302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0bJq-0004DR-FZ for submit@debbugs.gnu.org; Tue, 18 Apr 2017 18:09:54 -0400 Received: from cock.li ([185.100.85.212]:51166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0bJm-0004DA-KR for 26500@debbugs.gnu.org; Tue, 18 Apr 2017 18:09:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on cock.li X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40, NO_RECEIVED, NO_RELAYS, T_DKIM_INVALID autolearn=disabled version=3.4.0 Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cock.li; s=mail; t=1492553382; bh=Nva2DvF8XXF4Cj3yHZ6Hv4tHxaj0VhUlh2LMBHkb9hU=; h=Subject:To:References:From:Date:In-Reply-To:From; b=wrNqMbc/VZ9+haL8nIM+/80XBRtY9Ci6ouqKDKn1M5TtcpmziENVIGSHtGQkuChJN Se9U++pwZJvbO+PGCFyWAbnqdalw5SE2QwT6/yuFDIhmz1qWkz2ec0aUQpeIt6tvDU wSVe9f3T9OF+zuqZ53GqkYRbuw0gcwuRjG+Y3aSEbB58xIk7QNI0dKaT1KLf1wrkBu c9kS0uiyyminipiZeKYO6WCqxFFc9cv+WXL2CS/DUe7bzs54K8CXuffEuFmD6Q11Z3 6PW3H9mCdbPlo81w9tPZZCtpga1M/RRW16miGJsuy0A3N5FpE3KoX+l9aTMkLGAGoE 5+K04IJSm7nkw== To: 26500@debbugs.gnu.org References: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> From: nee X-Enigmail-Draft-Status: N1110 Message-ID: <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> Date: Wed, 19 Apr 2017 00:09:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> Content-Type: multipart/mixed; boundary="------------4DA0616580476CFC1F33417E" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------4DA0616580476CFC1F33417E Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 8bit Am 17.04.2017 um 21:21 schrieb Arun Isaac: > > If mupdf is a heavy dependency and it is not commonly needed, you can > drop it and just package with 7z and rar as dependencies. I have successfully patched in the path for 7zip. I init the variable that stores it with a unicode string. I make the assumption that the store path will never contain a ' character. I read a little bit about unrar and it's issues with mcomix. Unrar is very old and only supports RAR2, as someone says in the mcomix issues it is unable to unpack most rar archives created after 2002�. On other distro mcomix currently relies on an unfree rar package�, and there is an open ticket� about switching to a free library like libarchiver (which supports RAR5 and is also used by file-roller, which works fine on GuixSD). I tried unrar on the commandline and it would list file names, but always fail on unpacking. When called by mcomix, it would always try to read a password from stdin and freeze the gui. I will omit rar support for now, since unrar is mostly useless. > > Sort these inputs alphabetically, as I mentioned in the crawl thread. > > LGTM, otherwise! Please send an updated patch. Thanks! > Okay. (1) https://sourceforge.net/p/mcomix/feature-requests/82/#2bc5 (2) https://sourceforge.net/p/mcomix/feature-requests/82/ (3) https://sourceforge.net/p/mcomix/feature-requests/85/ --------------4DA0616580476CFC1F33417E Content-Type: text/x-patch; name="0001-gnu-Add-mcomix.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-gnu-Add-mcomix.patch" =46rom 6ecc38ecc8ce93d21cb4fa854b6332230c4ea4c9 Mon Sep 17 00:00:00 2001 From: nee Date: Fri, 14 Apr 2017 19:09:40 +0200 Subject: [PATCH] gnu: Add mcomix. * gnu/packages/image-viewers.scm (mcomix): New variable. --- gnu/packages/image-viewers.scm | 40 ++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.= scm index 830ce10ea..83ca1ee46 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -6,6 +6,7 @@ ;;; Copyright =C2=A9 2017 Alex Griffin ;;; Copyright =C2=A9 2017 ng0 ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2017 nee ;;; ;;; This file is part of GNU Guix. ;;; @@ -28,6 +29,7 @@ #:use-module (guix packages) #:use-module (guix build-system gnu) #:use-module (guix build-system cmake) + #:use-module (guix build-system python) #:use-module (gnu packages autotools) #:use-module (gnu packages algebra) #:use-module (gnu packages base) @@ -46,6 +48,7 @@ #:use-module (gnu packages pkg-config) #:use-module (gnu packages qt) #:use-module (gnu packages xorg) + #:use-module (gnu packages python) #:use-module (gnu packages)) =20 (define-public feh @@ -360,3 +363,40 @@ imaging. It supports several HDR and LDR image form= ats, and it can: @item Copy EXIF data between sets of images. @end itemize\n") (license license:gpl2+))) + +(define-public mcomix + (package + (name "mcomix") + (version "1.2.1") + (source (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mcomix/MComix-" = version + "/mcomix-" version ".tar.bz2")) + (sha256 + (base32 + "0fzsf9pklhfs1rzwzj64c0v30b74nk94p93h371rpg45qnfiahvy"))= )) + (build-system python-build-system) + (arguments + ;; Python 2.5 or newer (Python 3 and up is not supported) + `(#:python ,python-2 + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch + (lambda* (#:key inputs #:allow-other-keys) + (let ((p7zip (assoc-ref inputs "p7zip"))) + ;; insert absolute path to 7z executable + (substitute* "mcomix/archive/sevenzip_external.py" + (("_7z_executable =3D -1") + (string-append "_7z_executable =3D u'" p7zip "/bin/7z'= ")))) + #t))))) + (inputs `(("python2-pillow" ,python2-pillow) + ("python2-pygtk" ,python2-pygtk) + ("p7zip" ,p7zip))) + (home-page "https://sourceforge.net/p/mcomix/wiki/Home/") + (synopsis "Image viewer for comics") + (description "MComix is a customizable image viewer that specializes= as +a comic and manga reader. It supports a variety of container formats +including CBZ, CB7, CBT, LHA. +CBR and rar are currently unsupported, due to unfree dependencies. +For optional pdf support, you can install the mupdf package.") + (license license:gpl2+))) --=20 2.12.2 --------------4DA0616580476CFC1F33417E-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 11:54:07 2017 Received: (at 26500) by debbugs.gnu.org; 19 Apr 2017 15:54:07 +0000 Received: from localhost ([127.0.0.1]:57145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0rvj-0003sb-5C for submit@debbugs.gnu.org; Wed, 19 Apr 2017 11:54:07 -0400 Received: from o137.p8.mailjet.com ([87.253.233.137]:40965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@bnc3.mailjet.com>) id 1d0rvh-0003sR-Ld for 26500@debbugs.gnu.org; Wed, 19 Apr 2017 11:54:06 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=5kCtL2ds3rW6FtBXMBLy1ohBDzY=; b=g/FDfghAg0ERfke6esfuY4kD2ifg8ElsPPj1Enmc8rMd5+QS9RqKgkrCB +GfyOmuo+XalYcFa9jOmCxpOLCo9KJ2yf6w5PFpzbhI0g2OPVlWNP/crjqU4 gIRKHs8D25S3g+DpionMYZNhhix/mt3FmSZn2w2HVq8/oz1yYrb1jM= Message-Id: <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26500@debbugs.gnu.org Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. Date: Wed, 19 Apr 2017 21:23:49 +0530 In-reply-to: <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> References: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gcSHllLgfATHSEwZmCnvghhwAFgUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) nee writes: >> If mupdf is a heavy dependency and it is not commonly needed, you can >> drop it and just package with 7z and rar as dependencies. > > I have successfully patched in the path for 7zip. > I init the variable that stores it with a unicode string. I make the > assumption that the store path will never contain a ' character. > I read a little bit about unrar and it's issues with mcomix. > Unrar is very old and only supports RAR2, as someone says in the mcomix > issues it is unable to unpack most rar archives created after 2002¹. On > other distro mcomix currently relies on an unfree rar package², and > there is an open ticket³ about switching to a free library like > libarchiver (which supports RAR5 and is also used by file-roller, which > works fine on GuixSD). > > I tried unrar on the commandline and it would list file names, but > always fail on unpacking. When called by mcomix, it would always try to > read a password from stdin and freeze the gui. > I will omit rar support for now, since unrar is mostly useless. Ok, that's fine. > @@ -28,6 +29,7 @@ > #:use-module (guix packages) > #:use-module (guix build-system gnu) > #:use-module (guix build-system cmake) > + #:use-module (guix build-system python) > #:use-module (gnu packages autotools) > #:use-module (gnu packages algebra) > #:use-module (gnu packages base) > @@ -46,6 +48,7 @@ > #:use-module (gnu packages pkg-config) > #:use-module (gnu packages qt) > #:use-module (gnu packages xorg) > + #:use-module (gnu packages python) > #:use-module (gnu packages)) Since these modules are already in alphabetical order, it would be good to keep them that way. Insert (gnu packages python) at an appropriate position. > + (inputs `(("python2-pillow" ,python2-pillow) > + ("python2-pygtk" ,python2-pygtk) > + ("p7zip" ,p7zip))) Please put these in alphabetical order too. That means p7zip will go on the top. > + (description "MComix is a customizable image viewer that specializes as > +a comic and manga reader. It supports a variety of container formats > +including CBZ, CB7, CBT, LHA. > +CBR and rar are currently unsupported, due to unfree dependencies. > +For optional pdf support, you can install the mupdf package.") Can we move the information about RAR and PDF support to a comment above the package definition, as done for the octave package? From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 19 15:54:50 2017 Received: (at 26500) by debbugs.gnu.org; 19 Apr 2017 19:54:50 +0000 Received: from localhost ([127.0.0.1]:57387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0vgg-0003CR-IG for submit@debbugs.gnu.org; Wed, 19 Apr 2017 15:54:50 -0400 Received: from latitanza.investici.org ([82.94.249.234]:24848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0vge-0003CI-AW for 26500@debbugs.gnu.org; Wed, 19 Apr 2017 15:54:48 -0400 Received: from [82.94.249.234] (latitanza [82.94.249.234]) (Authenticated sender: niasterisk@grrlz.net) by localhost (Postfix) with ESMTPSA id BB939120D57; Wed, 19 Apr 2017 19:54:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cryptolab.net; s=stigmate; t=1492631687; bh=LVSAZFDIoBLi9NdOwsB3z34cqo1VvHbCIe6VEtXDyDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=cZACztm00SLBF92Fh7GTrYdK9kJLIB+zQSFCFAjXaX6ZKqQivsSlPH5aXQ9eDh7L5 KvF1KVb3EfBER4tg8LtrefJH9XUdY8+1tt4S8IPktdyzpSb7Kl2+1ULnnMLWEzWA+9 lP8ZPtVPG5raR9pXJfnPlc/7n4vxUOkliMDv/lP8= Date: Wed, 19 Apr 2017 19:54:44 +0000 From: ng0 To: Arun Isaac Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. Message-ID: <20170419195444.5njpx3arievj7mzo@abyayala> Mail-Followup-To: Arun Isaac , 26500@debbugs.gnu.org References: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26500 Cc: 26500@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Arun Isaac transcribed 2.4K bytes: > > nee writes: > > >> If mupdf is a heavy dependency and it is not commonly needed, you can > >> drop it and just package with 7z and rar as dependencies. > > > > I have successfully patched in the path for 7zip. > > I init the variable that stores it with a unicode string. I make the > > assumption that the store path will never contain a ' character. > > > I read a little bit about unrar and it's issues with mcomix. > > Unrar is very old and only supports RAR2, as someone says in the mcomix > > issues it is unable to unpack most rar archives created after 2002¹. On > > other distro mcomix currently relies on an unfree rar package², and > > there is an open ticket³ about switching to a free library like > > libarchiver (which supports RAR5 and is also used by file-roller, which > > works fine on GuixSD). > > > > I tried unrar on the commandline and it would list file names, but > > always fail on unpacking. When called by mcomix, it would always try to > > read a password from stdin and freeze the gui. > > I will omit rar support for now, since unrar is mostly useless. Oh... this could be why zathura-cb has massive issues with most .cbr comics I have! I had some ideas, but thanks for explaining this issue. > Ok, that's fine. > > > @@ -28,6 +29,7 @@ > > #:use-module (guix packages) > > #:use-module (guix build-system gnu) > > #:use-module (guix build-system cmake) > > + #:use-module (guix build-system python) > > #:use-module (gnu packages autotools) > > #:use-module (gnu packages algebra) > > #:use-module (gnu packages base) > > @@ -46,6 +48,7 @@ > > #:use-module (gnu packages pkg-config) > > #:use-module (gnu packages qt) > > #:use-module (gnu packages xorg) > > + #:use-module (gnu packages python) > > #:use-module (gnu packages)) > > Since these modules are already in alphabetical order, it would be good > to keep them that way. Insert (gnu packages python) at an appropriate > position. > > > + (inputs `(("python2-pillow" ,python2-pillow) > > + ("python2-pygtk" ,python2-pygtk) > > + ("p7zip" ,p7zip))) > > Please put these in alphabetical order too. That means p7zip will go on > the top. > > > + (description "MComix is a customizable image viewer that specializes as > > +a comic and manga reader. It supports a variety of container formats > > +including CBZ, CB7, CBT, LHA. > > +CBR and rar are currently unsupported, due to unfree dependencies. > > +For optional pdf support, you can install the mupdf package.") > > Can we move the information about RAR and PDF support to a comment above > the package definition, as done for the octave package? > > > -- PGP and more: https://people.pragmatique.xyz/ng0/ From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 05:00:40 2017 Received: (at 26500) by debbugs.gnu.org; 21 Apr 2017 09:00:41 +0000 Received: from localhost ([127.0.0.1]:59738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1UQi-0001y3-Jq for submit@debbugs.gnu.org; Fri, 21 Apr 2017 05:00:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1UQg-0001rl-Rz for 26500@debbugs.gnu.org; Fri, 21 Apr 2017 05:00:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d1UQY-0003OQ-NT for 26500@debbugs.gnu.org; Fri, 21 Apr 2017 05:00:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d1UQY-0003OH-Ja; Fri, 21 Apr 2017 05:00:30 -0400 Received: from [193.50.110.185] (port=51938 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d1UQX-0002R4-Lx; Fri, 21 Apr 2017 05:00:29 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Arun Isaac , nee Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. References: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> Date: Fri, 21 Apr 2017 11:00:27 +0200 In-Reply-To: <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> (Arun Isaac's message of "Wed, 19 Apr 2017 21:23:49 +0530") Message-ID: <87lgqu3zkk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26500 Cc: 26500@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hello! Arun Isaac skribis: > nee writes: [...] >> @@ -28,6 +29,7 @@ >> #:use-module (guix packages) >> #:use-module (guix build-system gnu) >> #:use-module (guix build-system cmake) >> + #:use-module (guix build-system python) >> #:use-module (gnu packages autotools) >> #:use-module (gnu packages algebra) >> #:use-module (gnu packages base) >> @@ -46,6 +48,7 @@ >> #:use-module (gnu packages pkg-config) >> #:use-module (gnu packages qt) >> #:use-module (gnu packages xorg) >> + #:use-module (gnu packages python) >> #:use-module (gnu packages)) > > Since these modules are already in alphabetical order, it would be good > to keep them that way. Insert (gnu packages python) at an appropriate > position. > >> + (inputs `(("python2-pillow" ,python2-pillow) >> + ("python2-pygtk" ,python2-pygtk) >> + ("p7zip" ,p7zip))) > > Please put these in alphabetical order too. That means p7zip will go on > the top. > >> + (description "MComix is a customizable image viewer that specialize= s as >> +a comic and manga reader. It supports a variety of container formats >> +including CBZ, CB7, CBT, LHA. >> +CBR and rar are currently unsupported, due to unfree dependencies. >> +For optional pdf support, you can install the mupdf package.") > > Can we move the information about RAR and PDF support to a comment above > the package definition, as done for the octave package? I agree with the comments, though I also think this shouldn=E2=80=99t block= the patch or drive nee away. :-) Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 13:58:14 2017 Received: (at 26500-done) by debbugs.gnu.org; 21 Apr 2017 17:58:14 +0000 Received: from localhost ([127.0.0.1]:32860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d1cov-0008JL-2y for submit@debbugs.gnu.org; Fri, 21 Apr 2017 13:58:13 -0400 Received: from o142.p8.mailjet.com ([87.253.233.142]:52363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <80fecf55.AEAAJVJo-W0AAAAAAAAAAAO3ApAAAAACwQwAAAAAAAW9WABY-kgy@bnc3.mailjet.com>) id 1d1cou-0008JD-0C for 26500-done@debbugs.gnu.org; Fri, 21 Apr 2017 13:58:12 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=m0/NjiS76IzSpkSoMiB+dDef8MA=; b=GHXu+d1XCcW1/alG9siXOw8g8c7VP4HFELB5yLIoV7T0IpqAXuqf8gw3H b/HcaIWBz32iEerVIj9kzQxSO2smUH3xfnXZUUBWS7JldudOZzJCcx6WRNRe 5oBIsaJlTdmbn+YozCm+dex5y2lcz9PkN1qET87Si8NBVRUx6YegGw= Message-Id: <80fecf55.AEAAJVJo-W0AAAAAAAAAAAO3ApAAAAACwQwAAAAAAAW9WABY-kgy@mailjet.com> MIME-Version: 1.0 From: Arun Isaac To: 26500-done@debbugs.gnu.org Subject: Re: bug#26500: [PATCH] gnu: Add mcomix. Date: Fri, 21 Apr 2017 23:27:55 +0530 In-reply-to: <87lgqu3zkk.fsf@gnu.org> References: <633024d3.AEEAJmX48o8AAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY9RXB@mailjet.com> <7d9f2380-156d-986b-e38c-2aa5d6f45341@cock.li> <3c4ce9dc.ADsAAHQt4TAAAAAAAAAAAAO1C4gAAAACwQwAAAAAAAW9WABY94gc@mailjet.com> <87lgqu3zkk.fsf@gnu.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEAAJVJo-W0AAAAAAAAAAAO3ApAAAAACwQwAAAAAAAW9WABY-kgyrdhX0DEDQGOISZg179KxzQAFgUc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 26500-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > I agree with the comments, though I also think this shouldn’t block the > patch or drive nee away. :-) Ok, pushed with changes! From unknown Sat Sep 13 11:54:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 May 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator