From unknown Sat Sep 13 07:33:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26498: [PATCH] scripts: lint: Fix Guile build warning. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Apr 2017 13:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26498 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 26498@debbugs.gnu.org Cc: Mathieu Othacehe X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14921754932463 (code B ref -1); Fri, 14 Apr 2017 13:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Apr 2017 13:11:33 +0000 Received: from localhost ([127.0.0.1]:46615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz10f-0000de-HF for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz10d-0000dS-Tc for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz10X-00059U-D0 for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cz10X-00059O-9C for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz10W-0006Pq-9r for guix-patches@gnu.org; Fri, 14 Apr 2017 09:11:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz10T-00056L-3v for guix-patches@gnu.org; Fri, 14 Apr 2017 09:11:24 -0400 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:35840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cz10S-00055r-Rr for guix-patches@gnu.org; Fri, 14 Apr 2017 09:11:21 -0400 Received: by mail-wr0-x22d.google.com with SMTP id c55so50861360wrc.3 for ; Fri, 14 Apr 2017 06:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MYIJxns99Jf0IcgoRUu8N+hE/6dLkz3M38OQWcCcxjE=; b=LKsla18U3ZyPj/MO+ZXypuzbBuiK/LxyiNuldgI3g4XiwlNtwNVck2DSsKygPByYFR 1TJULqJI1fQKQj5e6VbnYBtydR8H34v3SIXdNDdfVjvYXa5Kth1eAz172+2BKwiUNfF9 K0LvTXinR84UEIrc/wgtHKaFSU09yclJe1PomEY+OPW8MtThtCRx/jW7EuHWWop9Yiwm OJ6Q1ip1iMVxj9lo76PJIxex/4BfgU9+Som29wCfwI1Bgmaf+A9ae4YzMQII5do8Nxrk KWnrTlBk8Bj76ciK3wxrYPAjjmCd9ndic4gdT8LT+34XmCRKyWUo5UML0TPVH8LXAvru PtEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MYIJxns99Jf0IcgoRUu8N+hE/6dLkz3M38OQWcCcxjE=; b=HMAh6L40MGiVCvlqs5dj2+OB7G+7Cf7nXNem8v/u5GaLuluvJyNw8AK8NuIf0NV7di fflNJOK/00FpTtXvx+AhdMh7WlUX4b2MGsZDZ9JAv1mdfF8LrafiWtfBJkve7u+YOMLa gRUaFgqFmRm+X+9AuJ25yG/rZRM1whhBn8ADRN8Nq0qZ0VqOuUMjblyjWwdvE7Tqt/vn C6ERLtl5uRiWvdNRkBGos+d8k7S7fwaqzBbiq0xXcWjSs2hNua6EgU8XZa9mEVodCeyk xdyTb4Goyysx5hFm/7zUSF2VjkQMtNwOLpcZAePKCoIaMBlmdJ5KYS5RGWU5mL+/717q d+HQ== X-Gm-Message-State: AN3rC/7owNm9YyR3uQ/GJxWoPAtg2SXAHXmGImBZrOWchI22bOsA8P0Q B26M1ebJ+eUPiw== X-Received: by 10.223.148.230 with SMTP id 93mr8237234wrr.34.1492175479813; Fri, 14 Apr 2017 06:11:19 -0700 (PDT) Received: from cervin.8.8.8.8 (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id w16sm1820866wmd.0.2017.04.14.06.11.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 06:11:18 -0700 (PDT) From: Mathieu Othacehe Date: Fri, 14 Apr 2017 15:11:13 +0200 Message-Id: <20170414131113.831-1-m.othacehe@gmail.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * guix/scripts/lint.scm (warn-if-package-has-input): Put (_ message) in let, to avoid the following warning : guix/scripts/lint.scm:251:37: warning: non-literal format string --- guix/scripts/lint.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 811f16706..1105dc418 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2016 Danny Milosavljevic ;;; Copyright © 2016 Hartmut Goebel ;;; Copyright © 2017 Alex Kost +;;; Copyright © 2017 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -245,10 +246,13 @@ by two spaces; possible infraction~p at ~{~a~^, ~}") (package-name package) (if (> (length output) 0) (string-append ":" (car output)) - "")))) + ""))) + ;; Putting tr-msg in let prevents from this + ;; Guile warning: "non-literal format string". + (tr-msg (_ message))) (when (member input input-names) (emit-warning linted - (format #f (_ message) input) + (format #f tr-msg input) 'inputs-to-check))))) packages outputs)))) -- 2.12.2 From unknown Sat Sep 13 07:33:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mathieu Othacehe Subject: bug#26498: closed (Re: bug#26498: [PATCH] scripts: lint: Fix Guile build warning.) Message-ID: References: <87inm4pstr.fsf@gnu.org> <20170414131113.831-1-m.othacehe@gmail.com> X-Gnu-PR-Message: they-closed 26498 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 26498@debbugs.gnu.org Date: Sun, 16 Apr 2017 10:10:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1492337402-11864-1" This is a multi-part message in MIME format... ------------=_1492337402-11864-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #26498: [PATCH] scripts: lint: Fix Guile build warning. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 26498@debbugs.gnu.org. --=20 26498: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26498 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1492337402-11864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 26498-done) by debbugs.gnu.org; 16 Apr 2017 10:09:40 +0000 Received: from localhost ([127.0.0.1]:49779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czh7k-00034h-Br for submit@debbugs.gnu.org; Sun, 16 Apr 2017 06:09:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1czh7i-00034T-Nq for 26498-done@debbugs.gnu.org; Sun, 16 Apr 2017 06:09:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1czh7Y-0005xz-Ll for 26498-done@debbugs.gnu.org; Sun, 16 Apr 2017 06:09:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1czh7Y-0005va-I8; Sun, 16 Apr 2017 06:09:28 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:60332 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1czh7T-0001pq-KD; Sun, 16 Apr 2017 06:09:24 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mathieu Othacehe Subject: Re: bug#26498: [PATCH] scripts: lint: Fix Guile build warning. References: <20170414131113.831-1-m.othacehe@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 27 Germinal an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sun, 16 Apr 2017 12:09:20 +0200 In-Reply-To: <20170414131113.831-1-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Fri, 14 Apr 2017 15:11:13 +0200") Message-ID: <87inm4pstr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26498-done Cc: 26498-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi Mathieu, Mathieu Othacehe skribis: > * guix/scripts/lint.scm (warn-if-package-has-input): Put (_ message) > in let, to avoid the following warning : > > guix/scripts/lint.scm:251:37: warning: non-literal format string > --- > guix/scripts/lint.scm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm > index 811f16706..1105dc418 100644 > --- a/guix/scripts/lint.scm > +++ b/guix/scripts/lint.scm > @@ -6,6 +6,7 @@ > ;;; Copyright =C2=A9 2016 Danny Milosavljevic > ;;; Copyright =C2=A9 2016 Hartmut Goebel > ;;; Copyright =C2=A9 2017 Alex Kost > +;;; Copyright =C2=A9 2017 Mathieu Othacehe > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -245,10 +246,13 @@ by two spaces; possible infraction~p at ~{~a~^, ~}") > (package-name package) > (if (> (length output) 0) > (string-append ":" (car output)) > - "")))) > + ""))) > + ;; Putting tr-msg in let prevents from this > + ;; Guile warning: "non-literal format string". > + (tr-msg (_ message))) > (when (member input input-names) > (emit-warning linted > - (format #f (_ message) input) > + (format #f tr-msg input) Not OK. :-) The warning is expected here, it warns about a real issue, which is that we=E2=80=99re passing a non-literal format string. I fixed it by decoupling the computational from the UI part in commit 1730c5b509c236a948b5a91ae6b7063384c1eee6. Thanks, Ludo=E2=80=99. ------------=_1492337402-11864-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Apr 2017 13:11:33 +0000 Received: from localhost ([127.0.0.1]:46615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz10f-0000de-HF for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz10d-0000dS-Tc for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz10X-00059U-D0 for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cz10X-00059O-9C for submit@debbugs.gnu.org; Fri, 14 Apr 2017 09:11:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz10W-0006Pq-9r for guix-patches@gnu.org; Fri, 14 Apr 2017 09:11:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz10T-00056L-3v for guix-patches@gnu.org; Fri, 14 Apr 2017 09:11:24 -0400 Received: from mail-wr0-x22d.google.com ([2a00:1450:400c:c0c::22d]:35840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cz10S-00055r-Rr for guix-patches@gnu.org; Fri, 14 Apr 2017 09:11:21 -0400 Received: by mail-wr0-x22d.google.com with SMTP id c55so50861360wrc.3 for ; Fri, 14 Apr 2017 06:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MYIJxns99Jf0IcgoRUu8N+hE/6dLkz3M38OQWcCcxjE=; b=LKsla18U3ZyPj/MO+ZXypuzbBuiK/LxyiNuldgI3g4XiwlNtwNVck2DSsKygPByYFR 1TJULqJI1fQKQj5e6VbnYBtydR8H34v3SIXdNDdfVjvYXa5Kth1eAz172+2BKwiUNfF9 K0LvTXinR84UEIrc/wgtHKaFSU09yclJe1PomEY+OPW8MtThtCRx/jW7EuHWWop9Yiwm OJ6Q1ip1iMVxj9lo76PJIxex/4BfgU9+Som29wCfwI1Bgmaf+A9ae4YzMQII5do8Nxrk KWnrTlBk8Bj76ciK3wxrYPAjjmCd9ndic4gdT8LT+34XmCRKyWUo5UML0TPVH8LXAvru PtEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=MYIJxns99Jf0IcgoRUu8N+hE/6dLkz3M38OQWcCcxjE=; b=HMAh6L40MGiVCvlqs5dj2+OB7G+7Cf7nXNem8v/u5GaLuluvJyNw8AK8NuIf0NV7di fflNJOK/00FpTtXvx+AhdMh7WlUX4b2MGsZDZ9JAv1mdfF8LrafiWtfBJkve7u+YOMLa gRUaFgqFmRm+X+9AuJ25yG/rZRM1whhBn8ADRN8Nq0qZ0VqOuUMjblyjWwdvE7Tqt/vn C6ERLtl5uRiWvdNRkBGos+d8k7S7fwaqzBbiq0xXcWjSs2hNua6EgU8XZa9mEVodCeyk xdyTb4Goyysx5hFm/7zUSF2VjkQMtNwOLpcZAePKCoIaMBlmdJ5KYS5RGWU5mL+/717q d+HQ== X-Gm-Message-State: AN3rC/7owNm9YyR3uQ/GJxWoPAtg2SXAHXmGImBZrOWchI22bOsA8P0Q B26M1ebJ+eUPiw== X-Received: by 10.223.148.230 with SMTP id 93mr8237234wrr.34.1492175479813; Fri, 14 Apr 2017 06:11:19 -0700 (PDT) Received: from cervin.8.8.8.8 (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id w16sm1820866wmd.0.2017.04.14.06.11.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 06:11:18 -0700 (PDT) From: Mathieu Othacehe To: guix-patches@gnu.org Subject: [PATCH] scripts: lint: Fix Guile build warning. Date: Fri, 14 Apr 2017 15:11:13 +0200 Message-Id: <20170414131113.831-1-m.othacehe@gmail.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * guix/scripts/lint.scm (warn-if-package-has-input): Put (_ message) in let, to avoid the following warning : guix/scripts/lint.scm:251:37: warning: non-literal format string --- guix/scripts/lint.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index 811f16706..1105dc418 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2016 Danny Milosavljevic ;;; Copyright © 2016 Hartmut Goebel ;;; Copyright © 2017 Alex Kost +;;; Copyright © 2017 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -245,10 +246,13 @@ by two spaces; possible infraction~p at ~{~a~^, ~}") (package-name package) (if (> (length output) 0) (string-append ":" (car output)) - "")))) + ""))) + ;; Putting tr-msg in let prevents from this + ;; Guile warning: "non-literal format string". + (tr-msg (_ message))) (when (member input input-names) (emit-warning linted - (format #f (_ message) input) + (format #f tr-msg input) 'inputs-to-check))))) packages outputs)))) -- 2.12.2 ------------=_1492337402-11864-1--