From unknown Sat Sep 13 00:38:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26495: [PATCH] cargo-build-system: Remove store reference. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 14 Apr 2017 10:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26495 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 26495@debbugs.gnu.org Cc: Mathieu Othacehe X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149216479912070 (code B ref -1); Fri, 14 Apr 2017 10:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Apr 2017 10:13:19 +0000 Received: from localhost ([127.0.0.1]:46479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyyEA-00038c-SM for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyyE9-00038P-AD for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyyE3-0005Ou-7m for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cyyE3-0005Oj-56 for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyyE1-0000pC-V4 for guix-patches@gnu.org; Fri, 14 Apr 2017 06:13:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyyDy-0005JK-M4 for guix-patches@gnu.org; Fri, 14 Apr 2017 06:13:09 -0400 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:36265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cyyDy-0005IS-GT for guix-patches@gnu.org; Fri, 14 Apr 2017 06:13:06 -0400 Received: by mail-wr0-x235.google.com with SMTP id c55so48905644wrc.3 for ; Fri, 14 Apr 2017 03:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SxZSLxSk/vPB5ySiZFaOzB0X4Oar7xSJ4GrMbBXyJnU=; b=oL7H1pYlPAf2oh0NZrTxx1cu8fO49RAbxdwNAC59eeNGmhtxqfFdClgnt8spDB3QVp hi6h6vk4OUnigZvvxn5sK68Hfy4FzlV5cHrVmphBHuxx54StcghoCURyxpZCnaGK174B 6KWL1vQd0IYVoZTv+OC+npMwizA35od/KAKzRzDhEIe6cIWmiLVg3M+w/K0s6w/mGW/b jBvzEKnvSEUJYKNyIQyVq/hCHWs7eyuVp1fw4U1zHK3zJvyaF4PaabURkGfVXNG97s7/ 72JHqXWhGZe5ahH3JJ3MdhxQEZjcdt5ApLlBpFSfKVviYw78I+XSkD8y3Dv86bf1dfGy eagQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SxZSLxSk/vPB5ySiZFaOzB0X4Oar7xSJ4GrMbBXyJnU=; b=LNg+tbTSYCUbcd2qVtHdpO4OTvNc5+MN974E7Z3yCrDzGRrsqTj+aQmnUFErwSijLL cFY5l2YFDhWjIk0hL+iNU7Ely1xlUlySrSSOTSkunsQjRIx4v3oKOR4aWJ84figC+UTg PTLFsgNcC6NpNeoXqqQjH6ve8FwgusWzMbQbsBO+dB9bKWv/HkqHun8ZeoeudeCZ8nSY UlmlBkX96aBVNE0vACasn7aia341GVaC8egD+Tn/KnIv45IYBCB2p1aVriK7oPzdTC7z bJoWByG5QiXMh0D5SNidUfksioeDfucIcKcumMslDB6/laU4mzDb1mmUbfq6mSwOwKOX +SoA== X-Gm-Message-State: AN3rC/7g/WSXpVUg9GlHb1W8vryS+PVIwXk7Q0Gr7RTTHIKvw3DV3hHz Sbq8LGFWMFAmBA== X-Received: by 10.223.163.17 with SMTP id c17mr6549066wrb.186.1492164785540; Fri, 14 Apr 2017 03:13:05 -0700 (PDT) Received: from cervin.8.8.8.8 (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id 21sm1766319wrb.55.2017.04.14.03.13.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 03:13:04 -0700 (PDT) From: Mathieu Othacehe Date: Fri, 14 Apr 2017 12:12:56 +0200 Message-Id: <20170414101256.27380-1-m.othacehe@gmail.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * guix/build/cargo-build-system.scm (generate-checksums): Remove store reference from comment. This comment was matching assert-no-store-file-names regexp in Makefile.am. Also, edit procedure docstring to precise that DIR-NAME is a store directory. --- guix/build/cargo-build-system.scm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm index f11d85874..139b40321 100644 --- a/guix/build/cargo-build-system.scm +++ b/guix/build/cargo-build-system.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2016 David Craven +;;; Copyright © 2017 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -116,12 +117,12 @@ directory = '" port) (close-pipe port) result))) -;; Example dir-name: "/gnu/store/hwlr49riz3la33m6in2n898ly045ylld-rust-rand-0.3.15". (define (generate-checksums dir-name src-name) - "Given DIR-NAME, checksum all the files in it one by one and put the - result into the file \".cargo-checksum.json\" in the same directory. - Also includes the checksum of an extra file SRC-NAME as if it was - part of the directory DIR-NAME with name \"package\"." + "Given DIR-NAME, a store directory, checksum all the files in it one +by one and put the result into the file \".cargo-checksum.json\" in +the same directory. Also includes the checksum of an extra file +SRC-NAME as if it was part of the directory DIR-NAME with name +\"package\"." (let* ((file-names (find-files dir-name ".")) (dir-prefix-name (string-append dir-name "/")) (dir-prefix-name-len (string-length dir-prefix-name)) -- 2.12.2 From unknown Sat Sep 13 00:38:29 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mathieu Othacehe Subject: bug#26495: closed (Re: bug#26495: [PATCH] cargo-build-system: Remove store reference.) Message-ID: References: <8737dbgued.fsf@gnu.org> <20170414101256.27380-1-m.othacehe@gmail.com> X-Gnu-PR-Message: they-closed 26495 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 26495@debbugs.gnu.org Date: Fri, 14 Apr 2017 10:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1492165442-13183-1" This is a multi-part message in MIME format... ------------=_1492165442-13183-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #26495: [PATCH] cargo-build-system: Remove store reference. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 26495@debbugs.gnu.org. --=20 26495: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26495 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1492165442-13183-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 26495-done) by debbugs.gnu.org; 14 Apr 2017 10:23:35 +0000 Received: from localhost ([127.0.0.1]:46513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyyO6-0003Pv-RA for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:23:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyyO4-0003Pi-Jb for 26495-done@debbugs.gnu.org; Fri, 14 Apr 2017 06:23:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyyNw-0002CG-BN for 26495-done@debbugs.gnu.org; Fri, 14 Apr 2017 06:23:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50250) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyyNw-0002C3-7X; Fri, 14 Apr 2017 06:23:24 -0400 Received: from [193.50.110.181] (port=32780 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cyyNv-0004cs-Ll; Fri, 14 Apr 2017 06:23:23 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Mathieu Othacehe Subject: Re: bug#26495: [PATCH] cargo-build-system: Remove store reference. References: <20170414101256.27380-1-m.othacehe@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Germinal an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Fri, 14 Apr 2017 12:23:22 +0200 In-Reply-To: <20170414101256.27380-1-m.othacehe@gmail.com> (Mathieu Othacehe's message of "Fri, 14 Apr 2017 12:12:56 +0200") Message-ID: <8737dbgued.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26495-done Cc: 26495-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Mathieu Othacehe skribis: > * guix/build/cargo-build-system.scm (generate-checksums): Remove store > reference from comment. This comment was matching > assert-no-store-file-names regexp in Makefile.am. > Also, edit procedure docstring to precise that DIR-NAME is a store > directory. Applied, thanks! Ludo=E2=80=99. ------------=_1492165442-13183-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Apr 2017 10:13:19 +0000 Received: from localhost ([127.0.0.1]:46479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyyEA-00038c-SM for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyyE9-00038P-AD for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyyE3-0005Ou-7m for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40716) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cyyE3-0005Oj-56 for submit@debbugs.gnu.org; Fri, 14 Apr 2017 06:13:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44065) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyyE1-0000pC-V4 for guix-patches@gnu.org; Fri, 14 Apr 2017 06:13:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyyDy-0005JK-M4 for guix-patches@gnu.org; Fri, 14 Apr 2017 06:13:09 -0400 Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:36265) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cyyDy-0005IS-GT for guix-patches@gnu.org; Fri, 14 Apr 2017 06:13:06 -0400 Received: by mail-wr0-x235.google.com with SMTP id c55so48905644wrc.3 for ; Fri, 14 Apr 2017 03:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SxZSLxSk/vPB5ySiZFaOzB0X4Oar7xSJ4GrMbBXyJnU=; b=oL7H1pYlPAf2oh0NZrTxx1cu8fO49RAbxdwNAC59eeNGmhtxqfFdClgnt8spDB3QVp hi6h6vk4OUnigZvvxn5sK68Hfy4FzlV5cHrVmphBHuxx54StcghoCURyxpZCnaGK174B 6KWL1vQd0IYVoZTv+OC+npMwizA35od/KAKzRzDhEIe6cIWmiLVg3M+w/K0s6w/mGW/b jBvzEKnvSEUJYKNyIQyVq/hCHWs7eyuVp1fw4U1zHK3zJvyaF4PaabURkGfVXNG97s7/ 72JHqXWhGZe5ahH3JJ3MdhxQEZjcdt5ApLlBpFSfKVviYw78I+XSkD8y3Dv86bf1dfGy eagQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=SxZSLxSk/vPB5ySiZFaOzB0X4Oar7xSJ4GrMbBXyJnU=; b=LNg+tbTSYCUbcd2qVtHdpO4OTvNc5+MN974E7Z3yCrDzGRrsqTj+aQmnUFErwSijLL cFY5l2YFDhWjIk0hL+iNU7Ely1xlUlySrSSOTSkunsQjRIx4v3oKOR4aWJ84figC+UTg PTLFsgNcC6NpNeoXqqQjH6ve8FwgusWzMbQbsBO+dB9bKWv/HkqHun8ZeoeudeCZ8nSY UlmlBkX96aBVNE0vACasn7aia341GVaC8egD+Tn/KnIv45IYBCB2p1aVriK7oPzdTC7z bJoWByG5QiXMh0D5SNidUfksioeDfucIcKcumMslDB6/laU4mzDb1mmUbfq6mSwOwKOX +SoA== X-Gm-Message-State: AN3rC/7g/WSXpVUg9GlHb1W8vryS+PVIwXk7Q0Gr7RTTHIKvw3DV3hHz Sbq8LGFWMFAmBA== X-Received: by 10.223.163.17 with SMTP id c17mr6549066wrb.186.1492164785540; Fri, 14 Apr 2017 03:13:05 -0700 (PDT) Received: from cervin.8.8.8.8 (85-169-37-239.rev.numericable.fr. [85.169.37.239]) by smtp.gmail.com with ESMTPSA id 21sm1766319wrb.55.2017.04.14.03.13.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 03:13:04 -0700 (PDT) From: Mathieu Othacehe To: guix-patches@gnu.org Subject: [PATCH] cargo-build-system: Remove store reference. Date: Fri, 14 Apr 2017 12:12:56 +0200 Message-Id: <20170414101256.27380-1-m.othacehe@gmail.com> X-Mailer: git-send-email 2.12.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * guix/build/cargo-build-system.scm (generate-checksums): Remove store reference from comment. This comment was matching assert-no-store-file-names regexp in Makefile.am. Also, edit procedure docstring to precise that DIR-NAME is a store directory. --- guix/build/cargo-build-system.scm | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm index f11d85874..139b40321 100644 --- a/guix/build/cargo-build-system.scm +++ b/guix/build/cargo-build-system.scm @@ -1,5 +1,6 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2016 David Craven +;;; Copyright © 2017 Mathieu Othacehe ;;; ;;; This file is part of GNU Guix. ;;; @@ -116,12 +117,12 @@ directory = '" port) (close-pipe port) result))) -;; Example dir-name: "/gnu/store/hwlr49riz3la33m6in2n898ly045ylld-rust-rand-0.3.15". (define (generate-checksums dir-name src-name) - "Given DIR-NAME, checksum all the files in it one by one and put the - result into the file \".cargo-checksum.json\" in the same directory. - Also includes the checksum of an extra file SRC-NAME as if it was - part of the directory DIR-NAME with name \"package\"." + "Given DIR-NAME, a store directory, checksum all the files in it one +by one and put the result into the file \".cargo-checksum.json\" in +the same directory. Also includes the checksum of an extra file +SRC-NAME as if it was part of the directory DIR-NAME with name +\"package\"." (let* ((file-names (find-files dir-name ".")) (dir-prefix-name (string-append dir-name "/")) (dir-prefix-name-len (string-length dir-prefix-name)) -- 2.12.2 ------------=_1492165442-13183-1--