GNU bug report logs - #26492
[PATCH] gnu: emacs-company: Enable tests.

Previous Next

Package: guix-patches;

Reported by: Arun Isaac <arunisaac <at> systemreboot.net>

Date: Fri, 14 Apr 2017 08:17:01 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26492 in the body.
You can then email your comments to 26492 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#26492; Package guix-patches. (Fri, 14 Apr 2017 08:17:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Arun Isaac <arunisaac <at> systemreboot.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 14 Apr 2017 08:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH] gnu: emacs-company: Enable tests.
Date: Fri, 14 Apr 2017 13:46:09 +0530

* gnu/packages/emacs.scm (emacs-company)[arguments]: Add a 'check' phase.
---
 gnu/packages/emacs.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 71058136a..976ea31e0 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2088,6 +2088,18 @@ build jobs.")
         (base32
          "1fyrpchpdmvszssy1qmsw41aqpv6q5rybvs1bw00nv9xdhiaq4vh"))))
     (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'install 'check
+           (lambda _
+             ;; The company-files-candidates-normal-root test looks
+             ;; for the /bin directory, but the build environment has
+             ;; no /bin directory. Modify the test to look for the
+             ;; /tmp directory.
+             (substitute* "test/files-tests.el"
+               (("/bin/") "/tmp/"))
+             (zero? (system* "make" "test-batch")))))))
     (home-page "http://company-mode.github.io/")
     (synopsis "Modular text completion framework")
     (description
-- 
2.12.2
Information forwarded to guix-patches <at> gnu.org:
bug#26492; Package guix-patches. (Fri, 14 Apr 2017 10:25:02 GMT) Full text and rfc822 format available.

Message #8 received at 26492 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 26492 <at> debbugs.gnu.org
Subject: Re: bug#26492: [PATCH] gnu: emacs-company: Enable tests.
Date: Fri, 14 Apr 2017 12:24:34 +0200

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> * gnu/packages/emacs.scm (emacs-company)[arguments]: Add a 'check' phase.

LGTM, thanks!

Ludo’.
Reply sent to Arun Isaac <arunisaac <at> systemreboot.net>:
You have taken responsibility. (Fri, 14 Apr 2017 12:48:02 GMT) Full text and rfc822 format available.
Notification sent to Arun Isaac <arunisaac <at> systemreboot.net>:
bug acknowledged by developer. (Fri, 14 Apr 2017 12:48:02 GMT) Full text and rfc822 format available.

Message #13 received at 26492-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 26492-done <at> debbugs.gnu.org
Subject: Re: bug#26492: [PATCH] gnu: emacs-company: Enable tests.
Date: Fri, 14 Apr 2017 18:17:20 +0530

Pushed!
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 13 May 2017 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 8 years and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.