GNU bug report logs - #26490
25.1; package-buffer-info is incorrectly case-insensitive

Previous Next

Full log

Message #8 received at 26490 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Steve Purcell <steve <at> sanityinc.com>
Cc: 26490 <at> debbugs.gnu.org
Subject: Re: bug#26490: 25.1;
 package-buffer-info is incorrectly case-insensitive
Date: Fri, 14 Apr 2017 10:31:05 +0300

> From: Steve Purcell <steve <at> sanityinc.com>
> Date: Fri, 14 Apr 2017 12:44:24 +1200
> 
> `package-buffer-info' looks for an "filename.el ends here" comment line,
> where "filename.el" matches that provided on the first line of the
> file. However, it does not set `case-fold-search' to nil explicitly, and
> so will happily allow "FiLeNaMe.EL" in the trailing line.
> 
> I rely on this function in package-lint to detect certain issues with
> packaging, and noticed this failure there. I can work around it by
> unsetting `case-fold-search', but this seems the wrong fix.

Why do you think it would be wrong for you in your special use case to
bind case-fold-search to nil?  I think it's exactly the right
solution.

> A simple patch is attached.

What about Emacs running on case-insensitive filesystems?  What will
your patch do in that case?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.