GNU bug report logs - #26490
25.1; package-buffer-info is incorrectly case-insensitive

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 26490 <at> debbugs.gnu.org, Steve Purcell <steve <at> sanityinc.com>
Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive
Date: Wed, 02 Oct 2019 00:54:38 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> I've attached a patch which I believe would do this in a reasonable way.

Sorry, I haven't followed the discussion, but I have a minor nit:

> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el
> index ef0c5171de..5601e4d630 100644
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -1046,10 +1046,12 @@ package-buffer-info
>    (let ((file-name (match-string-no-properties 1))
>          (desc      (match-string-no-properties 2))
>          (start     (line-beginning-position)))
> -    ;; The terminating comment format could be extended to accept a
> -    ;; generic string that is not in English.
> +    ;; This warning was added in Emacs 27.1, and should be removed at
> +    ;; the earliest in version 31.1.  The idea is to phase out the
> +    ;; requirement for a "footer line" without unduly impacting users
> +    ;; on earlier Emacs versions.  See Bug#26490 for more details.
>      (unless (search-forward (concat ";;; " file-name ".el ends here"))
> -      (error "Package lacks a terminating comment"))
> +      (warn "Package lacks a terminating comment"))

Shouldn't this be (lwarn 'package ...) or similar?
(See, for example, the call to lwarn in package-initialize.)

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.