From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Steve Purcell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2017 00:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 26490@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149213072317317 (code B ref -1); Fri, 14 Apr 2017 00:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Apr 2017 00:45:23 +0000 Received: from localhost ([127.0.0.1]:46277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cypMY-0004VF-LU for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cypMW-0004V3-UM for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cypMQ-0002jV-MI for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cypMQ-0002jJ-Ii for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cypMP-0006uV-6H for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 20:45:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cypMM-0002hF-3H for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 20:45:13 -0400 Received: from purcellpeople.com ([85.214.32.38]:45312 helo=h1189701.stratoserver.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cypML-0002cY-Q5 for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 20:45:10 -0400 Received: from Mandala.local (unknown [219.88.237.154]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id C304127AC002 for ; Fri, 14 Apr 2017 02:44:28 +0200 (CEST) User-agent: mu4e 0.9.17; emacs 25.1.1 From: Steve Purcell Message-ID: Date: Fri, 14 Apr 2017 12:44:24 +1200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain `package-buffer-info' looks for an "filename.el ends here" comment line, where "filename.el" matches that provided on the first line of the file. However, it does not set `case-fold-search' to nil explicitly, and so will happily allow "FiLeNaMe.EL" in the trailing line. I rely on this function in package-lint to detect certain issues with packaging, and noticed this failure there. I can work around it by unsetting `case-fold-search', but this seems the wrong fix. A simple patch is attached. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-package.el-make-explicit-the-case-sensitivity-of-pac.patch Content-Description: patch >From bfa9b23e6b4ef030e36fdcf5c15cef15fb01074a Mon Sep 17 00:00:00 2001 From: Steve Purcell Date: Fri, 14 Apr 2017 12:38:17 +1200 Subject: [PATCH] package.el: make explicit the case sensitivity of package-buffer-info --- lisp/emacs-lisp/package.el | 63 +++++++++++++++++++++++----------------------- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 6728f1b80b1..d6ca14b135c 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -995,37 +995,38 @@ package-buffer-info error. If there is a package, narrow the buffer to the file's boundaries." (goto-char (point-min)) - (unless (re-search-forward "^;;; \\([^ ]*\\)\\.el ---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-[ \t]*\\)?$" nil t) - (error "Package lacks a file header")) - (let ((file-name (match-string-no-properties 1)) - (desc (match-string-no-properties 2)) - (start (line-beginning-position))) - (unless (search-forward (concat ";;; " file-name ".el ends here")) - (error "Package lacks a terminating comment")) - ;; Try to include a trailing newline. - (forward-line) - (narrow-to-region start (point)) - (require 'lisp-mnt) - ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) - ;; Prefer Package-Version; if defined, the package author - ;; probably wants us to use it. Otherwise try Version. - (pkg-version - (or (package-strip-rcs-id (lm-header "package-version")) - (package-strip-rcs-id (lm-header "version")))) - (homepage (lm-homepage))) - (unless pkg-version - (error - "Package lacks a \"Version\" or \"Package-Version\" header")) - (package-desc-from-define - file-name pkg-version desc - (if requires-str - (package--prepare-dependencies - (package-read-from-string requires-str))) - :kind 'single - :url homepage - :maintainer (lm-maintainer) - :authors (lm-authors))))) + (let ((case-fold-search nil)) + (unless (re-search-forward "^;;; \\([^ ]*\\)\\.el ---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-[ \t]*\\)?$" nil t) + (error "Package lacks a file header")) + (let ((file-name (match-string-no-properties 1)) + (desc (match-string-no-properties 2)) + (start (line-beginning-position))) + (unless (search-forward (concat ";;; " file-name ".el ends here")) + (error "Package lacks a terminating comment")) + ;; Try to include a trailing newline. + (forward-line) + (narrow-to-region start (point)) + (require 'lisp-mnt) + ;; Use some headers we've invented to drive the process. + (let* ((requires-str (lm-header "package-requires")) + ;; Prefer Package-Version; if defined, the package author + ;; probably wants us to use it. Otherwise try Version. + (pkg-version + (or (package-strip-rcs-id (lm-header "package-version")) + (package-strip-rcs-id (lm-header "version")))) + (homepage (lm-homepage))) + (unless pkg-version + (error + "Package lacks a \"Version\" or \"Package-Version\" header")) + (package-desc-from-define + file-name pkg-version desc + (if requires-str + (package--prepare-dependencies + (package-read-from-string requires-str))) + :kind 'single + :url homepage + :maintainer (lm-maintainer) + :authors (lm-authors)))))) (defun package--read-pkg-desc (kind) "Read a `define-package' form in current buffer. -- 2.12.2 --=-=-= Content-Type: text/plain In GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2016-09-21 built on builder10-9.porkrind.org Windowing system distributor 'Apple', version 10.3.1504 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US locale-coding-system: utf-8 --=-=-=-- From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2017 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Steve Purcell Cc: 26490@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.149215505028869 (code B ref 26490); Fri, 14 Apr 2017 07:31:02 +0000 Received: (at 26490) by debbugs.gnu.org; 14 Apr 2017 07:30:50 +0000 Received: from localhost ([127.0.0.1]:46387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyvgw-0007VY-EQ for submit@debbugs.gnu.org; Fri, 14 Apr 2017 03:30:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyvgv-0007VK-3S for 26490@debbugs.gnu.org; Fri, 14 Apr 2017 03:30:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyvgn-0006VI-0F for 26490@debbugs.gnu.org; Fri, 14 Apr 2017 03:30:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyvgm-0006VC-St; Fri, 14 Apr 2017 03:30:40 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1707 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cyvgm-0007Fw-4J; Fri, 14 Apr 2017 03:30:40 -0400 Date: Fri, 14 Apr 2017 10:31:05 +0300 Message-Id: <83pogfh2di.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Steve Purcell on Fri, 14 Apr 2017 12:44:24 +1200) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Steve Purcell > Date: Fri, 14 Apr 2017 12:44:24 +1200 > > `package-buffer-info' looks for an "filename.el ends here" comment line, > where "filename.el" matches that provided on the first line of the > file. However, it does not set `case-fold-search' to nil explicitly, and > so will happily allow "FiLeNaMe.EL" in the trailing line. > > I rely on this function in package-lint to detect certain issues with > packaging, and noticed this failure there. I can work around it by > unsetting `case-fold-search', but this seems the wrong fix. Why do you think it would be wrong for you in your special use case to bind case-fold-search to nil? I think it's exactly the right solution. > A simple patch is attached. What about Emacs running on case-insensitive filesystems? What will your patch do in that case? Thanks. From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Steve Purcell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2017 09:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 26490@debbugs.gnu.org Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.14921611856685 (code B ref 26490); Fri, 14 Apr 2017 09:14:01 +0000 Received: (at 26490) by debbugs.gnu.org; 14 Apr 2017 09:13:05 +0000 Received: from localhost ([127.0.0.1]:46449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyxHt-0001jl-HH for submit@debbugs.gnu.org; Fri, 14 Apr 2017 05:13:05 -0400 Received: from purcellpeople.com ([85.214.32.38]:42966 helo=h1189701.stratoserver.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyxHs-0001jF-2l for 26490@debbugs.gnu.org; Fri, 14 Apr 2017 05:13:04 -0400 Received: from [192.168.0.11] (unknown [219.88.237.154]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id E1B6027AC0AD; Fri, 14 Apr 2017 11:12:53 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) From: Steve Purcell In-Reply-To: <83pogfh2di.fsf@gnu.org> Date: Fri, 14 Apr 2017 21:12:47 +1200 Content-Transfer-Encoding: quoted-printable Message-Id: <06F852EE-C021-40D9-A345-1726CDAFD79E@sanityinc.com> References: <83pogfh2di.fsf@gnu.org> X-Mailer: Apple Mail (2.3273) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I=E2=80=99m going to bind case-fold-search to nil in my case anyway, but = I don=E2=80=99t think you want a situation in which the case of the = first and last lines differ, simply for the sake of consistency: = that=E2=80=99s all that this patch ensures, and it=E2=80=99s orthogonal = to filesystem case-sensitivity. (Further, in package-lint, the intention is to check that the filenames = on those lines exactly match the elisp buffer's filename, if any, and = the name of the provided feature. Those comparisons should always be = case-sensitive, I would think, because the elisp file could be taken = from a local case-insensitive FS to a case-sensitive FS, and mismatches = would presumably cause issues.) From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Apr 2017 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Steve Purcell Cc: 26490@debbugs.gnu.org Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.14922018074677 (code B ref 26490); Fri, 14 Apr 2017 20:31:02 +0000 Received: (at 26490) by debbugs.gnu.org; 14 Apr 2017 20:30:07 +0000 Received: from localhost ([127.0.0.1]:47513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz7r5-0001DN-HJ for submit@debbugs.gnu.org; Fri, 14 Apr 2017 16:30:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cz7r4-0001Bw-HF for 26490@debbugs.gnu.org; Fri, 14 Apr 2017 16:30:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cz7qy-0002Kp-Cf for 26490@debbugs.gnu.org; Fri, 14 Apr 2017 16:30:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cz7qm-0002Fd-Ei; Fri, 14 Apr 2017 16:29:48 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1cz7ql-00068B-VB; Fri, 14 Apr 2017 16:29:48 -0400 From: Glenn Morris References: X-Spook: Aladdin Coast Guard Incident BART diwn JUWTF Mole Armed X-Ran: 5eNQblxco;\{3[P7?*@K2.EFD.2vsw)LT\*~p<1?NO..Gb,ONh)Ke*h=hR@Q&ovtePY(.g X-Hue: green X-Attribution: GM Date: Fri, 14 Apr 2017 16:29:47 -0400 In-Reply-To: (Steve Purcell's message of "Fri, 14 Apr 2017 12:44:24 +1200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Steve Purcell wrote: > `package-buffer-info' looks for an "filename.el ends here" comment line, > where "filename.el" matches that provided on the first line of the > file. Why does it care at all? I thought the "filename ends here" was an ancient way of identifying files that might have been truncated in transit. It doesn't seem relevant in this day and age. And if that is what it's for, why should the case of the filename matter? So long as some "ends here" line is there, the file is ok. From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Steve Purcell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Apr 2017 17:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris , 26490@debbugs.gnu.org Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.14924492668048 (code B ref 26490); Mon, 17 Apr 2017 17:15:01 +0000 Received: (at 26490) by debbugs.gnu.org; 17 Apr 2017 17:14:26 +0000 Received: from localhost ([127.0.0.1]:52776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0AEM-00025i-3M for submit@debbugs.gnu.org; Mon, 17 Apr 2017 13:14:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0AEK-00025V-Qq for 26490@debbugs.gnu.org; Mon, 17 Apr 2017 13:14:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d0AEE-0004T4-UA for 26490@debbugs.gnu.org; Mon, 17 Apr 2017 13:14:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48314) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d0AEE-0004Sl-Px for 26490@debbugs.gnu.org; Mon, 17 Apr 2017 13:14:18 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1d0AEE-00084R-Fp for 26490@debbugs.gnu.org; Mon, 17 Apr 2017 13:14:18 -0400 Resent-Message-ID: <22772.63466.356252.450224@gnu.org> Resent-Date: Mon, 17 Apr 2017 13:14:18 -0400 Resent-From: Glenn Morris Resent-To: 26490@debbugs.gnu.org Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) References: In-Reply-To: Message-Id: <177B8B98-A006-426B-B215-60E63997CD4E@sanityinc.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] Date: Sat, 15 Apr 2017 11:02:48 +1200 From: Steve Purcell X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Why does it care at all? > I thought the "filename ends here" was an ancient way of identifying > files that might have been truncated in transit. It doesn't seem > relevant in this day and age. > And if that is what it's for, why should the case of the filename = matter? > So long as some "ends here" line is there, the file is ok. Nonetheless, it has been part of the format expected by package.el for = years. Making package.el more permissive over time can lead to problems with = packages in older Emacsen, a prime example being the recently-added = backwards-incompatible support for version-less dependencies in the = `Package-Requires` header: authors check their packages in a recent = Emacs and then find that an older otherwise-compatible Emacs can=E2=80=99t= even parse their package metadata.= From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive References: In-Reply-To: Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2019 05:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Glenn Morris Cc: 26490@debbugs.gnu.org, Steve Purcell Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.15666262468147 (code B ref 26490); Sat, 24 Aug 2019 05:58:01 +0000 Received: (at 26490) by debbugs.gnu.org; 24 Aug 2019 05:57:26 +0000 Received: from localhost ([127.0.0.1]:41500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1P3F-00027L-QA for submit@debbugs.gnu.org; Sat, 24 Aug 2019 01:57:26 -0400 Received: from mail-pg1-f171.google.com ([209.85.215.171]:38423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1P3E-000279-2X for 26490@debbugs.gnu.org; Sat, 24 Aug 2019 01:57:24 -0400 Received: by mail-pg1-f171.google.com with SMTP id e11so7041846pga.5 for <26490@debbugs.gnu.org>; Fri, 23 Aug 2019 22:57:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=DT8skMPZsP6F1e2xy5hnIUmeFN0avkCEE0vlwu6Eji0=; b=jIP99yt1d+MRASSCFSka+Ns4O4/HApxdwZsjkV1p3+pRVJaxb99ptfMly9A0HI7jSx Gmc8zvZg1jLpZ0s4Zen7cL3SzlWEGNKOge6yG6sSUuIp7nybCLFxC4BOIbRzzbIRkPhc GKR2/v09v5xP8UQmQiKb29nIssjuY6L9/vyMAGAgyENoIBbjEUfQ0HYYpLBny+9V40ds xxaTZTa+0LEHJqytp9BvPiKJUnuVY27Q4imNyxHIP+Zr6+/Yew3SdFBNruqCSVDtZnMG zJ9BJD0JG2aPzcDqxONG2jFWsvNeumczeTSZRlo+TVDYKszkb6G8jf0XaMfi8rqwH15c JosA== X-Gm-Message-State: APjAAAWEzTjKoNqWuBqgr5E0meiiKpGxse7vTPxVDbsAK8Ibw6TwxFHn lbKq2IDmuj3OuLFjA5YqEtpehGfjgJ7d4YNgujU= X-Google-Smtp-Source: APXvYqwqdeEut/Gjf6aSg0gNsv6N3azvsPkJloJmaVQxygzgl3U8XyJljntJKsbFrIwHGIoCVDKO+IMVtSwxqqR0PIg= X-Received: by 2002:a63:4c5c:: with SMTP id m28mr7362064pgl.333.1566626238103; Fri, 23 Aug 2019 22:57:18 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Sat, 24 Aug 2019 07:57:06 +0200 Message-ID: Content-Type: multipart/mixed; boundary="0000000000006b2bf60590d69890" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --0000000000006b2bf60590d69890 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Glenn Morris writes: > Why does it care at all? > I thought the "filename ends here" was an ancient way of identifying > files that might have been truncated in transit. It doesn't seem > relevant in this day and age. I agree; this is an ancient ritual from times long past. I suggest that we get rid of this requirement to consider a package valid. I think this requirement, while not the most important thing in the world, just looks Very Old (TM) to new developers looking to get started in Emacs Lisp. And since it indeed hardly plays an important role anymore, we have little to lose by getting rid of it, AFAIU. Steve Purcell writes: > Nonetheless, it has been part of the format expected by package.el for ye= ars. > > Making package.el more permissive over time can lead to problems with pac= kages > in older Emacsen, a prime example being the recently-added > backwards-incompatible support for version-less dependencies in the > `Package-Requires` header: authors check their packages in a recent Emacs= and > then find that an older otherwise-compatible Emacs can=E2=80=99t even par= se their > package metadata. Sure, that can be a problem. I think that means that we should not (yet) encourage package developers to not use them in their packages. But if we don't take a first step, we can never get rid of it. At the end of the day, it's the job of package developers to maintain backwards compatibility. I don't see why this change would be any different in that respect from the many other changes that we make between releases. I have attached a tentative patch to remove this requirement from package.el. Comments are more than welcome. Thanks, Stefan Kangas --0000000000006b2bf60590d69890 Content-Type: application/octet-stream; name="0001-Don-t-require-ending-comment-to-consider-a-package-v.patch" Content-Disposition: attachment; filename="0001-Don-t-require-ending-comment-to-consider-a-package-v.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzp4j5qx0 RnJvbSBiMWJhMjQ3N2JlOTg1NTk1YmYyN2E1NjkwODdmYWJjM2JkYmExNThkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBTYXQsIDI0IEF1ZyAyMDE5IDA3OjQ0OjAwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g RG9uJ3QgcmVxdWlyZSBlbmRpbmcgY29tbWVudCB0byBjb25zaWRlciBhIHBhY2thZ2UgdmFsaWQK CiogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgKHBhY2thZ2UtYnVmZmVyLWluZm8pOiBEb24n dCByZXF1aXJlCnRoZSBlbmRpbmcgY29tbWVudCAiOzs7IGZvby1wYWNrYWdlLmVsIGVuZHMgaGVy ZSIuICAoQnVnIzI2NDkwKQotLS0KIGxpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIHwgNCAtLS0t CiAxIGZpbGUgY2hhbmdlZCwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2VtYWNz LWxpc3AvcGFja2FnZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCmluZGV4IGNkMTI3 ZTFhOGUuLmM2YTNmMzA0NTIgMTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVs CisrKyBiL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsCkBAIC0xMDQ1LDEwICsxMDQ1LDYgQEAg cGFja2FnZS1idWZmZXItaW5mbwogICAobGV0ICgoZmlsZS1uYW1lIChtYXRjaC1zdHJpbmctbm8t cHJvcGVydGllcyAxKSkKICAgICAgICAgKGRlc2MgICAgICAobWF0Y2gtc3RyaW5nLW5vLXByb3Bl cnRpZXMgMikpCiAgICAgICAgIChzdGFydCAgICAgKGxpbmUtYmVnaW5uaW5nLXBvc2l0aW9uKSkp Ci0gICAgOzsgVGhlIHRlcm1pbmF0aW5nIGNvbW1lbnQgZm9ybWF0IGNvdWxkIGJlIGV4dGVuZGVk IHRvIGFjY2VwdCBhCi0gICAgOzsgZ2VuZXJpYyBzdHJpbmcgdGhhdCBpcyBub3QgaW4gRW5nbGlz aC4KLSAgICAodW5sZXNzIChzZWFyY2gtZm9yd2FyZCAoY29uY2F0ICI7OzsgIiBmaWxlLW5hbWUg Ii5lbCBlbmRzIGhlcmUiKSkKLSAgICAgIChlcnJvciAiUGFja2FnZSBsYWNrcyBhIHRlcm1pbmF0 aW5nIGNvbW1lbnQiKSkKICAgICA7OyBUcnkgdG8gaW5jbHVkZSBhIHRyYWlsaW5nIG5ld2xpbmUu CiAgICAgKGZvcndhcmQtbGluZSkKICAgICAobmFycm93LXRvLXJlZ2lvbiBzdGFydCAocG9pbnQp KQotLSAKMi4yMi4wCgo= --0000000000006b2bf60590d69890-- From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Steve Purcell Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2019 06:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 26490@debbugs.gnu.org Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.156662854911768 (code B ref 26490); Sat, 24 Aug 2019 06:36:01 +0000 Received: (at 26490) by debbugs.gnu.org; 24 Aug 2019 06:35:49 +0000 Received: from localhost ([127.0.0.1]:41519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1PeO-00033k-Pv for submit@debbugs.gnu.org; Sat, 24 Aug 2019 02:35:49 -0400 Received: from mail.purcellpeople.com ([85.214.32.38]:60092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1PeL-00033V-W6 for 26490@debbugs.gnu.org; Sat, 24 Aug 2019 02:35:47 -0400 Received: from [192.168.1.198] (122-57-139-164-adsl.sparkbb.co.nz [122.57.139.164]) by mail.purcellpeople.com (Postfix) with ESMTPSA id 6388F61E7E; Sat, 24 Aug 2019 08:35:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=sanityinc.com; s=default; t=1566628539; bh=24usaoUj2fZa2AlzLDiB2BPhm64FLe1QknBDIU4OHVE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=YpbLdYmGexM81Nlvns02MD0+7ZYmmb5xODY76IgMJYu3eM62SecumI/pRVnJwT72U FKi9r/FnF3Ol1+3GhD+2gJwoRtN0URdQtdEC2+e5g+HJoc63G7xUa8nLJBHXmIGETc 0ZQk53JVBuQZ/vMDgjBV+0yb6SwxiwgMGwv9YzAY= Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) From: Steve Purcell In-Reply-To: Date: Sat, 24 Aug 2019 18:35:31 +1200 Content-Transfer-Encoding: quoted-printable Message-Id: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> References: X-Mailer: Apple Mail (2.3445.104.11) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On 24 Aug 2019, at 17:57, Stefan Kangas wrote: > Steve Purcell writes: >=20 >> Nonetheless, it has been part of the format expected by package.el = for years. >>=20 >> Making package.el more permissive over time can lead to problems with = packages >> in older Emacsen, a prime example being the recently-added >> backwards-incompatible support for version-less dependencies in the >> `Package-Requires` header: authors check their packages in a recent = Emacs and >> then find that an older otherwise-compatible Emacs can=E2=80=99t even = parse their >> package metadata. >=20 > Sure, that can be a problem. I think that means that we should not > (yet) encourage package developers to not use them in their packages. > But if we don't take a first step, we can never get rid of it. > At the end of the day, it's the job of package developers to maintain > backwards compatibility. I don't see why this change would be any > different in that respect from the many other changes that we make > between releases. My point is that if a package file can=E2=80=99t even be parsed by an = older Emacs version=E2=80=99s =E2=80=9Cpackage.el=E2=80=9D, the user of = that Emacs version will automatically get an obscure error when they try = to install it, even if the the package author was helpful enough to add = `(emacs =E2=80=9C27=E2=80=9D)` as a dependency to indicate = incompatibility. That=E2=80=99s not something that the package author = could reasonably foresee, and it feels avoidable by keeping the basic = structure of required metadata stable and backwards compatible.= From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Sep 2019 10:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Steve Purcell Cc: 26490@debbugs.gnu.org Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.15696681294106 (code B ref 26490); Sat, 28 Sep 2019 10:56:01 +0000 Received: (at 26490) by debbugs.gnu.org; 28 Sep 2019 10:55:29 +0000 Received: from localhost ([127.0.0.1]:49405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEANt-00014A-FG for submit@debbugs.gnu.org; Sat, 28 Sep 2019 06:55:29 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:40593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEANr-00013u-2l for 26490@debbugs.gnu.org; Sat, 28 Sep 2019 06:55:28 -0400 Received: by mail-pf1-f193.google.com with SMTP id x127so2940451pfb.7 for <26490@debbugs.gnu.org>; Sat, 28 Sep 2019 03:55:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xx2FVI5BjuhbRJgD02gshDVDAqNwTYWAkZk89oAoqRo=; b=AITCIkMjp0V7ubuXFmTlwx7RqpbqZr8p9zr9KkH3TblWVAfB57HYzB7FXuI+T5GhzY S2ttdO4rebPq40P6lZSdoLubpJVbjmyz4imWNgwMy7KTmwzgNv9BtS3idMY5jlE435dK nZzuJ2gK4S/Ec0EPTXFe9FFyrSbKbTEXvs5zSO3ZGjBfxbljGbeK6fZOpfeArs4H35Sh a58FyTVIAsgXSXZ4DoGu9KVUecgsMW9NV/jArowXCqlkxLNYcecK+Hb9ZybLlsJ9JQlk TdwcaFgBdaRMiCmzwuLoPQ79lAxxTI7I5kcxO6aTAPIljeO845ehnnwKS+qrg4jswmG9 i5WA== X-Gm-Message-State: APjAAAWeiALGOOsvAsbk8CqAJ8wG9hlR9dK6Ed/GJDW9Cacec0/jsCHb PaV4hhB1nSW2/PBsqB7wldE53LSE9J12bXqx51CJ9w== X-Google-Smtp-Source: APXvYqwFQO+rxXLRABr7a+q5SzF0f3Mb2fdSRJGJS5EdKumn5e5/dWVketA5O57wlgluJAA3EKhJU2YrtjnLsE0CnSM= X-Received: by 2002:a62:e917:: with SMTP id j23mr10023320pfh.50.1569668121087; Sat, 28 Sep 2019 03:55:21 -0700 (PDT) MIME-Version: 1.0 References: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> In-Reply-To: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> From: Stefan Kangas Date: Sat, 28 Sep 2019 12:55:09 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000c5eb1605939ad606" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000c5eb1605939ad606 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Steve Purcell writes: > >> Nonetheless, it has been part of the format expected by package.el for= years. > >> > >> Making package.el more permissive over time can lead to problems with = packages > >> in older Emacsen, a prime example being the recently-added > >> backwards-incompatible support for version-less dependencies in the > >> `Package-Requires` header: authors check their packages in a recent Em= acs and > >> then find that an older otherwise-compatible Emacs can=E2=80=99t even = parse their > >> package metadata. > > > > Sure, that can be a problem. I think that means that we should not > > (yet) encourage package developers to not use them in their packages. > > But if we don't take a first step, we can never get rid of it. > > > At the end of the day, it's the job of package developers to maintain > > backwards compatibility. I don't see why this change would be any > > different in that respect from the many other changes that we make > > between releases. > > My point is that if a package file can=E2=80=99t even be parsed by an old= er Emacs > version=E2=80=99s =E2=80=9Cpackage.el=E2=80=9D, the user of that Emacs ve= rsion will automatically get an > obscure error when they try to install it, even if the the package author= was > helpful enough to add `(emacs =E2=80=9C27=E2=80=9D)` as a dependency to i= ndicate > incompatibility. That=E2=80=99s not something that the package author cou= ld reasonably > foresee, and it feels avoidable by keeping the basic structure of require= d > metadata stable and backwards compatible. I see your point. How about issuing a warning instead? That should be sufficiently discouraging for package authors, while also allowing us to drop this requirement at some point in the future. I've attached a patch which I believe would do this in a reasonable way. Best regards, Stefan Kangas --000000000000c5eb1605939ad606 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-refuse-to-install-packages-without-a-footer-li.patch" Content-Disposition: attachment; filename="0001-Don-t-refuse-to-install-packages-without-a-footer-li.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k13ftshu0 RnJvbSA5YzQ5NjY2ZGM4NTcwMDBjODM4ZGI0YmVmZjY0YTNiMzQ4NGFhODEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDIwIFNlcCAyMDE5IDE5OjE4OjAzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g RG9uJ3QgcmVmdXNlIHRvIGluc3RhbGwgcGFja2FnZXMgd2l0aG91dCBhICJmb290ZXIgbGluZSIK CiogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgKHBhY2thZ2UtYnVmZmVyLWluZm8pOiBEb24n dCBzaWduYWwgYW4KZXJyb3Igd2hlbiB0aGUgImZvb3RlciBsaW5lIiBpcyBtaXNzaW5nLiAgV2Fy biBvbmx5LiAgKEJ1ZyMyNjQ5MCkKKiBldGMvTkVXUzogQW5ub3VuY2UgaXQuCi0tLQogZXRjL05F V1MgICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysrKysrKwogbGlzcC9lbWFjcy1saXNw L3BhY2thZ2UuZWwgfCAgOCArKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25z KCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5k ZXggZjgzMjIxMDRkNC4uMGNiYmY2ZTY5MyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRj L05FV1MKQEAgLTk0Miw2ICs5NDIsMjAgQEAgaXQgY2FuJ3QgZmluZCB0aGUgY29uZmlnIGZpbGUu CiAKICoqIFBhY2thZ2UKIAorKioqIFdhcm4gaWYgImZvb3RlciBsaW5lIiBpcyBtaXNzaW5nLCBi dXQgc3RpbGwgaW5zdGFsbCBwYWNrYWdlLgorcGFja2FnZS5lbCB1c2VkIHRvIHJlZnVzZSB0byBp bnN0YWxsIGEgcGFja2FnZSB3aXRob3V0IHRoZSBzby1jYWxsZWQKKyJmb290ZXIgbGluZSIsIHdo aWNoIGFwcGVhcnMgYXQgdGhlIHZlcnkgZW5kIG9mIHRoZSBmaWxlOgorCis7OzsgRklMRU5BTUUg ZW5kcyBoZXJlCisKK3BhY2thZ2UuZWwgd2lsbCBub3cgaW5zdGFsbCBwYWNrYWdlcyB3aXRob3V0 IHRoaXMgbGluZSwgYnV0IGl0IHdpbGwKK2lzc3VlIGEgd2FybmluZy4gIFRvIGF2b2lkIHRoaXMg d2FybmluZywgcGFja2FnZXMgc2hvdWxkIGtlZXAgdGhlCisiZm9vdGVyIGxpbmUiLgorCitOb3Rl IHRoYXQgdmVyc2lvbnMgb2YgRW1hY3Mgb2xkZXIgdGhhbiAyNy4xIHdpbGwgbm90IG9ubHkgcmVm dXNlIHRvCitpbnN0YWxsIHBhY2thZ2VzIHdpdGhvdXQgc3VjaCBhIGxpbmUgLS0gdGhleSB3aWxs IGJlIHVuYWJsZSB0byBwYXJzZQorcGFja2FnZSBkYXRhLiAgSXQgaXMgdGhlcmVmb3JlIHJlY29t bWVuZGVkIHRvIGtlZXAgdGhpcyBsaW5lLgorCiAqKiogQ2hhbmdlIG9mICdwYWNrYWdlLWNoZWNr LXNpZ25hdHVyZScgZm9yIHBhY2thZ2VzIHdpdGggbXVsdGlwbGUgc2lncwogSW4gcHJldmlvdXMg RW1hY3NlbiwgJ3QnIGNoZWNrZWQgdGhhdCBhbGwgc2lnbmF0dXJlcyBhcmUgdmFsaWQuCiBOb3cg J3QnIG9ubHkgY2hlY2tzIHRoYXQgYXQgbGVhc3Qgb25lIHNpZ25hdHVyZSBpcyB2YWxpZCBhbmQg dGhlIG5ldyAnYWxsJwpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgYi9s aXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbAppbmRleCBlZjBjNTE3MWRlLi41NjAxZTRkNjMwIDEw MDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbAorKysgYi9saXNwL2VtYWNzLWxp c3AvcGFja2FnZS5lbApAQCAtMTA0NiwxMCArMTA0NiwxMiBAQCBwYWNrYWdlLWJ1ZmZlci1pbmZv CiAgIChsZXQgKChmaWxlLW5hbWUgKG1hdGNoLXN0cmluZy1uby1wcm9wZXJ0aWVzIDEpKQogICAg ICAgICAoZGVzYyAgICAgIChtYXRjaC1zdHJpbmctbm8tcHJvcGVydGllcyAyKSkKICAgICAgICAg KHN0YXJ0ICAgICAobGluZS1iZWdpbm5pbmctcG9zaXRpb24pKSkKLSAgICA7OyBUaGUgdGVybWlu YXRpbmcgY29tbWVudCBmb3JtYXQgY291bGQgYmUgZXh0ZW5kZWQgdG8gYWNjZXB0IGEKLSAgICA7 OyBnZW5lcmljIHN0cmluZyB0aGF0IGlzIG5vdCBpbiBFbmdsaXNoLgorICAgIDs7IFRoaXMgd2Fy bmluZyB3YXMgYWRkZWQgaW4gRW1hY3MgMjcuMSwgYW5kIHNob3VsZCBiZSByZW1vdmVkIGF0Cisg ICAgOzsgdGhlIGVhcmxpZXN0IGluIHZlcnNpb24gMzEuMS4gIFRoZSBpZGVhIGlzIHRvIHBoYXNl IG91dCB0aGUKKyAgICA7OyByZXF1aXJlbWVudCBmb3IgYSAiZm9vdGVyIGxpbmUiIHdpdGhvdXQg dW5kdWx5IGltcGFjdGluZyB1c2VycworICAgIDs7IG9uIGVhcmxpZXIgRW1hY3MgdmVyc2lvbnMu ICBTZWUgQnVnIzI2NDkwIGZvciBtb3JlIGRldGFpbHMuCiAgICAgKHVubGVzcyAoc2VhcmNoLWZv cndhcmQgKGNvbmNhdCAiOzs7ICIgZmlsZS1uYW1lICIuZWwgZW5kcyBoZXJlIikpCi0gICAgICAo ZXJyb3IgIlBhY2thZ2UgbGFja3MgYSB0ZXJtaW5hdGluZyBjb21tZW50IikpCisgICAgICAod2Fy biAiUGFja2FnZSBsYWNrcyBhIHRlcm1pbmF0aW5nIGNvbW1lbnQiKSkKICAgICA7OyBUcnkgdG8g aW5jbHVkZSBhIHRyYWlsaW5nIG5ld2xpbmUuCiAgICAgKGZvcndhcmQtbGluZSkKICAgICAobmFy cm93LXRvLXJlZ2lvbiBzdGFydCAocG9pbnQpKQotLSAKMi4yMC4xCgo= --000000000000c5eb1605939ad606-- From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 23:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 26490@debbugs.gnu.org, Steve Purcell Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.15699740959796 (code B ref 26490); Tue, 01 Oct 2019 23:55:01 +0000 Received: (at 26490) by debbugs.gnu.org; 1 Oct 2019 23:54:55 +0000 Received: from localhost ([127.0.0.1]:35218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFRyp-0002Xw-8I for submit@debbugs.gnu.org; Tue, 01 Oct 2019 19:54:55 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:33373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFRyk-0002Xc-Tc for 26490@debbugs.gnu.org; Tue, 01 Oct 2019 19:54:54 -0400 Received: by mail-wm1-f41.google.com with SMTP id r17so3650915wme.0 for <26490@debbugs.gnu.org>; Tue, 01 Oct 2019 16:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=IB7isFdgeLEZ2y5biLVgRib+o3E3wvjQ7RI1H/P7/5M=; b=yF4nRhjV5NHZWn9hGiYSR0EmYZFggHZdciflaPSvdbXY5wj95GZJfHmip6FK7u62vf 41ug4O1OY+p9uuYpCvDKNzy2Q8/aYLP9IVRbqk1o3K1A9Lv6NRUNIE3sFNcjEPlQIrvx gvh5XVlPFZYyRKLW8K8/6RPPXcmC4qi90XFJAP5ZWoQ32KW0DDALMbkxNnR83HbBw/3n yhaAnKLQUMJbN0rXMibxP2mrj3OpQnDfirbukJojXStSQJqKWEMHIdkQyIEaY5T3LnP7 Spd1Q9+FwqskWopm9D18XGybfdVhf+RTHfTh2HZPOn0btjX9Q3WjIFVzfBVab4NYTpMz YADg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=IB7isFdgeLEZ2y5biLVgRib+o3E3wvjQ7RI1H/P7/5M=; b=Z6A6+9K4RF6p8QGcdlj6cetQh9rpjlBgJJM/5WlY496ci+fHfaXW5g8IwQGns+/kAr DZMLeXXwtWgUn1CZrFdjN5YZmiwmFdGHj5SClF2WUGIRJ3F6+p3MDVIe2a0fjmJerzb2 PS+PiG8qA8UvRaofx4p+9V78Ic7jxk2ouI1EJTlotKa5PEezKoaqN8/FfQ0ffPWxtz92 UhakIsaJURFRnxp9kKnW2MV5lt55JSb+sXedeZOAH5rqxmls4o7L7bQzd+HNREYPZls5 KQE6Vkdx8Z4r8Vtwvn7FdrI8daCXi+v9aq6dP+3CHLvYgbAlC3aRWOBo7lf9fgMEjP72 kGNQ== X-Gm-Message-State: APjAAAXeO4nkbTBoDYfRoV0b21YaZgNguv5+9wjaVCfZpeGyMBzd+WSm m4Xs+K/6+JPkifnunBUaihmPdw== X-Google-Smtp-Source: APXvYqxi4yc1kQ8hzzT+4dOHiI5o962tfnbPScqO6KGJiMvJz8zlSPdnJu7vhCJxJbOhFEgW3fnmdQ== X-Received: by 2002:a7b:cc97:: with SMTP id p23mr488112wma.154.1569974084905; Tue, 01 Oct 2019 16:54:44 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id d10sm5283131wma.42.2019.10.01.16.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2019 16:54:43 -0700 (PDT) From: "Basil L. Contovounesios" References: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> Date: Wed, 02 Oct 2019 00:54:38 +0100 In-Reply-To: (Stefan Kangas's message of "Sat, 28 Sep 2019 12:55:09 +0200") Message-ID: <87imp8dnsx.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I've attached a patch which I believe would do this in a reasonable way. Sorry, I haven't followed the discussion, but I have a minor nit: > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index ef0c5171de..5601e4d630 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -1046,10 +1046,12 @@ package-buffer-info > (let ((file-name (match-string-no-properties 1)) > (desc (match-string-no-properties 2)) > (start (line-beginning-position))) > - ;; The terminating comment format could be extended to accept a > - ;; generic string that is not in English. > + ;; This warning was added in Emacs 27.1, and should be removed at > + ;; the earliest in version 31.1. The idea is to phase out the > + ;; requirement for a "footer line" without unduly impacting users > + ;; on earlier Emacs versions. See Bug#26490 for more details. > (unless (search-forward (concat ";;; " file-name ".el ends here")) > - (error "Package lacks a terminating comment")) > + (warn "Package lacks a terminating comment")) Shouldn't this be (lwarn 'package ...) or similar? (See, for example, the call to lwarn in package-initialize.) Thanks, -- Basil From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Oct 2019 12:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Basil L. Contovounesios" Cc: 26490@debbugs.gnu.org, Steve Purcell Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.157019335311019 (code B ref 26490); Fri, 04 Oct 2019 12:50:02 +0000 Received: (at 26490) by debbugs.gnu.org; 4 Oct 2019 12:49:13 +0000 Received: from localhost ([127.0.0.1]:41826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGN1F-0002rf-6S for submit@debbugs.gnu.org; Fri, 04 Oct 2019 08:49:13 -0400 Received: from mail-pg1-f175.google.com ([209.85.215.175]:40527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGN1B-0002rQ-Jo for 26490@debbugs.gnu.org; Fri, 04 Oct 2019 08:49:10 -0400 Received: by mail-pg1-f175.google.com with SMTP id d26so3707394pgl.7 for <26490@debbugs.gnu.org>; Fri, 04 Oct 2019 05:49:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y/ZRutichCrAfrcyJBGJ88DWaVRlGRLTxIf5Ojj8xNk=; b=TtDuh+hVPaRbNltsobjX/EU4LU1D5fwLW71cFZgISIelUr7zeO/4chH5KQupgp3wBn lmM2B/Y2fwYndY92/kn/gpjAHElmFQw1Da1c3oUutY4C8K3RfRWw8OTYYvwt72rjdfed 58pbpKT8jfe/F1/Tr1CfGR2y2OqyhYNy3Etwr5EFZkTskKjA1I0JVG7OQWiFJd/cjmZ9 cPxD5Ne2a5QFfWaMRvCndKDXUTS+J9VZ+Nw8eq49wgfgXnUbKDBpxm/4vBtKq40L6TH+ NGjatkoduXktkOzMtK/7jZYfgozJ9a1MCA5G5SojY9taCZPNdakncrSmpVmkhYseL9wV bemQ== X-Gm-Message-State: APjAAAXMm1fpRwUHjeKKpD+INkXnKp/Ls2ThPD1jWGWXbOW9VV6W+rQl R55JFKctQ9ZtsCXNkMqCzL6X24v1m9Pr0Vr6Qls= X-Google-Smtp-Source: APXvYqycQxIsih1m5CQsemw/M7YD9DoNlNgD5m7voGn3SIELPyaWA23/LO0AkOagE0/6kZqDm92fNtlP2GtZwR8G+E0= X-Received: by 2002:a65:5802:: with SMTP id g2mr15965640pgr.333.1570193343597; Fri, 04 Oct 2019 05:49:03 -0700 (PDT) MIME-Version: 1.0 References: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> <87imp8dnsx.fsf@tcd.ie> In-Reply-To: <87imp8dnsx.fsf@tcd.ie> From: Stefan Kangas Date: Fri, 4 Oct 2019 14:48:51 +0200 Message-ID: Content-Type: multipart/mixed; boundary="0000000000007986570594152020" X-Spam-Score: 0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) --0000000000007986570594152020 Content-Type: text/plain; charset="UTF-8" Basil L. Contovounesios writes: > Shouldn't this be (lwarn 'package ...) or similar? > (See, for example, the call to lwarn in package-initialize.) Indeed, thanks. Fixed in the attached patch. Best regards, Stefan Kangas --0000000000007986570594152020 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Don-t-refuse-to-install-packages-without-a-footer-li.patch" Content-Disposition: attachment; filename="0001-Don-t-refuse-to-install-packages-without-a-footer-li.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1c4jj3u0 RnJvbSA4OTUzMjE1ZmI4M2I2YjQwYTEyYmY3ZTkyOTVjOGViZjNmZWJhZDc1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDIwIFNlcCAyMDE5IDE5OjE4OjAzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g RG9uJ3QgcmVmdXNlIHRvIGluc3RhbGwgcGFja2FnZXMgd2l0aG91dCBhICJmb290ZXIgbGluZSIK CiogbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwgKHBhY2thZ2UtYnVmZmVyLWluZm8pOiBEb24n dCBzaWduYWwgYW4KZXJyb3Igd2hlbiB0aGUgImZvb3RlciBsaW5lIiBpcyBtaXNzaW5nLiAgV2Fy biBvbmx5LiAgKEJ1ZyMyNjQ5MCkKKiBldGMvTkVXUzogQW5ub3VuY2UgaXQuCi0tLQogZXRjL05F V1MgICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysrKysrKwogbGlzcC9lbWFjcy1saXNw L3BhY2thZ2UuZWwgfCAgOSArKysrKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0aW9u cygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmlu ZGV4IGY4MzIyMTA0ZDQuLjBjYmJmNmU2OTMgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0 Yy9ORVdTCkBAIC05NDIsNiArOTQyLDIwIEBAIGl0IGNhbid0IGZpbmQgdGhlIGNvbmZpZyBmaWxl LgogCiAqKiBQYWNrYWdlCiAKKyoqKiBXYXJuIGlmICJmb290ZXIgbGluZSIgaXMgbWlzc2luZywg YnV0IHN0aWxsIGluc3RhbGwgcGFja2FnZS4KK3BhY2thZ2UuZWwgdXNlZCB0byByZWZ1c2UgdG8g aW5zdGFsbCBhIHBhY2thZ2Ugd2l0aG91dCB0aGUgc28tY2FsbGVkCisiZm9vdGVyIGxpbmUiLCB3 aGljaCBhcHBlYXJzIGF0IHRoZSB2ZXJ5IGVuZCBvZiB0aGUgZmlsZToKKworOzs7IEZJTEVOQU1F IGVuZHMgaGVyZQorCitwYWNrYWdlLmVsIHdpbGwgbm93IGluc3RhbGwgcGFja2FnZXMgd2l0aG91 dCB0aGlzIGxpbmUsIGJ1dCBpdCB3aWxsCitpc3N1ZSBhIHdhcm5pbmcuICBUbyBhdm9pZCB0aGlz IHdhcm5pbmcsIHBhY2thZ2VzIHNob3VsZCBrZWVwIHRoZQorImZvb3RlciBsaW5lIi4KKworTm90 ZSB0aGF0IHZlcnNpb25zIG9mIEVtYWNzIG9sZGVyIHRoYW4gMjcuMSB3aWxsIG5vdCBvbmx5IHJl ZnVzZSB0bworaW5zdGFsbCBwYWNrYWdlcyB3aXRob3V0IHN1Y2ggYSBsaW5lIC0tIHRoZXkgd2ls bCBiZSB1bmFibGUgdG8gcGFyc2UKK3BhY2thZ2UgZGF0YS4gIEl0IGlzIHRoZXJlZm9yZSByZWNv bW1lbmRlZCB0byBrZWVwIHRoaXMgbGluZS4KKwogKioqIENoYW5nZSBvZiAncGFja2FnZS1jaGVj ay1zaWduYXR1cmUnIGZvciBwYWNrYWdlcyB3aXRoIG11bHRpcGxlIHNpZ3MKIEluIHByZXZpb3Vz IEVtYWNzZW4sICd0JyBjaGVja2VkIHRoYXQgYWxsIHNpZ25hdHVyZXMgYXJlIHZhbGlkLgogTm93 ICd0JyBvbmx5IGNoZWNrcyB0aGF0IGF0IGxlYXN0IG9uZSBzaWduYXR1cmUgaXMgdmFsaWQgYW5k IHRoZSBuZXcgJ2FsbCcKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIv bGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKaW5kZXggZWYwYzUxNzFkZS4uMjk1ZWRjN2YzNyAx MDA2NDQKLS0tIGEvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKKysrIGIvbGlzcC9lbWFjcy1s aXNwL3BhY2thZ2UuZWwKQEAgLTEwNDYsMTAgKzEwNDYsMTMgQEAgcGFja2FnZS1idWZmZXItaW5m bwogICAobGV0ICgoZmlsZS1uYW1lIChtYXRjaC1zdHJpbmctbm8tcHJvcGVydGllcyAxKSkKICAg ICAgICAgKGRlc2MgICAgICAobWF0Y2gtc3RyaW5nLW5vLXByb3BlcnRpZXMgMikpCiAgICAgICAg IChzdGFydCAgICAgKGxpbmUtYmVnaW5uaW5nLXBvc2l0aW9uKSkpCi0gICAgOzsgVGhlIHRlcm1p bmF0aW5nIGNvbW1lbnQgZm9ybWF0IGNvdWxkIGJlIGV4dGVuZGVkIHRvIGFjY2VwdCBhCi0gICAg OzsgZ2VuZXJpYyBzdHJpbmcgdGhhdCBpcyBub3QgaW4gRW5nbGlzaC4KKyAgICA7OyBUaGlzIHdh cm5pbmcgd2FzIGFkZGVkIGluIEVtYWNzIDI3LjEsIGFuZCBzaG91bGQgYmUgcmVtb3ZlZCBhdAor ICAgIDs7IHRoZSBlYXJsaWVzdCBpbiB2ZXJzaW9uIDMxLjEuICBUaGUgaWRlYSBpcyB0byBwaGFz ZSBvdXQgdGhlCisgICAgOzsgcmVxdWlyZW1lbnQgZm9yIGEgImZvb3RlciBsaW5lIiB3aXRob3V0 IHVuZHVseSBpbXBhY3RpbmcgdXNlcnMKKyAgICA7OyBvbiBlYXJsaWVyIEVtYWNzIHZlcnNpb25z LiAgU2VlIEJ1ZyMyNjQ5MCBmb3IgbW9yZSBkZXRhaWxzLgogICAgICh1bmxlc3MgKHNlYXJjaC1m b3J3YXJkIChjb25jYXQgIjs7OyAiIGZpbGUtbmFtZSAiLmVsIGVuZHMgaGVyZSIpKQotICAgICAg KGVycm9yICJQYWNrYWdlIGxhY2tzIGEgdGVybWluYXRpbmcgY29tbWVudCIpKQorICAgICAgKGx3 YXJuICcocGFja2FnZSBwYWNrYWdlLWZvcm1hdCkgOndhcm5pbmcKKyAgICAgICAgICAgICAiUGFj a2FnZSBsYWNrcyBhIHRlcm1pbmF0aW5nIGNvbW1lbnQiKSkKICAgICA7OyBUcnkgdG8gaW5jbHVk ZSBhIHRyYWlsaW5nIG5ld2xpbmUuCiAgICAgKGZvcndhcmQtbGluZSkKICAgICAobmFycm93LXRv LXJlZ2lvbiBzdGFydCAocG9pbnQpKQotLSAKMi4yMC4xCgo= --0000000000007986570594152020-- From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Oct 2019 14:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Steve Purcell Cc: 26490@debbugs.gnu.org, Stefan Monnier Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.15715810396424 (code B ref 26490); Sun, 20 Oct 2019 14:18:01 +0000 Received: (at 26490) by debbugs.gnu.org; 20 Oct 2019 14:17:19 +0000 Received: from localhost ([127.0.0.1]:55073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMC1G-0001fV-KO for submit@debbugs.gnu.org; Sun, 20 Oct 2019 10:17:18 -0400 Received: from mail-pl1-f174.google.com ([209.85.214.174]:40586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMC1E-0001fG-DO for 26490@debbugs.gnu.org; Sun, 20 Oct 2019 10:17:16 -0400 Received: by mail-pl1-f174.google.com with SMTP id d22so5239241pll.7 for <26490@debbugs.gnu.org>; Sun, 20 Oct 2019 07:17:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lPiArlSk3simpPk5N/2V5imUmKPj6fbFGKO6So/DUFM=; b=AelEwcYTDwkzfm/MTQmVuH1SdcAm7+quYCdqAyqZGZUeFX7jOvzNOG5XISmTOLKzNS ErWl4p0pnlTKtl3s7ysHu/hVYzT3DXZ3HZHuinejpXALvz5fpcaTWtDXu2kEJRmWSpcv x+54XsxftYAlMH7Eov0oIwvyvMCXeQrvHyn9+kunpeXsfYoclqA8Qy0sZIuamHNSUFj6 QP+PUT2RBayxvo8p31Rkwn7xZ1JDQf3KGF5GB7vp6UQ+oUbLdszvIFjOTQX/5WbASpUj CQBGTJXVRZlzlm+O/bMLr/kmKPb5OQGl39oX7/mJ1Z2H1A9L8GCejdDeRRVE69KMVV0s Fr9g== X-Gm-Message-State: APjAAAUOOLtJ5dIED0YdG16FZge67eQUuB3zoWsVOj3L6LR4+6AbKZfk xqcFNclRN7hm6KCOBzfq8Kz1nJZsEqxrftXsRJI= X-Google-Smtp-Source: APXvYqwe6qmevChi3pwEAtXUrrNs8bMy9zf/i++kGs+YI638rwB/Y4/fSXwC7TEBQslLs9dPVuo0N8cGCQJRYUl+r4s= X-Received: by 2002:a17:902:6b88:: with SMTP id p8mr18677840plk.251.1571581030268; Sun, 20 Oct 2019 07:17:10 -0700 (PDT) MIME-Version: 1.0 References: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> In-Reply-To: From: Stefan Kangas Date: Sun, 20 Oct 2019 16:16:58 +0200 Message-ID: Content-Type: multipart/mixed; boundary="0000000000000beca3059558399d" X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --0000000000000beca3059558399d Content-Type: text/plain; charset="UTF-8" Stefan Kangas writes: > I see your point. How about issuing a warning instead? That should > be sufficiently discouraging for package authors, while also allowing > us to drop this requirement at some point in the future. > > I've attached a patch which I believe would do this in a reasonable way. Ping! Does anyone have any objections to this change, or any comments? I've attached the latest version of the patch. In summary, it makes it possible to install packages even if they are missing the terminating ";; foo.el ends here" line. Instead, we raise a warning for such packages. Best regards, Stefan Kangas --0000000000000beca3059558399d Content-Type: application/octet-stream; name="0001-Allow-installation-packages-without-a-footer-line.patch" Content-Disposition: attachment; filename="0001-Allow-installation-packages-without-a-footer-line.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1z2nfet0 RnJvbSBjYmFkOThmNGFjODAyOWUzODMyNTVmZjQ1Mzk1YjVhYTAxOTM1MzA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDIwIFNlcCAyMDE5IDE5OjE4OjAzICswMjAwClN1YmplY3Q6IFtQQVRDSF0g QWxsb3cgaW5zdGFsbGF0aW9uIHBhY2thZ2VzIHdpdGhvdXQgYSAiZm9vdGVyIGxpbmUiCgoqIGxp c3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIChwYWNrYWdlLWJ1ZmZlci1pbmZvKTogV2FybiBpbnN0 ZWFkIG9mCnNpZ25hbGluZyBhbiBlcnJvciB3aGVuIHRoZXJlIGlzIG5vICJmb290ZXIgbGluZSIu ICBUaGlzIGFsbG93cyBzdWNoCnBhY2thZ2VzIHRvIGJlIGluc3RhbGxlZC4gIChCdWcjMjY0OTAp CiogZXRjL05FV1M6IEFubm91bmNlIGl0LgotLS0KIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAg IHwgMTUgKysrKysrKysrKysrKysrCiBsaXNwL2VtYWNzLWxpc3AvcGFja2FnZS5lbCB8IDExICsr KysrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA0NmVkNDBkZmNiLi5h NDdjNjA5OGQ0IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMTAzMCw2 ICsxMDMwLDIxIEBAIGl0IGNhbid0IGZpbmQgdGhlIGNvbmZpZyBmaWxlLgogCiAqKiBQYWNrYWdl CiAKKyoqKiBBbGxvdyBpbnN0YWxsYXRpb24gb2YgcGFja2FnZXMgbWlzc2luZyBhICJmb290ZXIg bGluZSIuCitQcmV2aW91c2x5LCB0aGUgcGFja2FnZSBzeXN0ZW0gcmVmdXNlZCB0byBpbnN0YWxs IGEgcGFja2FnZSB3aXRob3V0Cit0aGUgc28tY2FsbGVkICJmb290ZXIgbGluZSIsIHdoaWNoIHNo b3VsZCBhcHBlYXIgYXQgdGhlIHZlcnkgZW5kIG9mCit0aGUgZmlsZToKKworOzs7IEZJTEVOQU1F IGVuZHMgaGVyZQorCitFbWFjcyB3aWxsIG5vdyBvbmx5IGlzc3VlIGEgd2FybmluZyBmb3Igc3Vj aCBwYWNrYWdlcy4gIFRvIGF2b2lkIHRoaXMKK3dhcm5pbmcsIHBhY2thZ2VzIHNob3VsZCBrZWVw IHRoZSAiZm9vdGVyIGxpbmUiLgorCitOb3RlIHRoYXQgdmVyc2lvbnMgb2YgRW1hY3Mgb2xkZXIg dGhhbiAyNy4xIHdpbGwgbm90IG9ubHkgcmVmdXNlIHRvCitpbnN0YWxsIHBhY2thZ2VzIHdpdGhv dXQgc3VjaCBhIGxpbmUgLS0gdGhleSB3aWxsIGJlIHVuYWJsZSB0byBwYXJzZQordGhlIHBhY2th Z2UgZGF0YS4gIEl0IGlzIHRoZXJlZm9yZSBzdHJvbmdseSByZWNvbW1lbmRlZCB0byBrZWVwIHRo aXMKK2xpbmUsIGV2ZW4gaWYgeW91ciBwYWNrYWdlIG9ubHkgc3VwcG9ydHMgRW1hY3MgMjcuMSBv ciBsYXRlci4KKwogKioqIENoYW5nZSBvZiAncGFja2FnZS1jaGVjay1zaWduYXR1cmUnIGZvciBw YWNrYWdlcyB3aXRoIG11bHRpcGxlIHNpZ3MKIEluIHByZXZpb3VzIEVtYWNzZW4sICd0JyBjaGVj a2VkIHRoYXQgYWxsIHNpZ25hdHVyZXMgYXJlIHZhbGlkLgogTm93ICd0JyBvbmx5IGNoZWNrcyB0 aGF0IGF0IGxlYXN0IG9uZSBzaWduYXR1cmUgaXMgdmFsaWQgYW5kIHRoZSBuZXcgJ2FsbCcKZGlm ZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9wYWNrYWdlLmVsIGIvbGlzcC9lbWFjcy1saXNwL3Bh Y2thZ2UuZWwKaW5kZXggMjA0NjIwNjRhZi4uNjljYTY1OGI4MSAxMDA2NDQKLS0tIGEvbGlzcC9l bWFjcy1saXNwL3BhY2thZ2UuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL3BhY2thZ2UuZWwKQEAg LTEwODIsMTAgKzEwODIsMTUgQEAgcGFja2FnZS1idWZmZXItaW5mbwogICAobGV0ICgoZmlsZS1u YW1lIChtYXRjaC1zdHJpbmctbm8tcHJvcGVydGllcyAxKSkKICAgICAgICAgKGRlc2MgICAgICAo bWF0Y2gtc3RyaW5nLW5vLXByb3BlcnRpZXMgMikpCiAgICAgICAgIChzdGFydCAgICAgKGxpbmUt YmVnaW5uaW5nLXBvc2l0aW9uKSkpCi0gICAgOzsgVGhlIHRlcm1pbmF0aW5nIGNvbW1lbnQgZm9y bWF0IGNvdWxkIGJlIGV4dGVuZGVkIHRvIGFjY2VwdCBhCi0gICAgOzsgZ2VuZXJpYyBzdHJpbmcg dGhhdCBpcyBub3QgaW4gRW5nbGlzaC4KKyAgICA7OyBCZWZvcmUgdmVyc2lvbiAyNy4xLCBpdCB3 YXMgbm90IHBvc3NpYmxlIHRvIGluc3RhbGwgcGFja2FnZXMKKyAgICA7OyB3aXRob3V0IGEgdGVy bWluYXRpbmcgY29tbWVudC4gIFdlIG5vdyBvbmx5IGlzc3VlIGEgd2FybmluZy4KKyAgICA7OyBU aGlzIHdhcm5pbmcgc2hvdWxkIHByb2JhYmx5IGJlIGFyb3VuZCB1bnRpbCBhdCBsZWFzdCBFbWFj cworICAgIDs7IHZlcnNpb24gMzIuMSBvciBzbywgb3IgcG9zc2libHkgbG9uZ2VyLiAgVGhlIGlk ZWEgaXMgdG8gcGhhc2UKKyAgICA7OyBvdXQgdGhlIHJlcXVpcmVtZW50IGZvciBhICJmb290ZXIg bGluZSIgd2l0aG91dCB1bmR1bHkKKyAgICA7OyBpbXBhY3RpbmcgdXNlcnMgb24gZWFybGllciBF bWFjcyB2ZXJzaW9ucy4gIChCdWcjMjY0OTApCiAgICAgKHVubGVzcyAoc2VhcmNoLWZvcndhcmQg KGNvbmNhdCAiOzs7ICIgZmlsZS1uYW1lICIuZWwgZW5kcyBoZXJlIikpCi0gICAgICAoZXJyb3Ig IlBhY2thZ2UgbGFja3MgYSB0ZXJtaW5hdGluZyBjb21tZW50IikpCisgICAgICAobHdhcm4gJyhw YWNrYWdlIHBhY2thZ2UtZm9ybWF0KSA6d2FybmluZworICAgICAgICAgICAgICJQYWNrYWdlIGxh Y2tzIGEgdGVybWluYXRpbmcgY29tbWVudCIpKQogICAgIDs7IFRyeSB0byBpbmNsdWRlIGEgdHJh aWxpbmcgbmV3bGluZS4KICAgICAoZm9yd2FyZC1saW5lKQogICAgIChuYXJyb3ctdG8tcmVnaW9u IHN0YXJ0IChwb2ludCkpCi0tIAoyLjIzLjAKCg== --0000000000000beca3059558399d-- From unknown Thu Sep 11 20:48:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Oct 2019 16:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 26490@debbugs.gnu.org, Steve Purcell Received: via spool by 26490-submit@debbugs.gnu.org id=B26490.157167397015996 (code B ref 26490); Mon, 21 Oct 2019 16:07:02 +0000 Received: (at 26490) by debbugs.gnu.org; 21 Oct 2019 16:06:10 +0000 Received: from localhost ([127.0.0.1]:57673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMaCA-00049w-0K for submit@debbugs.gnu.org; Mon, 21 Oct 2019 12:06:10 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMaC8-00049P-7d for 26490@debbugs.gnu.org; Mon, 21 Oct 2019 12:06:09 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EA9EF81E25; Mon, 21 Oct 2019 12:06:01 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id B8A1C81CC2; Mon, 21 Oct 2019 12:06:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1571673960; bh=JEJrv+X/21qBwxx8nw7lLZj6tlIAApOcN8UDmya+7B0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=mBYDQkypEjpI8dCh/drxwXYRSe6fTFZhNIV496WLRkvf1Akk2jRLH7a+LGE54xitI H2wrw3HYbMYOzWR6FaH9jADSe3NidfZpfVEHqHyRhj1OOfORoKzwtmw9pUsQIsW7ax M2reJjmxAtfS7TSXeXRK/fmRxpjiOJmy5mfvBLtmCxFCuyzYjkC0FmLZPc5ENRY6jl hDL618I+JGw2tgy0PTkpTdeBXB4uUA3Fw2iR1ttFMW0+jn4mhUQDhXrmZRRUCozRi0 RaLgi7e+DVM6ATBswVoJNAKdMiGouCKe/0iTg8z+N9L02tC1BiM3U9gzgKj6oi9MAO 8fHraPpejLVyw== Received: from alfajor (unknown [216.154.30.71]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7DB8A12041A; Mon, 21 Oct 2019 12:06:00 -0400 (EDT) From: Stefan Monnier Message-ID: References: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> Date: Mon, 21 Oct 2019 12:05:53 -0400 In-Reply-To: (Stefan Kangas's message of "Sun, 20 Oct 2019 16:16:58 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Ping! Does anyone have any objections to this change, or any > comments? I've attached the latest version of the patch. No objection on my side, Stefan From unknown Thu Sep 11 20:48:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Steve Purcell Subject: bug#26490: closed (Re: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive) Message-ID: References: X-Gnu-PR-Message: they-closed 26490 X-Gnu-PR-Package: emacs Reply-To: 26490@debbugs.gnu.org Date: Sat, 02 Nov 2019 00:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1572654722-29566-1" This is a multi-part message in MIME format... ------------=_1572654722-29566-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #26490: 25.1; package-buffer-info is incorrectly case-insensitive which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 26490@debbugs.gnu.org. --=20 26490: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D26490 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1572654722-29566-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 26490-done) by debbugs.gnu.org; 2 Nov 2019 00:31:29 +0000 Received: from localhost ([127.0.0.1]:57620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQhKC-0007HS-KY for submit@debbugs.gnu.org; Fri, 01 Nov 2019 20:31:28 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:46843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQhKA-0007Bf-UK for 26490-done@debbugs.gnu.org; Fri, 01 Nov 2019 20:31:27 -0400 Received: by mail-pl1-f177.google.com with SMTP id q21so5029493plr.13 for <26490-done@debbugs.gnu.org>; Fri, 01 Nov 2019 17:31:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FF6zODPa3rKqMWCyEW+yj59yVkqcorwPE5PNUiz91zk=; b=uh4+tWcfzKf3/TzXA7RavxvjO+iVREu63lkTNPsioEu+khtsoXn8EQqIMyaA37LOu7 jb11PRGnN5V17W5fwi0Iic94I0cnDNyTUOx9hiIzrldKxbkRxuZOyB6MW0U5FqTuU/9y zSqT5+1YUfK1+ohS5zeUbMpBkigcZgwSK42FuAMM7HdKrvcyNd0AenCLGXk3Afu9u0zj 4DTh/ukRfycC2GcKovgEOObSxavPFQ0nNGnrY9vlchZzaaQ5J3Cu6p73de7q5UM7sGhG /Eshs5x5ZgVniqk+M4FgzFdJVel1rNtoZLEeDbvTPvj9vcezZlPn95EcbH82DBGC0M/3 H82Q== X-Gm-Message-State: APjAAAUDDJnkSRTXwRj+yLHoR21HRAw1aQBhRjgCirFJsxuhFJb0sdLO 86Rr9pWF9fRePKSIixmbsgTeMhjKlRqS+L1isks= X-Google-Smtp-Source: APXvYqwdwKnn/D5XExWJPEClnkvn9PcCtE4UmKkWLiL5gdE6iORMWUttQofAPGHfPm5EPTR84qQDy360fiVD5h/bDLU= X-Received: by 2002:a17:902:d70b:: with SMTP id w11mr15665262ply.128.1572654681125; Fri, 01 Nov 2019 17:31:21 -0700 (PDT) MIME-Version: 1.0 References: <751C9864-CA4C-47AC-9CBF-43C676D40B00@sanityinc.com> In-Reply-To: From: Stefan Kangas Date: Sat, 2 Nov 2019 01:31:09 +0100 Message-ID: Subject: Re: bug#26490: 25.1; package-buffer-info is incorrectly case-insensitive To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 26490-done Cc: 26490-done@debbugs.gnu.org, Steve Purcell X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: > > > Ping! Does anyone have any objections to this change, or any > > comments? I've attached the latest version of the patch. > > No objection on my side, No other comments within 13 days, so I've now pushed the patch as commit 6297eb0fca. I'm consequently closing this bug. Best regards, Stefan Kangas ------------=_1572654722-29566-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Apr 2017 00:45:23 +0000 Received: from localhost ([127.0.0.1]:46277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cypMY-0004VF-LU for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46664) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cypMW-0004V3-UM for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cypMQ-0002jV-MI for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cypMQ-0002jJ-Ii for submit@debbugs.gnu.org; Thu, 13 Apr 2017 20:45:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cypMP-0006uV-6H for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 20:45:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cypMM-0002hF-3H for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 20:45:13 -0400 Received: from purcellpeople.com ([85.214.32.38]:45312 helo=h1189701.stratoserver.net) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cypML-0002cY-Q5 for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 20:45:10 -0400 Received: from Mandala.local (unknown [219.88.237.154]) by h1189701.stratoserver.net (Postfix) with ESMTPSA id C304127AC002 for ; Fri, 14 Apr 2017 02:44:28 +0200 (CEST) User-agent: mu4e 0.9.17; emacs 25.1.1 From: Steve Purcell To: bug-gnu-emacs@gnu.org Subject: 25.1; package-buffer-info is incorrectly case-insensitive Message-ID: Date: Fri, 14 Apr 2017 12:44:24 +1200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain `package-buffer-info' looks for an "filename.el ends here" comment line, where "filename.el" matches that provided on the first line of the file. However, it does not set `case-fold-search' to nil explicitly, and so will happily allow "FiLeNaMe.EL" in the trailing line. I rely on this function in package-lint to detect certain issues with packaging, and noticed this failure there. I can work around it by unsetting `case-fold-search', but this seems the wrong fix. A simple patch is attached. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-package.el-make-explicit-the-case-sensitivity-of-pac.patch Content-Description: patch >From bfa9b23e6b4ef030e36fdcf5c15cef15fb01074a Mon Sep 17 00:00:00 2001 From: Steve Purcell Date: Fri, 14 Apr 2017 12:38:17 +1200 Subject: [PATCH] package.el: make explicit the case sensitivity of package-buffer-info --- lisp/emacs-lisp/package.el | 63 +++++++++++++++++++++++----------------------- 1 file changed, 32 insertions(+), 31 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 6728f1b80b1..d6ca14b135c 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -995,37 +995,38 @@ package-buffer-info error. If there is a package, narrow the buffer to the file's boundaries." (goto-char (point-min)) - (unless (re-search-forward "^;;; \\([^ ]*\\)\\.el ---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-[ \t]*\\)?$" nil t) - (error "Package lacks a file header")) - (let ((file-name (match-string-no-properties 1)) - (desc (match-string-no-properties 2)) - (start (line-beginning-position))) - (unless (search-forward (concat ";;; " file-name ".el ends here")) - (error "Package lacks a terminating comment")) - ;; Try to include a trailing newline. - (forward-line) - (narrow-to-region start (point)) - (require 'lisp-mnt) - ;; Use some headers we've invented to drive the process. - (let* ((requires-str (lm-header "package-requires")) - ;; Prefer Package-Version; if defined, the package author - ;; probably wants us to use it. Otherwise try Version. - (pkg-version - (or (package-strip-rcs-id (lm-header "package-version")) - (package-strip-rcs-id (lm-header "version")))) - (homepage (lm-homepage))) - (unless pkg-version - (error - "Package lacks a \"Version\" or \"Package-Version\" header")) - (package-desc-from-define - file-name pkg-version desc - (if requires-str - (package--prepare-dependencies - (package-read-from-string requires-str))) - :kind 'single - :url homepage - :maintainer (lm-maintainer) - :authors (lm-authors))))) + (let ((case-fold-search nil)) + (unless (re-search-forward "^;;; \\([^ ]*\\)\\.el ---[ \t]*\\(.*?\\)[ \t]*\\(-\\*-.*-\\*-[ \t]*\\)?$" nil t) + (error "Package lacks a file header")) + (let ((file-name (match-string-no-properties 1)) + (desc (match-string-no-properties 2)) + (start (line-beginning-position))) + (unless (search-forward (concat ";;; " file-name ".el ends here")) + (error "Package lacks a terminating comment")) + ;; Try to include a trailing newline. + (forward-line) + (narrow-to-region start (point)) + (require 'lisp-mnt) + ;; Use some headers we've invented to drive the process. + (let* ((requires-str (lm-header "package-requires")) + ;; Prefer Package-Version; if defined, the package author + ;; probably wants us to use it. Otherwise try Version. + (pkg-version + (or (package-strip-rcs-id (lm-header "package-version")) + (package-strip-rcs-id (lm-header "version")))) + (homepage (lm-homepage))) + (unless pkg-version + (error + "Package lacks a \"Version\" or \"Package-Version\" header")) + (package-desc-from-define + file-name pkg-version desc + (if requires-str + (package--prepare-dependencies + (package-read-from-string requires-str))) + :kind 'single + :url homepage + :maintainer (lm-maintainer) + :authors (lm-authors)))))) (defun package--read-pkg-desc (kind) "Read a `define-package' form in current buffer. -- 2.12.2 --=-=-= Content-Type: text/plain In GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2016-09-21 built on builder10-9.porkrind.org Windowing system distributor 'Apple', version 10.3.1504 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules' Configured features: NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS MODULES Important settings: value of $LC_CTYPE: en_US.UTF-8 value of $LANG: en_US locale-coding-system: utf-8 --=-=-=-- ------------=_1572654722-29566-1--