Subject: Re: bug#26487: Add antlr3

From: [email-masked] (Ludovic Courtès)
Date: Mon, 08 May 2017 22:16:58 +0200

Hello!

Julien Lepiller <[email-masked]> skribis:

> Hi, I fixed the reproducibility issue by copying part of the
> ant-build-system in antlr2's recipe.
>
> From bc2eaf6e11cea60169f16c35ca052a67f83990af Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <[email-masked]>
> Date: Thu, 13 Apr 2017 20:18:15 +0200
> Subject: [PATCH 1/4] guix: ant-build-system: Add src-dir parameter.
>
> * guix/build-system/ant.scm (ant-build): Add src-dir parameter.
> * guix/build/ant-build-system.scm (configure): Add src-dir parameter.
> (default-build.xml): Use it.
> * doc/guix.texi: Document it.

[...]

> --- a/guix/build-system/ant.scm
> +++ b/guix/build-system/ant.scm
> @@ -98,6 +98,7 @@
>                      (make-flags ''())
>                      (build-target "jar")
>                      (jar-name #f)
> +                    (src-dir "src")

The general guideline (info "(guix) Formatting Code") is to use full
words as identifiers.  Could you change ‘src-dir’ to ‘source-directory’?
(In the code and .texi.)

Kei already OKayed the remaining patches and they look good to me too.

Thanks!

Ludo’.