From unknown Thu Sep 11 11:55:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26486 <26486@debbugs.gnu.org> To: bug#26486 <26486@debbugs.gnu.org> Subject: Status: 25.1.91; unused var warning from cconv.el can't be suppressed Reply-To: bug#26486 <26486@debbugs.gnu.org> Date: Thu, 11 Sep 2025 18:55:10 +0000 retitle 26486 25.1.91; unused var warning from cconv.el can't be suppressed reassign 26486 emacs submitter 26486 John Williams severity 26486 minor tag 26486 patch confirmed moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 15:12:07 2017 Received: (at submit) by debbugs.gnu.org; 13 Apr 2017 19:12:07 +0000 Received: from localhost ([127.0.0.1]:46023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cykA2-0001Vz-TR for submit@debbugs.gnu.org; Thu, 13 Apr 2017 15:12:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyjy1-0001CH-D7 for submit@debbugs.gnu.org; Thu, 13 Apr 2017 14:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyjxu-0007o8-Nw for submit@debbugs.gnu.org; Thu, 13 Apr 2017 14:59:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34573) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cyjxu-0007nu-Kh for submit@debbugs.gnu.org; Thu, 13 Apr 2017 14:59:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyjxt-0008CE-3I for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 14:59:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyjxr-0007lr-KD for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 14:59:33 -0400 Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:34337) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cyjxr-0007l5-BB for bug-gnu-emacs@gnu.org; Thu, 13 Apr 2017 14:59:31 -0400 Received: by mail-pf0-x234.google.com with SMTP id c198so32320280pfc.1 for ; Thu, 13 Apr 2017 11:59:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=JKznMpSeBppy1y4XymBWPICwQgT8vzExGCmUaD3A5K4=; b=YA88NepCFcRwQ9NK0xWt2JTvf5S4Nt22IRyVH1nz+OGTcs3FC/ixXso7crKkfCQmdo SXKLzxiIuxk+QfdMuLb/Pwly3DDQ5R/fhHeXg8LrkrNakno76G8Kfn+AW5n46Uax1TgK JyjuupCq09RVn/yF3OztrHveKTpdvcDTxVGdBUgq3kBZLb7L8V8loQGuTnJ2Hz5a3uwB 4xvJmVgUL6YA1WEVPA+h+kV4PiFmAj47qt5OlXYQDtS2US3r0Yqsi/RxQ1WHKq5E56sA VR2sp1lNB2vuZaRg3DvcHfxvJz7vb9ySG+aa4JwrBYn8FlTDmdDjccg3E6fb6FXQqGrT eEMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=JKznMpSeBppy1y4XymBWPICwQgT8vzExGCmUaD3A5K4=; b=IOpYwYl58KMYCjsFBR2Egkc/MXf2OPxz8cEL+sy8uom5RzaKKtxgXPgQCHcjL04idq 3VxVRafLq1KhmXFEZrwI+rjDBcVzkvYsSRkACpRYUqrQixalfvH6GXR6NQBmW+A95HuS 8qYSCat8035MEBn3Ewew74Ih9Srz/ikT1YKtgQ5aQcb7FWhcYgRflQTN5YkjGbIn00EW P95zY/Xd2a5rsZZZ8mSzcOdTgtVDMdhlph4Ih9oWvx4wNxsdnpJVzQ3gzRj5pwoZYFpy f/NQUAvWayqq7ECFNraIBL/38PBJ6pq/8DlOlqnuVDQkHYYNovVcLH2QoqEdlsS9v29J uOZA== X-Gm-Message-State: AN3rC/7Tdz+rnL3CVnAda21JN8x/fxfpNb9LSvEwkAVsmwxCt3SZPlTJ 4AXuB03Is8374SPmd8nN9VWjHQKHaBf0zt4= X-Received: by 10.98.76.140 with SMTP id e12mr4134589pfj.128.1492109969276; Thu, 13 Apr 2017 11:59:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.154.144 with HTTP; Thu, 13 Apr 2017 11:59:08 -0700 (PDT) From: John Williams Date: Thu, 13 Apr 2017 11:59:08 -0700 X-Google-Sender-Auth: 98GN_KenCL_kCefyLNQ9OfkqZWw Message-ID: Subject: 25.1.91; spurious warnings from cconv.el To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 13 Apr 2017 15:12:04 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) When I byte compile a file where a macro expansion introduces an unused lexical veriable, I get warnings from cconv.el, even if I wrap the expansion in (with-no-warnings) and set byte-compile-warnings to nil. IMHO warnings of this type should never be issued for code that comes from a macro expansion, but it should at least be possible to suppress them with the usual mechanisms. Here's a file that demonstrates the problem when it's compiled with byte-compile-file: ======================================================================== ;; -*- lexical-binding: t; byte-compile-warnings: nil -*- (defmacro test () `(let (unused))) (with-no-warnings (test)) ======================================================================== In GNU Emacs 25.1.91.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.8), modified by Debian Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: Ubuntu 14.04.5 LTS Configured using: 'configure --build x86_64-linux-gnu --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --enable-locallisppath=/etc/google-emacs:/etc/emacs:/usr/local/share/emacs/25.1.91+gg1+2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/25.1.91+gg1+2/site-lisp:/usr/share/emacs/site-lisp --with-crt-dir=/usr/lib/x86_64-linux-gnu --disable-build-details --disable-silent-rules --with-modules GOOGLE_VERSION=25.1.91+gg1+2 --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars build_alias=x86_64-linux-gnu 'CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-fuse-ld=gold,--export-dynamic-symbol=__google_auxv' 'CPPFLAGS=-D_FORTIFY_SOURCE=2 -DGOOGLE_EMACS_DEFINE_AUXV'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: nil Mark set nil Quit Type "q" in help window to restore its previous buffer. Undo! [22 times] Saving file /usr/local/google/home/jrw/homedir/test.el... Wrote /usr/local/google/home/jrw/homedir/test.el Compiling /usr/local/google/home/jrw/homedir/test.el...done Wrote /usr/local/google/home/jrw/homedir/test.elc Quit Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils byte-opt compile comint ansi-color ring warnings thingatpt help-fns bytecomp byte-compile cl-extra help-mode cl-loaddefs pcase cl-lib cconv vc-git diff-mode easymenu easy-mmode time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 105959 7747) (symbols 48 21355 0) (miscs 40 404 190) (strings 32 19965 4463) (string-bytes 1 608139) (vectors 16 14200) (vector-slots 8 469169 6038) (floats 8 184 167) (intervals 56 1103 0) (buffers 976 22) (heap 1024 30017 1036)) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 15:28:29 2017 Received: (at 26486) by debbugs.gnu.org; 13 Apr 2017 19:28:29 +0000 Received: from localhost ([127.0.0.1]:46046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cykPt-0003iS-5G for submit@debbugs.gnu.org; Thu, 13 Apr 2017 15:28:29 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:33544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cykPr-0003i3-Ev for 26486@debbugs.gnu.org; Thu, 13 Apr 2017 15:28:27 -0400 Received: by mail-oi0-f53.google.com with SMTP id b187so75810162oif.0 for <26486@debbugs.gnu.org>; Thu, 13 Apr 2017 12:28:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=t+/jtSdcylGxQl/7oquTl9VEEhe6D7tDLx58I/nlca0=; b=tImsBReM855v9yMO+e1IT6JKf5ZIZlBPR08zdHk90U4x7NoZQbShiTs3afdxetOE2r 2EEdMXZqD3buSaZ+2uiRaHwu8M/IMpiqxmZnGlwefyLVLevPbgV4wiwWEvc0NluOI33X yxaTrtv3S3n54KlnbulTUSV0h1qu1TLmfDn+B6xvFVLnpYS08nMYcaVg+s8gOFhKjDVT w55HqeHdPChofo8xVrokFRJaSjPrn4gdc+0pSq+fjdAP6ipWhlolp7/ZEjmHUvdJ6IBr SPEjnGFzNATzhmdQzS6X7XIs6+Ti/hZHIi/hMe6fwWOYIrdURc2VoX6X48kCte4p4qV7 7PQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=t+/jtSdcylGxQl/7oquTl9VEEhe6D7tDLx58I/nlca0=; b=HohL+KyUfDRX8o/iuWPxWwWqso3hr435Qg6A7mGWp09Rveq+g/RVimJdJziZTabsHZ x2t3nrk3D5TwpStyG/KGlI5IhBNdDhiHO0IB82dv683QQqCkJEWovTH9QUGBne/yXSNN 0syCfidf1gS9EZYUZfa9YiCde9iVB1P3NoBo0TvXuSPjSKNuGXfdmgRpjOmwvEcngdqZ 8+Xvxf0Fs7j+GDff1t+ZRSTosl8wUWdsDZ9m2OyVOdLeNpAfZki5cWLWoUXL2HfPKjDc Eo5WOinnaYwwa0OOeFdfeEYfKB5nlmmxhnCGkY7a0nAm3lhyhpR7mkgwFGnF+T7hguIy rOxg== X-Gm-Message-State: AN3rC/7Rv9iT4KFaDFQz2b5x4YvCmEHkCM8RInb0HBd9Bd5m0uv4ykF9 RRdSkOZiSU9hRsVRtLSHOQuHJI8l8Q== X-Received: by 10.202.240.85 with SMTP id o82mr3083387oih.26.1492111701490; Thu, 13 Apr 2017 12:28:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.9.178 with HTTP; Thu, 13 Apr 2017 12:28:21 -0700 (PDT) In-Reply-To: References: From: Noam Postavsky Date: Thu, 13 Apr 2017 15:28:21 -0400 X-Google-Sender-Auth: xP32OIBwGPDLAF1Chw0gMHR_4wg Message-ID: Subject: Re: bug#26486: 25.1.91; spurious warnings from cconv.el To: John Williams Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 26486 Cc: 26486@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) retitle 26486 25.1.91; unused var warning from cconv.el can't be suppressed severity 26486 minor tag 26486 confirmed quit On Thu, Apr 13, 2017 at 2:59 PM, John Williams wrote: > When I byte compile a file where a macro expansion introduces an unused > lexical veriable, I get warnings from cconv.el, even if I wrap the > expansion in (with-no-warnings) and set byte-compile-warnings to nil. > IMHO warnings of this type should never be issued for code that comes > from a macro expansion, but it should at least be possible to suppress > them with the usual mechanisms. Here's a file that demonstrates the > problem when it's compiled with byte-compile-file: > > ======================================================================== > ;; -*- lexical-binding: t; byte-compile-warnings: nil -*- > > (defmacro test () > `(let (unused))) > > (with-no-warnings > (test)) > ======================================================================== This happens also without a macro. ;; -*- lexical-binding: t; byte-compile-warnings: nil -*- (with-no-warnings (let (unused))) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 10 16:49:06 2020 Received: (at control) by debbugs.gnu.org; 10 Aug 2020 20:49:06 +0000 Received: from localhost ([127.0.0.1]:37593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5EjC-0004bd-Ab for submit@debbugs.gnu.org; Mon, 10 Aug 2020 16:49:06 -0400 Received: from mail-yb1-f171.google.com ([209.85.219.171]:43408) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5EjA-0004b7-J5 for control@debbugs.gnu.org; Mon, 10 Aug 2020 16:49:05 -0400 Received: by mail-yb1-f171.google.com with SMTP id m200so5856317ybf.10 for ; Mon, 10 Aug 2020 13:49:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Q2o0nTJF4pQ6+UYBoRFjiM/CI8VKQ5NgynZ24x0xFBU=; b=EcZ4AX05UT8SbfpJ5xiUgU1F+7b2fDc63VAr+ohH5kj8Nbpr0QqP/5nf0yomn8GJ0Y T7UVXWkuKB90YqCj2CkdJCyvDffgqXrGsv4DX7aYkM2tEyfyzKORjUBokTfNrVMamXIc XHJ8wuoiSXEgLODAKlr8ufBD5uMs9T1qeMrHaN0XqG6r1cSZRqXu/S1nCxBSnrMq/TD9 rvb2wkvNVQxTkeacTmB9E4MsNCU1An9gnTy+drG46gLnaimgZBJoyVVqyOP0ZzU2LId4 xy+PS5Z8lvVyNxVcTN2zMb8HeWbGxD9g4b0GT7+dDvxqPvSeFkCTGccoSz2p4k6Aldid GCqQ== X-Gm-Message-State: AOAM532/Umn8hjvLrWwwXIPzTmWtd5ON4oOdBrbrdoyJc4J1XZxTYAKE uc7WQsAiAiOVLqfEjQeoF5k05+KsXkzbNvOa1/qpxapgEz9YVA== X-Google-Smtp-Source: ABdhPJwf/ADIIh6COQVo+zfvGY+SjtBX9pTqhnSEwR+MP/QwhyBpiqPdgjMeuMlpVbVGgROicfn4lP6Dr4XRcKDZ5Hc= X-Received: by 2002:a25:b88b:: with SMTP id w11mr44870319ybj.129.1597092538862; Mon, 10 Aug 2020 13:48:58 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Mon, 10 Aug 2020 22:48:48 +0200 Message-ID: Subject: To: control Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: found 26486 28.0.50 thanks Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.171 listed in wl.mailspike.net] 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: found 26486 28.0.50 thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.219.171 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.219.171 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 1.0 PDS_TONAME_EQ_TOLOCAL_VSHORT Very short body and From looks like 2 different emails -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 BLANK_SUBJECT Subject is present but empty found 26486 28.0.50 thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 05 11:17:33 2021 Received: (at 26486) by debbugs.gnu.org; 5 Jul 2021 15:17:34 +0000 Received: from localhost ([127.0.0.1]:46436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QLZ-0003ox-2Z for submit@debbugs.gnu.org; Mon, 05 Jul 2021 11:17:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QLX-0003of-AF for 26486@debbugs.gnu.org; Mon, 05 Jul 2021 11:17:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YzEN0yZ5xVLwfid0prmiCU97RR6WeakZOMO0T+OEnEs=; b=stlphW9bHn+D5TK99wF/5BRLNB S81zFOcGIC1Ivul6eMbWPTxLmWvhaZHVi8Ae/YGyWZzi9Lv6X3fdTIyFgiWX0h3QAr3mbJAILMtsL FG3s1k1XjycRvUJ9Au2PKylypcjVXjJ/cE7BAQ2mk3jF0/w/N5ilzjf1KIkzGAVX1tmg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0QLM-0005oe-RY; Mon, 05 Jul 2021 17:17:11 +0200 From: Lars Ingebrigtsen To: Noam Postavsky Subject: Re: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed References: X-Now-Playing: Tuxedomoon's _Live in Umbria (1989)_: "Nervous Guy" Date: Mon, 05 Jul 2021 17:17:06 +0200 In-Reply-To: (Noam Postavsky's message of "Thu, 13 Apr 2017 15:28:21 -0400") Message-ID: <87mtr0x025.fsf_-_@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Noam Postavsky writes: > This happens also without a macro. > > ; ; -*- lexical-binding: t; byte-compile-warnings: nil -*- > (with-no-warnings (let (unused))) This currently gives a warning about both an unused variable and an empty let body. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26486 Cc: John Williams , Stefan Monnier , 26486@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Noam Postavsky writes: > This happens also without a macro. > > ;; -*- lexical-binding: t; byte-compile-warnings: nil -*- > (with-no-warnings (let (unused))) This currently gives a warning about both an unused variable and an empty let body. The following seemingly straightforward patch fixes both these things, I'd appreciate it if somebody had a look over it first, though. :-) (So Stefan M added to the CCs.) diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 70999648d4..d97bc1073b 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -325,6 +325,7 @@ byte-compile-warnings docstrings docstrings that are too wide (longer than 80 characters, or `fill-column', whichever is bigger) suspicious constructs that usually don't do what the coder wanted. + empty-body the body of a binding form is empty. If the list begins with `not', then the remaining elements specify warnings to suppress. For example, (not mapcar) will suppress warnings about mapcar." diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el index f663710902..f1579cda8b 100644 --- a/lisp/emacs-lisp/cconv.el +++ b/lisp/emacs-lisp/cconv.el @@ -259,7 +259,8 @@ cconv--warn-unused-msg (not (intern-soft var)) (eq ?_ (aref (symbol-name var) 0)) ;; As a special exception, ignore "ignore". - (eq var 'ignored)) + (eq var 'ignored) + (not (byte-compile-warning-enabled-p 'unbound var))) (let ((suggestions (help-uni-confusable-suggestions (symbol-name var)))) (format "Unused lexical %s `%S'%s" varkind var diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el index df864464b7..e9c2eb3fee 100644 --- a/lisp/emacs-lisp/macroexp.el +++ b/lisp/emacs-lisp/macroexp.el @@ -319,14 +319,16 @@ macroexp--expand-all (`(,(and fun (or 'let 'let*)) . ,(or `(,bindings . ,body) pcase--dontcare)) (macroexp--cons fun - (macroexp--cons (macroexp--all-clauses bindings 1) - (if (null body) - (macroexp-unprogn - (macroexp-warn-and-return - (format "Empty %s body" fun) - nil t)) - (macroexp--all-forms body)) - (cdr form)) + (macroexp--cons + (macroexp--all-clauses bindings 1) + (if (null body) + (macroexp-unprogn + (macroexp-warn-and-return + (and (byte-compile-warning-enabled-p 'empty-body) + (format "Empty %s body" fun)) + nil t)) + (macroexp--all-forms body)) + (cdr form)) form)) (`(,(and fun `(lambda . ,_)) . ,args) ;; Embedded lambda in function position. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 05 11:17:34 2021 Received: (at control) by debbugs.gnu.org; 5 Jul 2021 15:17:34 +0000 Received: from localhost ([127.0.0.1]:46440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QLl-0003pQ-SR for submit@debbugs.gnu.org; Mon, 05 Jul 2021 11:17:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QLb-0003on-Sd for control@debbugs.gnu.org; Mon, 05 Jul 2021 11:17:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TY9Bsz09NThR+2gDje7zq/SKbkwpaMnrD/cewZA8tp4=; b=PObxZh1RakqiZ1U9phsbiAHqsj TtoVKeIfoZWZrCe0dc8kwy9byGPqtBfSM9jIPexyUWUwnl/mUKpFavEdwnggxg5DanDQrDSeYQWk+ POKxLxfpQAT6ZVPXFaor5vbnYeZxovsd8j9+I7ObG+4kGW4TDyiQ13omzi/SjPbawHn8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0QLU-0005on-CL for control@debbugs.gnu.org; Mon, 05 Jul 2021 17:17:18 +0200 Date: Mon, 05 Jul 2021 17:17:15 +0200 Message-Id: <87lf6kx01w.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26486 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 26486 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 26486 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 05 11:17:34 2021 Received: (at control) by debbugs.gnu.org; 5 Jul 2021 15:17:34 +0000 Received: from localhost ([127.0.0.1]:46442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QLm-0003pY-AR for submit@debbugs.gnu.org; Mon, 05 Jul 2021 11:17:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:58574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QLf-0003oz-2M for control@debbugs.gnu.org; Mon, 05 Jul 2021 11:17:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fDoCBGU0UrT6ZVsihJO6p80wVLmmNiFeLfHAAsYSbEU=; b=L+RPbdkNiO8+iudeTXjYswSbIN gju3KRftOmqBlpuGqn1b6GfzomhD/ARi5YTAJ4mY/MGTxpMSkMj1oUO2eZHkPqezjqVVPzHVjPlku s0ezolpxVdBDdXqUhQpbgScluR8SzxgLBhSvZoqDjfXepiAEu/+tv+hlZRjpCTix0BoA=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0QLX-0005ou-GC for control@debbugs.gnu.org; Mon, 05 Jul 2021 17:17:21 +0200 Date: Mon, 05 Jul 2021 17:17:19 +0200 Message-Id: <87k0m4x01s.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26486 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 26486 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 26486 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 05 11:29:56 2021 Received: (at 26486) by debbugs.gnu.org; 5 Jul 2021 15:29:56 +0000 Received: from localhost ([127.0.0.1]:46485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QXk-0004Du-6V for submit@debbugs.gnu.org; Mon, 05 Jul 2021 11:29:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:9030) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QXh-0004Df-7H for 26486@debbugs.gnu.org; Mon, 05 Jul 2021 11:29:54 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 361AB8090A; Mon, 5 Jul 2021 11:29:47 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7607180323; Mon, 5 Jul 2021 11:29:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1625498981; bh=adHwiM++PNR8aNxWawQer/1+S41XSQnvDImr/DhAu18=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=f7XkYeftgPJudxY476ugdWBjuwVzXgd1GxS/uaSgDAHVZpvFXMys3G9B19Uv5PAmZ gWlsmglKA53f4UbUAiIdRbGm18fGZ22Y2lv7yzMhEmZWNDHUBT2k6P0nBaHPSxKZbP 9Fr0HRwcmdabij1deOjYLmUCTC+xTJL3wEslQLvuuEbCU/oRyTCoCFQ6I4UmTHMcoj wPR/ydMlbfFHzAqm6OKZ4uLiXBMT1Tmxsw+yMauPQZbpLQ4DdR0LH16L0JhlkDT2fy 2sETP/cQkm3yFMjPhPqGZ3fRkmoDqm/0ME421Oli0vmPhsndUOKLcya5RXRbUu8Nmi 2YQ3WfqB7KzKA== Received: from alfajor (unknown [45.72.205.238]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3D7F2120050; Mon, 5 Jul 2021 11:29:41 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed Message-ID: References: <87mtr0x025.fsf_-_@gnus.org> Date: Mon, 05 Jul 2021 11:29:40 -0400 In-Reply-To: <87mtr0x025.fsf_-_@gnus.org> (Lars Ingebrigtsen's message of "Mon, 05 Jul 2021 17:17:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.069 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26486 Cc: 26486@debbugs.gnu.org, John Williams , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen [2021-07-05 17:17:06] wrote: > Noam Postavsky writes: > >> This happens also without a macro. >> >> ;; -*- lexical-binding: t; byte-compile-warnings: nil -*- >> (with-no-warnings (let (unused))) > > This currently gives a warning about both an unused variable and an > empty let body. > > The following seemingly straightforward patch fixes both these things, > I'd appreciate it if somebody had a look over it first, though. :-) > (So Stefan M added to the CCs.) [...] > @@ -259,7 +259,8 @@ cconv--warn-unused-msg > (not (intern-soft var)) > (eq ?_ (aref (symbol-name var) 0)) > ;; As a special exception, ignore "ignore". > - (eq var 'ignored)) > + (eq var 'ignored) > + (not (byte-compile-warning-enabled-p 'unbound var))) > (let ((suggestions (help-uni-confusable-suggestions (symbol-name var)))) > (format "Unused lexical %s `%S'%s" > varkind var LGTM, thank you. This said, I suspect that it may fail to correctly heed `with-suppressed-warnings`. More specifically, I think we may want to add a "category" argument to `macroexp-warn-and-return` which is then matched against `byte-compile-warnings` (either directly inside `macroexp-warn-and-return` or within the subsequent handling of `macroexp--funcall-if-compiled`). > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 70999648d4..d97bc1073b 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -325,6 +325,7 @@ byte-compile-warnings > docstrings docstrings that are too wide (longer than 80 characters, > or `fill-column', whichever is bigger) > suspicious constructs that usually don't do what the coder wanted. > + empty-body the body of a binding form is empty. > > If the list begins with `not', then the remaining elements specify warnings to > suppress. For example, (not mapcar) will suppress warnings about mapcar." > diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el > index f663710902..f1579cda8b 100644 > --- a/lisp/emacs-lisp/cconv.el > +++ b/lisp/emacs-lisp/cconv.el > diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el > index df864464b7..e9c2eb3fee 100644 > --- a/lisp/emacs-lisp/macroexp.el > +++ b/lisp/emacs-lisp/macroexp.el > @@ -319,14 +319,16 @@ macroexp--expand-all > (`(,(and fun (or 'let 'let*)) . ,(or `(,bindings . ,body) > pcase--dontcare)) > (macroexp--cons fun > - (macroexp--cons (macroexp--all-clauses bindings 1) > - (if (null body) > - (macroexp-unprogn > - (macroexp-warn-and-return > - (format "Empty %s body" fun) > - nil t)) > - (macroexp--all-forms body)) > - (cdr form)) > + (macroexp--cons > + (macroexp--all-clauses bindings 1) > + (if (null body) > + (macroexp-unprogn > + (macroexp-warn-and-return > + (and (byte-compile-warning-enabled-p 'empty-body) > + (format "Empty %s body" fun)) > + nil t)) > + (macroexp--all-forms body)) > + (cdr form)) > form)) > (`(,(and fun `(lambda . ,_)) . ,args) > ;; Embedded lambda in function position. We already discussed the use(ful|less)ness of this empty-body warning, and I don't think it's useful enough to justify adding a new warning category for it. When `byte-compile-warnings` is nil, arguably `macroexp-warn-and-return` should just silence all warnings. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 10:48:39 2021 Received: (at 26486) by debbugs.gnu.org; 6 Jul 2021 14:48:39 +0000 Received: from localhost ([127.0.0.1]:49650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mNL-0006i7-CT for submit@debbugs.gnu.org; Tue, 06 Jul 2021 10:48:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mNJ-0006ho-KX for 26486@debbugs.gnu.org; Tue, 06 Jul 2021 10:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/Mo50/di4sW5cWdRoQEZpjlxPEOvrruODm0HVnabC6s=; b=mNW+GMp6GHhhEgRdgVDix5QONu GGmrHssRILNRPAJQRnW/5kuaVQbLVHqYgI/y93Gmkk57ThMhekJ6bNzaUf/sYgq8l7px1o2bb0kM4 wqkzV97wHVgIPbU9pqc4D/N2ylJe0yMq40+CygOBQFI3OdRD6SNR+EtnEPGFnY4yOPa0=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0mN7-00024e-Cb; Tue, 06 Jul 2021 16:48:27 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed References: <87mtr0x025.fsf_-_@gnus.org> X-Now-Playing: David Allred's _Alone on Friendship Island_: "The Hermit and the Fly" Date: Tue, 06 Jul 2021 16:48:24 +0200 In-Reply-To: (Stefan Monnier's message of "Mon, 05 Jul 2021 11:29:40 -0400") Message-ID: <87lf6jts5j.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > LGTM, thank you. Thanks; applied. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26486 Cc: Noam Postavsky , 26486@debbugs.gnu.org, John Williams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > LGTM, thank you. Thanks; applied. > This said, I suspect that it may fail to correctly > heed `with-suppressed-warnings`. More specifically, I think we may want > to add a "category" argument to `macroexp-warn-and-return` which is then > matched against `byte-compile-warnings` (either directly inside > `macroexp-warn-and-return` or within the subsequent handling of > `macroexp--funcall-if-compiled`). Right. Could you fix that? :-) > We already discussed the use(ful|less)ness of this empty-body warning, > and I don't think it's useful enough to justify adding a new warning > category for it. > > When `byte-compile-warnings` is nil, arguably `macroexp-warn-and-return` > should just silence all warnings. Right... but it feels kinda hackish to add the check for just `byte-compile-warnings' there, since we don't have access to the category at that point, so I altered the call site instead. But perhaps `macroexp-warn-and-return` should just be extended with a category parameter and then the check moved into the function instead... I dunno... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 10:48:39 2021 Received: (at control) by debbugs.gnu.org; 6 Jul 2021 14:48:39 +0000 Received: from localhost ([127.0.0.1]:49652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mNL-0006i9-Kh for submit@debbugs.gnu.org; Tue, 06 Jul 2021 10:48:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0mNK-0006hq-5e for control@debbugs.gnu.org; Tue, 06 Jul 2021 10:48:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=v/T/8kQCQQUb2K5nU/gz43Wm0OeGmmEfzfdp5X9RjG8=; b=dJG/mTu103vz2qX6uHDErpOxrS j1yPFJurL5iCVQcOwl4ufTLogh4LMmkkYHhV1Tky92YNka75+rysFrrPlAtvIWOf19eOyOXu5Dd1h JizraV6Q21Absc4dWuVGGDFiBppViWURTe4oVKoqV4S7UC0kKyzifFrQCcmGCKYmeEI4=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0mNC-00024j-JN for control@debbugs.gnu.org; Tue, 06 Jul 2021 16:48:32 +0200 Date: Tue, 06 Jul 2021 16:48:30 +0200 Message-Id: <87k0m3ts5d.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #26486 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 26486 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 26486 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 15:54:03 2021 Received: (at 26486) by debbugs.gnu.org; 6 Jul 2021 19:54:03 +0000 Received: from localhost ([127.0.0.1]:50263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0r8t-0007SG-BX for submit@debbugs.gnu.org; Tue, 06 Jul 2021 15:54:03 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:55123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0r8q-0007Rk-D4 for 26486@debbugs.gnu.org; Tue, 06 Jul 2021 15:54:01 -0400 Received: by mail-wm1-f41.google.com with SMTP id l1so296271wme.4 for <26486@debbugs.gnu.org>; Tue, 06 Jul 2021 12:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=wYINz0/+zGy8TbpfiQCQ5LCmwJ2Fw/SHMKLlSf1WO7w=; b=fooiwOlnf8U+r2s/Bdxcmxwp71fsGuxV4yFwK00H2GeRqMjtgR7UQs6K/aVH7QyMNG S0rUl31aglODoh/f7mEKkaArlkHT5BTgoI/qRbEC9p+Ikhd2qPqWdSnL/Y4mEJ/oZDRA d+ljpsDz0cGYs5etG1k8m1WdRgq0+vrui8E18XHG0yzmrQkPSMn4WFKvMJikH8Rjleh1 co7Z9VvCxAPc6UgVbBnLpjQoJMRcpSc2BfC3ySoOOtiBYB+qestb4u8ejzqqor4i7zQb O7vllBf8vcO7rTYGk4lMr30HqHyWI/L3QuhHh6PsjjXCpEsdCjfXrJzWK/GS61ZOYDn4 pA4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wYINz0/+zGy8TbpfiQCQ5LCmwJ2Fw/SHMKLlSf1WO7w=; b=PvT6OhYCxRcImWaOrLAI/L4LvTBjf1tOnjYSGJ1IUIB4a1fhqH43rPV9LMGiAvjvSa TUGARmc2XJCdczQuA9Y/SJKol325BUmB0toCbRtImRoIl5CSMpUFaw6izbBYa9TyZP7t uChKhtgyFcUFUi4ZJZM1HpU/IEN7/mO5uOcJi6Q1Bv5/dw1S2bD+GHCeObezJ62/DXnK pAntggO69Obei0ROLFV4z1FS7/a0rIFUF+wMe+oTmJNPgryypbT8gUAQ/LKQl72uGTK0 OlbON9YzpyoFevCacWtJe3jqLo3T3iE7QFEXCSVjMZpKu3y7iz7ZtcrpkEjRnjkqKKCx P0QA== X-Gm-Message-State: AOAM533NqFnr8GMWxgnR2pjvY7CtVVJ1+Mh9cAAbNq4x8Tcfki4XlRo/ z6e/1zHtYA1JlA416FB7EJyC7w== X-Google-Smtp-Source: ABdhPJxpZwdtQQYMXn4onlTJetUICt8lEzLmRXdpOFGrPwcO4HWxnzCLcVKzI/Tl2HZQPAhzBBwk2A== X-Received: by 2002:a7b:cb53:: with SMTP id v19mr21874603wmj.127.1625601234211; Tue, 06 Jul 2021 12:53:54 -0700 (PDT) Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id a22sm15756728wrc.66.2021.07.06.12.53.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jul 2021 12:53:53 -0700 (PDT) From: "Basil L. Contovounesios" To: Lars Ingebrigtsen Subject: Re: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed References: <87mtr0x025.fsf_-_@gnus.org> Date: Tue, 06 Jul 2021 20:53:52 +0100 In-Reply-To: <87mtr0x025.fsf_-_@gnus.org> (Lars Ingebrigtsen's message of "Mon, 05 Jul 2021 17:17:06 +0200") Message-ID: <875yxn43sf.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 26486 Cc: John Williams , 26486@debbugs.gnu.org, Stefan Monnier , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Noam Postavsky writes: > >> This happens also without a macro. >> >> ;; -*- lexical-binding: t; byte-compile-warnings: nil -*- >> (with-no-warnings (let (unused))) > > This currently gives a warning about both an unused variable and an > empty let body. > > The following seemingly straightforward patch fixes both these things, > I'd appreciate it if somebody had a look over it first, though. :-) > (So Stefan M added to the CCs.) I suspect this patch causes the following: $ cat foo.el ;;; foo.el --- foo -*- lexical-binding: t -*- (let ()) ;;; foo.el ends here $ emacs -Q -script foo.el Eager macro-expansion failure: (void-function byte-compile-warning-enabled-p) Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 16:03:53 2021 Received: (at 26486) by debbugs.gnu.org; 6 Jul 2021 20:03:53 +0000 Received: from localhost ([127.0.0.1]:50287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rIO-0007im-PR for submit@debbugs.gnu.org; Tue, 06 Jul 2021 16:03:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rIN-0007iU-O8 for 26486@debbugs.gnu.org; Tue, 06 Jul 2021 16:03:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tNFMU4xcgsMO8GhsCq9ZP8UMQkaVGWfjPHNnMuQeojY=; b=YhvOc+ND2sZGwoczU7efcT1q4n iM2gaPV4Sr/BKNjJk76nLN0SOMgvQTklKZOcDkR+Hl/KBeuQjy2GYj9WzYRAdALt+U73YaEctqPce vovSklIWk1GzWUsEgPpyH6uTvD1x89DNdlXkLdG9MAsWbHSyb4pxPAJplzBeKRZUaKaI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0rI9-00056L-LW; Tue, 06 Jul 2021 22:03:40 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed References: <87mtr0x025.fsf_-_@gnus.org> <875yxn43sf.fsf@tcd.ie> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUOEC0WIVAWJVYK CROBh5JJSFEnJSr////DEuIVAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UHBhInI3oWF1QAAAGiSURB VDjLbZNNjsMgDIWNmHZdyAUaRuw9QskJkll32pJ1pDTc/whjA/kPq+p9eX7GuACro+LRxhjpFlXc km5KY8C53deRsCGBr/bnJhZZ310Gl3YuFBO+J6BAgBKTbMzsaO7EFn1xNDdQHJJ1zk7Aey8Uh+iI SseA0btpxNxTikjAvlsCpSj1HJGAMMY+vf3T5cqBDBR/a5/ZId0UDjHBmmfqq9gBblftQGIs6pyd MvJ8dSKF2zhSc3O3uHJIBKGp42ILYo8kFJAruS2YzgI2MkZB4gFQ8wwODl4NcHgohREAnAKz3GJd SWgDOKXLHahDuPZbD/JwIOQjlxgMite3lpXv+ijLnBdozjCEYWwYEKGq8deVZgy+G0afwfiq2oDS iQjCEHx4RPB5VO34oIJcqqNS3se+5KWv/OdXxieDvnbXEBioG0DdjX0EFobaDXlcNJ/rKwhAup+d 3gt6h328JTqkCA/zg83zx542KQPM86BaNISOFqnZPFCaZuCJbMG0ZgTeO+BA8l9VHwHnkeF5Asil bdOcAYfC+lPAj3vuoM7+AXSjllu5UxV8AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA3LTA2VDE4 OjM5OjM0KzAwOjAw2iC8vQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNy0wNlQxODozOTozNCsw MDowMKt9BAEAAAAASUVORK5CYII= X-Now-Playing: Yo La Tengo's _And Then Nothing Turned Itself Inside-Out_: "Night Falls On Hoboken" Date: Tue, 06 Jul 2021 22:03:37 +0200 In-Reply-To: <875yxn43sf.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 06 Jul 2021 20:53:52 +0100") Message-ID: <87lf6jnrae.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > I suspect this patch causes the following: > > $ cat foo.el > ;;; foo.el --- foo -*- lexical-binding: t -*- > (let ()) > ; ; ; foo.el ends here > $ emacs -Q -script foo.el > Eager macro-expansion fail [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26486 Cc: John Williams , 26486@debbugs.gnu.org, Stefan Monnier , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > I suspect this patch causes the following: > > $ cat foo.el > ;;; foo.el --- foo -*- lexical-binding: t -*- > (let ()) > ;;; foo.el ends here > $ emacs -Q -script foo.el > Eager macro-expansion failure: (void-function byte-compile-warning-enabled-p) Yup. The function is used elsewhere in macroexp, too, but there it's guarded by an fboundp. I think we should probably consider moving that function (and the variables defined by it) somewhere else (perhaps a new file), because it seems the requiring going on there is sort of in an odd direction. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 06 16:04:48 2021 Received: (at 26486) by debbugs.gnu.org; 6 Jul 2021 20:04:48 +0000 Received: from localhost ([127.0.0.1]:50294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rJI-0007kh-3D for submit@debbugs.gnu.org; Tue, 06 Jul 2021 16:04:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:44274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0rJG-0007kT-C6 for 26486@debbugs.gnu.org; Tue, 06 Jul 2021 16:04:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RxS84LZizZT7riXKP7DCjjVV35usyniwgJsQt/5Ffqs=; b=cqsRReE3amzUveMpdhpNuLoa1w qP8JbgtiejNoaaAVkydHoSZ+ovR52s1+rmmbCBNJw0ZE8JA1tMH9ybYSnuMFNg19hChbwInuK8Mgz a8CwVp5xZNTHMbey/+r54/6L/BYB9z6ZmhkNgKMXDoXNjsqal7p7V++V2olJ2UR6BPrg=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0rJ6-00056i-0c; Tue, 06 Jul 2021 22:04:38 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#26486: 25.1.91; unused var warning from cconv.el can't be suppressed References: <87mtr0x025.fsf_-_@gnus.org> <875yxn43sf.fsf@tcd.ie> <87lf6jnrae.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEUOEC0WIVAWJVYK CROBh5JJSFEnJSr////DEuIVAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UHBhInI3oWF1QAAAGiSURB VDjLbZNNjsMgDIWNmHZdyAUaRuw9QskJkll32pJ1pDTc/whjA/kPq+p9eX7GuACro+LRxhjpFlXc km5KY8C53deRsCGBr/bnJhZZ310Gl3YuFBO+J6BAgBKTbMzsaO7EFn1xNDdQHJJ1zk7Aey8Uh+iI SseA0btpxNxTikjAvlsCpSj1HJGAMMY+vf3T5cqBDBR/a5/ZId0UDjHBmmfqq9gBblftQGIs6pyd MvJ8dSKF2zhSc3O3uHJIBKGp42ILYo8kFJAruS2YzgI2MkZB4gFQ8wwODl4NcHgohREAnAKz3GJd SWgDOKXLHahDuPZbD/JwIOQjlxgMite3lpXv+ijLnBdozjCEYWwYEKGq8deVZgy+G0afwfiq2oDS iQjCEHx4RPB5VO34oIJcqqNS3se+5KWv/OdXxieDvnbXEBioG0DdjX0EFobaDXlcNJ/rKwhAup+d 3gt6h328JTqkCA/zg83zx542KQPM86BaNISOFqnZPFCaZuCJbMG0ZgTeO+BA8l9VHwHnkeF5Asil bdOcAYfC+lPAj3vuoM7+AXSjllu5UxV8AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTA3LTA2VDE4 OjM5OjM0KzAwOjAw2iC8vQAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0wNy0wNlQxODozOTozNCsw MDowMKt9BAEAAAAASUVORK5CYII= X-Now-Playing: Yo La Tengo's _And Then Nothing Turned Itself Inside-Out_: "Night Falls On Hoboken" Date: Tue, 06 Jul 2021 22:04:35 +0200 In-Reply-To: <87lf6jnrae.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 06 Jul 2021 22:03:37 +0200") Message-ID: <87h7h7nr8s.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > I think we should probably consider moving that function (and the > variables defined by it) somewhere else (perhaps a new file), because it > seems the requiring going on there is sort of in an odd [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 26486 Cc: John Williams , 26486@debbugs.gnu.org, Stefan Monnier , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > I think we should probably consider moving that function (and the > variables defined by it) somewhere else (perhaps a new file), because it > seems the requiring going on there is sort of in an odd direction. (But I pushed a quick fix now.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Thu Sep 11 11:55:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Aug 2021 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator