From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 00:44:23 2017 Received: (at submit) by debbugs.gnu.org; 12 Apr 2017 04:44:23 +0000 Received: from localhost ([127.0.0.1]:43526 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyA8l-0008Cw-4Z for submit@debbugs.gnu.org; Wed, 12 Apr 2017 00:44:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyA8j-0008Cl-VG for submit@debbugs.gnu.org; Wed, 12 Apr 2017 00:44:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyA8d-00070D-RW for submit@debbugs.gnu.org; Wed, 12 Apr 2017 00:44:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cyA8d-000709-Nu for submit@debbugs.gnu.org; Wed, 12 Apr 2017 00:44:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cyA8c-0004JQ-7v for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2017 00:44:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cyA8Y-0006yN-Am for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2017 00:44:14 -0400 Received: from mail.choca.pics ([62.210.108.126]:55228) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cyA8Y-0006wk-0O for bug-gnu-emacs@gnu.org; Wed, 12 Apr 2017 00:44:10 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 04D0C232A56B for ; Wed, 12 Apr 2017 06:43:59 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id BNFjZkdIEwHr for ; Wed, 12 Apr 2017 06:43:58 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 52907232B050 for ; Wed, 12 Apr 2017 06:43:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.choca.pics 52907232B050 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=9EA44F5C-DEF4-11E6-A83F-A08DF322D8FB; t=1491972238; bh=FKF+vEEofR621Zd3R2TwfbPz7bHH8khbUXjiq3Ud+kw=; h=From:To:Date:Message-ID:MIME-Version; b=ZLvqgy8Z2SHEqZ+wnQpdVH9yvE+0a7xnWIEjXH8KhLzGOJ+/FHS4uUtPlSmHbU37Z KkYj58ljhUlegpqmou9ylW7RzlFCKVaYltEBBAxLxWgX3l8GdkQFOXoHiYRjRSuubQ edtXb3X+5t8A5xzBqkYNPN6a0RFuHsSLFxp5Ih0pjgNQdB92LSaaKWIS2gt19CMmTj TAcqFFo5cxa6c54usH4UeCULh3ayI+UhTsisUywjzKHNdQhCmp3ycDYiiQnG8hW75B gudlhSfAX/kwXwKAiwTYdERPwciKbkph7vH/9NxLWQrbMMzgQy8LZ2Ua7hhPEExJ8q kwg0ytS2VfqBw== X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id bTo2Gbe9YpXP for ; Wed, 12 Apr 2017 06:43:58 +0200 (CEST) Received: from x230 (c80-216-198-172.bredband.comhem.se [80.216.198.172]) by mail.choca.pics (Postfix) with ESMTPSA id D3FF9232A56B for ; Wed, 12 Apr 2017 06:43:56 +0200 (CEST) From: Damien Cassou To: bug-gnu-emacs@gnu.org Subject: 25.2; Cannot pass a function to imenu-generic-expression Date: Wed, 12 Apr 2017 06:43:49 +0200 Message-ID: <87a87mz14q.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) $ emacs -Q M-: (setq-local imenu-generic-expression `(("Foo" "^;; .*$" 0 ,(lambda (item pos) (message "%s" item))))) M-x imenu This results in sort: Wrong type argument: number-or-marker-p, (# (lambda (item pos) (message "%s" item))) In GNU Emacs 25.2.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.9) of 2017-03-09 built on x230 Repository revision: aceac954ed29c2653e2a0eb71b899be5c916edda Windowing system distributor 'Fedora Project', version 11.0.11903000 Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 Important settings: value of $LANG: fr_FR.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 03:32:22 2017 Received: (at 26457) by debbugs.gnu.org; 12 Apr 2017 07:32:22 +0000 Received: from localhost ([127.0.0.1]:43576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyClK-0003qK-EM for submit@debbugs.gnu.org; Wed, 12 Apr 2017 03:32:22 -0400 Received: from mail.choca.pics ([62.210.108.126]:41728) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyClI-0003qA-9B for 26457@debbugs.gnu.org; Wed, 12 Apr 2017 03:32:21 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 31BA9232B07B for <26457@debbugs.gnu.org>; Wed, 12 Apr 2017 09:32:19 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id jTKC1yBT3-eE for <26457@debbugs.gnu.org>; Wed, 12 Apr 2017 09:32:18 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 55A40232B07D for <26457@debbugs.gnu.org>; Wed, 12 Apr 2017 09:32:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.choca.pics 55A40232B07D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=9EA44F5C-DEF4-11E6-A83F-A08DF322D8FB; t=1491982338; bh=LoCFOP323rn6xJjmM7Hixzs3BgxsZ9PU/eWPaDBYBeA=; h=From:To:Date:Message-ID:MIME-Version; b=ZsV/s7ODCMmeJHBgRntiC9DKn50M8Zbsd3A8haK9nsGEtGaKoeNHD482YmwXjhKsl 5LTyilDVxIVC0+IphopojpPO1ky4W4pLItij+tA2PAARtV7P+50SCAQR0K55VvA1sR o8sFORUg1RYw7S5Rs6rf/dU8Jz+EEJ9IlWfdJ4oI1EwWy9K0NT7HSKIhqfCx95AiZH KX94lY50O43jnK+Fibd+MtxR8TrVVi/soIrxOMkCY4GoA9a9fhld+xB1AOXBwpyVd+ h7zNaDcZEG1EI4VDMPa7p+MOpYbbKV7m31mJRqLPA+NKqMlr3S28/FRLt6pgjpqdOR nlIubv/IeGVbA== X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id mCc2OuFFbG78 for <26457@debbugs.gnu.org>; Wed, 12 Apr 2017 09:32:18 +0200 (CEST) Received: from luz4 (31-211-216-84.customers.ownit.se [31.211.216.84]) by mail.choca.pics (Postfix) with ESMTPSA id 1597E232B07B for <26457@debbugs.gnu.org>; Wed, 12 Apr 2017 09:32:18 +0200 (CEST) From: Damien Cassou To: 26457@debbugs.gnu.org Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression References: <87a87mz14q.fsf@cassou.me> Date: Wed, 12 Apr 2017 09:32:08 +0200 In-Reply-To: <87a87mz14q.fsf@cassou.me> (Damien Cassou's message of "Wed, 12 Apr 2017 06:43:49 +0200") Message-ID: <87bms26pzb.fsf@cassou.me> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; format=flowed Damien Cassou writes: > sort: Wrong type argument: number-or-marker-p, (# in > *scratch*> (lambda (item pos) (message "%s" item))) here is a patch -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-imenu-sort-by-position-for-non-pairs-parameters-.patch >From ae61937fd0ed634c3f63645f76c4e6b681d499be Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Wed, 12 Apr 2017 07:35:56 +0200 Subject: [PATCH] Fix imenu--sort-by-position for non-pairs parameters (bug#26457) * lisp/imenu.el (imenu--sort-by-position): Fix to accept lists beyond pairs. * test/lisp/imenu-tests.el: Add 2 tests for `imenu--sort-by-position`. --- lisp/imenu.el | 7 ++++++- test/lisp/imenu-tests.el | 10 ++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lisp/imenu.el b/lisp/imenu.el index 0f47a92..7606593 100644 --- a/lisp/imenu.el +++ b/lisp/imenu.el @@ -499,7 +499,12 @@ imenu--sort-by-name (string-lessp (car item1) (car item2))) (defun imenu--sort-by-position (item1 item2) - (< (cdr item1) (cdr item2))) + "Comparison function to sort items depending on their position. +Return t if and only if ITEM1's position is lower than ITEM2's +position." + (if (listp (cdr item1)) + (< (cadr item1) (cadr item2)) + (< (cdr item1) (cdr item2)))) (defun imenu--relative-position (&optional reverse) "Support function to calculate relative position in buffer. diff --git a/test/lisp/imenu-tests.el b/test/lisp/imenu-tests.el index 480368f..9309094 100644 --- a/test/lisp/imenu-tests.el +++ b/test/lisp/imenu-tests.el @@ -83,6 +83,16 @@ imenu-simple-scan-deftest } " '("a" "b" "c" "ABC_D")) +(ert-deftest imenu--sort-by-position-pairs () + (should (imenu--sort-by-position '("a" . 2) '("a" . 3))) + (should-not (imenu--sort-by-position '("a" . 3) '("a" . 2)))) + +;; Regression test for bug#26457: 25.2; Cannot pass a function to +;; imenu-generic-expression +(ert-deftest imenu--sort-by-position-list () + (should (imenu--sort-by-position '("a" 2 nil) '("a" 3 nil))) + (should-not (imenu--sort-by-position '("a" 3 nil) '("a" 2 nil)))) + (provide 'imenu-tests) ;;; imenu-tests.el ends here -- 2.9.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 04:03:21 2017 Received: (at 26457) by debbugs.gnu.org; 12 Apr 2017 08:03:21 +0000 Received: from localhost ([127.0.0.1]:43622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDFI-0004ZZ-Vo for submit@debbugs.gnu.org; Wed, 12 Apr 2017 04:03:21 -0400 Received: from petton.fr ([89.234.186.68]:57247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDFH-0004ZL-Di for 26457@debbugs.gnu.org; Wed, 12 Apr 2017 04:03:19 -0400 From: Nicolas Petton To: Damien Cassou Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> Date: Wed, 12 Apr 2017 10:03:10 +0200 In-Reply-To: <87bms26pzb.fsf@cassou.me> (Damien Cassou's message of "Wed, 12 Apr 2017 09:32:08 +0200") Message-ID: <87wpaq2gu9.fsf@petton.fr> MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1491984191; bh=4Th/Gt41JkZRsbz91Pw7tgQm03sNql/0ViU7T6SY1/s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; b=gQAoESnKbr4pP/ri2GRatxp1OAIF3ovtZtVgPHMPEjlf4aZjKX8Evor973+1944LoO7hY1l0u9Y+uCOYazmG6H/IUUM590RUyGM5D8/C8ep3hmE8TAUYsNfIJxS4hfGS6svhRgYXA3rZUNckvmduFp2/Ho8SaBjt1CsPHH/f64M= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 Cc: 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 26457 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 04:11:03 2017 Received: (at control) by debbugs.gnu.org; 12 Apr 2017 08:11:04 +0000 Received: from localhost ([127.0.0.1]:43627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDMl-0004kc-Of for submit@debbugs.gnu.org; Wed, 12 Apr 2017 04:11:03 -0400 Received: from petton.fr ([89.234.186.68]:57425) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDMk-0004k8-J1 for control@debbugs.gnu.org; Wed, 12 Apr 2017 04:11:02 -0400 From: Nicolas Petton To: control@debbugs.gnu.org Subject: [Nicolas Petton] bug#26457: 25.2; Cannot pass a function to imenu-generic-expression Date: Wed, 12 Apr 2017 10:10:55 +0200 Message-ID: <87mvbm2ghc.fsf@petton.fr> MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1491984656; bh=TnzZ/ZCaXdlWcEdW13WkvFW45O5Vtoz+bLiyMjpJeOg=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=0RhmxLvzfGCPqg8cpiCEcGyokHx1KKSgkXiVV1r25K+YXUuReYcdFfTrgNZ1sbYSe8eS8YYQdW3rnOsQxpHWW8cEuEvu8i97YYcHHmfSsuho9u8i+ztIPYGc2hNx0zBFGU52yjrCrGIjuopLwhu+cjSrUKsgsxTnyeqmHgl6ea0= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 26457 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 04:24:43 2017 Received: (at 26457) by debbugs.gnu.org; 12 Apr 2017 08:24:43 +0000 Received: from localhost ([127.0.0.1]:43645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDZz-0006qC-LT for submit@debbugs.gnu.org; Wed, 12 Apr 2017 04:24:43 -0400 Received: from petton.fr ([89.234.186.68]:57685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDZx-0006py-FF for 26457@debbugs.gnu.org; Wed, 12 Apr 2017 04:24:42 -0400 From: Nicolas Petton To: Damien Cassou Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> Date: Wed, 12 Apr 2017 10:24:34 +0200 In-Reply-To: <87bms26pzb.fsf@cassou.me> (Damien Cassou's message of "Wed, 12 Apr 2017 09:32:08 +0200") Message-ID: <87efwy2ful.fsf@petton.fr> MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1491985475; bh=iNO30JuVU4m7ebWlVpckTQ71ERUs9Ve4n/K0BIe5oU4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID:MIME-Version:Content-Type; b=kk9fJU8xvvuqZ7um7Ab7965IYpygCd7JYdmUfI1iTSHyHENJtMvq44F6EZcxPxuvh2HYJnXcODis3d8GKpC5JmksrfZRuuC+gM+BI9sME0XYMAWbUHfyLDNIQTtEzlnklpdTyC8EmKkabyJuqt3N9jQKnepi60qH/BfTi6eFh6U= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 Cc: 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Damien Cassou writes: > (defun imenu--sort-by-position (item1 item2) > - (< (cdr item1) (cdr item2))) > + "Comparison function to sort items depending on their position. > +Return t if and only if ITEM1's position is lower than ITEM2's ^^ We usually say "non-nil". > +(ert-deftest imenu--sort-by-position-pairs () > + (should (imenu--sort-by-position '("a" . 2) '("a" . 3))) > + (should-not (imenu--sort-by-position '("a" . 3) '("a" . 2)))) > + > +;; Regression test for bug#26457: 25.2; Cannot pass a function to > +;; imenu-generic-expression > +(ert-deftest imenu--sort-by-position-list () > + (should (imenu--sort-by-position '("a" 2 nil) '("a" 3 nil))) > + (should-not (imenu--sort-by-position '("a" 3 nil) '("a" 2 nil)))) Thanks for the regression test! Cheers, Nico From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 04:42:19 2017 Received: (at 26457) by debbugs.gnu.org; 12 Apr 2017 08:42:19 +0000 Received: from localhost ([127.0.0.1]:43655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDr1-0007FQ-DB for submit@debbugs.gnu.org; Wed, 12 Apr 2017 04:42:19 -0400 Received: from mail.choca.pics ([62.210.108.126]:42844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyDqz-0007FH-2T for 26457@debbugs.gnu.org; Wed, 12 Apr 2017 04:42:18 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id D5E8C232B099; Wed, 12 Apr 2017 10:42:12 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id 0-qKFlKoAbVZ; Wed, 12 Apr 2017 10:42:12 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id DE771232B098; Wed, 12 Apr 2017 10:42:11 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.choca.pics DE771232B098 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=9EA44F5C-DEF4-11E6-A83F-A08DF322D8FB; t=1491986531; bh=oTwODMhIM5X4FYwHdDRVWPYdOHV+452+uNxBZIC2BN0=; h=From:To:Date:Message-ID:MIME-Version; b=Rm8Vig8uiarwR8SEDFCJ9MNJzPkj+cksNlh10zjgwdKGUVkVsGbuGaP14LKY8ixwv 1V7xHMGXlejZWTM7tHIlKtDmRV6Xpov1WBdYXazZxIG1lZN/WvhcNCyPZ//hUUaE5P JgWQ1PjAxQ01EHAwDh8brYq2BHi30s5J5FUkJ+07XjWxWbE7wH7Tem/0bxdsDc7Ci7 KuXjPoZkRcdtWrF0itebUubPW+Gs+Cc8CTcHnl2if0jEJU+u8O+qRj7JhUsidwL8EO Pg7nptYkM+jeyR+r9lLhOJxw+vQMF9Q3FuoqWVo2Fq2VCbeN68rU3WoxQox2KSmy5Y CpmvKqIxDs70A== X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id KQfyLJcSP5ri; Wed, 12 Apr 2017 10:42:11 +0200 (CEST) Received: from luz4 (31-211-216-84.customers.ownit.se [31.211.216.84]) by mail.choca.pics (Postfix) with ESMTPSA id 9169D232B097; Wed, 12 Apr 2017 10:42:11 +0200 (CEST) From: Damien Cassou To: Nicolas Petton Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression In-Reply-To: <87efwy2ful.fsf@petton.fr> References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> <87efwy2ful.fsf@petton.fr> Date: Wed, 12 Apr 2017 10:42:08 +0200 Message-ID: <871ssy6mqn.fsf@cassou.me> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 Cc: 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Nicolas Petton writes: >We usually say "non-nil". =20 done=20 --=20 Damien Cassou F=C3=B6retagsplatsen AB Phone/Fax: +46 (0)8 774 63 00 Mobile: +33 (0)6 80 50 18 91 Address: Skeppsbron 26, 4tr, SE-111 30 Stockholm Web: www.foretagsplatsen.se --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-imenu-sort-by-position-for-non-pairs-parameters-.patch >From e4af13e6f9c811d91a4b4da648d4c4f79118e828 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Wed, 12 Apr 2017 07:35:56 +0200 Subject: [PATCH] Fix imenu--sort-by-position for non-pairs parameters (bug#26457) * lisp/imenu.el (imenu--sort-by-position): Fix to accept lists beyond pairs. * test/lisp/imenu-tests.el: Add 2 tests for `imenu--sort-by-position`. --- lisp/imenu.el | 7 ++++++- test/lisp/imenu-tests.el | 10 ++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lisp/imenu.el b/lisp/imenu.el index 0f47a92..c1fd400 100644 --- a/lisp/imenu.el +++ b/lisp/imenu.el @@ -499,7 +499,12 @@ imenu--sort-by-name (string-lessp (car item1) (car item2))) (defun imenu--sort-by-position (item1 item2) - (< (cdr item1) (cdr item2))) + "Comparison function to sort items depending on their position. +Return non-nil if and only if ITEM1's position is lower than ITEM2's +position." + (if (listp (cdr item1)) + (< (cadr item1) (cadr item2)) + (< (cdr item1) (cdr item2)))) (defun imenu--relative-position (&optional reverse) "Support function to calculate relative position in buffer. diff --git a/test/lisp/imenu-tests.el b/test/lisp/imenu-tests.el index 480368f..9309094 100644 --- a/test/lisp/imenu-tests.el +++ b/test/lisp/imenu-tests.el @@ -83,6 +83,16 @@ imenu-simple-scan-deftest } " '("a" "b" "c" "ABC_D")) +(ert-deftest imenu--sort-by-position-pairs () + (should (imenu--sort-by-position '("a" . 2) '("a" . 3))) + (should-not (imenu--sort-by-position '("a" . 3) '("a" . 2)))) + +;; Regression test for bug#26457: 25.2; Cannot pass a function to +;; imenu-generic-expression +(ert-deftest imenu--sort-by-position-list () + (should (imenu--sort-by-position '("a" 2 nil) '("a" 3 nil))) + (should-not (imenu--sort-by-position '("a" 3 nil) '("a" 2 nil)))) + (provide 'imenu-tests) ;;; imenu-tests.el ends here -- 2.9.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 08:42:52 2017 Received: (at 26457) by debbugs.gnu.org; 12 Apr 2017 12:42:52 +0000 Received: from localhost ([127.0.0.1]:43913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyHbn-0006js-Tv for submit@debbugs.gnu.org; Wed, 12 Apr 2017 08:42:52 -0400 Received: from petton.fr ([89.234.186.68]:33741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyHbm-0006je-28 for 26457@debbugs.gnu.org; Wed, 12 Apr 2017 08:42:50 -0400 From: Nicolas Petton To: Damien Cassou Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression In-Reply-To: <871ssy6mqn.fsf@cassou.me> References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> <87efwy2ful.fsf@petton.fr> <871ssy6mqn.fsf@cassou.me> Date: Wed, 12 Apr 2017 14:42:41 +0200 Message-ID: <874lxt3igu.fsf@petton.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1492000962; bh=pErMuamUpfKWfCX4WkSYxA3aNzEd/EpqBKjV5avBS6s=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type; b=iLHZcjnFq31OIDRswIU4kpcxu+RKwCUPHnXwMfhl4+OZNyyr0LmoQme3ovo22aXRlGSeFQbW7YlnZQ9EvSgwanQprtJC1Mf5t9XgUhIiQId1cF3xSHS8xfag/vJA6Ohf2py+siNtiiWJeCJouB7p0/ETGoYis9jj7y9KuNNQwPU= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 Cc: 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Damien Cassou writes: >>We usually say "non-nil". >=20=20 > done Thanks, it looks good to me. If nobody says anything I'll apply the patch to master tomorrow. Cheers, Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJY7iDBAAoJECM1h6R8IHkQ5EEH/3NFCbNuH3UzGGqAN+Eqt6dp uoVTU+2gUrpY74TdIwoUezSXuCA8QiSPtCYjhY0B8SrG20kUPnHJkk4ZqaXEUdnD 3hjO4TTlQXHqFtVZLb3FRn4Yd6vPA7gDb0uOX94C/7CeETQUaxjJNr6F1RnLkcds C4lrTY3qUr88xM5J9jBGj8hnAFDeIOezYTOMY62yn43WGwkOpp+ByFgt8EphKLep ljwARXa+KUlrlyvnwyC8q4Z9fQjNwRw+59nqlnrg6Eg9KM9d9iCZwsDuhGUCc/BB SxI1VtTh/rotQfjAxtzxmSagUfwo9bMi4m6zTgE4E8xm3F+8xy8/Isi1Mhn5VGQ= =zkJP -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 05:45:23 2017 Received: (at 26457) by debbugs.gnu.org; 13 Apr 2017 09:45:24 +0000 Received: from localhost ([127.0.0.1]:45057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cybJb-0000ZD-OM for submit@debbugs.gnu.org; Thu, 13 Apr 2017 05:45:23 -0400 Received: from petton.fr ([89.234.186.68]:34060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cybJY-0000Yz-8E for 26457@debbugs.gnu.org; Thu, 13 Apr 2017 05:45:22 -0400 From: Nicolas Petton To: Damien Cassou Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression In-Reply-To: <871ssy6mqn.fsf@cassou.me> References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> <87efwy2ful.fsf@petton.fr> <871ssy6mqn.fsf@cassou.me> Date: Thu, 13 Apr 2017 11:45:12 +0200 Message-ID: <87r30w4p5j.fsf@petton.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1492076713; bh=+x3pbyEh5/g1ZXpLX2Y+iLo12mJntQCpLTZn99C4uUc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type; b=AiL7oVKQee2ThCoPqOTQVwyJ6qlYdZi0ciXN+0JZ/yCZEQ3/sbxtW/hnH6KMTQ+ChY4YgTUkcvmVYH/brAJLkCT3Gkq0DAx29UpTUc6b4UXRYxtdW3ljwmwyTZ3fWVbD5wNMHuAXfIL3EjOtJDU1vVCi8uPAEfY9wPp0lx/kf28= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 Cc: 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Damien Cassou writes: > done Thanks, I just applied the patch on master. Cheers, Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJY70ioAAoJECM1h6R8IHkQyJ4H/3VQ3deuVcVZpko72HyYEBgt CUJSZQoICsT8UiET23Lyxmgqsf/yzZ9BbKUV0TJPcS+cWJQFqKexc6fv4aFtQ5cU 6cCnfv1hNG0Zx8f0K93d0KrbSJOIAvNBAShX/mK23O6F728KnNo4pviMR3/fh2GF gyOL5hgNl89mzXOmNlXlz1Bp7VF+C4kvmWMGUNGlhXHj1+K6EbO4q6H7t4Wr4Jkj hr8ZvP6SKDs/AHCaL2EaUdPfCsY3dDEM9pVKlpyB5jOq2+LNliks3ufTeatGFRoX QWjCizU5q3gUIsoRj1Cz7yMpY2b0wf3XvdcRKnmIY9TpY/uhM11mXZYev88OkXM= =5yNs -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 05:47:52 2017 Received: (at 26457-done) by debbugs.gnu.org; 13 Apr 2017 09:47:52 +0000 Received: from localhost ([127.0.0.1]:45061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cybM0-0000cu-4F for submit@debbugs.gnu.org; Thu, 13 Apr 2017 05:47:52 -0400 Received: from petton.fr ([89.234.186.68]:34089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cybLy-0000ci-TD for 26457-done@debbugs.gnu.org; Thu, 13 Apr 2017 05:47:51 -0400 From: Nicolas Petton To: 26457-done@debbugs.gnu.org Subject: [Nicolas Petton] Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression Date: Thu, 13 Apr 2017 11:47:43 +0200 Message-ID: <87mvbk4p1c.fsf@petton.fr> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="==-=-=" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1492076865; bh=hGiBRLGWeXDMz8SpZFvVN44uabJAe1glgT4yvwiJ/YY=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=nxuI48r9+hmqm7Yg5uJ+azvJGxXWomypk8wqmkrSN8ib6QpX9bDbCBBJtFunzp7HW7aGF6EIYNrWTyL/z6FzbET/3rxjkKCTK2LSsinTvv52C8EmgrV+uDMe7Rof43fwgxLPGOCl2ZliSJ/8NxjDLPcZC7byPiRuZph1GDBmqGc= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --==-=-= Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 8bit From: Nicolas Petton To: Damien Cassou Cc: 26457@debbugs.gnu.org Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression In-Reply-To: <871ssy6mqn.fsf@cassou.me> References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> <87efwy2ful.fsf@petton.fr> <871ssy6mqn.fsf@cassou.me> Date: Thu, 13 Apr 2017 11:45:12 +0200 Message-ID: <87r30w4p5j.fsf@petton.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Damien Cassou writes: > done Thanks, I just applied the patch on master. Cheers, Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJY70iqAAoJECM1h6R8IHkQycgH/10PZf7kIOdLwTNe4d6eUR56 2edbvyLDoMgJPFkYp+zQOdEjQQD/+9mbD+DiPh9PYVYY039iSG3QZpo/j5WMYId3 gRAVnHyM66shu5asfKYaGznn0A9URiAyR+lcsZUeoZBdZURB/RLyZTIMCGsmNDjK 0WF8JKFSH+M48pGiCeeZ6aAHSlHt/l1SaP5A29dMWAc0v2pj9YNMobzldriSrC+C ROkxmHg0gFJyPomX3LEYpkMgUEIoAv9aGi54DTdBb9PiErTHesUqRxXOhsQx12sN I2jWwHKkBrWVSle3ATrca/Tohx/QTkpYznwIrSq/8tTlpxfTMtnYKZbBLW5wN3k= =IYae -----END PGP SIGNATURE----- --=-=-=-- --==-=-= Content-Type: multipart/signed; boundary="===-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --===-=-= Content-Type: text/plain --===-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJY70k/AAoJECM1h6R8IHkQCbIH/j4g95dWWMIJfZlrceOhopX6 16ygDAeV5bhgJBoAU3+L+bSJhMkKeZ4jO6izjsRppbByRjP8F+R+WYvATLJRhp9o e9TGpZd/lLSsj9aw7YVoWrzN5aDG3m2Us5m2kBNY7CSay8xDZa4vV8dWBp2rKYAh zHFPsgW5wkH06UrF7YTugTmX0P0Hu+2zMjmmwZti759TNDOfG0j/s6rtGUtY7yLG WGYz3rfW10P9x251H5RJnJT9asPHhG/I4TZnVtYQ6hH7Fjz68suS8DBB34EIiBos tmFBlXOK0C6yULQwGZU4Ivhz2L5DLxaZYFKrLtXn4AinSuplNB5+Ccqonofat0w= =W5vj -----END PGP SIGNATURE----- --===-=-=-- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 06:35:38 2017 Received: (at 26457) by debbugs.gnu.org; 13 Apr 2017 10:35:38 +0000 Received: from localhost ([127.0.0.1]:45085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyc6E-0001uL-Kl for submit@debbugs.gnu.org; Thu, 13 Apr 2017 06:35:38 -0400 Received: from mail.choca.pics ([62.210.108.126]:33798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cyc6B-0001u6-Qg for 26457@debbugs.gnu.org; Thu, 13 Apr 2017 06:35:37 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id D63A3232B020; Thu, 13 Apr 2017 12:35:34 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id HW9olgimwEdP; Thu, 13 Apr 2017 12:35:34 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 06524232B184; Thu, 13 Apr 2017 12:35:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.choca.pics 06524232B184 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=9EA44F5C-DEF4-11E6-A83F-A08DF322D8FB; t=1492079734; bh=r36DYmGBtAZbxkoZSf4kUsBlSG8+CibB6kLs9gXcRms=; h=From:To:Date:Message-ID:MIME-Version; b=R56bvfqvdQ1hGAYq4FsZGBpNkD5kGXgoc1YhgrauhNO/S/odv0UQ9/UN8cpm6N3CV Z6j+xIGzWrtld/W7W3z/jWez9PJ3ooctQV6BsFieKUZblXylEl2ddl2FtvWmWAUhmQ z2UzaGsbkNn/UCWdKuZssotVH8x5mgnj4Oo5KcOWdtZXn5quOHLoRbsDdTcH9l2++V KAplS3LovDkvRNUy99YXKreUrGvqiDlfs1UT0LyOCT3Pvd2bLYmn/LpsVDspriFFDz nmMbUoPI0peatsLacHqfAQqnKHKanoR0HsGFzXLo8CB7tNvRh+kXqb4zBFCha0JUPx 8sj31UnX90FcQ== X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id CXRDc7LCKavR; Thu, 13 Apr 2017 12:35:33 +0200 (CEST) Received: from luz4 (31-211-216-84.customers.ownit.se [31.211.216.84]) by mail.choca.pics (Postfix) with ESMTPSA id B1756232B020; Thu, 13 Apr 2017 12:35:33 +0200 (CEST) From: Damien Cassou To: Nicolas Petton Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression In-Reply-To: <87r30w4p5j.fsf@petton.fr> References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> <87efwy2ful.fsf@petton.fr> <871ssy6mqn.fsf@cassou.me> <87r30w4p5j.fsf@petton.fr> Date: Thu, 13 Apr 2017 12:35:31 +0200 Message-ID: <87bms0egss.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 Cc: 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Nicolas Petton writes: > Thanks, I just applied the patch on master. thank you very much. Does it make sense to put it in 25 branch as well? I'm building a mode which needs this bug fix. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 06:42:04 2017 Received: (at 26457) by debbugs.gnu.org; 13 Apr 2017 10:42:04 +0000 Received: from localhost ([127.0.0.1]:45089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cycCS-00028D-BS for submit@debbugs.gnu.org; Thu, 13 Apr 2017 06:42:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cycCQ-00027g-EO for 26457@debbugs.gnu.org; Thu, 13 Apr 2017 06:42:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cycCH-0001Iu-W6 for 26457@debbugs.gnu.org; Thu, 13 Apr 2017 06:41:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cycCH-0001Iq-St; Thu, 13 Apr 2017 06:41:53 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cycCG-0001Dz-Pu; Thu, 13 Apr 2017 06:41:53 -0400 Date: Thu, 13 Apr 2017 13:42:14 +0300 Message-Id: <831sswio6x.fsf@gnu.org> From: Eli Zaretskii To: Damien Cassou In-reply-to: <87bms0egss.fsf@cassou.me> (message from Damien Cassou on Thu, 13 Apr 2017 12:35:31 +0200) Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> <87efwy2ful.fsf@petton.fr> <871ssy6mqn.fsf@cassou.me> <87r30w4p5j.fsf@petton.fr> <87bms0egss.fsf@cassou.me> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 26457 Cc: nicolas@petton.fr, 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Damien Cassou > Date: Thu, 13 Apr 2017 12:35:31 +0200 > Cc: 26457@debbugs.gnu.org > > Nicolas Petton writes: > > Thanks, I just applied the patch on master. > > thank you very much. Does it make sense to put it in 25 branch as > well? Not before Emacs 25.2 is released, no. And maybe not afterwards as well, depending on what, if anything we would like to release from that branch after 25.2. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 13 07:09:42 2017 Received: (at 26457) by debbugs.gnu.org; 13 Apr 2017 11:09:42 +0000 Received: from localhost ([127.0.0.1]:45103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cycdB-0004ZK-U1 for submit@debbugs.gnu.org; Thu, 13 Apr 2017 07:09:42 -0400 Received: from mail.choca.pics ([62.210.108.126]:34154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cycdA-0004ZB-6S for 26457@debbugs.gnu.org; Thu, 13 Apr 2017 07:09:41 -0400 Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 10373232A861; Thu, 13 Apr 2017 13:09:39 +0200 (CEST) Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id bM54HWS4d8Td; Thu, 13 Apr 2017 13:09:38 +0200 (CEST) Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 1F353232B186; Thu, 13 Apr 2017 13:09:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.choca.pics 1F353232B186 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cassou.me; s=9EA44F5C-DEF4-11E6-A83F-A08DF322D8FB; t=1492081778; bh=jz3UTPVsI7RfymM8ttXaQg+FQzpOwcArWfkWXQJF3us=; h=From:To:Date:Message-ID:MIME-Version; b=T/PaCA9sIvYFGgeuNSD3xnJAmIaSSUwEueLBcXVtxFjeM7KbOSEZhq7alixJEYXWX C7qExO9+W4xJL3sI1JkQsfVVwxHrhnj9Vd4KNylKL+5EmzDvAu8YVLzcqbCEoWx4Q+ xBr8idOUeQ5c3YjFTQ08Sl2Y0r0H1k5b0mKh8gUPAouairsKlnPahCHdcC5KYzpzp/ FLT1Otdz22FN2y5PG+RKIfyywO6MTCa2e26kGD74yWRsw3xsmevvt2IlpqYFGKz3bZ 4Id6gap4jT+qy54O/tWHebTgrQY37y2HGXdoYkoQaQWKj4YIsPO6wPNTfrWpoyYXfH f22JSlPlGKSWQ== X-Virus-Scanned: amavisd-new at choca.pics Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id NcNJe82msMdO; Thu, 13 Apr 2017 13:09:38 +0200 (CEST) Received: from luz4 (31-211-216-84.customers.ownit.se [31.211.216.84]) by mail.choca.pics (Postfix) with ESMTPSA id 8C5A4232A861; Thu, 13 Apr 2017 13:09:37 +0200 (CEST) From: Damien Cassou To: Eli Zaretskii Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression In-Reply-To: <831sswio6x.fsf@gnu.org> References: <87a87mz14q.fsf@cassou.me> <87bms26pzb.fsf@cassou.me> <87efwy2ful.fsf@petton.fr> <871ssy6mqn.fsf@cassou.me> <87r30w4p5j.fsf@petton.fr> <87bms0egss.fsf@cassou.me> <831sswio6x.fsf@gnu.org> Date: Thu, 13 Apr 2017 13:09:34 +0200 Message-ID: <878tn4ef81.fsf@cassou.me> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 26457 Cc: nicolas@petton.fr, 26457@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > Not before Emacs 25.2 is released, no. And maybe not afterwards > as well, depending on what, if anything we would like to release > from that branch after 25.2. I understand. Thanks for the explanation. -- Damien Cassou http://damiencassou.seasidehosting.st "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill From unknown Sun Jun 22 03:53:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 May 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator