GNU bug report logs - #26457
25.2; Cannot pass a function to imenu-generic-expression

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26457 in the body.
You can then email your comments to 26457 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2; Cannot pass a function to imenu-generic-expression
Date: Wed, 12 Apr 2017 06:43:49 +0200

$ emacs -Q

M-:
(setq-local imenu-generic-expression `(("Foo" "^;; .*$" 0 ,(lambda 
(item pos) (message "%s" item)))))

M-x imenu

This results in

 sort: Wrong type argument: number-or-marker-p, (#<marker at 72 
 in *scratch*> (lambda (item pos) (message "%s" item)))

In GNU Emacs 25.2.3 (x86_64-unknown-linux-gnu, GTK+ Version 
3.22.9) 
of 2017-03-09 built on x230
Repository revision: aceac954ed29c2653e2a0eb71b899be5c916edda
Windowing system distributor 'Fedora Project', version 
11.0.11903000
Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF 
GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT 
LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11
Important settings:
 value of $LANG: fr_FR.UTF-8
 value of $XMODIFIERS: @im=ibus
 locale-coding-system: utf-8-unix

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Message #8 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Wed, 12 Apr 2017 09:32:08 +0200

[Message part 1 (text/plain, inline)]

Damien Cassou <damien <at> cassou.me> writes:
>  sort: Wrong type argument: number-or-marker-p, (#<marker at 72 
>  in 
> *scratch*> (lambda (item pos) (message "%s" item)))

here is a patch 

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

[0001-Fix-imenu-sort-by-position-for-non-pairs-parameters-.patch (text/x-patch, attachment)]

Message #11 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Damien Cassou <damien <at> cassou.me>
Cc: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Wed, 12 Apr 2017 10:03:10 +0200

tags 26457 patch
thanks

Message #16 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Damien Cassou <damien <at> cassou.me>
Cc: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Wed, 12 Apr 2017 10:24:34 +0200

Damien Cassou <damien <at> cassou.me> writes:

>  (defun imenu--sort-by-position (item1 item2)
> -  (< (cdr item1) (cdr item2)))
> +  "Comparison function to sort items depending on their position.
> +Return t if and only if ITEM1's position is lower than ITEM2's
          ^^        
          We usually say "non-nil".

> +(ert-deftest imenu--sort-by-position-pairs ()
> +  (should (imenu--sort-by-position '("a" . 2) '("a" . 3)))
> +  (should-not (imenu--sort-by-position '("a" . 3) '("a" . 2))))
> +
> +;; Regression test for bug#26457: 25.2; Cannot pass a function to
> +;; imenu-generic-expression
> +(ert-deftest imenu--sort-by-position-list ()
> +  (should (imenu--sort-by-position '("a" 2 nil) '("a" 3 nil)))
> +  (should-not (imenu--sort-by-position '("a" 3 nil) '("a" 2 nil))))

Thanks for the regression test!

Cheers,
Nico

Message #19 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Wed, 12 Apr 2017 10:42:08 +0200

[Message part 1 (text/plain, inline)]

Nicolas Petton <nicolas <at> petton.fr> writes:
>We usually say "non-nil".


done 

-- 
Damien Cassou
Företagsplatsen AB
Phone/Fax: +46 (0)8 774 63 00
Mobile: +33 (0)6 80 50 18 91
Address: Skeppsbron 26, 4tr, SE-111 30 Stockholm
Web: www.foretagsplatsen.se

[0001-Fix-imenu-sort-by-position-for-non-pairs-parameters-.patch (text/x-patch, attachment)]

Message #22 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Damien Cassou <damien <at> cassou.me>
Cc: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Wed, 12 Apr 2017 14:42:41 +0200

[Message part 1 (text/plain, inline)]

Damien Cassou <damien <at> cassou.me> writes:

>>We usually say "non-nil".
>  
> done

Thanks, it looks good to me.
If nobody says anything I'll apply the patch to master tomorrow.

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: Damien Cassou <damien <at> cassou.me>
Cc: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Thu, 13 Apr 2017 11:45:12 +0200

[Message part 1 (text/plain, inline)]

Damien Cassou <damien <at> cassou.me> writes:

> done

Thanks, I just applied the patch on master.

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

Message #30 received at 26457-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Petton <nicolas <at> petton.fr>
To: 26457-done <at> debbugs.gnu.org
Subject: [Nicolas Petton] Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Thu, 13 Apr 2017 11:47:43 +0200

[Message part 1 (message/rfc822, inline)]

From: Nicolas Petton <nicolas <at> petton.fr>
To: Damien Cassou <damien <at> cassou.me>
Cc: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2; Cannot pass a function to imenu-generic-expression
Date: Thu, 13 Apr 2017 11:45:12 +0200

[Message part 2 (text/plain, inline)]

Damien Cassou <damien <at> cassou.me> writes:

> done

Thanks, I just applied the patch on master.

Cheers,
Nico

[signature.asc (application/pgp-signature, inline)]

[Message part 4 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

Message #33 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Nicolas Petton <nicolas <at> petton.fr>
Cc: 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Thu, 13 Apr 2017 12:35:31 +0200

Nicolas Petton <nicolas <at> petton.fr> writes:
> Thanks, I just applied the patch on master. 

thank you very much. Does it make sense to put it in 25 branch as 
well?  I'm building a mode which needs this bug fix. 

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Message #36 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Damien Cassou <damien <at> cassou.me>
Cc: nicolas <at> petton.fr, 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Thu, 13 Apr 2017 13:42:14 +0300

> From: Damien Cassou <damien <at> cassou.me>
> Date: Thu, 13 Apr 2017 12:35:31 +0200
> Cc: 26457 <at> debbugs.gnu.org
> 
> Nicolas Petton <nicolas <at> petton.fr> writes:
> > Thanks, I just applied the patch on master. 
> 
> thank you very much. Does it make sense to put it in 25 branch as 
> well?

Not before Emacs 25.2 is released, no.  And maybe not afterwards as
well, depending on what, if anything we would like to release from
that branch after 25.2.

Message #39 received at 26457 <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien <at> cassou.me>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: nicolas <at> petton.fr, 26457 <at> debbugs.gnu.org
Subject: Re: bug#26457: 25.2;
 Cannot pass a function to imenu-generic-expression
Date: Thu, 13 Apr 2017 13:09:34 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:
> Not before Emacs 25.2 is released, no.  And maybe not afterwards 
> as well, depending on what, if anything we would like to release 
> from that branch after 25.2. 

I understand. Thanks for the explanation.

-- 
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.