Subject: Re: bug#26454: [PATCH 2/2] gnu: add emacs-exwm

From: Arun Isaac <[email-masked]>
Date: Fri, 14 Apr 2017 18:57:21 +0530

Thanks for the patches.

> +(define-public emacs-xelb
> +  (package
> +    (name "emacs-xelb")
> +    (version "0.12.d1d6b6c")
> +    (home-page "https://github.com/ch11ng/xelb")

Could you put the home-page just before the synopsis as commonly done
in other package definitions?

> +    (synopsis "X protocol Emacs Lisp Binding")
> +    (description "XELB (X protocol Emacs Lisp Binding) is a pure Elisp

Please make this "@code{emacs-xelb} is a pure Emacs Lisp implementation
of ...". No need to repeat "X protocol Emacs Lisp Binding" as it is
already mentioned in the synopsis. Expand Elisp -> Emacs Lisp.

> +implementation of X11 protocol based on the XML description files from

*the* X11 protocol

> +XCB project.  It features an object-oriented API and permits a certain

*the* XCB project

> +degree of concurrency.  It should enable you to implement some low-level

Remove "some". It makes the whole sentence sound vague.

> +X11 applications.")

> +(define-public emacs-exwm
> +  (package
> +    (name "emacs-exwm")
> +    (home-page "https://github.com/ch11ng/exwm")

Same about home-page.

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit "7a5bb1156d07848e465f55fd31f8ec755b52aa01")))
> +              (file-name (string-append name "-" version))

Append "-checkout" at the end of file-name just like you did for
emacs-xelb.

LGTM, otherwise!

>> In your new patch, could you add a phase for generating this code from
>> the xcb-proto xml files as well? Thanks!

> I don't think it it a good idea, xcb-xproto.el provided by repo is
> tested by developer. if we regenerate it, i don't know whether it
> work or not.

@Ludo:

Could you please comment on this?