GNU bug report logs - #26441
Gnulib’s ‘test-lock’ fails to complete on machines with >= 32 cores

Previous Next

Full log

Message #38 received at 26441 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>, 26441 <at> debbugs.gnu.org
Subject: Re: bug#26441: [PATCH] gnu: findutils: Fix make check issues
 on	multi-core machines.
Date: Thu, 13 Apr 2017 21:38:46 +0200

[Message part 1 (text/plain, inline)]

Hi, thanks for working on these!

[...]
  
>  (define-public findutils
>    (package
> -   (name "findutils")
> -   (version "4.6.0")
> -   (source (origin
> -            (method url-fetch)
> -            (uri (string-append "mirror://gnu/findutils/findutils-"
> -                                version ".tar.gz"))
> -            (sha256
> -             (base32
> -              "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y"))
> -            (patches (search-patches "findutils-localstatedir.patch"
> -                                     "findutils-test-xargs.patch"))))
> -   (build-system gnu-build-system)
> -   (arguments
> -    `(#:configure-flags (list
> -                         ;; Tell 'updatedb' to write to /var.
> -                         "--localstatedir=/var"
> -
> -                         ;; Work around cross-compilation failure.  See
> -                         ;; <http://savannah.gnu.org/bugs/?27299#comment1>.
> -                         ,@(if (%current-target-system)
> -                               '("gl_cv_func_wcwidth_works=yes")
> -                               '()))))
> -   (synopsis "Operating on files matching given criteria")
> -   (description
> -    "Findutils supplies the basic file directory searching utilities of the
> +    (name "findutils")
> +    (version "4.6.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://gnu/findutils/findutils-"
> +                                  version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "178nn4dl7wbcw499czikirnkniwnx36argdnqgz4ik9i6zvwkm6y"))
> +              (patches (search-patches
> +                        "findutils-localstatedir.patch"
> +                        "findutils-test-xargs.patch"
> +                        ;; test-lock has performance issues on multi-core
> +                        ;; machines, it hangs or takes a long time to complete.
> +                        ;; This is a commit from gnulib to fix this issue.
> +                        "findutils-gnulib-multi-core.patch"))))

Please don't mix large indentation changes with functional changes. It
is really difficult to tell what this commit does. Can you split the
indentation change out in a separate commit?

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.