GNU bug report logs - #26437
[PATCH] gnu: Add emacspeak.

Previous Next

Full log

Message #11 received at 26437 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 26437 <at> debbugs.gnu.org
Subject: Re: bug#26437: [PATCH] gnu: Add emacspeak.
Date: Tue, 11 Apr 2017 11:22:21 -0400

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hello Kei,
>
> Kei Kebreau <kei <at> openmailbox.org> skribis:
>
>> * gnu/packages/emacs.scm (emacspeak): New variable.
>
> [...]
>
>> +         (add-after 'install-espeak-server 'wrap-program
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (emacspeak (string-append out "/bin/emacspeak"))
>> +                    (espeak (string-append (assoc-ref inputs "espeak")
>> +                                          "/bin/espeak")))
>> +               (wrap-program emacspeak
>> +                 `("DTK_PROGRAM" ":" prefix (,espeak)))))))
>
> Please return #t here.  Could you also add a note about what
> ‘DTK_PROGRAM’ is and what component honors it?
>
>> +    (home-page "http://emacspeak.sourceforge.net")
>> +    (synopsis "Audio desktop interface for Emacs")
>> +    (description
>> + "Emacspeak is an Emacs subsystem that provides complete speech
>> access.")
>
> Could you expound a bit, probably borrowing bits from their home page?
>
> Otherwise LGTM.  OK with these changes!
>
> Thanks,
> Ludo’.

Pushed to master with the required changes. Thanks for the review.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.