Subject: Re: bug#26437: [PATCH] gnu: Add emacspeak.

From: Kei Kebreau <[email-masked]>
Date: Tue, 11 Apr 2017 11:22:21 -0400

[email-masked] (Ludovic Courtès) writes:

> Hello Kei,
>
> Kei Kebreau <[email-masked]> skribis:
>
>> * gnu/packages/emacs.scm (emacspeak): New variable.
>
> [...]
>
>> +         (add-after 'install-espeak-server 'wrap-program
>> +           (lambda* (#:key inputs outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (emacspeak (string-append out "/bin/emacspeak"))
>> +                    (espeak (string-append (assoc-ref inputs "espeak")
>> +                                          "/bin/espeak")))
>> +               (wrap-program emacspeak
>> +                 `("DTK_PROGRAM" ":" prefix (,espeak)))))))
>
> Please return #t here.  Could you also add a note about what
> ‘DTK_PROGRAM’ is and what component honors it?
>
>> +    (home-page "http://emacspeak.sourceforge.net")
>> +    (synopsis "Audio desktop interface for Emacs")
>> +    (description
>> + "Emacspeak is an Emacs subsystem that provides complete speech
>> access.")
>
> Could you expound a bit, probably borrowing bits from their home page?
>
> Otherwise LGTM.  OK with these changes!
>
> Thanks,
> Ludo’.

Pushed to master with the required changes. Thanks for the review.