GNU bug report logs - #26425
[PATCH 1/2] gnu: Add python-poppler-qt5.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 26425 in the body.
You can then email your comments to 26425 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: guix-patches <at> gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH 1/2] gnu: Add python-poppler-qt5.
Date: Sun,  9 Apr 2017 22:47:52 +0200

* gnu/packages/pdf.scm (python-poppler-qt5): New variable.
---
 gnu/packages/pdf.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/gnu/packages/pdf.scm b/gnu/packages/pdf.scm
index 7f3dccc8b..0882d3b94 100644
--- a/gnu/packages/pdf.scm
+++ b/gnu/packages/pdf.scm
@@ -184,6 +184,53 @@
 Poppler PDF rendering library.")
     (license license:lgpl2.1+)))
 
+(define-public python-poppler-qt5
+  (package
+    (name "python-poppler-qt5")
+    (version "0.24.2")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "python-poppler-qt5" version))
+        (sha256
+         (base32
+          "0l69llw1fzwz8y90q0qp9q5pifbrqjjbwii7di54dwghw5fc6w1r"))))
+    (build-system python-build-system)
+    (arguments
+     `(;; There are no tests.  The check phase just causes a rebuild.
+       #:tests? #f
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'build
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "setup.py"
+               ;; This check always fails, so disable it.
+               (("if not check_qtxml\\(\\)")
+                "if True")
+               ;; Enable C++11, which is needed because of Qt5.
+               (("\\*\\*ext_args" line)
+                (string-append "extra_compile_args=['-std=gnu++11'], " line)))
+             ;; We need to pass an extra flag here.  This cannot be in
+             ;; configure-flags because it should not be passed for the
+             ;; installation phase.
+             ((@@ (guix build python-build-system) call-setuppy)
+              "build_ext" (list (string-append "--pyqt-sip-dir="
+                                               (assoc-ref inputs "python-pyqt")
+                                               "/share/sip")) #t))))))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (inputs
+     `(("python-sip" ,python-sip)
+       ("python-pyqt" ,python-pyqt)
+       ("poppler-qt5" ,poppler-qt5)
+       ("qtbase" ,qtbase)))
+    (home-page "https://pypi.python.org/pypi/python-poppler-qt5")
+    (synopsis "Python bindings for Poppler-Qt5")
+    (description
+     "This package provides Python bindings for the Qt5 interface of the
+Poppler PDF rendering library.")
+    (license license:lgpl2.1+)))
+
 (define-public libharu
   (package
    (name "libharu")
-- 
2.12.2

Message #8 received at 26425 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 26425 <at> debbugs.gnu.org
Subject: Re: bug#26425: [PATCH 1/2] gnu: Add python-poppler-qt5.
Date: Mon, 10 Apr 2017 11:12:55 +0200

Ricardo Wurmus <rekado <at> elephly.net> skribis:

> * gnu/packages/pdf.scm (python-poppler-qt5): New variable.

LGTM!

> +             (substitute* "setup.py"
> +               ;; This check always fails, so disable it.
> +               (("if not check_qtxml\\(\\)")
> +                "if True")

The check fails wrongfully?

> +    (description
> +     "This package provides Python bindings for the Qt5 interface of the
> +Poppler PDF rendering library.")

Python bindings of the Qt bindings of…  fun!  ;-)

Thank you,
Ludo’.

Message #11 received at 26425 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 26425 <at> debbugs.gnu.org
Subject: Re: bug#26425: [PATCH 1/2] gnu: Add python-poppler-qt5.
Date: Tue, 11 Apr 2017 10:06:21 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>
>> * gnu/packages/pdf.scm (python-poppler-qt5): New variable.
>
> LGTM!
>
>> +             (substitute* "setup.py"
>> +               ;; This check always fails, so disable it.
>> +               (("if not check_qtxml\\(\\)")
>> +                "if True")
>
> The check fails wrongfully?

Yes.  We do provide qtxml with qtbase.  It’s easier to disable this
check than to fix it, given that we know that we have qtxml.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #16 received at 26425-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 26425-done <at> debbugs.gnu.org
Subject: Re: bug#26425: [PATCH 1/2] gnu: Add python-poppler-qt5.
Date: Sat, 22 Apr 2017 23:13:57 +0200

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Ricardo Wurmus <rekado <at> elephly.net> skribis:
>>
>>> * gnu/packages/pdf.scm (python-poppler-qt5): New variable.
>>
>> LGTM!
>>
>>> +             (substitute* "setup.py"
>>> +               ;; This check always fails, so disable it.
>>> +               (("if not check_qtxml\\(\\)")
>>> +                "if True")
>>
>> The check fails wrongfully?
>
> Yes.  We do provide qtxml with qtbase.  It’s easier to disable this
> check than to fix it, given that we know that we have qtxml.

I forgot to close this bug.  This has been pushed to master with commit
99bcae94bcd50fc15bf44b5cc06cd39450f01ad5.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.