Subject: bug#26420: [PATCH 2/2] gnu: Add emacs-use-package.

From: [email-masked] (Ludovic Courtès)
Date: Mon, 10 Apr 2017 14:43:54 +0200

Arun Isaac <[email-masked]> skribis:

>>> +    (arguments
>>> +     `(#:phases
>>> +       (modify-phases %standard-phases
>>> +         ;; tests fail in this release
>>> +         (add-before 'install 'check
>>> +           (lambda _
>>> +             (zero? (system* "emacs" "--batch" "-L" "."
>>> +                             "-l" "use-package-tests.el"
>>> +                             "-f" "ert-run-tests-batch-and-exit"))
>>> +             #t)))))
>>
>> Please remove #t as it would hide a failure of the “emacs --batch”
>> command above.
>
> As noted in the comment, the tests fail in this release. I have put the
> #t there to make the package build succeed. In the upstream git
> checkout, tests pass. So, in the next release, tests should pass. When
> updating the package, the #t should be removed. Is this ok? Shall I
> leave the #t there?

Oh sure.  Maybe move the comment closer to #t and, if you have the
reference of the upstream fix, you can put it there.

Thanks,
Ludo’.