GNU bug report logs - #26360
26.0.50; ido-mode doesn't enable IDO for C-x 4 d

Previous Next

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 26360 <at> debbugs.gnu.org
Subject: bug#26360: 26.0.50; ido-mode doesn't enable IDO for C-x 4 d
Date: Sat, 22 Apr 2017 17:40:18 -0400

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

> <npostavs <at> users.sourceforge.net> schrieb am Fr., 21. Apr. 2017 um 05:28 Uhr:
>>
>> Patch looks good, except the test seems redundant to me.  I don't think
>> it's useful to test that a command is defined, or testing that specific
>> keybindings have been set (i.e., no need to test again that `defun' or
>> `define-key' are working).
>
>
> I've used a bit of TDD for this patch, thus the verbose test.

I suppose my real objection is that 'make check' is already taking long
enough that it makes me reluctant to use it, so I don't really want to
see more tests of such marginal utility.  But any single test isn't
adding a significant amount of time, so I'm not going to insist.

In conclusion, feel free to push this; as far as I'm concerned, the
decision about the test is up to you.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.