From unknown Tue Jun 17 20:14:09 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#26355 <26355@debbugs.gnu.org> To: bug#26355 <26355@debbugs.gnu.org> Subject: Status: 26.0.50; find-library doesn't handle load-history entries with nil FILE-NAME Reply-To: bug#26355 <26355@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:14:09 +0000 retitle 26355 26.0.50; find-library doesn't handle load-history entries wit= h nil FILE-NAME reassign 26355 emacs submitter 26355 npostavs@users.sourceforge.net severity 26355 minor tag 26355 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 03 21:26:38 2017 Received: (at submit) by debbugs.gnu.org; 4 Apr 2017 01:26:38 +0000 Received: from localhost ([127.0.0.1]:59659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvDEz-0000Ax-Qq for submit@debbugs.gnu.org; Mon, 03 Apr 2017 21:26:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvDEx-0000Ak-SV for submit@debbugs.gnu.org; Mon, 03 Apr 2017 21:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvDEl-0001Qp-O0 for submit@debbugs.gnu.org; Mon, 03 Apr 2017 21:26:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cvDEl-0001Qc-LF for submit@debbugs.gnu.org; Mon, 03 Apr 2017 21:26:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvDEf-0001KM-7l for bug-gnu-emacs@gnu.org; Mon, 03 Apr 2017 21:26:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvDEZ-0001A2-4x for bug-gnu-emacs@gnu.org; Mon, 03 Apr 2017 21:26:17 -0400 Received: from mail-it0-x22d.google.com ([2607:f8b0:4001:c0b::22d]:32888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvDEX-000176-U0 for bug-gnu-emacs@gnu.org; Mon, 03 Apr 2017 21:26:10 -0400 Received: by mail-it0-x22d.google.com with SMTP id 68so14542652itx.0 for ; Mon, 03 Apr 2017 18:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=Vln5nZVGZw714KzfV2qi5dhFnNHM5qYXUeVJDRignkk=; b=T1iQo9t2V00FRQHAydUGijJXJWHqD8uWM6x/iRRwu/VErjSdwVqPzNZPThEwq9JYYM Izr69AXoYAkBxZGEGIQ6Y4Gf1QRUu9uHfJwor9PCghL9UQJHFHDrbAfWRKNBqWWjyaCF W51EEdWWYwTCJoA6N/La6cR8HoPBQTM98ZQwH/KEw1A1CQOJD37lOODl8weJpbVCPlST jNhQI68oGNoiMbRgwsHpvRMNOjz/kJhaxA6xwvxaY65nNDcYWQBNm40aCsIIEUM5cGPb SdjdzEUYL/YZPZrUzhhMkVMZmM+AOlnfqgAl+u3vYmcf7A5+czWITuxlijKMiFhsDUhQ ONpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=Vln5nZVGZw714KzfV2qi5dhFnNHM5qYXUeVJDRignkk=; b=YkID4QYBVNnn2GJ5PHA2aeMTg9+fkNmxVB4jKNoUBAhr05UIysG5yjQaRYgns/qWCw d1UCXBgZ6udP7BsBUdswDozxyiGsJfQjh5Xb2nQm/vjVvtf6V6D/paF3hKlEFFAEPFaO pU4gTUE4BiRIZZof+XxoEYB7bNxkmbtD8VhcBlr8gRZfqlFmZV5RNkEngpuNowVa3/Q7 BohgO4XQNtEa/LRQg9dynwe9cwOcjgrdWyV1my00nUHB+ueNIjR8hLITufQuInHYujhu MUJ5Meth66EANwUTQ3vMRntsGrMY1jCBH970p/NeSVj9+EqY1J7mDzJbQBdlq6jxK42J TVfw== X-Gm-Message-State: AFeK/H0qgs/TsMoMdgcge0taGFNcYyO0mhZplX6DbtCR8I/108yirZghtAdhIaUh43BSCg== X-Received: by 10.36.208.134 with SMTP id m128mr13428832itg.44.1491269169043; Mon, 03 Apr 2017 18:26:09 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id l129sm10361173ite.1.2017.04.03.18.26.07 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Apr 2017 18:26:08 -0700 (PDT) From: npostavs@users.sourceforge.net To: bug-gnu-emacs@gnu.org Subject: 26.0.50; find-library doesn't handle load-history entries with nil FILE-NAME Date: Mon, 03 Apr 2017 21:27:31 -0400 Message-ID: <87efx9vu64.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Severiy: minor Tags: patch emacs -Q Insert (defun foo ()) and C-M-x on it. M-x find-library blah RET gives "Wrong type argument: stringp, nil" Expected "find-library-name: Can=E2=80=99t find library blah" Here is a patch. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Let-find-library-name-handle-load-history-entries.patch Content-Description: pathc >From bbd991199206e9d23170d47e0ae2bfb616ba6fff Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 25 Mar 2017 22:41:34 -0400 Subject: [PATCH v1] Let find-library-name handle load-history entries with nil file-name * lisp/emacs-lisp/find-func.el (find-library--from-load-history): Rename from find-library--from-load-path. Check for `load-history' entries with nil FILE-NAMEs. Simplify by not double checking for suffixes and making use of `locate-file'. --- lisp/emacs-lisp/find-func.el | 48 ++++++++++++-------------------------------- 1 file changed, 13 insertions(+), 35 deletions(-) diff --git a/lisp/emacs-lisp/find-func.el b/lisp/emacs-lisp/find-func.el index 6699e3fd2b..d0acc14775 100644 --- a/lisp/emacs-lisp/find-func.el +++ b/lisp/emacs-lisp/find-func.el @@ -43,7 +43,7 @@ ;;; Code: -(require 'seq) +(eval-when-compile (require 'cl-lib)) ;;; User variables: @@ -203,43 +203,21 @@ find-library-name (locate-file rel (or find-function-source-path load-path) load-file-rep-suffixes))))) - (find-library--from-load-path library) + (find-library--from-load-history library) (error "Can't find library %s" library))) -(defun find-library--from-load-path (library) +(defun find-library--from-load-history (library) ;; In `load-history', the file may be ".elc", ".el", ".el.gz", and - ;; LIBRARY may be "foo.el" or "foo", so make sure that we get all - ;; potential matches, and then see whether any of them lead us to an - ;; ".el" or an ".el.gz" file. - (let* ((elc-regexp "\\.el\\(c\\(\\..*\\)?\\)\\'") - (suffix-regexp - (concat "\\(" - (mapconcat 'regexp-quote (find-library-suffixes) "\\'\\|") - "\\|" elc-regexp "\\)\\'")) - (potentials - (mapcar - (lambda (entry) - (if (string-match suffix-regexp (car entry)) - (replace-match "" t t (car entry)) - (car entry))) - (seq-filter - (lambda (entry) - (string-match - (concat "\\`" - (regexp-quote - (replace-regexp-in-string suffix-regexp "" library)) - suffix-regexp) - (file-name-nondirectory (car entry)))) - load-history))) - result) - (dolist (file potentials) - (dolist (suffix (find-library-suffixes)) - (when (not result) - (cond ((file-exists-p file) - (setq result file)) - ((file-exists-p (concat file suffix)) - (setq result (concat file suffix))))))) - result)) + ;; LIBRARY may be "foo.el" or "foo". + (let ((load-re + (concat "\\(" (regexp-quote (file-name-sans-extension library)) "\\)" + (regexp-opt (get-load-suffixes)) "\\'"))) + (cl-loop + for (file . _) in load-history thereis + (and (stringp file) (string-match load-re file) + (let ((dir (substring file 0 (match-beginning 1))) + (basename (match-string 1 file))) + (locate-file basename (list dir) (find-library-suffixes))))))) (defvar find-function-C-source-directory (let ((dir (expand-file-name "src" source-directory))) -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 03 21:29:58 2017 Received: (at control) by debbugs.gnu.org; 4 Apr 2017 01:29:58 +0000 Received: from localhost ([127.0.0.1]:59664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvDIE-0000G6-Bj for submit@debbugs.gnu.org; Mon, 03 Apr 2017 21:29:58 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:35008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvDID-0000Ft-Kd for control@debbugs.gnu.org; Mon, 03 Apr 2017 21:29:57 -0400 Received: by mail-io0-f180.google.com with SMTP id z13so87091931iof.2 for ; Mon, 03 Apr 2017 18:29:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=jKsqHghN3HpRoteIMWrS4OdVJswEFd+d0PeTj2E5Vdw=; b=K3A+ss2qIyJ1/vcAE5KvTPaBcy+eNxxZd/w/jvZQtPGPtRdzpV2tBADdLhxZB4phue TWDNm/71+zxZRTqalj81jh81nEDL31gvWUhyO2gZci+bzK0pIIS/j+8/xZTl6wmKpqx3 MrztkT3noLA81VBO5rTdrh+2d+B5s7AZz6iPfZTnxmOedFFqduwLVsk2PlqQcglg47S0 S3gouwVlQiUf0E/AjLZv79kAZ/K/0z3qkm2+8Rgg7KwDOAW9cbtOlRbt4AmjYmAGcxaN 8GTd08CnIH47+KdcixW0qcvgUEfYh7szhCXDMLHK6tSe/CIvMdkLw5WJyKYUWOiDLPon 5Zkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=jKsqHghN3HpRoteIMWrS4OdVJswEFd+d0PeTj2E5Vdw=; b=OnK3ZVvq/0aIch5Q0wck/OfiGlhCc8mu8B2k2MRwFWUlhuBuNEqh0kSAn0RYTV5DoP gV6W/AzPLVK9sFX5tBU86BN8IBDhMyzC/Fhi9ZwehChC/lCHkg4jb+pMQF9fjJnyCR8Q siH9W6FacTHFrbzUnkxYAk+SzZMGinUeaPl6NLnqLC0IzuiVTh1CQkRJsNcFfRtDL7d0 7MRFJKB2TqoIdBsCGmEk8wtfnxFz9vqlOuR6D6w15IX6nHpE4a5RDBYHqGwLDE8UvHhr 98gR1IGV2PAGlNBDtB187VPIgjllFXEIImgE8qlMAIN4pn66NFPb1oEAgZR0Y5bUX+Xi nFmQ== X-Gm-Message-State: AFeK/H0pTVB7qTh7OafZB+f41dp3/Y4dxdtcIH7Ixq13DPufB5kBGMrizUS19GcXUIuDsA== X-Received: by 10.107.132.140 with SMTP id o12mr18717326ioi.181.1491269391753; Mon, 03 Apr 2017 18:29:51 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p198sm6545172itg.31.2017.04.03.18.29.50 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Apr 2017 18:29:50 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: Re: bug#26355: 26.0.50; find-library doesn't handle load-history entries with nil FILE-NAME References: <87efx9vu64.fsf@users.sourceforge.net> Date: Mon, 03 Apr 2017 21:31:13 -0400 In-Reply-To: <87efx9vu64.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Mon, 03 Apr 2017 21:27:31 -0400") Message-ID: <87a87xvtzy.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) severity 26355 minor quit npostavs@users.sourceforge.net writes: > Severiy: minor From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 18 08:06:21 2017 Received: (at 26355) by debbugs.gnu.org; 18 Apr 2017 12:06:22 +0000 Received: from localhost ([127.0.0.1]:53521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0Rtl-0002pL-Oz for submit@debbugs.gnu.org; Tue, 18 Apr 2017 08:06:21 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:33831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d0Rtk-0002p0-1l; Tue, 18 Apr 2017 08:06:20 -0400 Received: by mail-io0-f170.google.com with SMTP id a103so188446655ioj.1; Tue, 18 Apr 2017 05:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=mDwFWMZUAQM6t15IDsTMtivinU8XYIIzLNOJ/5WEHak=; b=DyvNr0AOAKmRdxKAqvJUqH3I9Rog/5t3IkXivrUnNCnU9/yNHX/OlEGHAC3GrTIe/o aPQSuyDYEAKs6WZdOeUkOJWSz2epl8VMD7yyoy7Ct5hZuuLv6rO7DowsA9dbRELF/Eg/ I/ue+NtyNfwsUWWBFHPEzETuYUIPkWKmu3OnQBC788TuN7pHbqAFTQOwKimWAcmADfGc bb6cbwHoZTtve/PCJwAtjg6Zsgx9pqfZEQwGuwSjurPAh8Ddf4AV5PrhgdWe17DwKADW HSyWItioKafNSi+Un6xSWfHINGuRfzlNPLgj9a5AuvA+bHqK6J47ajyUFvmAoXFa1aUO DyLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=mDwFWMZUAQM6t15IDsTMtivinU8XYIIzLNOJ/5WEHak=; b=tXJc2yC3RDdDIH2O+5xEyGzL+qPj/PzJzx7oSrFmsXn7+ceOdLdPwDBzIojjYJKUiw ls03XP1oEuBGc/DgbqPw+oUHoeE6OCi+/DFEhho6ywkDIStLXZbl/YQ+/hRFIEFVCt7k ozi4/ll7ez3SXubBstUCkQgQ8+L/YKqPqfmCkM53ygYfatxZTIp/oi0b/KJem4bu6Oqj wINkOQl808KuCxGCHetVSTtPWP8MLRdulfwRQAYB4K0gVyEjVNn3Ii0ShzQ+L/ZNKwOq rGo3xkwJKTwWlxVzF9p0Bozq62/htmBMEGl8JhZOAlimtmC5sa7KRMngsmX/Pk3NLPvi S4Rw== X-Gm-Message-State: AN3rC/5IsIi1LHlGAU5DAj5jfn0tkZW2mtamIltAXr2kLi7pr3kt/pRv xAybUj7e5hpljv13 X-Received: by 10.36.116.205 with SMTP id o196mr13093355itc.96.1492517174344; Tue, 18 Apr 2017 05:06:14 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 139sm6289170ioz.2.2017.04.18.05.06.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Apr 2017 05:06:13 -0700 (PDT) From: npostavs@users.sourceforge.net To: 26355@debbugs.gnu.org Subject: Re: bug#26355: 26.0.50; find-library doesn't handle load-history entries with nil FILE-NAME References: <87efx9vu64.fsf@users.sourceforge.net> Date: Tue, 18 Apr 2017 08:07:41 -0400 In-Reply-To: <87efx9vu64.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Mon, 03 Apr 2017 21:27:31 -0400") Message-ID: <87a87dsyuq.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 26355 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 26355 fixed close 26355=20 quit npostavs@users.sourceforge.net writes: > emacs -Q > > Insert (defun foo ()) and C-M-x on it. > M-x find-library blah RET gives "Wrong type argument: stringp, nil" > Expected "find-library-name: Can=E2=80=99t find library blah" > > Here is a patch. Pushed to master [1: 861824dbec]. 1: 2017-04-18 07:54:28 -0400 861824dbecc96339c68b1e15008a21c31e04721b Fix find-library-name for load-history entries with nil FILE-NAME (Bug#26= 355) From unknown Tue Jun 17 20:14:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 17 May 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator