GNU bug report logs - #26345
25.1; vc-annotate in Git is unable to fully navigate the history if the file was moved

Previous Next

Full log

View this message in rfc822 format

From: Jakub Ječmínek <kuba <at> kubajecminek.cz>
To: Sean Whitton <spwhitton <at> spwhitton.name>, Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 26345 <at> debbugs.gnu.org, wojciech.siewierski <at> gmail.com
Subject: bug#26345: [PATCH] Handle renamed files when cycling through revisions
Date: Mon, 7 Jul 2025 23:09:18 +0200

[Message part 1 (text/plain, inline)]

On 7/7/25 10:34, Sean Whitton wrote:
> That's okay, I think the only thing is to check that the backend
> implements file-name-changes using vc-find-backend-function.  Then so
> long as the general approach makes sense and works for Git it's fine.

I've updated the patch based on your suggestions. You're right, 
`vc-annotate' is indeed a better place for this change.

>> Dmitry Gutov <dgutov <at> yandex.ru> writes:
>>
>>> On 05/07/2025 19:42, Sean Whitton wrote:
>>> I think (?) the file name might have changed in some later revision - so
>>> it won't be returned by vc-git-file-name-changes for that specific REV,
>>> but still might not match the current name.
>>
>> I'm not sure.
> 
> Seems like this needs to be investigated before we can proceed.
I've tested various scenarios and haven't encountered any issues with 
the current implementation. It would be great if you could test the 
change as well, in case there are edge cases I missed.

[0001-Handle-renamed-files-when-cycling-through-revisions.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.