GNU bug report logs - #26345
25.1; vc-annotate in Git is unable to fully navigate the history if the file was moved

Previous Next

Full log

Message #45 received at 26345 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: Jakub Ječmínek <kuba <at> kubajecminek.cz>, eliz <at> gnu.org,
 26345 <at> debbugs.gnu.org, wojciech.siewierski <at> gmail.com
Subject: Re: bug#26345: [PATCH] Handle renamed files when cycling through
 revisions
Date: Mon, 07 Jul 2025 09:34:30 +0100

Hello,

On Sun 06 Jul 2025 at 11:30pm +02, Jakub Ječmínek via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:

> Sean Whitton <spwhitton <at> spwhitton.name> writes:
>
>> And maybe then this could happen up in vc-annotate instead of being
>> Git-specific.  It's kind of a heuristic anyway.
>
> The problem occurs when we call `vc-annotate-next-revision', which in
> turn calls `vc-annotate-warp-revision'. I can make the change there, but
> I'm not familiar with any VCS other than Git, so I can't test it.

That's okay, I think the only thing is to check that the backend
implements file-name-changes using vc-find-backend-function.  Then so
long as the general approach makes sense and works for Git it's fine.

> Dmitry Gutov <dgutov <at> yandex.ru> writes:
>
>> On 05/07/2025 19:42, Sean Whitton wrote:
>> I think (?) the file name might have changed in some later revision - so
>> it won't be returned by vc-git-file-name-changes for that specific REV,
>> but still might not match the current name.
>
> I'm not sure.

Seems like this needs to be investigated before we can proceed.

-- 
Sean Whitton

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.